summaryrefslogtreecommitdiffstats
path: root/VNFs/DPPD-PROX
diff options
context:
space:
mode:
authorXavier Simonart <xavier.simonart@intel.com>2019-10-09 19:03:29 +0200
committerXavier Simonart <xavier.simonart@intel.com>2019-10-09 19:45:25 +0200
commitda4e41a67cca12cc4160a66ca46a37889137fa1e (patch)
tree7d8b0a32bee65f8420e53918a3f533a4b5bf40d7 /VNFs/DPPD-PROX
parent48f8c3d212644a33dd0abaaa1a0c71d4decaafdf (diff)
Fix strncpy issue introduced by fb0c44a8
Change-Id: I833d753bd5c426d50c0c9fdee5668f3b9fff13b9 Signed-off-by: Xavier Simonart <xavier.simonart@intel.com>
Diffstat (limited to 'VNFs/DPPD-PROX')
-rw-r--r--VNFs/DPPD-PROX/cmd_parser.c5
1 files changed, 4 insertions, 1 deletions
diff --git a/VNFs/DPPD-PROX/cmd_parser.c b/VNFs/DPPD-PROX/cmd_parser.c
index d4bfed01..dea955f4 100644
--- a/VNFs/DPPD-PROX/cmd_parser.c
+++ b/VNFs/DPPD-PROX/cmd_parser.c
@@ -2272,7 +2272,10 @@ static int parse_cmd_help(const char *str, struct input *input)
len3 = max_len;
}
- prox_strncpy(tmp, h, len3);
+ // Use strncpy here and not prox_strncpy. The dest (tmp) has been initialized with 0.
+ // The fact that we are copying 80 characters potentially not null terminated is hence not an issue.
+ // Using prox_strncpy here might cause a PROX_PANIC
+ strncpy(tmp, h, len3);
h += len3;
while (h[0] == ' ' && strlen(h))
h++;