Merge "[dovetail] split the sla check results into process recovery and service recovery for HA tcs"

4 files changed, 52 insertions, 20 deletions

diff --git a/yardstick/benchmark/scenarios/availability/monitor/monitor_multi.py b/yardstick/benchmark/scenarios/availability/monitor/monitor_multi.py
index 971bae1e9..8f1f53cde 100644
--- a/yardstick/benchmark/scenarios/availability/monitor/monitor_multi.py
+++ b/yardstick/benchmark/scenarios/availability/monitor/monitor_multi.py
@@ -62,20 +62,19 @@ class MultiMonitor(basemonitor.BaseMonitor):
         outage_time = (
             last_outage - first_outage if last_outage > first_outage else 0
         )
+        self._result = {"outage_time": outage_time}
         LOG.debug("outage_time is: %f", outage_time)
 
         max_outage_time = 0
-        if "max_outage_time" in self._config["sla"]:
-            max_outage_time = self._config["sla"]["max_outage_time"]
-        elif "max_recover_time" in self._config["sla"]:
-            max_outage_time = self._config["sla"]["max_recover_time"]
-        else:
-            raise RuntimeError("'max_outage_time' or 'max_recover_time' "
-                               "config is not found")
-        self._result = {"outage_time": outage_time}
-
-        if outage_time > max_outage_time:
-            LOG.error("SLA failure: %f > %f", outage_time, max_outage_time)
-            return False
-        else:
-            return True
+        if self._config.get("sla"):
+            if "max_outage_time" in self._config["sla"]:
+                max_outage_time = self._config["sla"]["max_outage_time"]
+            elif "max_recover_time" in self._config["sla"]:
+                max_outage_time = self._config["sla"]["max_recover_time"]
+            else:
+                raise RuntimeError("'max_outage_time' or 'max_recover_time' "
+                                   "config is not found")
+            if outage_time > max_outage_time:
+                LOG.error("SLA failure: %f > %f", outage_time, max_outage_time)
+                return False
+        return True
diff --git a/yardstick/benchmark/scenarios/availability/monitor/monitor_process.py b/yardstick/benchmark/scenarios/availability/monitor/monitor_process.py
index 8d2f2633c..280e5811d 100644
--- a/yardstick/benchmark/scenarios/availability/monitor/monitor_process.py
+++ b/yardstick/benchmark/scenarios/availability/monitor/monitor_process.py
@@ -46,12 +46,12 @@ class MonitorProcess(basemonitor.BaseMonitor):
 
     def verify_SLA(self):
         outage_time = self._result.get('outage_time', None)
-        max_outage_time = self._config["sla"]["max_recover_time"]
-        if outage_time > max_outage_time:
-            LOG.info("SLA failure: %f > %f", outage_time, max_outage_time)
-            return False
-        else:
-            return True
+        if self._config.get("sla"):
+            max_outage_time = self._config["sla"]["max_recover_time"]
+            if outage_time > max_outage_time:
+                LOG.info("SLA failure: %f > %f", outage_time, max_outage_time)
+                return False
+        return True
 
 
 def _test():    # pragma: no cover
diff --git a/yardstick/tests/unit/benchmark/scenarios/availability/test_monitor_multi.py b/yardstick/tests/unit/benchmark/scenarios/availability/test_monitor_multi.py
index e9c680257..dc3a4b99a 100644
--- a/yardstick/tests/unit/benchmark/scenarios/availability/test_monitor_multi.py
+++ b/yardstick/tests/unit/benchmark/scenarios/availability/test_monitor_multi.py
@@ -63,3 +63,20 @@ class MultiMonitorServiceTestCase(unittest.TestCase):
         ins.start_monitor()
         ins.wait_monitor()
         ins.verify_SLA()
+
+    def test__monitor_multi_no_sla(self, mock_open, mock_ssh):
+        monitor_cfg = {
+            'monitor_type': 'general-monitor',
+            'monitor_number': 3,
+            'key': 'service-status',
+            'monitor_key': 'service-status',
+            'host': 'node1',
+            'monitor_time': 0.1,
+            'parameter': {'serviceName': 'haproxy'}
+        }
+        ins = monitor_multi.MultiMonitor(
+            monitor_cfg, self.context, {"nova-api": 10})
+        mock_ssh.SSH.from_node().execute.return_value = (0, "running", '')
+        ins.start_monitor()
+        ins.wait_monitor()
+        self.assertTrue(ins.verify_SLA())
diff --git a/yardstick/tests/unit/benchmark/scenarios/availability/test_monitor_process.py b/yardstick/tests/unit/benchmark/scenarios/availability/test_monitor_process.py
index a6d2ca398..8c73bf221 100644
--- a/yardstick/tests/unit/benchmark/scenarios/availability/test_monitor_process.py
+++ b/yardstick/tests/unit/benchmark/scenarios/availability/test_monitor_process.py
@@ -55,3 +55,19 @@ class MonitorProcessTestCase(unittest.TestCase):
         ins.monitor_func()
         ins._result = {"outage_time": 10}
         ins.verify_SLA()
+
+    def test__monitor_process_no_sla(self, mock_ssh):
+
+        monitor_cfg = {
+            'monitor_type': 'process',
+            'process_name': 'nova-api',
+            'host': "node1",
+            'monitor_time': 1,
+        }
+        ins = monitor_process.MonitorProcess(monitor_cfg, self.context, {"nova-api": 10})
+
+        mock_ssh.SSH.from_node().execute.return_value = (0, "0", '')
+        ins.setup()
+        ins.monitor_func()
+        ins._result = {"outage_time": 10}
+        self.assertTrue(ins.verify_SLA())