aboutsummaryrefslogtreecommitdiffstats
path: root/yardstick/tests/unit/benchmark/scenarios/lib/test_create_server.py
diff options
context:
space:
mode:
authorEmma Foley <emma.l.foley@intel.com>2018-03-05 17:41:33 +0000
committerEmma Foley <emma.l.foley@intel.com>2018-03-05 17:41:33 +0000
commit3478059d4397c5ee3a1d1e4707c5883afd0974a8 (patch)
tree2c2d5c68c3f2a6232ab0b71e00e07184ded9926f /yardstick/tests/unit/benchmark/scenarios/lib/test_create_server.py
parent8400c1895c49cb0c7802692f75d820fb5b8b7dc4 (diff)
assertTrue(mock.called) -> mock.assert_called
When checking whether a mocked method has been called, mock.assert_called or mock.assert_called_once should be used, and not unittest.assertTrue(mock.called) This change does this update. It can be verified with: grep -irn "self.assertTrue(.*called)" --exclude-dir=.tox And the replacement was done with: sed -i 's/self.assertTrue(\(.*\).called)/\1.assert_called_once()/g' <list_of_files> Change-Id: I4f26e0c736bf33e0b2413c8e8c33dbdb91f090e2 JIRA: YARDSTICK-865 Signed-off-by: Emma Foley <emma.l.foley@intel.com>
Diffstat (limited to 'yardstick/tests/unit/benchmark/scenarios/lib/test_create_server.py')
-rw-r--r--yardstick/tests/unit/benchmark/scenarios/lib/test_create_server.py8
1 files changed, 4 insertions, 4 deletions
diff --git a/yardstick/tests/unit/benchmark/scenarios/lib/test_create_server.py b/yardstick/tests/unit/benchmark/scenarios/lib/test_create_server.py
index faee98fd1..9d6d8cb1b 100644
--- a/yardstick/tests/unit/benchmark/scenarios/lib/test_create_server.py
+++ b/yardstick/tests/unit/benchmark/scenarios/lib/test_create_server.py
@@ -28,7 +28,7 @@ class CreateServerTestCase(unittest.TestCase):
}
obj = CreateServer(scenario_cfg, {})
obj.run({})
- self.assertTrue(mock_get_nova_client.called)
- self.assertTrue(mock_get_glance_client.called)
- self.assertTrue(mock_get_neutron_client.called)
- self.assertTrue(mock_create_instance_and_wait_for_active.called)
+ mock_get_nova_client.assert_called_once()
+ mock_get_glance_client.assert_called_once()
+ mock_get_neutron_client.assert_called_once()
+ mock_create_instance_and_wait_for_active.assert_called_once()