diff options
| author |   Emma Foley <emma.l.foley@intel.com> | 2018-03-05 17:41:33 +0000 |
|---|---|---|
| committer | Emma Foley <emma.l.foley@intel.com> | 2018-03-05 17:41:33 +0000 |
| commit | 3478059d4397c5ee3a1d1e4707c5883afd0974a8 (patch) | |
| tree | 2c2d5c68c3f2a6232ab0b71e00e07184ded9926f /yardstick/tests/unit/benchmark/core | |
| parent | 8400c1895c49cb0c7802692f75d820fb5b8b7dc4 (diff) | |
assertTrue(mock.called) -> mock.assert_called
When checking whether a mocked method has been called,
mock.assert_called or mock.assert_called_once should be
used, and not unittest.assertTrue(mock.called)
This change does this update.
It can be verified with:
grep -irn "self.assertTrue(.*called)" --exclude-dir=.tox
And the replacement was done with:
sed -i 's/self.assertTrue(\(.*\).called)/\1.assert_called_once()/g' <list_of_files>
Change-Id: I4f26e0c736bf33e0b2413c8e8c33dbdb91f090e2
JIRA: YARDSTICK-865
Signed-off-by: Emma Foley <emma.l.foley@intel.com>
Diffstat (limited to 'yardstick/tests/unit/benchmark/core')
| -rw-r--r-- | yardstick/tests/unit/benchmark/core/test_task.py | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/yardstick/tests/unit/benchmark/core/test_task.py b/yardstick/tests/unit/benchmark/core/test_task.py index 82a90b172..1ce30eacb 100644 --- a/yardstick/tests/unit/benchmark/core/test_task.py +++ b/yardstick/tests/unit/benchmark/core/test_task.py @@ -153,7 +153,7 @@ class TaskTestCase(unittest.TestCase): runner.get_result.return_value = [] mock_base_runner.Runner.get.return_value = runner t._run([scenario], False, "yardstick.out") - self.assertTrue(runner.run.called) + runner.run.assert_called_once() @mock.patch.object(os, 'environ') def test_check_precondition(self, mock_os_environ): |