summaryrefslogtreecommitdiffstats
path: root/api/resources/env_action.py
diff options
context:
space:
mode:
authorRoss Brattain <ross.b.brattain@intel.com>2017-01-25 16:15:52 -0800
committerRoss Brattain <ross.b.brattain@intel.com>2017-02-08 06:51:04 +0000
commitc6d584f5e050cf79eb640bae3d6ca36e2788890f (patch)
treebf4a69eb9f51e989947e80a7339a11429b9bf3b9 /api/resources/env_action.py
parenta4241e6e9b121447a50fdfe0d79b322c2e2aaea9 (diff)
pylint fixes: remove redundant parens, fix comparison order
removed redundant parens in if and while clauses use var != constant, not constant != var. Python doesn't allow for assignment in if statements, so we don't have to use the old C workarounds remove unwanted commas use raw strings for regexps with backslashes, e.g. r'\s' instead of '\s' Change-Id: I7aad645dd3d7f4b4b62f4e4510a425611c9d28f2 Signed-off-by: Ross Brattain <ross.b.brattain@intel.com>
Diffstat (limited to 'api/resources/env_action.py')
-rw-r--r--api/resources/env_action.py2
1 files changed, 1 insertions, 1 deletions
diff --git a/api/resources/env_action.py b/api/resources/env_action.py
index 8955f3cb6..917681c37 100644
--- a/api/resources/env_action.py
+++ b/api/resources/env_action.py
@@ -248,7 +248,7 @@ def _get_remote_rc_file(rc_file, installer_ip, installer_type):
cmd = [os_fetch_script, '-d', rc_file, '-i', installer_type,
'-a', installer_ip]
p = subprocess.Popen(cmd, stdout=subprocess.PIPE)
- p.communicate()[0]
+ p.communicate()
if p.returncode != 0:
logger.debug('Failed to fetch credentials from installer')