From c6d584f5e050cf79eb640bae3d6ca36e2788890f Mon Sep 17 00:00:00 2001 From: Ross Brattain Date: Wed, 25 Jan 2017 16:15:52 -0800 Subject: pylint fixes: remove redundant parens, fix comparison order removed redundant parens in if and while clauses use var != constant, not constant != var. Python doesn't allow for assignment in if statements, so we don't have to use the old C workarounds remove unwanted commas use raw strings for regexps with backslashes, e.g. r'\s' instead of '\s' Change-Id: I7aad645dd3d7f4b4b62f4e4510a425611c9d28f2 Signed-off-by: Ross Brattain --- api/resources/env_action.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) (limited to 'api/resources/env_action.py') diff --git a/api/resources/env_action.py b/api/resources/env_action.py index 8955f3cb6..917681c37 100644 --- a/api/resources/env_action.py +++ b/api/resources/env_action.py @@ -248,7 +248,7 @@ def _get_remote_rc_file(rc_file, installer_ip, installer_type): cmd = [os_fetch_script, '-d', rc_file, '-i', installer_type, '-a', installer_ip] p = subprocess.Popen(cmd, stdout=subprocess.PIPE) - p.communicate()[0] + p.communicate() if p.returncode != 0: logger.debug('Failed to fetch credentials from installer') -- cgit 1.2.3-korg