diff options
| author |   Morgan Richomme <morgan.richomme@orange.com> | 2017-05-17 10:29:20 +0200 |
|---|---|---|
| committer |   spisarski <s.pisarski@cablelabs.com> | 2017-05-17 09:51:05 -0600 |
| commit | 956acc7da293b931c3e21e64fa0a9011f995c11c (patch) | |
| tree | fdc3690743dfebb92f185a5481531f8fe2399858 /snaps/openstack/utils/neutron_utils.py | |
| parent | 10c665d7c831cf198ac9e675654693860e602bf9 (diff) | |
bugfix: get_security_group_by_id always return first element
add check on id before return value
fixed kwarg into the neutron.list_security_groups to the correct one 'id'
added unit test to ensure this function always works as designed
JIRA: SNAPS-82
Change-Id: I965e1dd54fd1efa8c2d7f6efb87c78ab24cca0e5
Signed-off-by: Morgan Richomme <morgan.richomme@orange.com>
Diffstat (limited to 'snaps/openstack/utils/neutron_utils.py')
| -rw-r--r-- | snaps/openstack/utils/neutron_utils.py | 5 |
1 files changed, 3 insertions, 2 deletions
diff --git a/snaps/openstack/utils/neutron_utils.py b/snaps/openstack/utils/neutron_utils.py index a65a42f..3063176 100644 --- a/snaps/openstack/utils/neutron_utils.py +++ b/snaps/openstack/utils/neutron_utils.py @@ -336,9 +336,10 @@ def get_security_group_by_id(neutron, sec_grp_id): """ logger.info('Retrieving security group with ID - ' + sec_grp_id) - groups = neutron.list_security_groups(**{'sec_grp_id': sec_grp_id}) + groups = neutron.list_security_groups(**{'id': sec_grp_id}) for group in groups['security_groups']: - return {'security_group': group} + if group['id'] == sec_grp_id: + return {'security_group': group} return None |