diff options
| author |   Markos Chandras <mchandras@suse.de> | 2018-03-26 10:23:13 +0100 |
|---|---|---|
| committer | Markos Chandras <mchandras@suse.de> | 2018-03-26 20:47:17 +0100 |
| commit | 9e1d3d6e62abf5d0da26a296bcd235f37a54d9c6 (patch) | |
| tree | fc2fb9d8056786b4543379977fb8e72de3f2125b /xci/playbooks/get-opnfv-scenario-requirements.yml | |
| parent | 8f3c33c97acc5fc10a83e7cc7635da67e2460769 (diff) | |
xci: playbooks: Fixes various ansible-lint warnings
In preparation for adding support for the 'ansible-lint' tool we fix
various problems in our playbooks to make the tool happy before we make
it mandatory.
Some of the problems that are fixed here are
- [ANSIBLE0011] All tasks should be named
- [ANSIBLE0012] Commands should not change things if nothing needs doing
- [ANSIBLE0013] Use shell only when shell functionality is required
- [ANSIBLE0010] Package installs should not use latest
installer-type:osa
deploy-scenario:os-nosdn-nofeature
Change-Id: I66c759d3932a414b81b2846393d2d98ce80c0b6d
Signed-off-by: Markos Chandras <mchandras@suse.de>
Diffstat (limited to 'xci/playbooks/get-opnfv-scenario-requirements.yml')
| -rw-r--r-- | xci/playbooks/get-opnfv-scenario-requirements.yml | 9 |
1 files changed, 6 insertions, 3 deletions
diff --git a/xci/playbooks/get-opnfv-scenario-requirements.yml b/xci/playbooks/get-opnfv-scenario-requirements.yml index 3c291384..6572e278 100644 --- a/xci/playbooks/get-opnfv-scenario-requirements.yml +++ b/xci/playbooks/get-opnfv-scenario-requirements.yml @@ -105,18 +105,21 @@ - name: Determine if the selected {{ deploy_scenario }} scenario can be deployed block: - - set_fact: + - name: Set scenario installer fact + set_fact: deploy_scenario_installer: "{{ item }}" with_items: "{{ deploy_scenario.installers }}" loop_control: label: "{{ item.installer }}" when: item.installer == installer_type - - set_fact: + - name: Set scenario flavor fact + set_fact: deploy_scenario_flavor: "{{ (xci_flavor in deploy_scenario_installer.flavors) | bool }}" when: - deploy_scenario_installer is defined - deploy_scenario_installer - - set_fact: + - name: Set scenario distro flavor fact + set_fact: deploy_scenario_distro: "{{ (xci_distro in deploy_scenario_installer.distros) | bool }}" when: - deploy_scenario_flavor is defined |