Age | Commit message (Collapse) | Author | Files | Lines |
|
* Update docs/submodules/functest from branch 'master'
- Disable orchestra_clearwaterims in functest-vnf
It fixes a typo.
Change-Id: I684eab0ed74e2ebcb6f72442d0b3012d1b5de7aa
Signed-off-by: Cédric Ollivier <cedric.ollivier@orange.com>
|
|
* Update docs/submodules/functest from branch 'master'
- Precise Tempest tests list
Else full mode could run tests defined in tempest plugins too [1].
[1] https://docs.openstack.org/tempest/latest/plugin-registry.html
Change-Id: I4355b03ba1b9ba47938f748c4f1a8822fd412142
Signed-off-by: Cédric Ollivier <cedric.ollivier@orange.com>
|
|
* Update docs/submodules/yardstick from branch 'master'
- Merge "Replace neutron network deletion with shade."
- Replace neutron network deletion with shade.
Function delete_neutron_net now uses shade client instead of neutron
client.
JIRA: YARDSTICK-890
Change-Id: I99b6f3ecd37d6e3b783f7eb3da9f971398fc3bdd
Signed-off-by: Shobhi Jain <shobhi.jain@intel.com>
|
|
* Update docs/submodules/yardstick from branch 'master'
- Merge "Make segmentation_id configurable for tc_heat_rfc2544_ipv4_1rule_1flow_64B_trex"
- Make segmentation_id configurable for tc_heat_rfc2544_ipv4_1rule_1flow_64B_trex
Updated vfw/tc_heat_rfc2544_ipv4_1rule_1flow_64B_trex.yaml TC to be
able to configure segmentation_id from commmand line.
E.g.:
yardstick -d task start --task-args='{"provider": "sriov", \
"segmentation_id": 100}' ...
JIRA: YARDSTICK-1004
Change-Id: I53daae3468de2a1f523bd96817143a5f809238a2
Signed-off-by: Mytnyk, Volodymyr <volodymyrx.mytnyk@intel.com>
|
|
* Update docs/submodules/fuel from branch 'master'
- Merge "[Horizon] Fix 'mcp' version check pattern"
- [Horizon] Fix 'mcp' version check pattern
Previous commit used a pattern that is too generic and always matches
the substring 'mcp' vs the node hostname, not only pkg version.
Fixes: 4658acf
Change-Id: Ia4dcbbf7cdfa68574c86459217101d83d61add01
Signed-off-by: Alexandru Avadanii <Alexandru.Avadanii@enea.com>
|
|
* Update docs/submodules/fuel from branch 'master'
- Merge "[MaaS] Add maas.machines.set_storage_layout sls"
- [MaaS] Add maas.machines.set_storage_layout sls
On cmp nodes, allocate only 30GB (fixed for now) for / partition.
The rest of the disk(s) can later be allocated via salt-formula-linux.
JIRA: FUEL-330
Change-Id: Ie11c78791e60801719cd33475ff91fc003df5ffa
Signed-off-by: Alexandru Avadanii <Alexandru.Avadanii@enea.com>
|
|
* Update docs/submodules/fuel from branch 'master'
- Merge changes from topics 'lab-proxy-keyserver', 'maas-override-failed-testing'
* changes:
[baremetal] Use upstream lab proxy for keyservers
[MaaS] Override failed testing by default
- [baremetal] Use upstream lab proxy for keyservers
Proxy chainloading does not always work for keyserver requests, so:
- mv common.infra.lab_proxy_pdf common.include.lab_proxy_pdf;
- mv common.include.proxy common.include.maas_proxy;
- include lab_proxy_pdf after each maas_proxy, so if upstream_proxy
is defined, it will override the MaaS proxy;
JIRA: FUEL-317
Change-Id: I63749be0d350ea73ea2cf6e629710766b14ecb73
Signed-off-by: Alexandru Avadanii <Alexandru.Avadanii@enea.com>
- [MaaS] Override failed testing by default
Some nodes fail automatic testing done by MaaS during commissioning,
although running the testing suites one more time manually works.
For now, just override all 'failed testing' nodes unconditionally.
JIRA: FUEL-333
Change-Id: I13d3ee3d82550524480aa53aa8752ab90aa940cd
Signed-off-by: Alexandru Avadanii <Alexandru.Avadanii@enea.com>
|
|
* Update docs/submodules/fuel from branch 'master'
- Merge "[patch] MaaS: mcp.rsa.pub to auth keys via pillar"
- [patch] MaaS: mcp.rsa.pub to auth keys via pillar
Drop one questionable patch responsible for MaaS node authorized
keys to include mcp.rsa.pub by reading the contents of authorized
keys on mas01, assuming mcp.rsa.pub will be on the first line.
Instead, export the contents of the public key using a shell env
var during deploy, which gets expanded via maas_pdf j2 template
into a reclass param, leveraging existing salt-formula-maas sshprefs
mechanism for delivering the key to MaaS.
Since we require the public key to exist before expanding templates,
move `generate_ssh_key` call outside the current infrastructure
handling block, allowing it to execute during all `deploy.sh` calls,
even for dry-runs.
Change-Id: I0f53b0f764a2fafd292e0ffd399c284acf61bd30
Signed-off-by: Alexandru Avadanii <Alexandru.Avadanii@enea.com>
|
|
* Update docs/submodules/functest from branch 'master'
- Enhance variable manipulation in tempest
Use getattr/setattr to read/write CONST.
JIRA: FUNCTEST-932
Change-Id: Ic9a944100c60563b16f5d89b622ef7f04183cceb
Signed-off-by: Juha Kosonen <juha.kosonen@nokia.com>
|
|
* Update docs/submodules/armband from branch 'master'
- u/fuel: Bump & rebase for virtual PDF support
Finally drop hardcoded IP addresses for virtual deploys from reclass,
but keep one small patch adjusting the local vPDF to achieve the same
goal.
JIRA: FUEL-322
Change-Id: I56a3b0487f564355a4c51b4eb71ec97e92531f1d
Signed-off-by: Alexandru Avadanii <Alexandru.Avadanii@enea.com>
|
|
* Update docs/submodules/fuel from branch 'master'
- Merge "reclass: maas: Dynamic machine definitions"
- reclass: maas: Dynamic machine definitions
Refactor maas machine definition flow from going through variables
in pod_config.yaml to directly handling it in Fuel using a new j2
template.
This prepares for future improvements allowing a dynamic compute
node count, as well as parameterizing new values via j2.
For now, node roles and count are still statically mapped to PDF
nodes.
JIRA: FUEL-319
Change-Id: I770d82987fcb99792f9d5bc0857ab513f5cd3731
Signed-off-by: Alexandru Avadanii <Alexandru.Avadanii@enea.com>
|
|
* Update docs/submodules/yardstick from branch 'master'
- Merge "Workaround to fix Heat stack deletion bug in Shade"
- Workaround to fix Heat stack deletion bug in Shade
There is a bug in Shade, in the function "event_utils.poll_for_events".
While Shade is waiting for the Heat stack to be deleted, retrieves
periodically the status of this Heat stack. When the stack is deleted,
the function "get_stack" [1] returns None; then L90 tries to access to
a key of this None object.
[1]https://github.com/openstack-infra/shade/blob/e5bcb705c5b32334cdc1dd9807126298c87b0622/shade/_heat/event_utils.py#L89-L90
Shade function
JIRA: YARDSTICK-1015
Change-Id: I56ea853be41bfd7f63e094d7a3696d97ba078ba4
Signed-off-by: Rodolfo Alonso Hernandez <rodolfo.alonso.hernandez@intel.com>
|
|
* Update docs/submodules/functest from branch 'master'
- Remove one debug print
Change-Id: I531d1e519fc0352525993c69142eea14b99a3f63
Signed-off-by: Cédric Ollivier <cedric.ollivier@orange.com>
|
|
* Update docs/submodules/functest from branch 'master'
- Mock additional methods related to OpenStackFlavor
keystone_utils.keystone_client() and keystone_utils.get_project()
have to be mocked when unit testing flavor creation since [1].
[1] https://gerrit.opnfv.org/gerrit/#/c/52157/
Change-Id: I898cde1001c14d0b450c3dd43ade7dca47b1ffb3
Signed-off-by: Cédric Ollivier <cedric.ollivier@orange.com>
|
|
* Update docs/submodules/compass4nfv from branch 'master'
- Merge "deploy/conf: add ha role to k8 scenario"
- deploy/conf: add ha role to k8 scenario
Only K8s ha scenario is supported now. This noha scenario is broken.
Add minor fixup so we can still use it to deploy K8s on two nodes.
Change-Id: I3a763fe07ea2d31cd3ae049621e3d978c1bca4be
Signed-off-by: Yibo Cai <yibo.cai@arm.com>
|
|
* Update docs/submodules/nfvbench from branch 'master'
- [NFVBENCH-67] NFVbench should have same TX rate for different rate formats
Change-Id: I55e03319efba353dd3067b8b946815b631a87896
Signed-off-by: Yichen Wang <yicwang@cisco.com>
|
|
* Update docs/submodules/apex from branch 'master'
- Merge "Fixes ensuring VBMCs are actually running"
- Fixes ensuring VBMCs are actually running
We currently start VBMCs using CLI due to issues with the VBMC python
lib. However when we start them, there is no check to make sure they
are actually changed to 'running' status. This patch adds logic to
check (up to 5 times) to ensure each VBMC is running or raises an error.
Note this is for virtual deployments only.
JIRA: APEX-527
Change-Id: Iab7ee3b76292d6fc547f18c83f23c04205e9bb2e
Signed-off-by: Tim Rozet <trozet@redhat.com>
|
|
* Update docs/submodules/apex from branch 'master'
- Merge "Fixes stale undercloud delorean repos"
- Fixes stale undercloud delorean repos
When we build artifacts for release, we try to freeze the disk images
and artifacts we use for deployment. This includes the delorean repo
which provides OpenStack packages. This repo however expires after a
couple months and then if any packages were missing in the Undercloud
released artifact, they will attempt to be downloaded during install
and fail.
This patch adds some logic to detect if there is internet connectivity,
and if so then download and update the delorean repo on the undercloud.
JIRA: APEX-565
Change-Id: I58c28437fb5c5b179033c939377fd97aefbf427c
Signed-off-by: Tim Rozet <trozet@redhat.com>
|
|
* Update docs/submodules/apex from branch 'master'
- Add http(s)_proxy handling to apex
JIRA: APEX-512
Change-Id: I875bd99203b425e448e7a3f64eb9a8f99d03ddaf
Signed-off-by: Dan Radez <dradez@redhat.com>
|
|
* Update docs/submodules/nfvbench from branch 'master'
- NFVBENCH-66 Fixed rate run with multiple frame sizes sends same tx/rx
results for all frame sizes
Change-Id: I549c2504dfb95718ef60c82c4b20256fc5939c8c
Signed-off-by: mortenhillbom <mortenhillbom@gmail.com>
|
|
* Update docs/submodules/yardstick from branch 'master'
- Merge "Bump pip packages installed in "nsb_setup.sh" script"
- Bump pip packages installed in "nsb_setup.sh" script
Bump pip package versions installed in "nsb_setup.sh" script to match
"./requirements.txt" versions.
JIRA: YARDSTICK-1008
Change-Id: Icb0f7e99c1be38848ee7122735ace7c1c715ef5b
Signed-off-by: Rodolfo Alonso Hernandez <rodolfo.alonso.hernandez@intel.com>
|
|
* Update docs/submodules/yardstick from branch 'master'
- Merge "Fix "./docker/Dockerfile.aarch64.patch""
- Fix "./docker/Dockerfile.aarch64.patch"
Patch "./docker/Dockerfile.aarch64.patch" doesn't apply on
"./docker/Dockerfile" due to the latest modification done in the
original file
The original reference lines must be changed.
JIRA: YARDSTICK-1007
Change-Id: I5cfc349fbaf34e8da59608e5b803818e2cd9d295
Signed-off-by: Rodolfo Alonso Hernandez <rodolfo.alonso.hernandez@intel.com>
|
|
* Update docs/submodules/yardstick from branch 'master'
- Merge "Remove tool provisioning from DpdkVnfSetupEnvHelper._setup_dpdk"
- Remove tool provisioning from DpdkVnfSetupEnvHelper._setup_dpdk
Both "uio" and "igb_uio" drivers are present in the VM image generated
using "./nsb_setup.sh" script. "igb_uio" driver is compiled along with
the DPDK library compilation.
Tool "nsb_setup.sh" provisioning and execution should be removed from
this function because there is not needed anymore.
In case "igb_uio" driver is not loaded, an exception should be raised.
JIRA: YARDSTICK-999
Change-Id: I89174f84ac36d8231587402c96751746cb18e290
Signed-off-by: Rodolfo Alonso Hernandez <rodolfo.alonso.hernandez@intel.com>
|
|
* Update docs/submodules/dovetail from branch 'master'
- Add a function to check the cacert file
1. Currently it won't pass the cacert file to other containers if the
OS_AUTH_URL is http not https.
2. However, even though the OS_AUTH_URL is http, it still needs cacert file
somewhere for Functest and Rally.
3. This problem is found on Fuel Euphrates.
4. Add a function to check whether the cacert file exists.
5. If exists, pass it to testing project containers.
JIRA: DOVETAIL-616
Change-Id: Ied7bcc72e8f1c738bbce32c18096ca13641d3cd7
Signed-off-by: xudan <xudan16@huawei.com>
|
|
* Update docs/submodules/pharos from branch 'master'
- Configure stacklight IP addresses
Related to: https://gerrit.opnfv.org/gerrit/#/c/52043/
Change-Id: I8378070f9efedc24229efc3c3d5542b62808e1e6
Signed-off-by: Delia Popescu <delia.popescu@enea.com>
|
|
* Update docs/submodules/fuel from branch 'master'
- Set nova disk cachemodes to file directsync
Set nova/libvirt disk cache modes to file directsync to bypass the
host page cache & prevent instance's kernel panic due to absent
/dev partition. Caching mode directsync effectively turns all guest
I/O operations into direct I/O operations on the host, which is the
NFS client (virtuals) or GlusterFS (baremetals).
Also return back to hwe kernel as a golden mean between GA & Edge ones.
Change-Id: I51ab7d0ee71c214ff16b756cfee16e918738b6fd
Signed-off-by: Michael Polenchuk <mpolenchuk@mirantis.com>
|
|
* Update docs/submodules/dovetail from branch 'master'
- Add Functest test case snaps_smoke into proposed_tests test suite
Add snaps_smoke into proposed_tests test suite.
Then this test case can be run by Dovetail on CI.
JIRA: DOVETAIL-596
Change-Id: I8fc4bb656bcac551ae4b693dbc4d817b665c6111
Signed-off-by: xudan <xudan16@huawei.com>
|
|
* Update docs/submodules/apex from branch 'master'
- Ensures v4/v6 iptables filters are loaded
We configure host iptables to open different ports for VBMC. This may
fail if the iptables filters are not loaded.
JIRA: APEX-521
Change-Id: Ia33032c29aba3555551e39b4f819087aeafe05d9
Signed-off-by: Tim Rozet <trozet@redhat.com>
|
|
* Update docs/submodules/snaps from branch 'master'
- Added functionality for OpenStackSecurityGroup#initialize() not to accept
security groups with the same name from a different project
JIRA: SNAPS-264
Change-Id: I7c905e5588d5e503b47ea0e9f5997be89e841aec
Signed-off-by: spisarski <s.pisarski@cablelabs.com>
|
|
* Update docs/submodules/functest from branch 'master'
- Add suffixes in vnf keypair names
Change-Id: Ia9c8ef535b16326a520367d2c7c98b7e8db4822c
Signed-off-by: Cédric Ollivier <cedric.ollivier@orange.com>
|
|
* Update docs/submodules/functest from branch 'master'
- Get properly env vars or their default values
It defines env.get() as an unique way to get Functest env vars or
their default values. It can be considered as a wrapper above os.environ.
It enforces backward compatibility via CONST which mustn't be used
for that purpose. It should be noted that it also stops using CONST
for getting OpenStack env vars.
Change-Id: I333dc1afbc0123166a7eaff8b551370098efa341
Signed-off-by: Cédric Ollivier <cedric.ollivier@orange.com>
|
|
* Update docs/submodules/fuel from branch 'master'
- Fix check if node type is baremetal for novcp
Fixes: 86c8109
Change-Id: I0a947bd7db5dd7cb830cc932f5a0d16831551923
Signed-off-by: Delia Popescu <delia.popescu@enea.com>
Signed-off-by: Alexandru Avadanii <Alexandru.Avadanii@enea.com>
|
|
* Update docs/submodules/yardstick from branch 'master'
- NSB: Ixia remove unused traffic_generator arg
also fix pylint unittest warnings
JIRA: YARDSTICK-1014
Change-Id: I4ff9769fdca89c6fc1fb9ca62e9f8ea6b174681e
Signed-off-by: Ross Brattain <ross.b.brattain@intel.com>
|
|
* Update docs/submodules/apex from branch 'master'
- Fixes python2 docutils req and also installs ansible
For some reason we were requiring python2-docutils in to build our rpm
instead of python34-docutils. Patch also includes some logic to install
ansible.
JIRA: APEX-515
Change-Id: I1b85e5b4b29f74f5ff5399296f24831c334c289c
Signed-off-by: Tim Rozet <trozet@redhat.com>
|
|
* Update docs/submodules/functest from branch 'master'
- Merge "Removed os_utils and fully switched to snaps"
- Removed os_utils and fully switched to snaps
JIRA: FUNCTEST-925
Change-Id: Ibcbf42c34b764fda09d4d49513b261aae296a68b
Signed-off-by: soumaya <soumaya.nayek@rebaca.com>
|
|
* Update docs/submodules/functest from branch 'master'
- Add suffixes to OpenStack resource names
All vnf testcases have to add suffixes in OpenStack resources names
simply because the password is now generated before any run [1].
Snaps mainly creates the resource only if unfound in all tenants [2].
Then one remaining resource could easily raise permissions denied.
It avoid conflicts between vrouter and cloudify_ims which are using the
same names.
[1] https://gerrit.opnfv.org/gerrit/#/c/50747/
[2] https://jira.opnfv.org/browse/SNAPS-257
Depends-On: If56cc44fe35ca06bc9033af620ddd3c0586877fe
Change-Id: I1800886e575189b64fdc580a5ee6b59c81fcde5c
Signed-off-by: Cédric Ollivier <cedric.ollivier@orange.com>
|
|
* Update docs/submodules/functest from branch 'master'
- Fix typos in cloudify_ims
Change-Id: I5d29b3e58cae7e9a334ec6f264cdb5e280860d97
Signed-off-by: Cédric Ollivier <cedric.ollivier@orange.com>
|
|
* Update docs/submodules/functest from branch 'master'
- Stop reading SDN_CONTROLLER env var.
Joid doesn't support ODL and this exception is no longer needed.
It will be a simple switch from SDN_CONTROLLER to SDN_CONTROLLER_IP
if Joid supports ODL again.
Change-Id: I925965f9c1adf24914e4110ff3206443f4063ac8
Signed-off-by: Cédric Ollivier <cedric.ollivier@orange.com>
|
|
* Update docs/submodules/yardstick from branch 'master'
- Merge "Update heat RFC2544 based TC to support SRIOV VF ports."
- Update heat RFC2544 based TC to support SRIOV VF ports.
Updated vfw/tc_heat_rfc2544_ipv4_1rule_1flow_64B_trex.yaml TC to be
able to run it in heat context with SRIOV VF ports configured in
OpenStack.
E.g.:
yardstick task start --task-args='{"provider": "sriov"}' ...
yardstick task start --task-args='{"provider": "sriov"}\
physical_networks: ["physnet1", "physnet2"]}' ...
Console log: http://paste.openstack.org/show/666931/
Result output: http://paste.openstack.org/show/666930/
JIRA: YARDSTICK-1004
Change-Id: If0dabd0791e4e295782fee0f3de1536474218876
Signed-off-by: Mytnyk, Volodymyr <volodymyrx.mytnyk@intel.com>
|
|
* Update docs/submodules/functest from branch 'master'
- Merge "Stop reading NODE_NAME in tempest and refstack"
- Stop reading NODE_NAME in tempest and refstack
NODE_NAME should only be read by TestCase when publishing the results
to the database. Other debug data are already printed by run_tests.
INSTALLER_TYPE and DEPLOY_SCENARIO are also unused by refstack.
Change-Id: Ib82d5c1512553beba2c56f4ec2860cb2593f801e
Signed-off-by: Cédric Ollivier <cedric.ollivier@orange.com>
|
|
* Update docs/submodules/snaps from branch 'master'
- Merge "Compare strings instead of objects in SecurityGroupConfig"
- Compare strings instead of objects in SecurityGroupConfig
It could have worked thanks to interned strings.
Change-Id: If56cc44fe35ca06bc9033af620ddd3c0586877fe
Signed-off-by: Cédric Ollivier <cedric.ollivier@orange.com>
|
|
* Update docs/submodules/snaps from branch 'master'
- Merge "Set region_name in get_os_creds()"
- Set region_name in get_os_creds()
Change-Id: Idb6912319e24edb39e18114bd3c1ef5bca750752
Signed-off-by: Cédric Ollivier <cedric.ollivier@orange.com>
|
|
* Update docs/submodules/sdnvpn from branch 'master'
- Merge "fix for sdnvpn CI test failure"
- fix for sdnvpn CI test failure
Change-Id: Ie55ccbe68f57a9bb03efc8b6eebf23a0018a0bca
Signed-off-by: Periyasamy Palanisamy <periyasamy.palanisamy@ericsson.com>
|
|
* Update docs/submodules/fuel from branch 'master'
- Mask opendaylight service
In order to avoid using cache data with initial/outdated
configuration, mask opendaylight service before package
installation.
JIRA: FUEL-344
Change-Id: I71eb0b0a5af93d6d21698e76587b32098aba96b4
Signed-off-by: Michael Polenchuk <mpolenchuk@mirantis.com>
|
|
* Update docs/submodules/sdnvpn from branch 'master'
- Use bgvpn-delete and create instead of update
Testcases 1 and 4 fail because of netvirt bug [1]
The same functionality is now achieved by using
bgvpn-delete and bgpvpn-create cli commands instead
of bgpvpn-update
[1] https://jira.opendaylight.org/browse/NETVIRT-1067
Change-Id: Iaba6e06d0f39e356bf364b0640c707b0a83470d7
Signed-off-by: tomsou <soth@intracom-telecom.com>
Signed-off-by: Periyasamy Palanisamy <periyasamy.palanisamy@ericsson.com>
|
|
* Update docs/submodules/releng from branch 'master'
- jjb: xci: Add missing job blockers for XCI merge jobs
We shouldn't allow the merge jobs to run in parallel with the verify
ones when both are testing the same distro since one may wipe the
'clean VM' of the other one. Moreover, we should restrict the number of
jobs allocated on nodes in order to avoid overloading them.
Change-Id: I9c0b9b5061e41b21c01789fc4676e72e0e082f17
Signed-off-by: Markos Chandras <mchandras@suse.de>
|
|
* Update docs/submodules/samplevnf from branch 'master'
- Merge "Auto Generated INFO.yaml file"
- Auto Generated INFO.yaml file
INFO.yaml meant to be machine readable.
This file was auto generated from an ldap lookup
and your projects INFO file.
Meeting times are not currently filled out.
please ammend this patchset to complete
Going forward comitter promotions should be done
against this file.
PTLs:
Must be merged for you to gain delete access on
testresults.opnfv.org
If project_lead: is missing (my script could not parse)
please amend with same from commiters section eg:
project_lead: &opnfv_$project_ptl
name: 'Lead Name'
email: 'lead email'
id: 'lead lfid'
company: 'lead company'
Change-Id: Ib034d62db7138a9f7c66c4d3377d6681764c41b4
Signed-off-by: agardner <agardner@linuxfoundation.org>
|
|
* Update docs/submodules/samplevnf from branch 'master'
- Merge "Fix potential crash in rx and tx distribution"
- Fix potential crash in rx and tx distribution
In some (rare) modes, more than 64 packets can be received through
one rx function. This is for instance the case of the lat mode.
Change-Id: Ie733c927a8e116c679c464f2551768185ef85366
Signed-off-by: Xavier Simonart <xavier.simonart@intel.com>
|
|
* Update docs/submodules/yardstick from branch 'master'
- BugFix: Fix to pod context filename
The "context:file" of tc_prox_baremetal_lw_aftr
has an incorrect path, compaired to all other
prox test cases.
Change-Id: Id24e74905f36bc84fdf93d1a2966211ecad55c8b
Signed-off-by: Xavier Simonart <xavier.simonart@intel.com>
|
|
* Update docs/submodules/pharos from branch 'master'
- Merge "[PDF/IDF] LF-POD4"
- [PDF/IDF] LF-POD4
Add PDF and IDF for LF-POD4
Change-Id: Ie3e682e40f751b8f91340373fbcabd522d3686a8
Signed-off-by: Trevor Bramwell <tbramwell@linuxfoundation.org>
|