summaryrefslogtreecommitdiffstats
AgeCommit message (Collapse)AuthorFilesLines
2017-03-29Update git submodulesNikolas Hermanns1-0/+0
* Update docs/submodules/sdnvpn from branch 'stable/danube' - Reduce overview Change-Id: Ifb8915d62ea26f44f29c4d3b84beecd78dceae9e Signed-off-by: Nikolas Hermanns <nikolas.hermanns@ericsson.com> (cherry picked from commit c063e49cec6afa6ba1ab743a86482768fe1cc28e)
2017-03-29Update git submodulesNikolas Hermanns1-0/+0
* Update docs/submodules/sdnvpn from branch 'stable/danube' - Changing to new docs structure Change-Id: I4c15e1635981b2b5fe5473be89b5abab78bfabd5 Signed-off-by: Nikolas Hermanns <nikolas.hermanns@ericsson.com> (cherry picked from commit 0f8220d5d96cc0a45be00e937c73ab938133e587)
2017-03-29Updating the submodules HEADs manualySofia Wallin7-0/+0
Change-Id: If182c2eaf4cc3a4aa7a4da51c375cf25fd011a1b Signed-off-by: Sofia Wallin <sofia.wallin@ericsson.com>
2017-03-29Remove Openretriever submoduleSofia Wallin1-5/+0
Change-Id: I3e25775eea6ae5c426e449c87330b4f127e9156d Signed-off-by: Sofia Wallin <sofia.wallin@ericsson.com>
2017-03-29Updated VSPERF description and fixed Wiki links to projectTrevor Cooper2-5/+7
Change-Id: Ic71f8004621dbb99715907ba3d82acd0f20e2291 Signed-off-by: Trevor Cooper <trevor.cooper@intel.com> (cherry picked from commit b54f4712cea42b96d5a6c5a63066119f6e90470e)
2017-03-29Fix search form overflowShubhamRathi1-0/+8
Search input in the navbar overflowed to the next line in the navbar in certain pages. Change-Id: Ica9b01c6051cb2649f773a90a506ab89a8d74ac3 Signed-off-by: ShubhamRathi <shubhamiiitbackup@gmail.com> (cherry picked from commit dc9acd0ae17c4be0f7ad0f059b175d99185b0268)
2017-03-29Merge "Adding the submdules directory for DoveTail." into stable/danubeSofia Wallin2-0/+5
2017-03-29Adding the submdules directory for DoveTail.ChristopherPrice2-0/+5
Can be cherry picked to stable, the content will not be linked in docs.opnfv.org at this time. Change-Id: Iae4ab8e9bc902c2726b69386b3ecf611f7890dee Signed-off-by: ChristopherPrice <christopher.price@ericsson.com>
2017-03-29Show master branch as 'Latest'ShubhamRathi1-2/+3
Documentation built on RTD shows the branch name of the latest (master) branch as Danube. This patch fixes the branch name to 'Latest' Change-Id: I3d52fda5992fbb3e5fb17c9784d7a98396c0ebdc Signed-off-by: ShubhamRathi <shubhamiiitbackup@gmail.com> (cherry picked from commit e0ec89a74253d01f3fa9b471fcfd6ca247710345)
2017-03-29Re-order testing user guide index pageYujun Zhang1-4/+4
Testing tools needs to be configured before use. Change-Id: I04862af1c9d2ee8d9fdb91397c3e18da2207a964 Signed-off-by: Yujun Zhang <zhang.yujunz@zte.com.cn> (cherry picked from commit b775f4fca6cfa580f71dc338dcf063e3397a80cf)
2017-03-29Remove Moon, Add PromiceShubhamRathi1-76/+387
Moon has been deferred until E release. Promice was erroneously removed, re-adding. Change-Id: Ia5c5989f9aa9811998755f4c0802756e1b088c67 Signed-off-by: ShubhamRathi <shubhamiiitbackup@gmail.com> (cherry picked from commit bdefaca3c0136edfeb0b00817d72a69b768fb0a5)
2017-03-29Remove Moon & OVSNFV documentationShubhamRathi1-4/+0
Change-Id: I87026f857af1c589426158bb89db6b1f9324e2e1 Signed-off-by: ShubhamRathi <shubhamiiitbackup@gmail.com> (cherry picked from commit 61f47cdee31c3c8e14475b07ea5a991a8e8ad474)
2017-03-29Updated vsperf doc refs for release-notes and testingTrevor Cooper3-3/+21
Change-Id: I736ff7c5699e5be929ebe9104a0dfc619ef0ebc8 Signed-off-by: Trevor Cooper <trevor.cooper@intel.com> (cherry picked from commit cb5d501a339ef5b8ce262efd17d5b1729d95757a)
2017-03-29Updating Submodule refsSofia Wallin1-1/+0
Change-Id: I90dbb2cb78d5db7844badfbcea80751e76c4fd0a Signed-off-by: ShubhamRathi <shubhamiiitbackup@gmail.com> Signed-off-by: Sofia Wallin <sofia.wallin@ericsson.com>
2017-03-29Update git submodulesyuyang1-0/+0
* Update docs/submodules/bottlenecks from branch 'stable/danube' - bugfix: bottlenecks devguide in docs.opnfv.org JIRA: BOTTLENECK-149 Adjust the directory structure to make Bottlenecks devguide on docs.opnfv.org. Change-Id: Ib773a26ca5f4eaee94834ff641ec45531ef3025c Signed-off-by: yuyang <Gabriel.yuyang@huawei.com> (cherry picked from commit 3480c32bb5113a8a5f56b7e1db82c3a9236418fb)
2017-03-29Update git submodulesyuyang1-0/+0
* Update docs/submodules/bottlenecks from branch 'stable/danube' - bugfix: fix bugs for running 'teststory run' JIRA: BOTTLENECK-144 utils/parser.py:56 has incorrect var:cls which cause pass more var to testcase_read function. Change-Id: I2d4b93f95d19a205e537515529746f6d9e13fe2c Signed-off-by: yuyang <Gabriel.yuyang@huawei.com> (cherry picked from commit 1760c89637ac71b877a17896e5768640a20360c3)
2017-03-29Make gerrit URL relativeShubhamRathi1-38/+38
Change-Id: I005a70a2ecca597fe8bb16c755d9acc35d7999f1 Signed-off-by: ShubhamRathi <shubhamiiitbackup@gmail.com> (cherry picked from commit 93f2c3343f7ad404ede346222f55ddd7985183ac)
2017-03-29Merge "Add ignore = dirty in gitmodule" into stable/danubeSofia Wallin1-40/+38
2017-03-29Add ignore = dirty in gitmoduleShubhamRathi1-40/+38
Change-Id: Ia08581f90a63d1acc19a33c16cc3e83a76c00682 Signed-off-by: ShubhamRathi <shubhamiiitbackup@gmail.com>
2017-03-29Update git submodulesyuyang1-0/+0
* Update docs/submodules/bottlenecks from branch 'stable/danube' - Add docker clean-up for run test JIRA: BOTTLENECK-148 Currently, only OPNFV CI includes env-cleanup for Bottlenecks. It is preferable to also include the operation locally for test automation and repeatability. Changes: 1. Translate tab into 4 spaces Change-Id: I9f4efb95c155e442afd3141c00f707421c61b2da Signed-off-by: yuyang <Gabriel.yuyang@huawei.com> (cherry picked from commit fe83578bd2fe1a09f8334f85e30a0afbb68cc5cc)
2017-03-29Update git submodulesTrevor Cooper1-0/+0
* Update docs/submodules/vswitchperf from branch 'stable/danube' - Fixed indexes Change-Id: I5e10d9b2469ed7ec7fbced12b041e659bd568c2d Signed-off-by: Trevor Cooper <trevor.cooper@intel.com>
2017-03-29Update git submodulesTrevor Cooper1-0/+0
* Update docs/submodules/vswitchperf from branch 'stable/danube' - Updated index Change-Id: I9e180eff666c3ca98eb51d9c958e3b1410ddddd5 Signed-off-by: Trevor Cooper <trevor.cooper@intel.com>
2017-03-29Update git submodulesTrevor Cooper1-0/+0
* Update docs/submodules/vswitchperf from branch 'stable/danube' - Removed Indices Change-Id: I57420dfca1a2113ebc35faded3084116c670dbc1 Signed-off-by: Trevor Cooper <trevor.cooper@intel.com>
2017-03-28Update git submodulesUlas Kozat1-0/+0
* Update docs/submodules/domino from branch 'stable/danube' - JIRA 23: Fix line break in configuration section Change-Id: I9866e50dba2e36b97b5f0b1930609ffcb77dc8d2 Signed-off-by: Ulas Kozat <ulas.kozat@gmail.com>
2017-03-28Update git submodulesBin Hu1-0/+0
* Update docs/submodules/ipv6 from branch 'stable/danube' - Fix typo issue Change-Id: If4d0bad9d2ce0e90dd59f11a4bec7484307feacc Signed-off-by: Bin Hu <bh526r@att.com> (cherry picked from commit 087c95c300b0c6599a1c9d39151d06df1352789c) - Final 1.0.0 for Release Notes Change-Id: I2494a6c28233d6667ebab5db97c7366a1762f817 Signed-off-by: Bin Hu <bh526r@att.com> (cherry picked from commit 4ee9deb73423eafc67f37c076fc7e2de9535efd2) - Split Gap Analysis into 2 files One for OpenStack Newton, and the other for ODL Boron. Change-Id: Ic2e7d67c44e33009a402e02ea27d9c0fe38485ef Signed-off-by: Bin Hu <bh526r@att.com> (cherry picked from commit 951f066001be8a3184084a759f3a9ef4d2fcfa20) - Update the reference URL of OPNFV Releases Change-Id: I010074952edb8f5ef100cd48414c8cc6f518a76b Signed-off-by: Bin Hu <bh526r@att.com> (cherry picked from commit e136eed871db256c4ffbcd21eb0eeef1e2735d7a) - Draft of Release Notes Change-Id: I76d4390f3916bb9eff14ef477e6274d47d501d67 Signed-off-by: Bin Hu <bh526r@att.com> (cherry picked from commit 6805a791acbbaa26d3363dc8dabcdff4c7a1d99a)
2017-03-28Update git submoduleskalyanreddy1-0/+0
* Update docs/submodules/kvmfornfv from branch 'stable/danube' - Update documentation structure. This patch includes adjusting docs directory structure for kvmfornfv project. Change-Id: Ic2f992cd5e8f6808ca3ba088172eb6da342182ba Signed-off-by: Gundarapu Kalyan Reddy <reddyx.gundarapu@intel.com>
2017-03-28Update git submodulesMichael Polenchuk1-0/+0
* Update docs/submodules/fuel from branch 'stable/danube' - Revert "Revert: Blueprint "bp/distributed-serialization"" This reverts commit 8b28c44a4be6beef8a71e672f543001bcc0a080f. The issue has been fixed in upstream. Change-Id: Id4ad8fb7b1ec887f8d8d1d5b18a9b33a73bda10c Signed-off-by: Michael Polenchuk <mpolenchuk@mirantis.com> (cherry picked from commit 4a360c5076f839c8b700638f9b85c3e630894826)
2017-03-28Update git submodulesSofia Wallin1-0/+0
* Update docs/submodules/joid from branch 'stable/danube' - Updated release name and release date Change-Id: I64d1c3abb1b5556bf81fb2a637614f02cb92d679 Signed-off-by: Sofia Wallin <sofia.wallin@ericsson.com> (cherry picked from commit 2c03acdb23144b72ed9c8b5f9b85c8646172a057) - Add interface renaming on maas for heterogeneous hardware config Change-Id: I7b26821802f1843d738a116082b70bd27b35b35b Signed-off-by: Blaisonneau David <david.blaisonneau@orange.com> (cherry picked from commit 4afffb76ced3bafae18e92a80137c25f969898f2) - correct of maas deploy and orange pod2 update MAAS deploy correction to manage heterogeneous hardware (different interfaces mapping or naming amoung nodes, and configuration of a VLAN on an interface without network_cidr) Change-Id: Ib3825bd8600cf62637cee85779d9ee0a55f896c4 Signed-off-by: Blaisonneau David <david.blaisonneau@orange.com> - Add labels for scenario docs Change-Id: I6e0e3fbc51b6d164144e22b236705eebb79050ba Signed-off-by: ShubhamRathi <shubhamiiitbackup@gmail.com> (cherry picked from commit 9cb4fd572a2cf6966adc4c94ce1a606a4ca94774) - configure the VIP accordingly and also change the sequence. Remove the admin-openrc file. Change-Id: I8a14dc6de22d0f0de346d69e6d02a7e9c295ece1 Signed-off-by: Narinder Gupta <narinder.gupta@canonical.com> (cherry picked from commit 0c50df832b79dc06fa44dfd918d78ceb894ffd64) - fix for mutiple block devices for lxd containers. Change-Id: I4e7cb6b8505d0c2c395adf0345cbf22e63a73853 Signed-off-by: Narinder Gupta <narinder.gupta@canonical.com> (cherry picked from commit c44406f505cb49858caf1a2b1c2f2606cf935d92) - modfiied to corner the concerns of Orange labs. Change-Id: I82125424714ce5083f045224f8fc9fa4c7a0edc2 Signed-off-by: Narinder Gupta <narinder.gupta@canonical.com> (cherry picked from commit cb6d37a8b4f7762fbd254e9870a19c2c4d865553) - Updated the documentation as per latest devlopment. Change-Id: If62157368de79c7c44adc3e27945e1bf6dbf6b2c Signed-off-by: Narinder Gupta <narinder.gupta@canonical.com>
2017-03-28Update git submoduleskalyanreddy1-0/+0
* Update docs/submodules/kvmfornfv from branch 'stable/danube' - Update documentation structure. This patch is used to update documentation structure. Change-Id: I50d4ef4256ccfc57a0434123e7532a50000582cf Co-Authored by:Srinivas <srinivas.atmakuri@tcs.com> Co-Authored by:RajithaY<rajithax.yerrumsetty@intel.com> Co-Authored by:shravani paladugula <shravanix.paladugula@intel.com> Co-Authored by:Navya Bathula <navyax.bathula@intel.com> Signed-off-by: Gundarapu Kalyan Reddy <reddyx.gundarapu@intel.com> (cherry picked from commit f1f3cc27f23bdde81c37d8142d4288d811bd5e45)
2017-03-28Update git submodulesGeorg Kunz1-0/+0
* Update docs/submodules/netready from branch 'stable/danube' - Fixing broken links in documentation Using rst references to link to other documentation pages instead of relative HTML links. Change-Id: Id8164a4f50f4fd39c996f5ae354b22f3c960fb08 Signed-off-by: Georg Kunz <georg.kunz@ericsson.com> (cherry picked from commit 0c59ca9234d712a74fa01c1eaba676dfb0080052) - Adding further documentation for the Gluon scenario Change-Id: I4926ab30223312b91b6349b798f652615d70001e Signed-off-by: Georg Kunz <georg.kunz@ericsson.com> (cherry picked from commit 8a3e022acdcab14bd1f51cf08f4a26004dda49e7)
2017-03-28Few minor edits plus used the SPDX license identifierRay Paik1-10/+10
Change-Id: Ibdd3c700bdf0ed8f67d5cd794568a99c2d0efab9 Signed-off-by: Ray Paik <rpaik@linuxfoundation.org> (cherry picked from commit 9bce0476fec83c40e5fb1e60134d44f44151743f)
2017-03-28Update git submodulesShubhamRathi1-0/+0
* Update docs/submodules/fds from branch 'stable/danube' - Add Scenario Documentation Labels Change-Id: Icff2c400c054d960c3c4ec32bc2c69c561c5bf1d Signed-off-by: ShubhamRathi <shubhamiiitbackup@gmail.com> (cherry picked from commit 03210b90f9208a2e2d80f9f31d6132e7b2ca576f)
2017-03-28Update git submodulesGeorge Paraskevopoulos1-0/+0
* Update docs/submodules/functest from branch 'stable/danube' - Revert "Make SFC test a python call to main()" This reverts commit d5820bef80ea4bdb871380dbfe41db12290fc5f8. Robot test runs before SFC test and it imports https://github.com/robotframework/SSHLibrary which does a monkey patching in the python runtime / paramiko. Untill now sfc run in a new python process (clean) because it run using the bash command. But when importing it as a module and call main() from python, it will run in the patched runtime and it will error out. https://hastebin.com/iyobuxutib.py Change-Id: I54237c32c957718b363d302efe84e01bc78e4f47 Signed-off-by: George Paraskevopoulos <geopar@intracom-telecom.com> (cherry picked from commit e59055e29b5cc6a027d3a24803cc05fd709cca90)
2017-03-28Update git submodulesTomas Cechvala1-0/+0
* Update docs/submodules/fds from branch 'stable/danube' - Check for a flavor with hugepages Flavor is not checked by name but by huge_pages extra option. It is created when no flavor has huge_pages setting. Change-Id: I1266a6e58047c24456b12f16fc3061082916558c Signed-off-by: Tomas Cechvala <tcechval@cisco.com> Signed-off-by: juraj.linkes <jlinkes@cisco.com> (cherry picked from commit a717a49967f77ede476da582b6d3bb2c6359da1b)
2017-03-28Update git submodulesYujun Zhang1-0/+0
* Update docs/submodules/qtip from branch 'stable/danube' - Merge "Add overview in developer guide" into stable/danube - Add overview in developer guide Change-Id: I491f921d87cf0cec3bbef5a78e9f3065b1e012a1 Signed-off-by: Yujun Zhang <zhang.yujunz@zte.com.cn> (cherry picked from commit cb8ec13d8981cea1dc5556d86ea01b45c29f1046)
2017-03-28Update git submodulesNikolas Hermanns1-0/+0
* Update docs/submodules/functest from branch 'stable/danube' - Remove vping_ssh from bgpvpn and gluon scenario Cause of the bug: https://bugs.opendaylight.org/show_bug.cgi?id=5586 Floating ip is not working at the moment for us. We don't want to remove the vping_ssh test from fuel. the scenarios are called different in fuel and in apex. odl-bgpvpn in apex. odl_l2-bgpvpn in fuel. Change-Id: Iaa2e6cea8a4fdb8635f018427aaf30634fd8d2d5 Signed-off-by: Nikolas Hermanns <nikolas.hermanns@ericsson.com> (cherry picked from commit 5af67bcca589c275b73fe5e4bca9bea5871948aa)
2017-03-28Update git submodulesakhilbatra8981-0/+0
* Update docs/submodules/qtip from branch 'stable/danube' - Add API docs - Add developer guide for API - Add user guide for API - Add api to user guide doctree JIRA: QTIP-234 Change-Id: Id388f82c52e31b3c75599ab846e64431be8083b7 Signed-off-by: akhilbatra898 <akhil.batra@research.iiit.ac.in> (cherry picked from commit 6cd177d400b3462cd6c6b251f9135b45c33dfbb8)
2017-03-28Update git submodulesYujun Zhang1-0/+0
* Update docs/submodules/qtip from branch 'stable/danube' - Merge "remove replicated dependencies" into stable/danube - remove replicated dependencies Change-Id: Ie82153d201a06e7008465a5ea116b389dc1311c6 Signed-off-by: SerenaFeng <feng.xiaowei@zte.com.cn> (cherry picked from commit 50ab8b586a0564da1e1d029bff65d36464142fce)
2017-03-28Update git submodulesYujun Zhang1-0/+0
* Update docs/submodules/qtip from branch 'stable/danube' - Merge "cite danube.rst in index.rst" into stable/danube - cite danube.rst in index.rst Change-Id: I00aa92a22e4e6aabd69463f3dd97d5d4a58f1e3a Signed-off-by: SerenaFeng <feng.xiaowei@zte.com.cn> (cherry picked from commit 7bae1022dcb5fd89016254b70566721e8b59eae3)
2017-03-28Update git submodulesYujun Zhang1-0/+0
* Update docs/submodules/qtip from branch 'stable/danube' - Merge "update user docs" into stable/danube - update user docs Change-Id: I7a7a1343c457fe1c3063dfeafa079154d495eac0 Signed-off-by: wu.zhihui <wu.zhihui1@zte.com.cn> (cherry picked from commit 16f2362065636b833c31722c778e485f62acb981)
2017-03-28Update git submodulesYujun Zhang1-0/+0
* Update docs/submodules/qtip from branch 'stable/danube' - Merge "Align folder structure `docs/testing/developer` to opnfvdocs template" into stable/danube - Align folder structure `docs/testing/developer` to opnfvdocs template Change-Id: I9ce069cf4b5384b5788ca7cfc70e4188519667d5 Signed-off-by: Yujun Zhang <zhang.yujunz@zte.com.cn> (cherry picked from commit 9639c68d1ed674f74ff1b187346241f5d7c82910)
2017-03-28Update git submodulesYujun Zhang1-0/+0
* Update docs/submodules/qtip from branch 'stable/danube' - Merge "Rename docs/testing/developer/design to docs/testing/developer/devguide" into stable/danube - Rename docs/testing/developer/design to docs/testing/developer/devguide See https://git.opnfv.org/opnfvdocs/tree/docs/testing/testing-dev.rst Change-Id: Iac14adf4a2876fd74972dcf6279f7022e92cb9b5 Signed-off-by: Yujun Zhang <zhang.yujunz@zte.com.cn>
2017-03-28Update git submodulesYujun Zhang1-0/+0
* Update docs/submodules/qtip from branch 'stable/danube' - Merge "Add project introduction" into stable/danube - Add project introduction Change-Id: I5d0553f0ccec571f9db90b2fd8f25f0941f00b03 Signed-off-by: Yujun Zhang <zhang.yujunz@zte.com.cn>
2017-03-28Update git submodulesTaseer1-0/+0
* Update docs/submodules/qtip from branch 'stable/danube' - Add info about selective running Change-Id: Ic5f7969c3d3969b7790d17beec10d73991ca8d08 Signed-off-by: Taseer Ahmed <taseer94@gmail.com> (cherry picked from commit ee667225c20ded7d6dbfc38e8631fc96cc0dea2a)
2017-03-28Update git submodulesNikolas Hermanns1-0/+0
* Update docs/submodules/sdnvpn from branch 'stable/danube' - Remove quagga fix in the testcase Solves partly: JIRA: SDNVPN-130 Change-Id: I1cf99e9294925545f6fece660983e32f6543f2b8 Signed-off-by: Nikolas Hermanns <nikolas.hermanns@ericsson.com> (cherry picked from commit 5960fab7230bebbffc439457d5542d086cb3f8af)
2017-03-28Update git submodulesTim Rozet1-0/+0
* Update docs/submodules/apex from branch 'stable/danube' - Merge "Fix quagga user and dirs" into stable/danube - Fix quagga user and dirs The rpm spec of quagga still misses the correct user and dir setup for quagga. This is the jira to remove this later on: https://jira.opnfv.org/projects/SDNVPN/issues/SDNVPN-130 Change-Id: I71885a6b177443f58d0c093833e76656eb83b428 Signed-off-by: Nikolas Hermanns <nikolas.hermanns@ericsson.com> (cherry picked from commit 7dcaaf6f8f7af379124c65f3a19f4890064fa97c)
2017-03-28Update git submodulesJingLu51-0/+0
* Update docs/submodules/yardstick from branch 'stable/danube' - Bugfix:add storperf flavor for TC074 JIRA: YARDSTICK-604 the storperf container now uses a flavor called "storperf", if this flavor is absent, stack creating process will fail. also the openstack variables that passed to the storperf container also needs a update Change-Id: Iab4be6491cc9b24526948e5571f0476ec885a93d Signed-off-by: JingLu5 <lvjing5@huawei.com> (cherry picked from commit 0691766d310e00d7f1cec763427db271076b5633)
2017-03-28Update git submodulesTim Rozet1-0/+0
* Update docs/submodules/apex from branch 'stable/danube' - Merge "Adding OVN as an SDN option to Apex" into stable/danube - Adding OVN as an SDN option to Apex JIRA: APEX-129 opnfv-tht-pr: 111 opnfv-puppet-tripleo-pr: 18 Change-Id: I71de5802ed476b6f78ad5a718ac15d9aec9a6a1d Signed-off-by: Dan Radez <dradez@redhat.com>
2017-03-28Update git submodulesTim Rozet1-0/+0
* Update docs/submodules/apex from branch 'stable/danube' - Disables ODL clustering for FDIO+ODL scenarios ODL clustering has issues with VPP mounting, so we are disabling clustering for now and should have the bug in ODL fixed by Danube 2.0. Change-Id: I19b9c9167596105a3197de8c5a537bed1280f241 Signed-off-by: Tim Rozet <trozet@redhat.com> (cherry picked from commit 5108498adb2870581cc5a4bb99db693a05ff9c3b)
2017-03-28Update git submodulesYujun Zhang1-0/+0
* Update docs/submodules/qtip from branch 'stable/danube' - Merge "Update CLI docs." into stable/danube - Update CLI docs. - Update command to execute runner - Include reporter JIRA: QTIP-231 Change-Id: I834ac94821cea7221078fbb6160ef7467b2bd4cf Signed-off-by: Taseer Ahmed <taseer94@gmail.com>