1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
265
266
267
268
269
270
271
272
273
274
275
276
277
278
279
280
281
282
283
284
285
286
287
288
289
290
291
292
293
294
295
296
297
298
299
300
301
302
303
304
305
306
307
308
309
310
311
312
313
314
315
316
317
318
319
320
321
322
323
324
325
326
327
328
329
330
331
332
333
334
335
336
337
338
339
340
341
342
343
344
345
346
347
348
349
350
351
352
353
354
355
356
357
358
359
360
361
362
363
|
package org.apache.maven.project;
/*
* Licensed to the Apache Software Foundation (ASF) under one
* or more contributor license agreements. See the NOTICE file
* distributed with this work for additional information
* regarding copyright ownership. The ASF licenses this file
* to you under the Apache License, Version 2.0 (the
* "License"); you may not use this file except in compliance
* with the License. You may obtain a copy of the License at
*
* http://www.apache.org/licenses/LICENSE-2.0
*
* Unless required by applicable law or agreed to in writing,
* software distributed under the License is distributed on an
* "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
* KIND, either express or implied. See the License for the
* specific language governing permissions and limitations
* under the License.
*/
import java.util.ArrayList;
import java.util.Collections;
import java.util.List;
import junit.framework.TestCase;
import org.apache.maven.model.Build;
import org.apache.maven.model.Dependency;
import org.apache.maven.model.Extension;
import org.apache.maven.model.Model;
import org.apache.maven.model.Parent;
import org.apache.maven.model.Plugin;
import org.apache.maven.model.PluginManagement;
import org.codehaus.plexus.util.dag.CycleDetectedException;
/**
* Test sorting projects by dependencies.
*
* @author <a href="mailto:brett@apache.org">Brett Porter</a>
*/
public class ProjectSorterTest
extends TestCase
{
private Parent createParent( MavenProject project )
{
return createParent( project.getGroupId(), project.getArtifactId(), project.getVersion() );
}
private Parent createParent( String groupId, String artifactId, String version )
{
Parent plugin = new Parent();
plugin.setGroupId( groupId );
plugin.setArtifactId( artifactId );
plugin.setVersion( version );
return plugin;
}
private Dependency createDependency( MavenProject project )
{
return createDependency( project.getGroupId(), project.getArtifactId(), project.getVersion() );
}
private Dependency createDependency( String groupId, String artifactId, String version )
{
Dependency depdendency = new Dependency();
depdendency.setGroupId( groupId );
depdendency.setArtifactId( artifactId );
depdendency.setVersion( version );
return depdendency;
}
private Plugin createPlugin( MavenProject project )
{
return createPlugin( project.getGroupId(), project.getArtifactId(), project.getVersion() );
}
private Plugin createPlugin( String groupId, String artifactId, String version )
{
Plugin plugin = new Plugin();
plugin.setGroupId( groupId );
plugin.setArtifactId( artifactId );
plugin.setVersion( version );
return plugin;
}
private Extension createExtension( String groupId, String artifactId, String version )
{
Extension extension = new Extension();
extension.setGroupId( groupId );
extension.setArtifactId( artifactId );
extension.setVersion( version );
return extension;
}
private static MavenProject createProject( String groupId, String artifactId, String version )
{
Model model = new Model();
model.setGroupId( groupId );
model.setArtifactId( artifactId );
model.setVersion( version );
model.setBuild( new Build() );
return new MavenProject( model );
}
public void testShouldNotFailWhenPluginDepReferencesCurrentProject()
throws CycleDetectedException, DuplicateProjectException
{
MavenProject project = createProject( "group", "artifact", "1.0" );
Build build = project.getModel().getBuild();
Plugin plugin = createPlugin( "other.group", "other-artifact", "1.0" );
Dependency dep = createDependency( "group", "artifact", "1.0" );
plugin.addDependency( dep );
build.addPlugin( plugin );
new ProjectSorter( Collections.singletonList( project ) );
}
public void testShouldNotFailWhenManagedPluginDepReferencesCurrentProject()
throws CycleDetectedException, DuplicateProjectException
{
MavenProject project = createProject( "group", "artifact", "1.0" );
Build build = project.getModel().getBuild();
PluginManagement pMgmt = new PluginManagement();
Plugin plugin = createPlugin( "other.group", "other-artifact", "1.0" );
Dependency dep = createDependency( "group", "artifact", "1.0" );
plugin.addDependency( dep );
pMgmt.addPlugin( plugin );
build.setPluginManagement( pMgmt );
new ProjectSorter( Collections.singletonList( project ) );
}
public void testShouldNotFailWhenProjectReferencesNonExistentProject()
throws CycleDetectedException, DuplicateProjectException
{
MavenProject project = createProject( "group", "artifact", "1.0" );
Build build = project.getModel().getBuild();
Extension extension = createExtension( "other.group", "other-artifact", "1.0" );
build.addExtension( extension );
new ProjectSorter( Collections.singletonList( project ) );
}
public void testMatchingArtifactIdsDifferentGroupIds()
throws CycleDetectedException, DuplicateProjectException
{
List<MavenProject> projects = new ArrayList<MavenProject>();
MavenProject project1 = createProject( "groupId1", "artifactId", "1.0" );
projects.add( project1 );
MavenProject project2 = createProject( "groupId2", "artifactId", "1.0" );
projects.add( project2 );
project1.getDependencies().add( createDependency( project2 ) );
projects = new ProjectSorter( projects ).getSortedProjects();
assertEquals( project2, projects.get( 0 ) );
assertEquals( project1, projects.get( 1 ) );
}
public void testMatchingGroupIdsDifferentArtifactIds()
throws CycleDetectedException, DuplicateProjectException
{
List<MavenProject> projects = new ArrayList<MavenProject>();
MavenProject project1 = createProject( "groupId", "artifactId1", "1.0" );
projects.add( project1 );
MavenProject project2 = createProject( "groupId", "artifactId2", "1.0" );
projects.add( project2 );
project1.getDependencies().add( createDependency( project2 ) );
projects = new ProjectSorter( projects ).getSortedProjects();
assertEquals( project2, projects.get( 0 ) );
assertEquals( project1, projects.get( 1 ) );
}
public void testMatchingIdsAndVersions()
throws CycleDetectedException
{
List<MavenProject> projects = new ArrayList<MavenProject>();
MavenProject project1 = createProject( "groupId", "artifactId", "1.0" );
projects.add( project1 );
MavenProject project2 = createProject( "groupId", "artifactId", "1.0" );
projects.add( project2 );
try
{
projects = new ProjectSorter( projects ).getSortedProjects();
fail( "Duplicate projects should fail" );
}
catch ( DuplicateProjectException e )
{
// expected
assertTrue( true );
}
}
public void testMatchingIdsAndDifferentVersions()
throws CycleDetectedException, DuplicateProjectException
{
List<MavenProject> projects = new ArrayList<MavenProject>();
MavenProject project1 = createProject( "groupId", "artifactId", "1.0" );
projects.add( project1 );
MavenProject project2 = createProject( "groupId", "artifactId", "2.0" );
projects.add( project2 );
projects = new ProjectSorter( projects ).getSortedProjects();
assertEquals( project1, projects.get( 0 ) );
assertEquals( project2, projects.get( 1 ) );
}
public void testPluginDependenciesInfluenceSorting()
throws Exception
{
List<MavenProject> projects = new ArrayList<MavenProject>();
MavenProject parentProject = createProject( "groupId", "parent", "1.0" );
projects.add( parentProject );
MavenProject declaringProject = createProject( "groupId", "declarer", "1.0" );
declaringProject.setParent( parentProject );
declaringProject.getModel().setParent( createParent( parentProject ) );
projects.add( declaringProject );
MavenProject pluginLevelDepProject = createProject( "groupId", "plugin-level-dep", "1.0" );
pluginLevelDepProject.setParent( parentProject );
pluginLevelDepProject.getModel().setParent( createParent( parentProject ) );
projects.add( pluginLevelDepProject );
MavenProject pluginProject = createProject( "groupId", "plugin", "1.0" );
pluginProject.setParent( parentProject );
pluginProject.getModel().setParent( createParent( parentProject ) );
projects.add( pluginProject );
Plugin plugin = createPlugin( pluginProject );
plugin.addDependency( createDependency( pluginLevelDepProject ) );
Build build = declaringProject.getModel().getBuild();
build.addPlugin( plugin );
projects = new ProjectSorter( projects ).getSortedProjects();
assertEquals( parentProject, projects.get( 0 ) );
// the order of these two is non-deterministic, based on when they're added to the reactor.
assertTrue( projects.contains( pluginProject ) );
assertTrue( projects.contains( pluginLevelDepProject ) );
// the declaring project MUST be listed after the plugin and its plugin-level dep, though.
assertEquals( declaringProject, projects.get( 3 ) );
}
public void testPluginDependenciesInfluenceSorting_DeclarationInParent()
throws Exception
{
List<MavenProject> projects = new ArrayList<MavenProject>();
MavenProject parentProject = createProject( "groupId", "parent-declarer", "1.0" );
projects.add( parentProject );
MavenProject pluginProject = createProject( "groupId", "plugin", "1.0" );
pluginProject.setParent( parentProject );
pluginProject.getModel().setParent( createParent( parentProject ) );
projects.add( pluginProject );
MavenProject pluginLevelDepProject = createProject( "groupId", "plugin-level-dep", "1.0" );
pluginLevelDepProject.setParent( parentProject );
pluginLevelDepProject.getModel().setParent( createParent( parentProject ) );
projects.add( pluginLevelDepProject );
Plugin plugin = createPlugin( pluginProject );
plugin.addDependency( createDependency( pluginLevelDepProject ) );
Build build = parentProject.getModel().getBuild();
build.addPlugin( plugin );
projects = new ProjectSorter( projects ).getSortedProjects();
System.out.println( projects );
assertEquals( parentProject, projects.get( 0 ) );
// the order of these two is non-deterministic, based on when they're added to the reactor.
assertTrue( projects.contains( pluginProject ) );
assertTrue( projects.contains( pluginLevelDepProject ) );
}
public void testPluginVersionsAreConsidered()
throws Exception
{
List<MavenProject> projects = new ArrayList<MavenProject>();
MavenProject pluginProjectA = createProject( "group", "plugin-a", "2.0-SNAPSHOT" );
projects.add( pluginProjectA );
pluginProjectA.getModel().getBuild().addPlugin( createPlugin( "group", "plugin-b", "1.0" ) );
MavenProject pluginProjectB = createProject( "group", "plugin-b", "2.0-SNAPSHOT" );
projects.add( pluginProjectB );
pluginProjectB.getModel().getBuild().addPlugin( createPlugin( "group", "plugin-a", "1.0" ) );
projects = new ProjectSorter( projects ).getSortedProjects();
assertTrue( projects.contains( pluginProjectA ) );
assertTrue( projects.contains( pluginProjectB ) );
}
public void testDependencyPrecedesProjectThatUsesSpecificDependencyVersion()
throws Exception
{
List<MavenProject> projects = new ArrayList<MavenProject>();
MavenProject usingProject = createProject( "group", "project", "1.0" );
projects.add( usingProject );
usingProject.getModel().addDependency( createDependency( "group", "dependency", "1.0" ) );
MavenProject pluginProject = createProject( "group", "dependency", "1.0" );
projects.add( pluginProject );
projects = new ProjectSorter( projects ).getSortedProjects();
assertEquals( pluginProject, projects.get( 0 ) );
assertEquals( usingProject, projects.get( 1 ) );
}
public void testDependencyPrecedesProjectThatUsesUnresolvedDependencyVersion()
throws Exception
{
List<MavenProject> projects = new ArrayList<MavenProject>();
MavenProject usingProject = createProject( "group", "project", "1.0" );
projects.add( usingProject );
usingProject.getModel().addDependency( createDependency( "group", "dependency", "[1.0,)" ) );
MavenProject pluginProject = createProject( "group", "dependency", "1.0" );
projects.add( pluginProject );
projects = new ProjectSorter( projects ).getSortedProjects();
assertEquals( pluginProject, projects.get( 0 ) );
assertEquals( usingProject, projects.get( 1 ) );
}
}
|
