aboutsummaryrefslogtreecommitdiffstats
path: root/xtesting/utils
diff options
context:
space:
mode:
authorVincent Danno <vincent.danno@orange.com>2021-05-10 09:28:36 +0200
committerVincent Danno <vincent.danno@orange.com>2021-05-10 09:28:36 +0200
commit92eb358358a3cb4a70daa8bbe6e53a1ff44c9d17 (patch)
treefbdd179b9d2e1a9b410534fcea417f1203ca23de /xtesting/utils
parent81576fd969217d38f2ccc26434ea286bb704df94 (diff)
Remove unnecessary condition in statement flow
First, the condition should be limited to only defining the default value, rather than applying to the statement flow. This not only avoids unnecessary repetition of statements, but is more logical. Second, it is not even necessary to explicitly code a condition here, because the language itself defaults to our desired default value. Signed-off-by: Vincent Danno <vincent.danno@orange.com> Change-Id: I119567f5b31444a0e864ba41dee8a5f640ff0c22
Diffstat (limited to 'xtesting/utils')
-rw-r--r--xtesting/utils/env.py5
1 files changed, 2 insertions, 3 deletions
diff --git a/xtesting/utils/env.py b/xtesting/utils/env.py
index 042ab675..83484914 100644
--- a/xtesting/utils/env.py
+++ b/xtesting/utils/env.py
@@ -30,9 +30,8 @@ INPUTS = {
def get(env_var):
- if env_var not in INPUTS.keys():
- return os.environ.get(env_var, None)
- return os.environ.get(env_var, INPUTS[env_var])
+ # defaults to None if env_var is not found
+ return os.environ.get(env_var, INPUTS.get(env_var))
def string():