aboutsummaryrefslogtreecommitdiffstats
path: root/docs
AgeCommit message (Collapse)AuthorFilesLines
2017-04-20Merge "ixia: Support of 1 NIC connection to trafficgen"Martin Klozik1-0/+8
2017-04-19docs: Remove whitespaces from indexesMartin Klozik2-3/+3
Whitespaces were removed from RST indexes to correctly pass rst validation. Change-Id: I5f277d5f8846653c6e7ea3fbb29881e2dd3f610b Signed-off-by: Martin Klozik <martinx.klozik@intel.com> Reviewed-by: Al Morton <acmorton@att.com> Reviewed-by: Christian Trautman <ctrautma@redhat.com> Reviewed-by: Sridhar Rao <sridhar.rao@spirent.com> Reviewed-by: Trevor Cooper <trevor.cooper@intel.com>
2017-04-19Merge "xena_verify: Add final verification option to Xena"Martin Klozik1-0/+31
2017-04-19ixia: Support of 1 NIC connection to trafficgenMartin Klozik1-0/+8
For some testcases it is useful to have only one connection between traffic generator and DUT. Thus IxNet class was extended to support such connection. Feature is enabled if both IXIA ports are set to the same value. New integration testcase ixnet_pvp_tput_1nic was created to demonstrate this feature. Unused code was removed from 3rd_party/ixia/ixnetrfc2544.tcl to simplify introduction of new features and to speed up IXIA configuration. JIRA: VSPERF-503 Change-Id: I92ab24fa58eeb1ccb7f00ac7f3530ffca7b99241 Signed-off-by: Martin Klozik <martinx.klozik@intel.com> Reviewed-by: Al Morton <acmorton@att.com> Reviewed-by: Christian Trautman <ctrautma@redhat.com> Reviewed-by: Sridhar Rao <sridhar.rao@spirent.com> Reviewed-by: Trevor Cooper <trevor.cooper@intel.com>
2017-04-18xena_verify: Add final verification option to XenaChristian Trautman1-0/+31
Adds final verification option to Xena traffic generator inside VSPerf. Works by running the Xena2544.exe again after the initial run is complete with modified values inside the json file. If the final verify fails it will revert the settings and continue the in a pattern based on if the smart search is enabled. JIRA: VSPERF-506 Change-Id: Ic272628c489b88989f67549bd020af7354dc9b91 Signed-off-by: Christian Trautman <ctrautma@redhat.com>
2017-04-12Merge "jumbo_frame: Add jumbo frame support"Martin Klozik1-0/+59
2017-03-31Changes index depthTrevor Cooper2-16/+8
Change-Id: I9f83b22eebb61de7ab98040bd67f7dd7f3caf129 Signed-off-by: Trevor Cooper <trevor.cooper@intel.com>
2017-03-30jumbo_frame: Add jumbo frame supportChristian Trautman1-0/+59
Add jumbo frame support for all packet forwarding applications inside guest for pxp testing. Enable jumbo frame support for OvsVanilla, OvsDpdkVhostUser, and Packet forwarding. Add minor fix for missing method issue when running packet forwarding tests. The get_version method was missing in the packet_forwaring core module. JIRA: VSPERF-501 Change-Id: Ia99975f47c64259ed2566bde3c85b2779c309e80 Signed-off-by: Christian Trautman <ctrautma@redhat.com>
2017-03-29Removed white spaceTrevor Cooper1-1/+1
Change-Id: I4455ce38ca81ad1d5a028c626e3ac53d6d87db43 Signed-off-by: Trevor Cooper <trevor.cooper@intel.com>
2017-03-28Fixed indexes in user and developer documentationTrevor Cooper3-20/+13
Change-Id: Iad5c130936a815c41265b29053d2978808ff14bb Signed-off-by: Trevor Cooper <trevor.cooper@intel.com>
2017-03-24ixia: Make L3 and L4 headers optionalMartin Klozik3-7/+21
During testing it is sometimes useful to generate pure L2 traffic without L3 or L4 related headers. IxNetwork TCL script was updated to support this option. Generic TRAFFIC array was enhanced by on/off switch for L3 and L4 headers. Thus it can be implemented by other traffic generators in the future, if this feature will prove itself useful. JIRA: VSPERF-500 Change-Id: I723c703e5d6ef609fd5b7db366871278a4730203 Signed-off-by: Martin Klozik <martinx.klozik@intel.com> Reviewed-by: Al Morton <acmorton@att.com> Reviewed-by: Christian Trautman <ctrautma@redhat.com> Reviewed-by: Sridhar Rao <sridhar.rao@spirent.com> Reviewed-by: Trevor Cooper <trevor.cooper@intel.com>
2017-03-24multistream: Support huge number of streamsMartin Klozik1-1/+2
Restriction of 64K streams was limited only to L4 stream type. In case of L3 and L2 stream type, it is possible to define unlimited number of streams to be simulated by traffic generator. JIRA: VSPERF-498 Change-Id: I4ce3253299473127d135c01543999a8593b9556f Signed-off-by: Martin Klozik <martinx.klozik@intel.com> Reviewed-by: Al Morton <acmorton@att.com> Reviewed-by: Christian Trautman <ctrautma@redhat.com> Reviewed-by: Bill Michalowski <bmichalo@redhat.com> Reviewed-by: Sridhar Rao <sridhar.rao@spirent.com> Reviewed-by: Trevor Cooper <trevor.cooper@intel.com>
2017-03-23Removed reference to POD 3 since VSPERF POD was moved to POD 12Trevor Cooper2-11/+7
Change-Id: Ic278ba90c3174b9f83766861981aeb66320c8963 Signed-off-by: Trevor Cooper <trevor.cooper@intel.com>
2017-03-23Added index files for user and dev doc dirsTrevor Cooper3-24/+68
Change-Id: I0ac84324be97de91c8d4730cd3cb73e994cf28a7 Signed-off-by: Trevor Cooper <trevor.cooper@intel.com>
2017-03-23Updates release note numberingTrevor Cooper2-13/+0
Change-Id: Id0510b96375033540fa80fe22b301fb1d0d20e40 Signed-off-by: Trevor Cooper <trevor.cooper@intel.com>
2017-03-22New doc structure changes for stable/danubeTrevor Cooper1-0/+1
Change-Id: I2e9b432a74ee22690fdb366de619dc3a5d2ad725 Signed-off-by: Trevor Cooper <trevor.cooper@intel.com>
2017-03-21Updated doc locations for new structureTrevor Cooper32-52/+60
Change-Id: I8d948bad350ec90618edac5fc451167c06e8baa5 Signed-off-by: Trevor Cooper <trevor.cooper@intel.com>
2017-03-22Revert "Moved doc files to testing document structureTrevor Cooper32-65/+76
This reverts commit 32a5263216d79ad34041dca55357278f092bb931. Change-Id: I641b967badffd52ffd9e249b75e67bb7c82a8150 Signed-off-by: Trevor Cooper <trevor.cooper@intel.com>
2017-03-21Moved doc files to testing document structure testing/user ... ↵Trevor Cooper32-76/+65
testing/developer and modified doc index to match dir structure Change-Id: I4b1a535808a48773505fa7874c61707cd349fced Signed-off-by: Trevor Cooper <trevor.cooper@intel.com>
2017-03-20Renamed release notes file and added index file to release-notes dirTrevor Cooper2-0/+12
Change-Id: I448fd909a89103b2c11cb16f91b8c646fb5adee8 Signed-off-by: Trevor Cooper <trevor.cooper@intel.com>
2017-03-15vpp: Initial support of VPP vSwitchMartin Klozik5-18/+68
Support of VPP was implemented into VSPERF. Initial implementation uses step driven testcases to configure P2P, PVP and PVVP network scenarios. These testcases were prepared for three RFC2544 traffic types, i.e. throughput, continuous stream and back to back. VPP configuration is driven by new configuration option VSWITCH_VPP_ARGS. It is possible to use three types of l2 port connection supported by VPP, i.e. l2 xconnect (default), l2patch and l2 bridge features. Configuration is driven by parameter VSWITCH_VPP_L2_CONNECT_MODE. JIRA: VSPERF-495 Change-Id: Idebef9b10fb0d70796adb3405fec77302de00a7e Signed-off-by: Martin Klozik <martinx.klozik@intel.com> Reviewed-by: Al Morton <acmorton@att.com> Reviewed-by: Christian Trautman <ctrautma@redhat.com> Reviewed-by: Sridhar Rao <sridhar.rao@spirent.com> Reviewed-by: Trevor Cooper <trevor.cooper@intel.com>
2017-03-07Changed "NEWS" to "Release Notes" and added openSUSETrevor Cooper1-3/+4
Change-Id: I55d50656930f386b55924ee23948b2e321d2745b Signed-off-by: Trevor Cooper <trevor.cooper@intel.com>
2017-03-07Renamed NEWS.rst to vsperf-release.rst and moved into release dir per new ↵Trevor Cooper2-6/+0
doc structure Remove reference to NEWS.rst in index file ... release notes will be referenced in Release section Change-Id: I8f32c7cd23b0b2cd33703950a71cbb626c0c35fc Signed-off-by: Trevor Cooper <trevor.cooper@intel.com>
2017-03-06Add support for openSUSE Leap 42.2Marco Varlese1-0/+1
This patch enables openSUSE Leap 42.2 systems to build and run VSPERF. Change-Id: I182cec8a11ee5f0d70670f1ae18dd35fcc257616 Signed-off-by: Marco Varlese <marco.varlese@suse.com>
2017-03-02Updated project description and license headerTrevor Cooper1-12/+18
Change-Id: I122bdec1a7fa9a9e3da51acb31b30a231eff7890 Signed-off-by: Trevor Cooper <trevor.cooper@intel.com>
2017-02-17license: Add license info to all project filesgoldammx4-0/+18
All files were updated with license header. In case of binary files is license stored in LICENSE file stored in the same directory. Packages.txt was removed, because file has not been used.List of packages differs according OS distribution, all of neccesary packages are include in instalation scripts JIRA: VSPERF-489 Change-Id: I6ecae21b8db2a0f22fa5a66f9525352080f1fcc0 Signed-off-by: Martin Goldammer <martinx.goldammer@intel.com> Reviewed-by: Martin Klozik <martinx.klozik@intel.com> Reviewed-by: Al Morton <acmorton@att.com> Reviewed-by: Christian Trautman <ctrautma@redhat.com> Reviewed-by: Bill Michalowski <bmichalo@redhat.com> Reviewed-by: Antonio Fischetti <antonio.fischetti@intel.com> Reviewed-by: Sridhar Rao <sridhar.rao@spirent.com>
2017-01-30docs: Remove hyperlinks to docs in artifactsMartin Klozik20-215/+172
It is possible to use sphinx cross referencing feature in case, that only one level of toctree is used. Thus documentation was reorganized to utilize just one top level index with toctree. After that it was possible to use rst native syntax to create a cross links among vsperf documentation chapters. As a result only 2 hyperlinks to the yardstick documentation are version specific. JIRA: VSPERF-442 Change-Id: I15c2f53922e88765506448de61af4a299f5d53c5 Signed-off-by: Martin Klozik <martinx.klozik@intel.com> Reviewed-by: Al Morton <acmorton@att.com> Reviewed-by: Christian Trautman <ctrautma@redhat.com> Reviewed-by: Bill Michalowski <bmichalo@redhat.com> Reviewed-by: Antonio Fischetti <antonio.fischetti@intel.com> Reviewed-by: Sridhar Rao <sridhar.rao@spirent.com> Reviewed-by: Martin Goldammer <martinx.goldammer@intel.com> Reviewed-by: Trevor Cooper <trevor.cooper@intel.com>
2017-01-27Merge "pkt_gen: STC - RFC 2889 Address Learning and Caching Support"Martin Klozik1-7/+86
2017-01-27pkt_gen: STC - RFC 2889 Address Learning and Caching SupportSridhar K. N. Rao1-7/+86
This patch adds RFC-2889 address-learning-rate test and address-caching-capacity tests. The patch includes following changes 1. 01_testcases.conf: testcase definitions are added for new tests 2. results_constants.py: 3 new results constants are added, removed unsupported constants 3. testcenter-rfc2889-rest.py: Added support to these two new tests. Removed un-necessary synchronization of db-file. 5 new configuration parameters are added - which are explained in (4). 4. trafficgen.rst: Configuration description for rfc2889 tests are added. Stale information is removed. 5. testcenter.py: Support for two new tests are added. Separate functions for results analysis and parameter settings are added. 6. traffic_controller_rfc2889.py: Calls to functions in testcenter.py, based on the traffic_type, are added. Removed trailing whitespaces from trafficgen.rst JIRA: VSPERF-395 Change-Id: Ie6ca87519b7736e7410d7f0e60904579934af24a Signed-off-by: Sridhar K. N. Rao <sridhar.rao@spirent.com>
2017-01-26fedora_remove_old: Remove installation scripts for Fedora 20-22goldammx1-3/+0
VSPERF with DPDK 16.04 and 16.07 did not work on Fedora 20-22. Installtion scripts for F20-F22 were deleted. VSPERF supports F24 and F25. JIRA: VSPERF-475 Change-Id: I3ce62b8883844cbcaab5b75fb9374068f9fced16 Signed-off-by: Martin Goldammer <martinx.goldammer@intel.com> Reviewed-by: Martin Klozik <martinx.klozik@intel.com> Reviewed-by: Al Morton <acmorton@att.com> Reviewed-by: Christian Trautman <ctrautma@redhat.com> Reviewed-by: Bill Michalowski <bmichalo@redhat.com> Reviewed-by: Antonio Fischetti <antonio.fischetti@intel.com> Reviewed-by: Sridhar Rao <sridhar.rao@spirent.com>
2017-01-25fedora25_install: Provide installer script for Fedora 25goldammx1-0/+1
Adds installer script for Fedora 25. Kernel version on Fedora 25 requires DPDK 16.11 and newer. VSPERF user must use DPDK and OVS versions, which are compatible with installed kernel. Adds new folder for current distribution with installation scripts. JIRA: VSPERF-453 Change-Id: Icb86ea7655e95df57a8052e4a8523348a0c75dc0 Signed-off-by: Martin Goldammer <martinx.goldammer@intel.com> Reviewed-by: Martin Klozik <martinx.klozik@intel.com> Reviewed-by: Al Morton <acmorton@att.com> Reviewed-by: Christian Trautman <ctrautma@redhat.com> Reviewed-by: Bill Michalowski <bmichalo@redhat.com> Reviewed-by: Antonio Fischetti <antonio.fischetti@intel.com> Reviewed-by: Sridhar Rao <sridhar.rao@spirent.com>
2017-01-24fedora24_install: Provide installer script for Fedora 24goldammx1-0/+1
Adds installer script for Fedora 24. Kernel version on Fedora 24 requires DPDK 16.11 and newer. VSPERF user must ensure, that used DPDK and OVS version which are compatible with installed kernel. Adds new folder for current distribution with installation scripts. JIRA: VSPERF-453 Change-Id: I08846d6e51faa578ea9305173174bfc49b77018a Signed-off-by: Martin Goldammer <martinx.goldammer@intel.com> Reviewed-by: Martin Klozik <martinx.klozik@intel.com> Reviewed-by: Al Morton <acmorton@att.com> Reviewed-by: Christian Trautman <ctrautma@redhat.com> Reviewed-by: Bill Michalowski <bmichalo@redhat.com> Reviewed-by: Antonio Fischetti <antonio.fischetti@intel.com> Reviewed-by: Sridhar Rao <sridhar.rao@spirent.com>
2017-01-24docs: Installation doc updatedMartin Klozik18-60/+129
Documentation was updated as follows: * description of vsperf downloading was added * VNF section was updated * additions to installation and virtualnev related parts * file permissions of all documentaton files was unified on 644 * README.md was updated with links to doc files and online docs * 3rd_party/readme was renamed and updated to follow markdown syntax JIRA: VSPERF-441 Change-Id: I648c6a8f0bb283bbc0875fd6fecd2539ca0c9056 Signed-off-by: Martin Klozik <martinx.klozik@intel.com> Reviewed-by: Al Morton <acmorton@att.com> Reviewed-by: Christian Trautman <ctrautma@redhat.com> Reviewed-by: Bill Michalowski <bmichalo@redhat.com> Reviewed-by: Antonio Fischetti <antonio.fischetti@intel.com> Reviewed-by: Sridhar Rao <sridhar.rao@spirent.com> Reviewed-by: Martin Goldammer <martinx.goldammer@intel.com>
2017-01-24Merge "centos73_install: Provide installer script for CentOS 7.3"Martin Klozik1-5/+5
2017-01-24Merge "xena_cont_learning: Adds learning preemption to continuous traffic"Martin Klozik1-0/+13
2017-01-24docs: Upgrade instructionsMartin Klozik2-0/+190
New section specific to upgrade was added into documentation. Description of configuration changes beetween Colorado and Danube releases is discussed in detail. JIRA: VSPERF-269 Change-Id: Ibbd1bb447e5d85c6b269ad26e10ff5d646a2bfbe Signed-off-by: Martin Klozik <martinx.klozik@intel.com> Reviewed-by: Al Morton <acmorton@att.com> Reviewed-by: Christian Trautman <ctrautma@redhat.com> Reviewed-by: Bill Michalowski <bmichalo@redhat.com> Reviewed-by: Antonio Fischetti <antonio.fischetti@intel.com> Reviewed-by: Sridhar Rao <sridhar.rao@spirent.com> Reviewed-by: Martin Goldammer <martinx.goldammer@intel.com>
2017-01-23xena_cont_learning: Adds learning preemption to continuous trafficChristian Trautman1-0/+13
Adds a configurable learning preemptive option when running xena continuous traffic tests. This resolves a missing packet or two when running OVS tests at flow rates that should not drop packets. JIRA: VSPERF-473 Change-Id: I056578ed9c9181287d97aea55a002f09aac14e81 Signed-off-by: Christian Trautman <ctrautma@redhat.com>
2017-01-20centos73_install: Provide installer script for CentOS 7.3goldammx1-5/+5
Adds installer script for CentOS 7.3. Modifications are based on installation script for RHEL7.3. Modified dpdk makefile to allow upstream dpdk to build. Prevents upstream vanilla OVS from building due to kernel incompatibilities. JIRA: VSPERF-452 Change-Id: Iaf05de0cf2ad7f5636d9474f351d3c7d193123cf Signed-off-by: Martin Goldammer <martinx.goldammer@intel.com> Reviewed-by: Martin Klozik <martinx.klozik@intel.com> Reviewed-by: Al Morton <acmorton@att.com> Reviewed-by: Christian Trautman <ctrautma@redhat.com> Reviewed-by: Bill Michalowski <bmichalo@redhat.com> Reviewed-by: Antonio Fischetti <antonio.fischetti@intel.com> Reviewed-by: Sridhar Rao <sridhar.rao@spirent.com>
2017-01-18Merge "mrg_buff_doc: Add documentation on mergable buffer option"Martin Klozik1-0/+38
2017-01-18mrg_buff_doc: Add documentation on mergable buffer optionChristian Trautman1-0/+38
Adds section about mergable buffers option to testusage doc. Also adds drive boot type info into gotchas section of testusage doc. JIRA: VSPERF-459 Change-Id: I159273502663dd29f4847b0737535009a42e430d Signed-off-by: Christian Trautman <ctrautma@redhat.com>
2017-01-18docs: Ixia docs updateMartin Klozik1-36/+46
Ixia generator related documenation was reviewed and updated. Links to the chapters specific to supported traffic generators were created. JIRA: VSPERF-454 Change-Id: I3a19b054002ac8be3ed3115bc21986b3ca4ea187 Signed-off-by: Martin Klozik <martinx.klozik@intel.com> Reviewed-by: Al Morton <acmorton@att.com> Reviewed-by: Christian Trautman <ctrautma@redhat.com> Reviewed-by: Bill Michalowski <bmichalo@redhat.com> Reviewed-by: Antonio Fischetti <antonio.fischetti@intel.com> Reviewed-by: Sridhar Rao <sridhar.rao@spirent.com>
2017-01-18docs: Dummy pre-configured resultsMartin Klozik1-15/+84
In case of Dummy traffic generator, the test results can be pre-configured. Configuration and examples were described in trafficgen related chapter. JIRA: VSPERF-458 Change-Id: I6179e98f3999e5b2df2ad4080582302bf4177cda Signed-off-by: Martin Klozik <martinx.klozik@intel.com> Reviewed-by: Al Morton <acmorton@att.com> Reviewed-by: Christian Trautman <ctrautma@redhat.com> Reviewed-by: Bill Michalowski <bmichalo@redhat.com> Reviewed-by: Antonio Fischetti <antonio.fischetti@intel.com> Reviewed-by: Sridhar Rao <sridhar.rao@spirent.com>
2017-01-17Merge "traffic: Configurable traffic details"Martin Klozik7-71/+186
2017-01-16traffic: Configurable traffic detailsMartin Klozik7-71/+186
Traffic generated by traffic generator is based on default values and their modifications specific to particular testing scenario. Traffic default values were defined inside VSPERF code and it was not possible to change them. This patch introduces new TRAFFIC dictionary inside 03_traffic.conf. Thus user can modify any of TRAFFIC values either in configuration file or by CLI or by 'Parameters' section of testcase definition. Following CLI options were obsoleted by this patch: 'bidirectional', 'traffic_type', 'iload', 'multistream', 'stream_type' and 'pre-installed_flows' Following CLI option was renamed to be consistent with other options: 'tunnel_type' => 'TUNNEL_TYPE' Following sections of testcase definition were obsoleted: "Traffic Type", "biDirectional", "MultiStream", "Stream Type", "Pre-installed Flows", "Flow Type" and "iLoad" New TRAFFIC dictionary should be used instead of old CLI options and old testcase definition sections. Testcase definitons, yardstick sample testcases and documentation were updated to reflect configuration changes. JIRA: VSPERF-433 Change-Id: I03a388c766491d5688e715f6d7b51e8e0377ec27 Signed-off-by: Martin Klozik <martinx.klozik@intel.com> Reviewed-by: Al Morton <acmorton@att.com> Reviewed-by: Christian Trautman <ctrautma@redhat.com> Reviewed-by: Bill Michalowski <bmichalo@redhat.com> Reviewed-by: Antonio Fischetti <antonio.fischetti@intel.com> Reviewed-by: <sridhar.rao@spirent.com>
2017-01-16docs: Update NEWS sectionMartin Klozik1-6/+50
Update NEWS with details about vsperf changes implemented during Danube release. JIRA: VSPERF-440 Change-Id: I3ebb010ef2a86806084c856257a6195b425b98a6 Signed-off-by: Martin Klozik <martinx.klozik@intel.com> Reviewed-by: Al Morton <acmorton@att.com> Reviewed-by: Christian Trautman <ctrautma@redhat.com> Reviewed-by: Bill Michalowski <bmichalo@redhat.com> Reviewed-by: Antonio Fischetti <antonio.fischetti@intel.com> Reviewed-by: Sridhar Rao <sridhar.rao@spirent.com>
2017-01-16Merge "testpmd_pvp: Adds pkt_fwd to allow pvp topology testing"Martin Klozik2-2/+53
2017-01-13testpmd_pvp: Adds pkt_fwd to allow pvp topology testingChristian Trautman2-2/+53
Requires DPDK 16.11 or greater to support vdev flags. Initial support for TestPMD to support guests. Allows vsperf to execute TestPMD as a switch for pvp test scenarios. Can be increased in functionality later to support multiple guest configs. JIRA: VSPERF-406 Change-Id: I67a5a355c990ca6cfcbb5845a2beaf1c1f21f5f0 Signed-off-by: Christian Trautman <ctrautma@redhat.com>
2017-01-12docs: Fix links to default test parametersMartin Klozik1-20/+28
Links to the default test parameters were fixed. JIRA: VSPERF-442 Change-Id: I775d5598799050fe44a5f0fc23a28716e24c2c76 Signed-off-by: Martin Klozik <martinx.klozik@intel.com> Reviewed-by: Al Morton <acmorton@att.com> Reviewed-by: Christian Trautman <ctrautma@redhat.com> Reviewed-by: Bill Michalowski <bmichalo@redhat.com> Reviewed-by: Antonio Fischetti <antonio.fischetti@intel.com> Reviewed-by: Sridhar Rao <sridhar.rao@spirent.com>
2017-01-10Merge "rhel73_install: Provide installer script for RHEL 7.3"Martin Klozik2-12/+21
2017-01-06rhel73_install: Provide installer script for RHEL 7.3Christian Trautman2-12/+21
Adds installer scripts for RHEL 7.3 OS. Modified dpdk makefile to allow upstream dpdk to build. Prevents upstream OVS from building due to kernel incompatibilities. Provides instructions on setting up RHEL 7.3 for usage with binary OVS packages when testing with OVS Vanilla. Tested under RHEL 7.3 JIRA: VSPerf-322 Change-Id: If294d465f28f60a1c514a7b661ce4696ac3b5b73 Signed-off-by: Christian Trautman <ctrautma@redhat.com>