summaryrefslogtreecommitdiffstats
path: root/docs
AgeCommit message (Collapse)AuthorFilesLines
2016-10-10IETF Draft: Comments from IETF-96Al Morton1-0/+1027
JIRA: VSPERF-410 x Ramki on OVS features - the scope of benchmarking does not include the ever-growing list of OVS features, only the general and switch-agnostic features will be assessed. x Justify the length of SOAK tests (with variability allowed), mention that the goal is stability characterization, not the typical short term benchmarks of performance. x Fix the LTD Reference to point to Brahmaputra version (which is frozen in the release docs) Change-Id: I2f795cd42e7ec2e06e5cd35bbf0c1f336a5e43ca Signed-off-by: Al Morton <acmorton@att.com> Reviewed-by: Maryam Tahhan <maryam.tahhan@intel.com> Reviewed-by: Billy O'Mahony<billy.o.mahony@intel.com> Reviewed-by: Christian Trautman <ctrautma@redhat.com>
2016-10-09CLI: add Multiqueue params.Antonio Fischetti1-0/+12
This patch implements the following new CLI parameters that can be used in the --test-params list. 1. guest_nic_queues, which overrides all GUEST_NIC_QUEUES values 2. guest_testpmd_txq, which overrides all GUEST_TESTPMD_TXQ 3. guest_testpmd_rxq, which overrides all GUEST_TESTPMD_RXQ 4. guest_testpmd_nb_cores, which overrides all GUEST_TESTPMD_NB_CORES values 5. guest_testpmd_cpu_mask, which overrides all GUEST_TESTPMD_CPU_MASK values 6. vswitch_dpdk_multi_queues, which overrides VSWITCH_DPDK_MULTI_QUEUES 7. guest_smp, which overrides all GUEST_SMP values 8. guest_core_binding, which overrides all GUEST_CORE_BINDING values When they are present in the CLI the corresponding settings from the configuration files will be overridden. As an example a usage can be: ./vsperf --test-params "guest_nic_queues=2;guest_testpmd_txq=1;\ guest_testpmd_rxq=1;guest_testpmd_nb_cores=1"... v2: rebase + rework to add other CLI params as suggested and update doc. v3: changes in 'testusage.rst' doc. JIRA: VSPERF-371 Change-Id: I140d6e068c1653d21aaa0df27532a48c4a12c151 Signed-off-by: Antonio Fischetti <antonio.fischetti@intel.com> Reviewed-by: Maryam Tahhan <maryam.tahhan@intel.com> Reviewed-by: Martin Klozik <martinx.klozik@intel.com>
2016-10-04Merge "pkt_gen: Spirent Testcenter RFC 2889 Support"Martin Klozik1-0/+36
2016-09-21pkt_gen: Spirent Testcenter RFC 2889 SupportSridhar K. N. Rao1-0/+36
The changes/additions, apart from spirent testcenter-specific, also includes to some files in conf (01_testcase and 03_traffic) and core (result- constants, traffic_controller and component_factory) folders. Currently, only RFC2889 Forwarding testcase is supported. Incorporated following review suggestions: 1. Log level fixes 2. Removing unused function in results_constants.py 3. Added documentation to docs/configguide/trafficgen.rst. Userguide will be updated once other RFC2889 tests are implemented. 4. string matching in component_factory. 5. Remove Trailing Whitespaces JIRA: VSPERF-286 Change-Id: I0195720ab2f8cf2c3a5aa490d66166bdca0afcb0 Signed-off-by: Sridhar K. N. Rao <sridhar.rao@spirent.com>
2016-09-15paths: Support binary packagesMartin Klozik3-20/+195
Currently VSPERF supports OVS, DPDK and QEMU built from the source code only. In some cases it is required to support installation of these tools from binary packages available for given linux distribution. Thus VSPERF configuration and code was modified to suport both source and binary versions of tools. This can be configured perf tool, so various combinations of source and binary version are supported. Together with new configuration also a handling of kernel modules was modified to automatically detect and load module dependencies. JIRA: VSPERF-340 JIRA: VSPERF-339 Change-Id: I855cb438cbd8998bdc499613ea5e7de2526299d7 Signed-off-by: Martin Klozik <martinx.klozik@intel.com> Reviewed-by: Maryam Tahhan <maryam.tahhan@intel.com> Reviewed-by: Al Morton <acmorton@att.com> Reviewed-by: Christian Trautman <ctrautma@redhat.com> Reviewed-by: Bill Michalowski <bmichalo@redhat.com> Reviewed-by: Otto Sabart <osabart@redhat.com>
2016-09-06Merge "docs: Fix links and formatting"Martin Klozik3-49/+94
2016-09-05docs: Fix links and formattingMartin Klozik3-49/+94
Documentation was updated as follows: * section decorators were fixed in LTD * links to testcase and deployment descriptions were fixed * duplicate labels removed from LTP&LTD * fixed typos in formatting and text * links to scalability and stress tests fixed after their renaming JIRA: VSPERF-349 Change-Id: I86c2b723231431388b69d3d696805de2a4e12435 Signed-off-by: Martin Klozik <martinx.klozik@intel.com> Reviewed-by: Maryam Tahhan <maryam.tahhan@intel.com> Reviewed-by: Al Morton <acmorton@att.com> Reviewed-by: Christian Trautman <ctrautma@redhat.com> Reviewed-by: Bill Michalowski <bmichalo@redhat.com>
2016-09-02Merge "test_spec: Remove formatted text file verions of IETF Draft"Maryam Tahhan3-3696/+0
2016-09-02Merge "multi VM: Multi VMs in serial or parallel"Martin Klozik4-18/+326
2016-09-02docs: Remove links to Brahmaputra documentationMartin Klozik1-2/+2
Hyperlinks to the yardstick documentation were updated to refer to files generated from the master branch. JIRA: VSPERF-349 Change-Id: I248795b6a951377885492515fa9b96a694c9da5d Signed-off-by: Martin Klozik <martinx.klozik@intel.com> Reviewed-by: Maryam Tahhan <maryam.tahhan@intel.com> Reviewed-by: Al Morton <acmorton@att.com> Reviewed-by: Christian Trautman <ctrautma@redhat.com> Reviewed-by: Bill Michalowski <bmichalo@redhat.com>
2016-09-01test_spec: Remove formatted text file verions of IETF DraftAl Morton3-3696/+0
Remove files with IETF copyrights (Internet Draft .txt files). I assume these files have to be removed in C-stable branch... JIRA: VSPERF-387 Change-Id: I76709ab055f845cec0bec8d07b14c29dec349f54 Signed-off-by: Al Morton <acmorton@att.com> Reviewed-by: Maryam Tahhan <maryam.tahhan@intel.com> Reviewed-by: Bill Michalowski <bmichalo@redhat.com> Reviewed-by: Christian Trautman <ctrautma@redhat.com> Reviewed-by: Antonio Fischetti <antonio.fischetti@intel.com>
2016-09-01multi VM: Multi VMs in serial or parallelMartin Klozik4-18/+326
Support for deployment scenarios with any number of VMs in both serial and parallel configuration. Detailed content of the patch: * VswitchControllerPXP class for multi VM support * pvvpxx and pvpvxx deployments for xx VMs in serial respective parallel configuration * special GUEST_ options expansion to requested number of VMs; * support of GUEST_ options specific macros #VMINDEX, #MAC(), #IP() and #EVAL() * all GUEST specific options are turned to lists to be VM specific * support for VM with 1 NIC * support for VM with multiple NIC pairs; traffic is routed in serial or parallel between NIC paris based on deployment scenario * support for PVVP and PVPV scenarios using VMs with different numbers of NICs JIRA: VSPERF-361 Change-Id: I05bedbdfa9a81ea0166d9b03d83ae49d6cb8b19b Signed-off-by: Martin Klozik <martinx.klozik@intel.com> Reviewed-by: Maryam Tahhan <maryam.tahhan@intel.com> Reviewed-by: Al Morton <acmorton@att.com> Reviewed-by: Christian Trautman <ctrautma@redhat.com> Reviewed-by: Bill Michalowski <bmichalo@redhat.com> Reviewed-by: Antonio Fischetti <antonio.fischetti@intel.com>
2016-08-26docs: vloop-vnf changelog updateMartin Klozik1-0/+6
Documentation was updated to reflect recent changes of vloop-vnf image. JIRA: VSPERF-374 Change-Id: I65a34a7618593a7b77c38eb2fa4c87619b937346 Signed-off-by: Martin Klozik <martinx.klozik@intel.com> Reviewed-by: Maryam Tahhan <maryam.tahhan@intel.com> Reviewed-by: Al Morton <acmorton@att.com> Reviewed-by: Christian Trautman <ctrautma@redhat.com> Reviewed-by: Bill Michalowski <bmichalo@redhat.com>
2016-08-24Vanilla_Multi_Queue: Add vanilla ovs multi-queue functionalityChristian Trautman3-19/+35
Adds multi-queue for vanilla OVS using virtio-net. TunTap ports will use multi_queue parameter when ports are created/deleted if guest nic queues are enabled and vswitch is ovs vanilla. Virtio net will now add guest nic queues to qemu command line if appropriate. Reworked multi-queue documentation to reflect these changes. Adds vhost net thread affinitization which is recommended when performing vanilla ovs multi-queue. Guests will require ethtool if using l2fwd or linux bridge as the loopback application when vanilla ovs multi-queue is enabled. Modified dpdk setting in vswitch conf to be better worded for separation from vanilla ovs multi-queue. Updated release and installation doc for new vloop image that includes required ethtool utility. JIRA: VSPERF-373 Change-Id: Idb550515190b1a93390308c11f54da368f962512 Signed-off-by: Christian Trautman <ctrautma@redhat.com>
2016-08-18cuse: Remove vHost Cuse supportMartin Klozik2-27/+6
Support of vHost Cuse interface is not supported by OVS anymore, so it was removed also from VSPERF. Cuse can be used with older VSPERF release if needed. JIRA: VSPERF-376 Change-Id: Id786bddf5fa9dce5706a93de7b089707a60317cd Signed-off-by: Martin Klozik <martinx.klozik@intel.com> Reviewed-by: Maryam Tahhan <maryam.tahhan@intel.com> Reviewed-by: Al Morton <acmorton@att.com> Reviewed-by: Christian Trautman <ctrautma@redhat.com> Reviewed-by: Bill Michalowski <bmichalo@redhat.com>
2016-08-18Merge "old_style_multi-queue: Allows for multi-queue with ovs <= 2.5.0"Martin Klozik1-1/+10
2016-08-16integration: Support for VxLAN TC without using overlay traffic gen.Sugesh Chandran1-0/+49
The test case for verifying the vxlan tunneling feature without using any ingress tunnel traffic. The virtual switch(OVS) is configured to mangle and generate tunnel traffic in the deployment. The packet flow in the test case is as follows TRAFFIC-IN --> [ENCAP-PKT] --> [MOD-PKT] --> [DECAP-PKT] --> TRAFFIC-OUT ENCAP-PKT - Encapsulate the ingress packet to a tunnel type. MOD-PKT - Modify the tunnel header to match the following decap interface. DECAP-PKT - Decapsulate the newly generated tunneled packet. Change-Id: Ie24bacb3cb1c069bd60403e5a4ef8bcdf0e12e54 Signed-off-by: Sugesh Chandran <sugesh.chandran@intel.com>
2016-08-16old_style_multi-queue: Allows for multi-queue with ovs <= 2.5.0Christian Trautman1-1/+10
Enables multi-queue option for OVS versions 2.5.0 or less with dpdk. Instead of enabling MQ on a port by port basis this sets the global MQ option after starting the ovs switch. JIRA: VSPERF-372 Change-Id: I245c76779695518d0005122d8214bbf3f141bb96 Signed-off-by: Christian Trautman <ctrautma@redhat.com>
2016-08-14docs: add vm2vm testing methodologyMaryam Tahhan5-0/+42
Change-Id: I8a89ee3eedd3b439f0243eaef2fafc50ee807739 Signed-off-by: Maryam Tahhan <maryam.tahhan@intel.com>
2016-08-14Merge "docs: add LTP to index.rst"Maryam Tahhan3-30/+26
2016-08-12doc_fixup: Grammar and link fixes to documentationChristian Trautman4-7/+21
Fixes minor grammar and link issues. JIRA: VSPERF-349 Change-Id: Id8708aee5b099287b5c99e79ca6da9ab8778897f Signed-off-by: Christian Trautman <ctrautma@redhat.com>
2016-08-12docs: add LTP to index.rstMaryam Tahhan3-30/+26
Fix build issues and add the LTP to index.rst. JIRA: DOCS-95 Change-Id: I2d22646af935c544645c01600b92a5f51ede39ec Signed-off-by: Maryam Tahhan <maryam.tahhan@intel.com>
2016-08-12pkt_gen: Update MoonGen Documentionbmichalo1-0/+15
Updating MoonGen configuration guide JIRA: VSPERF-370 Change-Id: I577491a6ece249a6162e1a3595a8682b826e5734 Signed-off-by: bmichalo <bmichalo@redhat.com>
2016-08-10Merge "docs: split LTD into LTP and LTD."Maryam Tahhan2-1050/+1327
2016-08-10docs: split LTD into LTP and LTD.Maryam Tahhan2-1050/+1327
Change-Id: Id0b2ce7460e76ffb3d478bd255a7e5b8e75ba001 Signed-off-by: Maryam Tahhan <maryam.tahhan@intel.com> Reviewed-by: Al Morton <acmorton@att.com> Reviewed-by: Christian Trautman <ctrautma@redhat.com> Reviewed-by: <bmichalo@redhat.com> Reviewed-by: <sridhar.rao@spirent.com>
2016-08-09Xena_2544_tput_options: Add options for rfc 2544 testingChristian Trautman1-0/+19
Adds options to Xena for testing options when running RFC 2544 throughput testing. JIRA: VSPERF-369 Change-Id: I3145bd1a4d697d7b06cafda4f9d77cce859d1839 Signed-off-by: Christian Trautman <ctrautma@redhat.com>
2016-08-09Merge "test_spec: LTD: MatchAction Performance testing"Maryam Tahhan1-0/+122
2016-08-09test_spec: LTD: MatchAction Performance testingAl Morton1-0/+122
One of the new tests we agreed by working on Etherpad was MatchAction. Maryam led the development, and many provided comments there. This is another chance for comments before we merge. JIRA: VSPERF-242 Change-Id: I9da74efb703d5f221280567159e4ed6d830eb92c Signed-off-by: Al Morton <acmorton@att.com> Reviewed-by: Maryam Tahhan <maryam.tahhan@intel.com> Reviewed-by: Billy O'Mahony<billy.o.mahony@intel.com> Reviewed-by: Christian Trautman <ctrautma@redhat.com>
2016-08-09Merge "bugfix: Harmonize test/trial RFC2544 terminology"Maryam Tahhan4-13/+13
2016-08-09hugepage_detect: Change hugepage detection to check for free hugepagesChristian Trautman1-1/+11
Change hugepage detection to check if hugepages are configured. Also verifies enough free hugepages are available based on test configuration. Will result in an exception if not enough hugepages are found. This performs the check based on the guest memory configs as well as the dpdk socket configs. Adds some new methods to check for free hugepages based on all hugepages or for socket free hugepages. Adds new logging indicitaing needed and free hugepages as well as info level event if hugepages are not configured at recommended 1GB size. JIRA: VSPerf-255 Change-Id: I80d5605308861070c412568d8d40339f01b9718b Signed-off-by: Christian Trautman <ctrautma@redhat.com>
2016-08-08Merge "dpdk: Testpmd forwarding mode changes in v16.07"Maryam Tahhan1-2/+5
2016-08-05dpdk: Testpmd forwarding mode changes in v16.07Martin Klozik1-2/+5
Testpmd forwarding mode mac_retry was obsoleted in DPDK v16.07. Retry option is supported by multiple forwarding modes now. Former "mac_retry" mode can be replaced by "mac retry" construct. JIRA: VSPERF-333 Change-Id: I1563427985966264f07d10b1a8351784fe999d74 Signed-off-by: Martin Klozik <martinx.klozik@intel.com> Reviewed-by: Maryam Tahhan <maryam.tahhan@intel.com> Reviewed-by: Al Morton <acmorton@att.com> Reviewed-by: Christian Trautman <ctrautma@redhat.com> Reviewed-by: <bmichalo@redhat.com>
2016-08-05Merge "Hugepages: on the fly allocation."Maryam Tahhan1-0/+5
2016-08-05Merge "pkt_gen: MoonGen start rates not correct"Maryam Tahhan1-0/+2
2016-08-04bugfix: Harmonize test/trial RFC2544 terminologyMartin Klozik4-13/+13
VSPERF framework was updated to follow RFC2544 definition of 'test' and 'trial' terms. Test parameter 'rfc2544_trials' was replaced by new parameter 'rfc2544_tests'. Both code and documentation were updated to reflect these changes. JIRA: VSPERF-300 Change-Id: I144a28359fd06394f1f87ef324458bafd5aad45f Signed-off-by: Martin Klozik <martinx.klozik@intel.com> Reviewed-by: Maryam Tahhan <maryam.tahhan@intel.com> Reviewed-by: Al Morton <acmorton@att.com> Reviewed-by: Christian Trautman <ctrautma@redhat.com> Reviewed-by: <bmichalo@redhat.com>
2016-08-04docs: Update vloop-vnf changelogMartin Klozik1-0/+7
Updated version of vloop-vnf image was added into the changelog inside installation guide. JIRA: VSPERF-349 Change-Id: I64a1acdf2191858dc282ea6c3b588048b3bdd742 Signed-off-by: Martin Klozik <martinx.klozik@intel.com> Reviewed-by: Maryam Tahhan <maryam.tahhan@intel.com> Reviewed-by: Al Morton <acmorton@att.com> Reviewed-by: Christian Trautman <ctrautma@redhat.com> Reviewed-by: <bmichalo@redhat.com>
2016-08-04Hugepages: on the fly allocation.Mars Toktonaliev1-0/+5
If no hugepages are available, try to allocate HUGEPAGE_RAM_ALLOCATION amount of RAM for hugepages. JIRA: VSPERF-290 Change-Id: I092b3831254579eeebbe45e85884828f9d749895 Signed-off-by: Mars Toktonaliev <mars.toktonaliev@nokia.com>
2016-08-03pkt_gen: MoonGen start rates not correctbmichalo1-0/+2
The VSPERF traffic profile for starting rate is in a percentage of line rate. MoonGen programs its starting rate as Mpps. Therefore the traffic profile for VSPERF needs to be converted to a MoonGen format. There was a hardcoding of 14.88 that was used for the starting frame rate for all frame sizes. This needs to be corrected to take into account all frame sizes. JIRA: VSPERF-350 Change-Id: Ied71668a560d7d2b03483f9a1192dd2fb4965996 Signed-off-by: bmichalo <bmichalo@redhat.com>
2016-08-03Merge "docs: Enhancement of IxNetwork configuration guide"Maryam Tahhan2-0/+86
2016-08-02docs: Update release notesMartin Klozik1-0/+9
Release notes were updated with features introduced by Colorado release. JIRA: VSPERF-349 Change-Id: I43179028c973cae4be6746e633c27fd3419e951a Signed-off-by: Martin Klozik <martinx.klozik@intel.com> Reviewed-by: Maryam Tahhan <maryam.tahhan@intel.com> Reviewed-by: Al Morton <acmorton@att.com> Reviewed-by: Christian Trautman <ctrautma@redhat.com> Reviewed-by: <bmichalo@redhat.com>
2016-07-27docs: Enhancement of IxNetwork configuration guideMartin Klozik2-0/+86
Configuration guide has been updated with description of IxNetwork specific configuration options. New section was added with description of test results sharing between IxNetwork and VSPERF. Additional changes: * wrong formatting inside installation.rst was fixed * description of IxNetwork configuration was updated inside ixnet.py JIRA: VSPERF-302 Change-Id: Ida0e086e69b82fd1f9821d16ea750b2dec1d5aa2 Signed-off-by: Martin Klozik <martinx.klozik@intel.com> Reviewed-by: Maryam Tahhan <maryam.tahhan@intel.com> Reviewed-by: Al Morton <acmorton@att.com> Reviewed-by: Christian Trautman <ctrautma@redhat.com> Reviewed-by: <bmichalo@redhat.com>
2016-07-27Integration docs: HelloWorld and other basic examples.Antonio Fischetti1-1/+327
This patch adds to Integration docs some simple testcase examples like a HelloWorld. The purpose is to show how to use some basic features: rules on L3/L4 fields, MultiStream, Multi-VM setup. Patch Set 2: removed trailing whitespaces. Patch Set 3: moved the examples to the middle of the file to avoid potential conflicts with the VxLan TC patch from Sugesh. Patch Set 4: fix typo. Patch Set 5: added descriptions on each example. Patch Set 6: reworked description for VM Replacement TC. JIRA: VSPERF-331 Change-Id: I9dea23c26138db874fd67f41d8de8a628db5d91f Signed-off-by: Antonio Fischetti <antonio.fischetti@intel.com> Reviewed-by: Maryam Tahhan <maryam.tahhan@intel.com> Reviewed-by: Martin Klozik <martinx.klozik@intel.com>
2016-07-21docs: Remove trailing whitespacesMartin Klozik1-21/+21
Wrong whitespace characters breaks automatic generation of VSPERF documentation. It is necessary to remove wrong characters before merge of the draft into VSPERF doc, e.g. by filtering through tr -d '\014' JIRA: VSPERF-324 Change-Id: Ie280f5a443c89d4235cae5eb89fdceae74ea4213 Signed-off-by: Martin Klozik <martinx.klozik@intel.com> Reviewed-by: Maryam Tahhan <maryam.tahhan@intel.com> Reviewed-by: Al Morton <acmorton@att.com> Reviewed-by: Christian Trautman <ctrautma@redhat.com> Reviewed-by: <bmichalo@redhat.com>
2016-07-15New IETF Draft WG versionAl Morton2-0/+2248
JIRA: VSPERF-?? Change-Id: I1f07a70bf3c8604df890defd8493f107550bf8f3 Signed-off-by: Al Morton <acmorton@att.com> Reviewed-by: Maryam Tahhan <maryam.tahhan@intel.com> Reviewed-by: Billy O'Mahony<billy.o.mahony@intel.com>
2016-07-13docs: Update yardstick userguideMartin Klozik1-2/+2
Documentation update based on review comments received after the merge of original patch. JIRA: VSPERF-288 Change-Id: I86305fa064cc07e2e0797276a7b89b1d4b23d126 Signed-off-by: Martin Klozik <martinx.klozik@intel.com> Reviewed-by: Maryam Tahhan <maryam.tahhan@intel.com> Reviewed-by: Al Morton <acmorton@att.com> Reviewed-by: Christian Trautman <ctrautma@redhat.com> Reviewed-by: <bmichalo@redhat.com> Reviewed-by: <sridhar.rao@spirent.com>
2016-07-08yardstick: Documentation and YAML testcase definitionsMartin Klozik2-0/+224
Yardstick supports execution of vsperf specific testcases. These testcases are specified by YAML files located inside yardstick/tests directory. Documentation describing yardstick usage and execution of vsperf testcases is part of the userguide. JIRA: VSPERF-288 Change-Id: I5a575d28d344e0f3e0a1c8434e2f3231fd312d31 Signed-off-by: Martin Klozik <martinx.klozik@intel.com> Reviewed-by: Maryam Tahhan <maryam.tahhan@intel.com> Reviewed-by: Al Morton <acmorton@att.com> Reviewed-by: Christian Trautman <ctrautma@redhat.com> Reviewed-by: <bmichalo@redhat.com> Reviewed-by: <sridhar.rao@spirent.com>
2016-07-01Merge "multi-queue: Add basic multi-queue functionality"Christian Trautman1-0/+58
2016-07-01Merge "pkt_gen: Adding MoonGen traffic generator"Christian Trautman1-0/+43
2016-06-30pkt_gen: Adding MoonGen traffic generatorbmichalo1-0/+43
Adds support for the MoonGen packet generator. The following traffic types are included: * RFC 2544 Throughput: Synchronous Interface * RFC 2544 Back 2 Back: Synchronous Interface * Continous Flow: Synchronous Interface JIRA: VSPERF-168 Sample log of execution can be found as an attachment within JIRA VSPERF-168 Change-Id: I5bb84290945f4ba41bc962370e643bbbeff0e486 Signed-off-by: bmichalo <bmichalo@redhat.com>
2016-06-29multi-queue: Add basic multi-queue functionalityChristian Trautman1-0/+58
Adds support for multi-queue using the following config. * VNF = QemuDpdkVhostUser * VSWITCH = OvsDpdkVhost * Guest Loopback as testpmd Adds CPU mask, nbcore, rxq, and txq options for testpmd. Adds option for guest nic multi-queue. Adds option for dpdkvhostuser and dpdk multi-queue enable JIRA: VSPERF-309 Change-Id: I5296fc18b430eace598d8c51620fc27a6c46a65e Signed-off-by: Christian Trautman <ctrautma@redhat.com>