aboutsummaryrefslogtreecommitdiffstats
AgeCommit message (Collapse)AuthorFilesLines
2017-03-02Updated project description and license headerTrevor Cooper1-12/+18
Change-Id: I122bdec1a7fa9a9e3da51acb31b30a231eff7890 Signed-off-by: Trevor Cooper <trevor.cooper@intel.com>
2017-02-28Xena_pylint_fix: Fix param call to changes made by pylint patchChristian Trautman1-4/+4
Missed this small issue when calling continuous streams caused by the param name change from the pylint patch in XenaDriver.py ca9c9275ed6d5d852987c69a378e88a3502cb2ab. Change-Id: Ic8ad86358f72e91edea34cb37207d7dc583128b4 Signed-off-by: Christian Trautman <ctrautma@redhat.com>
2017-02-22pkt_gen: STC parameter reordering bug.Sridhar K. N. Rao2-5/+4
This patch fixes a bug caused due to wrong parameter ordering. stc_common_settings should come after rfc2544_common_settings. It also gets rid of 'Import' error for module 'conf' JIRA: VSPERF-491 Change-Id: I356294b4efdf9ebd0cea4492d3ed1cb8e04ec9b1 Signed-off-by: Sridhar K. N. Rao <sridhar.rao@spirent.com>
2017-02-17license: Add license info to all project filesgoldammx36-34/+195
All files were updated with license header. In case of binary files is license stored in LICENSE file stored in the same directory. Packages.txt was removed, because file has not been used.List of packages differs according OS distribution, all of neccesary packages are include in instalation scripts JIRA: VSPERF-489 Change-Id: I6ecae21b8db2a0f22fa5a66f9525352080f1fcc0 Signed-off-by: Martin Goldammer <martinx.goldammer@intel.com> Reviewed-by: Martin Klozik <martinx.klozik@intel.com> Reviewed-by: Al Morton <acmorton@att.com> Reviewed-by: Christian Trautman <ctrautma@redhat.com> Reviewed-by: Bill Michalowski <bmichalo@redhat.com> Reviewed-by: Antonio Fischetti <antonio.fischetti@intel.com> Reviewed-by: Sridhar Rao <sridhar.rao@spirent.com>
2017-02-16Merge "ci: Add SRIOV TC to CI daily job"Martin Klozik1-0/+21
2017-02-16ci: Execute pylint checks by VERIFY and MERGE jobsMartin Klozik2-19/+82
Pylint should be executed automatically for every patch to assure, that new code meets vsperf coding standards. JIRA: VSPERF-114 Change-Id: Icb1000e207b2d728497ff3d349fb3cb8334baac7 Signed-off-by: Martin Klozik <martinx.klozik@intel.com>
2017-02-14ci: Add SRIOV TC to CI daily jobMartin Klozik1-0/+21
SRIOV functionality should be regularly tested to detect any issues brought by new features. Testcase pvp_tput will be executed by daily job for several packet sizes. Testcase results will be reported and stored into artifactory, but they won't be stored into result database. JIRA: VSPERF-390 Change-Id: I9f6290b3be297a84c185681ce354bc7365b4036c Signed-off-by: Martin Klozik <martinx.klozik@intel.com> Reviewed-by: Al Morton <acmorton@att.com> Reviewed-by: Christian Trautman <ctrautma@redhat.com> Reviewed-by: Bill Michalowski <bmichalo@redhat.com> Reviewed-by: Antonio Fischetti <antonio.fischetti@intel.com> Reviewed-by: Sridhar Rao <sridhar.rao@spirent.com> Reviewed-by: Martin Goldammer <martinx.goldammer@intel.com> Reviewed-by: Trevor Cooper <trevor.cooper@intel.com>
2017-02-13pylint: Fixing pylint errors and warningsgoldammx38-215/+279
All python files must reach pylint score 10/10. This will be regularly verified by Jenkins jobs to keep constant code quality. VSPERF specific pylintrc file was updated according to the vsperf coding standards. Distro version included in reports will be slightly different, due to migration to new python package distro. Previously used platform.distro() will be deprecated since python 3.7. JIRA: VSPERF-487 Change-Id: I934120208b9624787a3567ccaa49e14d77d7a5bf Signed-off-by: Martin Goldammer <martinx.goldammer@intel.com> Reviewed-by: Martin Klozik <martinx.klozik@intel.com> Reviewed-by: Al Morton <acmorton@att.com> Reviewed-by: Christian Trautman <ctrautma@redhat.com> Reviewed-by: Bill Michalowski <bmichalo@redhat.com> Reviewed-by: Antonio Fischetti <antonio.fischetti@intel.com> Reviewed-by: Sridhar Rao <sridhar.rao@spirent.com>
2017-01-30docs: Remove hyperlinks to docs in artifactsMartin Klozik20-215/+172
It is possible to use sphinx cross referencing feature in case, that only one level of toctree is used. Thus documentation was reorganized to utilize just one top level index with toctree. After that it was possible to use rst native syntax to create a cross links among vsperf documentation chapters. As a result only 2 hyperlinks to the yardstick documentation are version specific. JIRA: VSPERF-442 Change-Id: I15c2f53922e88765506448de61af4a299f5d53c5 Signed-off-by: Martin Klozik <martinx.klozik@intel.com> Reviewed-by: Al Morton <acmorton@att.com> Reviewed-by: Christian Trautman <ctrautma@redhat.com> Reviewed-by: Bill Michalowski <bmichalo@redhat.com> Reviewed-by: Antonio Fischetti <antonio.fischetti@intel.com> Reviewed-by: Sridhar Rao <sridhar.rao@spirent.com> Reviewed-by: Martin Goldammer <martinx.goldammer@intel.com> Reviewed-by: Trevor Cooper <trevor.cooper@intel.com>
2017-01-27Merge "pkt_gen: STC - RFC 2889 Address Learning and Caching Support"Martin Klozik6-93/+353
2017-01-27pkt_gen: STC - RFC 2889 Address Learning and Caching SupportSridhar K. N. Rao6-93/+353
This patch adds RFC-2889 address-learning-rate test and address-caching-capacity tests. The patch includes following changes 1. 01_testcases.conf: testcase definitions are added for new tests 2. results_constants.py: 3 new results constants are added, removed unsupported constants 3. testcenter-rfc2889-rest.py: Added support to these two new tests. Removed un-necessary synchronization of db-file. 5 new configuration parameters are added - which are explained in (4). 4. trafficgen.rst: Configuration description for rfc2889 tests are added. Stale information is removed. 5. testcenter.py: Support for two new tests are added. Separate functions for results analysis and parameter settings are added. 6. traffic_controller_rfc2889.py: Calls to functions in testcenter.py, based on the traffic_type, are added. Removed trailing whitespaces from trafficgen.rst JIRA: VSPERF-395 Change-Id: Ie6ca87519b7736e7410d7f0e60904579934af24a Signed-off-by: Sridhar K. N. Rao <sridhar.rao@spirent.com>
2017-01-26fedora_remove_old: Remove installation scripts for Fedora 20-22goldammx7-316/+0
VSPERF with DPDK 16.04 and 16.07 did not work on Fedora 20-22. Installtion scripts for F20-F22 were deleted. VSPERF supports F24 and F25. JIRA: VSPERF-475 Change-Id: I3ce62b8883844cbcaab5b75fb9374068f9fced16 Signed-off-by: Martin Goldammer <martinx.goldammer@intel.com> Reviewed-by: Martin Klozik <martinx.klozik@intel.com> Reviewed-by: Al Morton <acmorton@att.com> Reviewed-by: Christian Trautman <ctrautma@redhat.com> Reviewed-by: Bill Michalowski <bmichalo@redhat.com> Reviewed-by: Antonio Fischetti <antonio.fischetti@intel.com> Reviewed-by: Sridhar Rao <sridhar.rao@spirent.com>
2017-01-26Merge "fedora25_install: Provide installer script for Fedora 25"Martin Klozik3-0/+104
2017-01-25fedora25_install: Provide installer script for Fedora 25goldammx3-0/+104
Adds installer script for Fedora 25. Kernel version on Fedora 25 requires DPDK 16.11 and newer. VSPERF user must use DPDK and OVS versions, which are compatible with installed kernel. Adds new folder for current distribution with installation scripts. JIRA: VSPERF-453 Change-Id: Icb86ea7655e95df57a8052e4a8523348a0c75dc0 Signed-off-by: Martin Goldammer <martinx.goldammer@intel.com> Reviewed-by: Martin Klozik <martinx.klozik@intel.com> Reviewed-by: Al Morton <acmorton@att.com> Reviewed-by: Christian Trautman <ctrautma@redhat.com> Reviewed-by: Bill Michalowski <bmichalo@redhat.com> Reviewed-by: Antonio Fischetti <antonio.fischetti@intel.com> Reviewed-by: Sridhar Rao <sridhar.rao@spirent.com>
2017-01-25info: Updated key project factsTrevor Cooper1-6/+8
List of commiters was updated and name of IRC channel added. Change-Id: Ib12cc5fd9991f5918be06e0bccf5ef09dcff5628 Signed-off-by: Trevor Cooper <trevor.cooper@intel.com>
2017-01-24Merge "fedora24_install: Provide installer script for Fedora 24"Martin Klozik3-0/+103
2017-01-24fedora24_install: Provide installer script for Fedora 24goldammx3-0/+103
Adds installer script for Fedora 24. Kernel version on Fedora 24 requires DPDK 16.11 and newer. VSPERF user must ensure, that used DPDK and OVS version which are compatible with installed kernel. Adds new folder for current distribution with installation scripts. JIRA: VSPERF-453 Change-Id: I08846d6e51faa578ea9305173174bfc49b77018a Signed-off-by: Martin Goldammer <martinx.goldammer@intel.com> Reviewed-by: Martin Klozik <martinx.klozik@intel.com> Reviewed-by: Al Morton <acmorton@att.com> Reviewed-by: Christian Trautman <ctrautma@redhat.com> Reviewed-by: Bill Michalowski <bmichalo@redhat.com> Reviewed-by: Antonio Fischetti <antonio.fischetti@intel.com> Reviewed-by: Sridhar Rao <sridhar.rao@spirent.com>
2017-01-24Merge "rte_target_fix: Resolves blank rte_target issue in conf file"Martin Klozik1-1/+1
2017-01-24rte_target_fix: Resolves blank rte_target issue in conf fileChristian Trautman1-1/+1
Modifies RTE_TARGET in conf/10_custom.conf which overwrites default value in 02_vswitch.conf file. JIRA: VSPERF-359 Change-Id: I83561d94543a6543764cd76eb4376ccdc091a4cd Signed-off-by: Christian Trautman <ctrautma@redhat.com>
2017-01-24docs: Installation doc updatedMartin Klozik21-67/+143
Documentation was updated as follows: * description of vsperf downloading was added * VNF section was updated * additions to installation and virtualnev related parts * file permissions of all documentaton files was unified on 644 * README.md was updated with links to doc files and online docs * 3rd_party/readme was renamed and updated to follow markdown syntax JIRA: VSPERF-441 Change-Id: I648c6a8f0bb283bbc0875fd6fecd2539ca0c9056 Signed-off-by: Martin Klozik <martinx.klozik@intel.com> Reviewed-by: Al Morton <acmorton@att.com> Reviewed-by: Christian Trautman <ctrautma@redhat.com> Reviewed-by: Bill Michalowski <bmichalo@redhat.com> Reviewed-by: Antonio Fischetti <antonio.fischetti@intel.com> Reviewed-by: Sridhar Rao <sridhar.rao@spirent.com> Reviewed-by: Martin Goldammer <martinx.goldammer@intel.com>
2017-01-24Merge "centos73_install: Provide installer script for CentOS 7.3"Martin Klozik3-5/+13
2017-01-24Merge "dpdk_vhostuser_mq_fix: Fixes erroneous error message with MQ and dpdk"Martin Klozik1-5/+0
2017-01-24Merge "xena_cont_accuracy_fix: Xena continuous traffic accuracy fixes"Martin Klozik1-7/+11
2017-01-24Merge "xena_cont_learning: Adds learning preemption to continuous traffic"Martin Klozik5-0/+41
2017-01-24docs: Upgrade instructionsMartin Klozik2-0/+190
New section specific to upgrade was added into documentation. Description of configuration changes beetween Colorado and Danube releases is discussed in detail. JIRA: VSPERF-269 Change-Id: Ibbd1bb447e5d85c6b269ad26e10ff5d646a2bfbe Signed-off-by: Martin Klozik <martinx.klozik@intel.com> Reviewed-by: Al Morton <acmorton@att.com> Reviewed-by: Christian Trautman <ctrautma@redhat.com> Reviewed-by: Bill Michalowski <bmichalo@redhat.com> Reviewed-by: Antonio Fischetti <antonio.fischetti@intel.com> Reviewed-by: Sridhar Rao <sridhar.rao@spirent.com> Reviewed-by: Martin Goldammer <martinx.goldammer@intel.com>
2017-01-23xena_cont_learning: Adds learning preemption to continuous trafficChristian Trautman5-0/+41
Adds a configurable learning preemptive option when running xena continuous traffic tests. This resolves a missing packet or two when running OVS tests at flow rates that should not drop packets. JIRA: VSPERF-473 Change-Id: I056578ed9c9181287d97aea55a002f09aac14e81 Signed-off-by: Christian Trautman <ctrautma@redhat.com>
2017-01-23xena_cont_accuracy_fix: Xena continuous traffic accuracy fixesChristian Trautman1-7/+11
Second patch to help improve Xena continuous traffic accuracy. Increases delay before gathering statistics to allow packets in flight to be received. Changes bps and fps to be calculated based on total bytes and packets received versus capturing the data while port is transmitting from active statistics. Sets time limit on ports based on duration. JIRA: VSPerf-423 Change-Id: I574819694d3141edb539de64bc16dcd6c6fcf489 Signed-off-by: Christian Trautman <ctrautma@redhat.com>
2017-01-23dpdk_vhostuser_mq_fix: Fixes erroneous error message with MQ and dpdkChristian Trautman1-5/+0
Removes un-needed code to set multi-queue option on vhostuser ports. JIRA: VSPerf-471 Change-Id: I9f58e53d9a9bb62ef5ed441a7b4b1dea37a2f557 Signed-off-by: Christian Trautman <ctrautma@redhat.com>
2017-01-20centos73_install: Provide installer script for CentOS 7.3goldammx3-5/+13
Adds installer script for CentOS 7.3. Modifications are based on installation script for RHEL7.3. Modified dpdk makefile to allow upstream dpdk to build. Prevents upstream vanilla OVS from building due to kernel incompatibilities. JIRA: VSPERF-452 Change-Id: Iaf05de0cf2ad7f5636d9474f351d3c7d193123cf Signed-off-by: Martin Goldammer <martinx.goldammer@intel.com> Reviewed-by: Martin Klozik <martinx.klozik@intel.com> Reviewed-by: Al Morton <acmorton@att.com> Reviewed-by: Christian Trautman <ctrautma@redhat.com> Reviewed-by: Bill Michalowski <bmichalo@redhat.com> Reviewed-by: Antonio Fischetti <antonio.fischetti@intel.com> Reviewed-by: Sridhar Rao <sridhar.rao@spirent.com>
2017-01-19Merge "testpmd_pvp_fix: Fix SR-IOV QemuPciPassthrough mode to not use vdev"Martin Klozik1-3/+5
2017-01-18Merge "mrg_buff_doc: Add documentation on mergable buffer option"Martin Klozik1-0/+38
2017-01-18mrg_buff_doc: Add documentation on mergable buffer optionChristian Trautman1-0/+38
Adds section about mergable buffers option to testusage doc. Also adds drive boot type info into gotchas section of testusage doc. JIRA: VSPERF-459 Change-Id: I159273502663dd29f4847b0737535009a42e430d Signed-off-by: Christian Trautman <ctrautma@redhat.com>
2017-01-18docs: Ixia docs updateMartin Klozik1-36/+46
Ixia generator related documenation was reviewed and updated. Links to the chapters specific to supported traffic generators were created. JIRA: VSPERF-454 Change-Id: I3a19b054002ac8be3ed3115bc21986b3ca4ea187 Signed-off-by: Martin Klozik <martinx.klozik@intel.com> Reviewed-by: Al Morton <acmorton@att.com> Reviewed-by: Christian Trautman <ctrautma@redhat.com> Reviewed-by: Bill Michalowski <bmichalo@redhat.com> Reviewed-by: Antonio Fischetti <antonio.fischetti@intel.com> Reviewed-by: Sridhar Rao <sridhar.rao@spirent.com>
2017-01-18docs: Dummy pre-configured resultsMartin Klozik1-15/+84
In case of Dummy traffic generator, the test results can be pre-configured. Configuration and examples were described in trafficgen related chapter. JIRA: VSPERF-458 Change-Id: I6179e98f3999e5b2df2ad4080582302bf4177cda Signed-off-by: Martin Klozik <martinx.klozik@intel.com> Reviewed-by: Al Morton <acmorton@att.com> Reviewed-by: Christian Trautman <ctrautma@redhat.com> Reviewed-by: Bill Michalowski <bmichalo@redhat.com> Reviewed-by: Antonio Fischetti <antonio.fischetti@intel.com> Reviewed-by: Sridhar Rao <sridhar.rao@spirent.com>
2017-01-18testpmd_pvp_fix: Fix SR-IOV QemuPciPassthrough mode to not use vdevChristian Trautman1-3/+5
A recent patch introduced a bug where SR-IOV would use code designed for use with testpmd_pvp scenarios. This is because this scenario also calls for the vswitch=none flag. This patch resolves this issue to stop the vdev devices from being added when the vnf is specified as QemuPciPassthrough. JIRA: VSPERF-460 Change-Id: Ie4522b046982ec5554c3deb6a507d86ca9798124 Signed-off-by: Christian Trautman <ctrautma@redhat.com>
2017-01-17Merge "traffic: Configurable traffic details"Martin Klozik25-413/+577
2017-01-16traffic: Configurable traffic detailsMartin Klozik25-413/+577
Traffic generated by traffic generator is based on default values and their modifications specific to particular testing scenario. Traffic default values were defined inside VSPERF code and it was not possible to change them. This patch introduces new TRAFFIC dictionary inside 03_traffic.conf. Thus user can modify any of TRAFFIC values either in configuration file or by CLI or by 'Parameters' section of testcase definition. Following CLI options were obsoleted by this patch: 'bidirectional', 'traffic_type', 'iload', 'multistream', 'stream_type' and 'pre-installed_flows' Following CLI option was renamed to be consistent with other options: 'tunnel_type' => 'TUNNEL_TYPE' Following sections of testcase definition were obsoleted: "Traffic Type", "biDirectional", "MultiStream", "Stream Type", "Pre-installed Flows", "Flow Type" and "iLoad" New TRAFFIC dictionary should be used instead of old CLI options and old testcase definition sections. Testcase definitons, yardstick sample testcases and documentation were updated to reflect configuration changes. JIRA: VSPERF-433 Change-Id: I03a388c766491d5688e715f6d7b51e8e0377ec27 Signed-off-by: Martin Klozik <martinx.klozik@intel.com> Reviewed-by: Al Morton <acmorton@att.com> Reviewed-by: Christian Trautman <ctrautma@redhat.com> Reviewed-by: Bill Michalowski <bmichalo@redhat.com> Reviewed-by: Antonio Fischetti <antonio.fischetti@intel.com> Reviewed-by: <sridhar.rao@spirent.com>
2017-01-16docs: Update NEWS sectionMartin Klozik1-6/+50
Update NEWS with details about vsperf changes implemented during Danube release. JIRA: VSPERF-440 Change-Id: I3ebb010ef2a86806084c856257a6195b425b98a6 Signed-off-by: Martin Klozik <martinx.klozik@intel.com> Reviewed-by: Al Morton <acmorton@att.com> Reviewed-by: Christian Trautman <ctrautma@redhat.com> Reviewed-by: Bill Michalowski <bmichalo@redhat.com> Reviewed-by: Antonio Fischetti <antonio.fischetti@intel.com> Reviewed-by: Sridhar Rao <sridhar.rao@spirent.com>
2017-01-16Merge "testpmd_pvp: Adds pkt_fwd to allow pvp topology testing"Martin Klozik7-5/+102
2017-01-16Merge "docs: Fix links to default test parameters"Martin Klozik1-20/+28
2017-01-13testpmd_pvp: Adds pkt_fwd to allow pvp topology testingChristian Trautman7-5/+102
Requires DPDK 16.11 or greater to support vdev flags. Initial support for TestPMD to support guests. Allows vsperf to execute TestPMD as a switch for pvp test scenarios. Can be increased in functionality later to support multiple guest configs. JIRA: VSPERF-406 Change-Id: I67a5a355c990ca6cfcbb5845a2beaf1c1f21f5f0 Signed-off-by: Christian Trautman <ctrautma@redhat.com>
2017-01-12docs: Fix links to default test parametersMartin Klozik1-20/+28
Links to the default test parameters were fixed. JIRA: VSPERF-442 Change-Id: I775d5598799050fe44a5f0fc23a28716e24c2c76 Signed-off-by: Martin Klozik <martinx.klozik@intel.com> Reviewed-by: Al Morton <acmorton@att.com> Reviewed-by: Christian Trautman <ctrautma@redhat.com> Reviewed-by: Bill Michalowski <bmichalo@redhat.com> Reviewed-by: Antonio Fischetti <antonio.fischetti@intel.com> Reviewed-by: Sridhar Rao <sridhar.rao@spirent.com>
2017-01-11ovs-dpdk port setup: specify PCI slot.Antonio_Fischetti1-1/+5
Update to use options:dpdk-devargs coming from the Arbitray Port Naming feature lately upstreamed in Ovs-DPDK project. See Commit ID: 55e075e65ef9ecbd70e5e0fada2704c3d73724d8. By this new param you can explicitly select a PCI slot for a dpdk port. JIRA: VSPERF-449 Change-Id: Id6028cc4efbaf228a99c6f0a346a8e96a82e43a6 Signed-off-by: Antonio Fischetti <antonio.fischetti@intel.com> Reviewed-by: Maryam Tahhan <maryam.tahhan@intel.com> Reviewed-by: Martin Klozik martinx.klozik@intel.com Reviewed-by: Al Morton <acmorton@att.com> Reviewed-by: Christian Trautman <ctrautma@redhat.com> Reviewed-by: <bmichalo@redhat.com> Reviewed-by: <sridhar.rao@spirent.com>
2017-01-10Merge "rhel73_install: Provide installer script for RHEL 7.3"Martin Klozik6-12/+180
2017-01-06rhel73_install: Provide installer script for RHEL 7.3Christian Trautman6-12/+180
Adds installer scripts for RHEL 7.3 OS. Modified dpdk makefile to allow upstream dpdk to build. Prevents upstream OVS from building due to kernel incompatibilities. Provides instructions on setting up RHEL 7.3 for usage with binary OVS packages when testing with OVS Vanilla. Tested under RHEL 7.3 JIRA: VSPerf-322 Change-Id: If294d465f28f60a1c514a7b661ce4696ac3b5b73 Signed-off-by: Christian Trautman <ctrautma@redhat.com>
2017-01-05Merge "pkt_gen: STC - Handle Results DB file synchronization failures."Martin Klozik2-4/+14
2017-01-05pkt_gen: STC - Handle Results DB file synchronization failures.Sridhar K. N. Rao2-4/+14
If the downloading of results-database file fails, the CSV file and corresponding results are not generated - eventhough the test was successful. This small patch handles such cases. Updated the logging to be more explicit. JIRA: VSPERF-435 Change-Id: I14bf519fbca2ea362777e29920bc1759494965e0 Signed-off-by: Sridhar K. N. Rao <sridhar.rao@spirent.com>
2017-01-04bugfix: Ethernet type and vnf stop fixesMartin Klozik4-7/+8
Usage of ethernet type for IPv4 was harmonized, to use 0x0800 at all places. Together with this fix a bug during VNF cleanup was removed - VNF started by TestSteps are tested for validity before the call of their stop() method. It avoid vsperf crash in case, that VNF was not properly started. JIRA: VSPERF-436 Change-Id: Ic1a36919f5c9d707aa0aad64b5d96a1214c56cb3 Signed-off-by: Martin Klozik <martinx.klozik@intel.com> Reviewed-by: Al Morton <acmorton@att.com> Reviewed-by: Christian Trautman <ctrautma@redhat.com> Reviewed-by: Bill Michalowski <bmichalo@redhat.com> Reviewed-by: Antonio Fischetti <antonio.fischetti@intel.com> Reviewed-by: Sridhar Rao <sridhar.rao@spirent.com>
2016-12-19Merge "install: Ubuntu 16.xx support"Martin Klozik3-0/+4
2016-12-14conf: traffic type naming step2Martin Klozik7-8/+9
Update of the rest of old traffic type names. JIRA: VSPERF-420 Change-Id: Icf4bab7afad09f9b48ee25b9ff020c83cf2e02bd Signed-off-by: Martin Klozik <martinx.klozik@intel.com> Reviewed-by: Al Morton <acmorton@att.com> Reviewed-by: Christian Trautman <ctrautma@redhat.com> Reviewed-by: Bill Michalowski <bmichalo@redhat.com> Reviewed-by: Antonio Fischetti <antonio.fischetti@intel.com> Reviewed-by: <sridhar.rao@spirent.com>