summaryrefslogtreecommitdiffstats
AgeCommit message (Collapse)AuthorFilesLines
2016-06-08Spirent Support for Continuous TrafficSridhar Rao2-2/+129
Adding changes for supporting continuous traffic for Spirent Testcenter The changes are as follows: 1. From send_cont_traffic invoke function in testcenter-rfc2544-rest.py 2. In testcenter-rfc2544-rest.py check for the traffic_custom 3. If the traffic_custom is 'cont' do additional configuration on traffic. JIRA: VSPERF-146 Change-Id: Ic963f9f0c2bd013f6e676c9d18b151ae67ff77af Signed-off-by: Sridhar Rao <sridhar.rao@spirent.com>
2016-06-02Merge "integration_doc: Update integration document"Maryam Tahhan1-3/+91
2016-05-26integration_doc: Update integration documentChristian Trautman1-3/+91
Update integration document to reflect tests are not just overlay tests. * Include instructions for using macros * Include information on test step validation JIRA: VSPERF-298 Change-Id: Ic0d5f277b2a8b646f331e967f83421708b374f21 Signed-off-by: Christian Trautman <ctrautma@redhat.com>
2016-05-25Merge "Rebase to fuel 9.0 and add vagrant based build and enhance some scripts"Maryam Tahhan10-39/+65
2016-05-23bugfix: Remove dependency on ifconfigMartin Klozik3-14/+30
VSPERF uses ifconfig at several places to bring up a networking interface. However ifconfig has been deprecated by iproute2 package and it is not available in standard installation of many Linux distributions. Thus all calls of ifconfig have been replaced by call of 'ip' tool. Change-Id: I935eaf85b6082e4641d12cffea3e0882c634e5ea JIRA: VSPERF-299 Signed-off-by: Martin Klozik <martinx.klozik@intel.com> Reviewed-by: Maryam Tahhan <maryam.tahhan@intel.com> Reviewed-by: Al Morton <acmorton@att.com> Reviewed-by: Christian Trautman <ctrautma@redhat.com> Reviewed-by: Brian Castelli <brian.castelli@spirent.com>
2016-05-23Merge "xena_multistream_fix: Fix multistream json config"Maryam Tahhan1-1/+1
2016-05-20Rebase to fuel 9.0 and add vagrant based build and enhance some scriptsGuo Ruijing10-39/+65
Change-Id: Id3a38d662c330cd388c6509c9d6e90409c1da6e7 Signed-off-by: Guo Ruijing <ruijing.guo@intel.com>
2016-05-18Merge "run_task_fix: Fix run_task to provide all output from command"Maryam Tahhan1-7/+14
2016-05-17Updating Committer list (Committer removals)Aric Gardner1-4/+1
Change-Id: I508954206a92a96446b28f40680acb87cd916c0b Signed-off-by: Aric Gardner <agardner@linuxfoundation.org>
2016-05-12run_task_fix: Fix run_task to provide all output from commandChristian Trautman1-7/+14
Fix run_task to correctly provide all output from command sent. Commands that produced longer output would not return all text. JIRA: VSPERF-296 Change-Id: I7e501690ffdb7c01f90d524ffbabe65500f62304 Signed-off-by: Christian Trautman <ctrautma@redhat.com>
2016-05-12xena_multistream_fix: Fix multistream json configChristian Trautman1-1/+1
Fix xena_json module to correctly assign hwmodifier for multistream. Append was incorrect application and list needs to be assigned directly. JIRA: VSPERF-293 Change-Id: I88d1930b88711af7c920b507a4db6c29cca83d8d Signed-off-by: Christian Trautman <ctrautma@redhat.com>
2016-05-12dpdk: Support of DPDK v16.04Martin Klozik4-14/+45
Configuration options modified by VSPERF were split between config_base and config_linuxapp files. Makefile was modified to reflect this change. Additional changes: * content of qemu shared dir is copied without preservation of attributes to avoid compilation issues due misaligned clocks => could produce broken igb_uio module * added support of new testpmd "Bye.." message * DPDK sources are copied from RTE_SDK_USER directory for all VNF variants - this has been wrongly reverted by inttest patch Change-Id: Id502a072c1f843258496decbf031e7ba7264d459 JIRA: VSPERF-297 Signed-off-by: Martin Klozik <martinx.klozik@intel.com> Reviewed-by: Maryam Tahhan <maryam.tahhan@intel.com> Reviewed-by: Al Morton <acmorton@att.com> Reviewed-by: Christian Trautman <ctrautma@redhat.com> Reviewed-by: Brian Castelli <brian.castelli@spirent.com> Reviewed-by: Michal Weglicki <michalx.weglicki@intel.com>
2016-05-12Merge "docs: updated the added features list"Maryam Tahhan1-1/+11
2016-05-12docs: add gotcha for activating the python 3 envMaryam Tahhan1-0/+23
Add instructions for gotcha when activating the python 3 env. Change-Id: Ia531ca796ad15354974dee13033a8d97a42c7747 Signed-off-by: Maryam Tahhan <maryam.tahhan@intel.com> Reviewed-by: Christian Trautman <ctrautma@redhat.com> Reviewed-by: Martin Klozik <martinx.klozik@intel.com> Reviewed-by: Al Morton <acmorton@att.com>
2016-05-12Merge "testcase: execution time"Maryam Tahhan2-0/+8
2016-05-12ovsdb: Add delay after ovsdb startMartin Klozik1-1/+4
Ovsdb must be up and running before any configuration option is modified or vswitchd is executed. Otherwise options won't be modified in DB and/or vswitchd won't be able to use correct options during start up. Change-Id: I04948d383272f2e694ec685b3a21d639068125ca JIRA: VSPERF-291 Signed-off-by: Martin Klozik <martinx.klozik@intel.com> Reviewed-by: Maryam Tahhan <maryam.tahhan@intel.com> Reviewed-by: Al Morton <acmorton@att.com> Reviewed-by: Christian Trautman <ctrautma@redhat.com> Reviewed-by: Brian Castelli <brian.castelli@spirent.com>
2016-05-11Merge "ovs: update to OVS 2.5"Maryam Tahhan2-1/+8
2016-05-11testcase: execution timeMaryam Tahhan2-0/+8
Measure the execution time for a testcase and add it to the log. We need to report the test execution times for the testcases for OPNFV release C. Modified the timing result in the csv + results file to display a H:M:S format. Change-Id: Ife9e361da5f8b3fc3721050ae3e6dce049f7402d Signed-off-by: Maryam Tahhan <maryam.tahhan@intel.com> Reviewed-by: Christian Trautman <ctrautma@redhat.com> Reviewed-by: Martin Klozik <martinx.klozik@intel.com> Reviewed-by: Al Morton <acmorton@att.com>
2016-05-11docs: updated the added features listMaryam Tahhan1-1/+11
Updated the added features list in NEWS.rst. If there's anything I missed please let me know. Change-Id: I12dd63cbea293642f14e1ab3eb0d5b715e3a015e Signed-off-by: Maryam Tahhan <maryam.tahhan@intel.com> Reviewed-by: Christian Trautman <ctrautma@redhat.com> Reviewed-by: Martin Klozik <martinx.klozik@intel.com> Reviewed-by: Al Morton <acmorton@att.com>
2016-05-11ovs: update to OVS 2.5Maryam Tahhan2-1/+8
Upgrade OVS version tested to 2.5. Tested with OVS with DPDK and stock OVS. JIRA: VSPERF-254 Change-Id: I78f6cdca0b96c5b13524cec3a662e55f49320f69 Signed-off-by: Maryam Tahhan <maryam.tahhan@intel.com> Reviewed-by: Christian Trautman <ctrautma@redhat.com> Reviewed-by: Martin Klozik <martinx.klozik@intel.com> Reviewed-by: Al Morton <acmorton@att.com>
2016-05-11qemu: add python path to configureMaryam Tahhan1-1/+1
Add python path to ./configure arguments for QEMU to overcome build issue. Change-Id: I6a29f471a27bc0088609bf78176120637709df21 Signed-off-by: Maryam Tahhan <maryam.tahhan@intel.com> Reviewed-by: Christian Trautman <ctrautma@redhat.com> Reviewed-by: Martin Klozik <martinx.klozik@intel.com> Reviewed-by: Al Morton <acmorton@att.com>
2016-05-11build_base_machine: added sysstatMaryam Tahhan1-1/+2
Added sysstat package to build base machine for Ubuntu. Change-Id: I648f5a8db21a7713fb5c24ef010db877c9ec4d15 Signed-off-by: Maryam Tahhan <maryam.tahhan@intel.com> Reviewed-by: Christian Trautman <ctrautma@redhat.com> Reviewed-by: Martin Klozik <martinx.klozik@intel.com> Reviewed-by: Al Morton <acmorton@att.com>
2016-05-06dpdk: Support new way of DPDK configuration in ovs-vswitchdMartin Klozik9-184/+214
Configuration of DPDK options in ovs-vswitchd has changed. Previously used option --dpdk was deprecated and all DPDK related options have to be configured through ovsdb via ovs-vsctl calls. VSPERF was modified to detect and use correct version of DPDK configuration. New configuration options should be put into VSWITCHD_DPDK_CONFIG dictionary. VSPERF classes specific to OVS were refactored. Change-Id: Ia3fad5906221439f477638f1f9734289dbf737bb JIRA: VSPERF-291 Signed-off-by: Martin Klozik <martinx.klozik@intel.com> Reviewed-by: Maryam Tahhan <maryam.tahhan@intel.com> Reviewed-by: Al Morton <acmorton@att.com> Reviewed-by: Christian Trautman <ctrautma@redhat.com> Reviewed-by: Brian Castelli <brian.castelli@spirent.com>
2016-05-04pkt_gen: Reporting FPS and MBPS from Spirent Testcentersridharkn1-8/+28
Support for reporting FPS and MBPS (TX and RX) is added. JIRA: VSPERF-285 Change-Id: Ic4b6ca02368b1808f0f985e90099cdb0b41c2afa Signed-off-by: sridharkn <sridhar.rao@spirent.com>
2016-05-04Merge "bugfix: Fix creation of vsperfenv in Ubuntu"Maryam Tahhan2-3/+4
2016-05-04Merge "bidirectional value: Fix inconsistency for bidir param"Maryam Tahhan8-28/+34
2016-05-04Merge "hugepage_doc: Add hugepage configuration info to installation doc"Maryam Tahhan1-0/+39
2016-05-04Merge "makefile: Remove obsolete copy operations"Maryam Tahhan2-12/+0
2016-05-04bidirectional value: Fix inconsistency for bidir paramChristian Trautman8-28/+34
Fixes bi-directional param and enforces string type in testcase configuration. Modifies all instance where bi directional value is used to string. * Changes documentation to specify value type as needed * Changes traffic defaults to use string for bidir value * Fixes testcases configuration files to use bidir as str * Change testcase conf documentation to note enforcement of string type * Sets bidir to title format to keep consitency in traffic profile when passed to traffic generators * Fix pvp/pvvp check for bidir value * Raise exception if testcase configuration is not set as str for bidir value * Change Xena bi-dir check to string compare instead of typecasting to boolean to compare. JIRA: VSPERF-282 Change-Id: I7c91fcd7333a1d1e1371bfd31700c01d7da268b5 Signed-off-by: Christian Trautman <ctrautma@redhat.com>
2016-05-04bugfix: Fix creation of vsperfenv in UbuntuMartin Klozik2-3/+4
Wrong version of virtualenv was executed in Ubuntu specific script. So python modules could not be installed and vsperf was not working. Hugepages mount point is newly created inside sudo environment to avoid issues with permissions. Change-Id: I4f5afc22bceb2eebbf018c42f42b7074a93e2293 JIRA: VSPERF-292 Signed-off-by: Martin Klozik <martinx.klozik@intel.com> Reviewed-by: Maryam Tahhan <maryam.tahhan@intel.com>
2016-05-04bugfix: Graceful shutdown of VM - improvementMartin Klozik8-30/+108
Cleanup phase of PVVP scenario sometimes causes server reboot. Following updates were made to prevent reboots: * better generic process termination procedure * ovsdb is terminated after vswitchd termination * vswitchd is terminated directly instead of parent sudo process * already running VNFs are terminated in case of failure during VNF start() Change-Id: Ic09d60d7bfdea01c84a2685ede3d0316f0d09be7 JIRA: VSPERF-271 Signed-off-by: Martin Klozik <martinx.klozik@intel.com> Reviewed-by: Maryam Tahhan <maryam.tahhan@intel.com>
2016-05-03hugepage_doc: Add hugepage configuration info to installation docChristian Trautman1-0/+39
Adds some documentation to the installation guide on proper hugepage configuration to run vsperf with dpdk and/or guests. JIRA: VSPERF-256 Change-Id: I3b85fe7d69b00841844aa82ba8faf936d7e37825 Signed-off-by: Christian Trautman <ctrautma@redhat.com>
2016-05-03Merge "integration: Support of PVP and PVVP integration TCs"Maryam Tahhan9-183/+500
2016-04-29makefile: Remove obsolete copy operationsMartin Klozik2-12/+0
In the past DPDK, OVS and QEMU were copied and compiled for all three OVS configurations, i.e. Vanilla OVS, OVS+DPDK with vHost Cuse and OVS+DPK with vHost User. Later compilation of QEMU was triggered just once and DPDK compilation was removed from OVS Vanilla dir. However source code was still copied to all directories. Unnecessary copy operations were removed. Signed-off-by: Martin Klozik <martinx.klozik@intel.com> Reviewed-by: Maryam Tahhan <maryam.tahhan@intel.com> Reviewed-by: Al Morton <acmorton@att.com> Reviewed-by: Christian Trautman <ctrautma@redhat.com> Reviewed-by: Brian Castelli <brian.castelli@spirent.com>
2016-04-27integration: Support of PVP and PVVP integration TCsMartin Klozik9-183/+500
Integration TC support has been enhanced to support PVP and PVVP scenarios. Definition of integration testcases have been modified to use a sort of macros for repetitive parts. Additional improvements were introduced: * instances of testcases are created only for testcases selected for execution * new TC definition options allow to define test specific vswitch, VNF, traffic generator and test options * tests filter applied on pattern specified by --tests allows to define negative filter only; In that case list of all tests is used as base for negative filter. * traffic values defined within teststep passed to send_traffic is merged with default values; This is essential for execution of TCs with linux_bridge or SRIOV support. It also simplifies integration TC definition * typos removed Change-Id: Icb734a7afd7e5154f27a8ff25615a39e01f58c27 JIRA: VSPERF-213 JIRA: VSPERF-216 Signed-off-by: Martin Klozik <martinx.klozik@intel.com> Reviewed-by: Maryam Tahhan <maryam.tahhan@intel.com> Reviewed-by: Al Morton <acmorton@att.com> Reviewed-by: Christian Trautman <ctrautma@redhat.com> Reviewed-by: Brian Castelli <brian.castelli@spirent.com>
2016-04-25xena_port_ip: Add port ip assignment for Xena traffic generatorChristian Trautman5-4/+95
Adds port ip set options as part of conf files. Allows for IPv4 address assignment. Adds ipv6 options for later implementation when available in framework. * Adds Xena to documentation area where available traffic gens are listed. JIRA: VSPERF-273 Change-Id: Ia4129222ea95f1d399d5cc0c589c9a99d7b1b81a Signed-off-by: Christian Trautman <ctrautma@redhat.com>
2016-04-20xena_version: Add versioning info for report file from XenaChristian Trautman2-1/+9
Adds Xena version info to report files. Works by pulling the version info from the result file and adding it to the settings dictionary. JIRA: VSPERF-274 Change-Id: I2b7db30e5a621f32a7eaacfe48ab1bca498e4287 Signed-off-by: Christian Trautman <ctrautma@redhat.com>
2016-04-19vm: use the same testpmd sources inside VMMartin Klozik3-12/+4
Always copy testpmd sources from the directory with vHost User version of DPDK. This will avoid possible issues with missing dependencies in some VM images. It will also ensure, that testpmd inside VM is agnostic to chosen vHost method. Change-Id: I0496cc846eff3f7d4c1aef0a9c825545a4c3c818 JIRA: VSPERF-283 Signed-off-by: Martin Klozik <martinx.klozik@intel.com> Reviewed-by: Maryam Tahhan <maryam.tahhan@intel.com> Reviewed-by: Al Morton <acmorton@att.com> Reviewed-by: Christian Trautman <ctrautma@redhat.com> Reviewed-by: Brian Castelli <brian.castelli@spirent.com>
2016-04-19xena: Back 2 Back implementationChristian Trautman3-36/+63
Allows for execution of back 2 back tests by enabling back to back test scenario in json file when executing Xena2544.exe. Return results are the number of frames. Results for test execution can be found in the coresponding JIRA ticket. - Disabled throughput by default in json file. - Modified test params in baseconfig file for b2b test - Modified create_result method to use data in resulting xml file over using inspect strategy to detect test type - Added line to Xena installation guide for issue that was found locally after installation JIRA: VSPERF-264 Change-Id: I0ecd6e1ce750613c53fe308aea3f5a55cca69c20 Signed-off-by: Christian Trautman <ctrautma@redhat.com>
2016-04-19systems: Fix build scripts from arch specific packagesChristian Trautman5-5/+7
Fixes the build scripts to stop using arch specific packages. The issue was found on an x86_64 arch when performing the installation script. The glibc.i686 would fail to install because a dependency was installed with a x86_64 arch. While testing I found other versions of Fedora should also include the glib2-devel package which was added to Fedora 22 build_base_machine script in another patch. This does not seem to be included in the base installation of the OS. Tested on Centos7, Fedora22, 21, 20, and Rhel7.2. JIRA: VSPERF-281 Change-Id: I884d14fdacf0ceb96c9dc341e82c96d864653766 Signed-off-by: Christian Trautman <ctrautma@redhat.com>
2016-04-19bugfix: Graceful shutdown of VMMartin Klozik1-2/+6
Cleanup phase of PVVP scenario sometimes causes server reboot. Following updates were made to prevent reboots: * sleep after VM OS shutdown allows QEMU to finish its own shutdown procedure * shared dir was mounted as read only to prevent its modification, which sometimes causes delays during shutdown; Also warning messages are causing CI jobs failures. Change-Id: I1607e79beeee343893496efe01ca0be5ea684a9d JIRA: VSPERF-271 Signed-off-by: Martin Klozik <martinx.klozik@intel.com> Reviewed-by: Maryam Tahhan <maryam.tahhan@intel.com> Reviewed-by: Al Morton <acmorton@att.com> Reviewed-by: Christian Trautman <ctrautma@redhat.com> Reviewed-by: Brian Castelli <brian.castelli@spirent.com>
2016-04-14sriov: Support of SRIOV and Qemu PCI passthroughMartin Klozik18-139/+701
Generic support of SRIOV has been added. Virtual interfaces can be used in multiplei scenarios instead of physical NICs. Virtual functions can be directly accessed from VM by PCI passthrough method. Another option is to use VFs with vSwtich to evaluate impact on performance. Additonal modifications: * Automatic detection of NIC details has been added to simplify configuration. * Obsoleted configuration options have been removed. * Logging usage within vsperf script was fixed. * Vsperf main was refactored and final cleanup function added. * Configurable forwarding mode of TestPMD executed inside VM. JIRA: VSPERF-198 Change-Id: I4a0d5d262b245d433b12419de79399fb5825a623 Signed-off-by: Martin Klozik <martinx.klozik@intel.com> Reviewed-by: Maryam Tahhan <maryam.tahhan@intel.com> Reviewed-by: Al Morton <acmorton@att.com> Reviewed-by: Christian Trautman <ctrautma@redhat.com> Reviewed-by: Brian Castelli <brian.castelli@spirent.com>
2016-04-12docs: rename scalability testMaryam Tahhan2-4/+4
Rename LTD.Scalability.RFC2544.0PacketLoss to LTD.Scalability.Flows.RFC2544.0PacketLoss to indicate what is being scaled. Change-Id: I398cbccf319fc09b621e7a68d7f81e4ff8d0b050 Signed-off-by: Maryam Tahhan <maryam.tahhan@intel.com> Reviewed-by: Christian Trautman <ctrautma@redhat.com> Reviewed-by: Al Morton <acmorton@att.com> Reviewed-by: Martin Klozik <martinx.klozik@intel.com>
2016-04-12pkt_gen: Testcenter traffic generation using STC-REST API -Import Issue.sridharkn1-2/+3
The import of stcrestclient in moved down to avoid execution errors. Change-Id: Ib9b64f62400c20a031f0ffcd3410582741cf1644 JIRA: VSPERF-237
2016-04-11docs: Fix param name test-param to test-paramsChristian Trautman3-7/+7
Repair of documentation and configuration files where test-params is incorrectly listed as test-param. JIRA: VSPERF-266 Change-Id: I6be6c387fd57338f5dc5fba2ca8e1438dada0852 Signed-off-by: Christian Trautman <ctrautma@redhat.com>
2016-04-08xena: Throughput method implementation for Xena NetworksChristian Trautman8-0/+1340
Add files for Xena Networks 2544 throughput implementation. This allows for Xena to execute tput tests from VSPerf. For information on how this works please see the JIRA ticket. Modify traffic gen guide on install instructions for Xena. Add in scapy to requirements file. Modify conf file for Xena chassis connection information. * Added license info to __init__.py / baseconfig.x2544 * Set initial rate to 10% line rate for tput testing * Modified default mac address xena_json->set_header_layer2 from aa:aa:aa:aa:aa:aa to cc:cc:cc:cc:cc:cc * Removed obsolete multistream params * Added traffic params to 03_traffic.conf * Comments to explain try/catch for latency values * Removed unused import * Rebased to fix merge conflict * Added Xena to available traffic gen list in conf files JIRA: VSPERF-261 Change-Id: I3c4b4a332fd532e10b6096e9ed97a4a39d410839 Signed-off-by: Christian Trautman <ctrautma@redhat.com>
2016-04-07doc: Fix typos in documentationMartin Klozik3-30/+37
A few fixes in documentation to assure clean pdf build. Change-Id: Ib42818820f18ee96efb98d2016f4d6d9ee3e2b62 Signed-off-by: Martin Klozik <martinx.klozik@intel.com> Reviewed-by: Maryam Tahhan <maryam.tahhan@intel.com> Reviewed-by: Al Morton <acmorton@att.com> Reviewed-by: Christian Trautman <ctrautma@redhat.com> Reviewed-by: Brian Castelli <brian.castelli@spirent.com>
2016-04-07pkt_gen: Adding Support of testcenter traffic generation using STC REST API.sridharkn3-28/+729
Stcrestclient package based script is added. Support for RFC22544 backtoback, latency, frameloss are also added, along with the throughput. Comments Addressed: 1. Parameter name consistency. Ex: use duration (refer dummy.py). 2. Moved 'only the necessary contents of README to configguide/trafficgen.rst. 3. Removed README file 4. Commit message format (pkt_gen: and linewrap) 5. Merged 4 scripts (throughput/backtoback/latency/frameloss) that were rest-based into one single script. Name: testcenter-rfc2544-test.py 6. Changed year to 2016 7. Moved imports to the top (testcenter-rfc2544-rest.py) 8. Changed prints to Log (testcenter-rfc2544-rest.py) 9. Reporting the frame loss percentage. 10. Calls to frameloss and latency are not added as the 'caller' class TrafficControllerRFC2544 is only calling backtoback and throughput. 11. Changed Exception, e to Exception as e for python 3 compatibility 12. Remaining prints to debug and logger.error for errors. 13. Moved Session creation under try block. 14. Removed deadcode 15. Fixed missing docstring 16. Generic to specific Exception. 17. if-if to if-elif 18. Debug level logging only under verbose flag. 19. Fixed Arguments mismatch. 20. Ordering of the imports Note: The testcenter-rfc2544-rest.py is spawned as a separate process, and need not be wrapped in a class. JIRA: VSPERF-237 Change-Id: I05d2b24fca1da4ba67bc4d79206c5d755ebf8f20 Signed-off-by: sridharkn <sridhar.rao@spirent.com>
2016-04-07Configuration: Fix of default param in custom conf fileChristian Trautman1-1/+1
Fixing default param for packet sizes to be of correct parameter name. JIRA: VSPERF-260 Change-Id: Ie09cae6fa47d85f1a15e7da40325a48d3acd1518 Signed-off-by: Christian Trautman <ctrautma@redhat.com>
2016-04-05bugfix: Graceful shutdown of VMsMartin Klozik1-10/+25
Cleanup phase of PVVP scenario sometimes causes server reboot. It seems, that forced kill of VMs is the root cause. So graceful shutdown of VMs was introduced. Change-Id: I427404406fd7174d2a034f3cf0b51fe0833f9ecf JIRA: VSPERF-271 Signed-off-by: Martin Klozik <martinx.klozik@intel.com> Reviewed-by: Maryam Tahhan <maryam.tahhan@intel.com> Reviewed-by: Al Morton <acmorton@att.com> Reviewed-by: Christian Trautman <ctrautma@redhat.com> Reviewed-by: Brian Castelli <brian.castelli@spirent.com>