diff options
| author |   goldammx <martinx.goldammer@intel.com> | 2017-02-09 08:03:00 -0500 |
|---|---|---|
| committer | goldammx <martinx.goldammer@intel.com> | 2017-02-13 06:21:28 -0500 |
| commit | ca9c9275ed6d5d852987c69a378e88a3502cb2ab (patch) | |
| tree | 23a28663a4db92cd1c409b887691650642f18023 /vswitches/ovs_vanilla.py | |
| parent | ea4376cb3c89f4e3605d7f48036fd61325a52fcf (diff) | |
pylint: Fixing pylint errors and warnings
All python files must reach pylint score 10/10. This will be
regularly verified by Jenkins jobs to keep constant code quality.
VSPERF specific pylintrc file was updated according to the vsperf
coding standards. Distro version included in reports will be
slightly different, due to migration to new python package distro.
Previously used platform.distro() will be deprecated since python 3.7.
JIRA: VSPERF-487
Change-Id: I934120208b9624787a3567ccaa49e14d77d7a5bf
Signed-off-by: Martin Goldammer <martinx.goldammer@intel.com>
Reviewed-by: Martin Klozik <martinx.klozik@intel.com>
Reviewed-by: Al Morton <acmorton@att.com>
Reviewed-by: Christian Trautman <ctrautma@redhat.com>
Reviewed-by: Bill Michalowski <bmichalo@redhat.com>
Reviewed-by: Antonio Fischetti <antonio.fischetti@intel.com>
Reviewed-by: Sridhar Rao <sridhar.rao@spirent.com>
Diffstat (limited to 'vswitches/ovs_vanilla.py')
| -rw-r--r-- | vswitches/ovs_vanilla.py | 9 |
1 files changed, 2 insertions, 7 deletions
diff --git a/vswitches/ovs_vanilla.py b/vswitches/ovs_vanilla.py index 12a460af..649a5ab9 100644 --- a/vswitches/ovs_vanilla.py +++ b/vswitches/ovs_vanilla.py @@ -1,4 +1,4 @@ -# Copyright 2015-2016 Intel Corporation. +# Copyright 2015-2017 Intel Corporation. # # Licensed under the Apache License, Version 2.0 (the "License"); # you may not use this file except in compliance with the License. @@ -19,7 +19,6 @@ import logging from conf import settings from vswitches.ovs import IVSwitchOvs from src.ovs import DPCtl -from tools.module_manager import ModuleManager from tools import tasks class OvsVanilla(IVSwitchOvs): @@ -41,7 +40,6 @@ class OvsVanilla(IVSwitchOvs): self._logger = logging.getLogger(__name__) self._vswitchd_args += ["unix:%s" % self.get_db_sock_path()] self._vswitchd_args += settings.getValue('VSWITCHD_VANILLA_ARGS') - self._module_manager = ModuleManager() def stop(self): """See IVswitch for general description @@ -75,8 +73,7 @@ class OvsVanilla(IVSwitchOvs): self._logger.error("Can't add port! There are only " + len(self._ports) + " ports " + "defined in config!") - raise - + raise RuntimeError('Failed to add phy port') if not self._ports[self._current_id]: self._logger.error("Can't detect device name for NIC %s", self._current_id) raise ValueError("Invalid device name for %s" % self._current_id) @@ -128,5 +125,3 @@ class OvsVanilla(IVSwitchOvs): bridge = self._bridges[switch_name] of_port = bridge.add_port(tap_name, []) return (tap_name, of_port) - - |