pylint: Fixing pylint errors and warnings

All python files must reach pylint score 10/10. This will be
regularly verified by Jenkins jobs to keep constant code quality.
VSPERF specific pylintrc file was updated according to the vsperf
coding standards. Distro version included in reports will be
slightly different, due to migration to new python package distro.
Previously used platform.distro() will be deprecated since python 3.7.

JIRA: VSPERF-487

Change-Id: I934120208b9624787a3567ccaa49e14d77d7a5bf
Signed-off-by: Martin Goldammer <martinx.goldammer@intel.com>
Reviewed-by: Martin Klozik <martinx.klozik@intel.com>
Reviewed-by: Al Morton <acmorton@att.com>
Reviewed-by: Christian Trautman <ctrautma@redhat.com>
Reviewed-by: Bill Michalowski <bmichalo@redhat.com>
Reviewed-by: Antonio Fischetti <antonio.fischetti@intel.com>
Reviewed-by: Sridhar Rao <sridhar.rao@spirent.com>

1 files changed, 6 insertions, 8 deletions

diff --git a/tools/opnfvdashboard/opnfvdashboard.py b/tools/opnfvdashboard/opnfvdashboard.py
index 6f53526d..3f465c04 100644
--- a/tools/opnfvdashboard/opnfvdashboard.py
+++ b/tools/opnfvdashboard/opnfvdashboard.py
@@ -1,7 +1,7 @@
 """
 vsperf2dashboard
 """
-# Copyright 2015 Intel Corporation.
+# Copyright 2015-2017 Intel Corporation.
 #
 # Licensed under the Apache License, Version 2.0 (the "License");
 # you may not use this file except in compliance with the License.
@@ -15,12 +15,10 @@ vsperf2dashboard
 # See the License for the specific language governing permissions and
 # limitations under the License.
 
-
 import os
 import csv
-import requests
-import json
 import logging
+import requests
 
 def results2opnfv_dashboard(results_path, int_data):
     """
@@ -66,7 +64,7 @@ def _push_results(reader, int_data):
                 version_ovs = line.replace(' ', '')
                 version_ovs = version_ovs.replace('OVS_TAG?=', '')
             if "DPDK_TAG" in line:
-                if int_data['vanilla'] == False:
+                if int_data['vanilla'] is False:
                     version_dpdk = line.replace(' ', '')
                     version_dpdk = version_dpdk.replace('DPDK_TAG?=', '')
                 else:
@@ -81,8 +79,8 @@ def _push_results(reader, int_data):
             "version": version,
             "details": details}
 
-    myData = requests.post(url, json=body)
-    logging.info("Results for %s sent to opnfv, http response: %s", casename, myData)
+    my_data = requests.post(url, json=body)
+    logging.info("Results for %s sent to opnfv, http response: %s", casename, my_data)
     logging.debug("opnfv url: %s", db_url)
     logging.debug("the body sent to opnfv")
     logging.debug(body)
@@ -111,7 +109,7 @@ def _generate_test_name(testcase, int_data):
     for name, name_list in names.items():
         if name != testcase:
             continue
-        if vanilla == True:
+        if vanilla is True:
             res_name = name_list[1]
         else:
             res_name = name_list[0]