aboutsummaryrefslogtreecommitdiffstats
AgeCommit message (Collapse)AuthorFilesLines
2017-01-05Merge "pkt_gen: STC - Handle Results DB file synchronization failures."Martin Klozik2-4/+14
2017-01-05pkt_gen: STC - Handle Results DB file synchronization failures.Sridhar K. N. Rao2-4/+14
If the downloading of results-database file fails, the CSV file and corresponding results are not generated - eventhough the test was successful. This small patch handles such cases. Updated the logging to be more explicit. JIRA: VSPERF-435 Change-Id: I14bf519fbca2ea362777e29920bc1759494965e0 Signed-off-by: Sridhar K. N. Rao <sridhar.rao@spirent.com>
2017-01-04bugfix: Ethernet type and vnf stop fixesMartin Klozik4-7/+8
Usage of ethernet type for IPv4 was harmonized, to use 0x0800 at all places. Together with this fix a bug during VNF cleanup was removed - VNF started by TestSteps are tested for validity before the call of their stop() method. It avoid vsperf crash in case, that VNF was not properly started. JIRA: VSPERF-436 Change-Id: Ic1a36919f5c9d707aa0aad64b5d96a1214c56cb3 Signed-off-by: Martin Klozik <martinx.klozik@intel.com> Reviewed-by: Al Morton <acmorton@att.com> Reviewed-by: Christian Trautman <ctrautma@redhat.com> Reviewed-by: Bill Michalowski <bmichalo@redhat.com> Reviewed-by: Antonio Fischetti <antonio.fischetti@intel.com> Reviewed-by: Sridhar Rao <sridhar.rao@spirent.com>
2016-12-19Merge "install: Ubuntu 16.xx support"Martin Klozik3-0/+4
2016-12-14conf: traffic type naming step2Martin Klozik7-8/+9
Update of the rest of old traffic type names. JIRA: VSPERF-420 Change-Id: Icf4bab7afad09f9b48ee25b9ff020c83cf2e02bd Signed-off-by: Martin Klozik <martinx.klozik@intel.com> Reviewed-by: Al Morton <acmorton@att.com> Reviewed-by: Christian Trautman <ctrautma@redhat.com> Reviewed-by: Bill Michalowski <bmichalo@redhat.com> Reviewed-by: Antonio Fischetti <antonio.fischetti@intel.com> Reviewed-by: <sridhar.rao@spirent.com>
2016-12-13install: Ubuntu 16.xx supportMartin Klozik3-0/+4
Installation scripts were updated to support Ubuntu 16.04 LTS and Ubuntu 16.10. Ubuntu 16.10 uses kernel 4.8, which is supported since DPDK 16.11. It is up to the vsperf user to use DPDK and OVS versions compatible with active Linux kernel. JIRA: VSPERF-408 Change-Id: Ifb71de72cf6d4f9d6e2319cb5c1d7d5dcbe5314f Signed-off-by: Goldammer, MartinX <martinx.goldammer@intel.com> Signed-off-by: Martin Klozik <martinx.klozik@intel.com> Reviewed-by: Al Morton <acmorton@att.com> Reviewed-by: Christian Trautman <ctrautma@redhat.com> Reviewed-by: Bill Michalowski <bmichalo@redhat.com> Reviewed-by: Antonio Fischetti <antonio.fischetti@intel.com> Reviewed-by: <sridhar.rao@spirent.com>
2016-12-07Merge "conf:Traffic-type naming convention and consistency"Martin Klozik7-70/+79
2016-12-07conf:Traffic-type naming convention and consistencySridhar K. N. Rao7-70/+79
Following changes are added following first review 1. Descriptions in integration/01_testcases.conf 2. Comment in conf/01_testcases.conf 3. Checking all cases of traffic types in traffic_controller_rfc2544.py 4. Removing whitespaces 5. Missing changes (throughput->rfc2544_throughput) 6. Syntax error in core/traffic_controller_rfc2544.py Currently the traffic-type values that are provided as part of the test case definition needs some fix to support additional traffic - apart from rfc2544. The Current and the proposed changed is summarized in the below table: |--------------------------------------------------------------------| | Parameter | Existing traffic_type value | Changed to | ---------------------------------------------------------------------- | Throughput | rfc2544 OR throughput | rfc2544_throughput | ---------------------------------------------------------------------- | Back2Back | back2back | rfc2544_back2back | ---------------------------------------------------------------------- | Continuous | continuous | rfc2544_continuous | ---------------------------------------------------------------------- JIRA: VSPERF-420 Change-Id: I22bd897f6389d2b568a6a3735c67f0003e813445 Signed-off-by: Sridhar K. N. Rao <sridhar.rao@spirent.com>
2016-12-06Merge "scl_fix: Fix broken link to install python33"Christian Trautman2-5/+17
2016-12-01Merge "pkt_gen: MoonGen updated to keep parity with master"Martin Klozik2-12/+11
2016-12-01Merge "yardstick: CLI params support for yardstick TCs"Martin Klozik9-157/+358
2016-11-30scl_fix: Fix broken link to install python33Christian Trautman2-5/+17
Fixes broken link to download python33 rpm scl installer. Replaces Centos with software collections recommended method to install Python33. Adds temporary repo for Rhel7.2 to install python33. Verified on Centos7.2 and Rhel7.2. JIRA: VSPerf-429 Change-Id: Id86748e898f1d81011d19024d9ff2c0e9a47479f Signed-off-by: Christian Trautman <ctrautma@redhat.com>
2016-11-30pkt_gen: MoonGen updated to keep parity with masterbmichalo2-12/+11
Need to make VSPERF's MoonGen codebase in parity with master emmerich MoonGen branch. JIRA: VSPERF-400 Change-Id: I8c50ed89c9e7b0080497107c1af826f49c1e82f0 Signed-off-by: bmichalo <bmichalo@redhat.com>
2016-11-30yardstick: CLI params support for yardstick TCsMartin Klozik9-157/+358
Vswitchperf specific class in yardstick was updated to reflect new functionality of --test-params. These changes have impact on vsperf documentation and yardstick samples. As part of this fix following changes were made: * trafficgen mode can be executed with default configuration * yardstick specific TC samples were updated * dummy traffic generator was enhanced to support back2back * dummy traffic generator was enhanced to accept traffic results from configuration JIRA: VSPERF-422 JIRA: VSPERF-205 Change-Id: Ibeaa6ef46bde453e3ca5dee6e4568fc8c3853521 Signed-off-by: Martin Klozik <martinx.klozik@intel.com> Reviewed-by: Al Morton <acmorton@att.com> Reviewed-by: Christian Trautman <ctrautma@redhat.com> Reviewed-by: Bill Michalowski <bmichalo@redhat.com> Reviewed-by: Antonio Fischetti <antonio.fischetti@intel.com> Reviewed-by: <sridhar.rao@spirent.com>
2016-11-24ci: Configure hugepages directly from CI scriptMartin Klozik1-3/+21
In case of CI it is better to enforce hugepages allocation. Just for case, that hugepages were left enabled by last vsperf execution or by another job. JIRA: VSPERF-391 Change-Id: I0531b2a8a1e5024d73c227377dd9c487d6931c35 Signed-off-by: Martin Klozik <martinx.klozik@intel.com> Reviewed-by: Al Morton <acmorton@att.com> Reviewed-by: Christian Trautman <ctrautma@redhat.com> Reviewed-by: Bill Michalowski <bmichalo@redhat.com>
2016-11-23Merge "Xena_cont_accuracy: Modify continuous from duration to packet limit"Martin Klozik2-4/+46
2016-11-23Merge "ci: Use HTML report instead of PDF"Martin Klozik1-3/+3
2016-11-23Merge "Rebase to fuel 10.0 for fuel@opnfv D release"Maryam Tahhan1-3/+3
2016-11-23Merge "Rhel_scl_python: Modify python build in place to scl usage"Martin Klozik3-32/+19
2016-11-22ci: Use HTML report instead of PDFMartin Klozik1-3/+3
After the switch to opnfvdocs script for documentation build, the pdf version of documentation is not generated. HTML report should be stored inside artifactory instead. JIRA: VSPERF-324 Change-Id: I42f918721264959ba7c94223204d83ce1fe8ad60 Signed-off-by: Martin Klozik <martinx.klozik@intel.com> Reviewed-by: Al Morton <acmorton@att.com> Reviewed-by: Christian Trautman <ctrautma@redhat.com> Reviewed-by: Bill Michalowski <bmichalo@redhat.com> Reviewed-by: Antonio Fischetti <antonio.fischetti@intel.com> Reviewed-by: Otto Sabart <osabart@redhat.com>
2016-11-22Merge "report: [fix] remove upper border of a process table"Martin Klozik1-1/+0
2016-11-21Xena_cont_accuracy: Modify continuous from duration to packet limitChristian Trautman2-4/+46
First of a few patches planned to help increase Xena continuous traffic accuracy. Modifies port limits to packet calculated limits versus time based limits which can be wildly inaccurate. Also modifies some port settings to be more inline with how rfc2544 settings are applied on Xena. Increased time delay by one second to allow packets to finish transmitting before stat collection occurs. JIRA: VSPerf-423 Change-Id: I214b13d743a84a0733e885ccfc5bdd57812d7104 Signed-off-by: Christian Trautman <ctrautma@redhat.com>
2016-11-21ci: Decrease hugepages size for VERIFY&MERGE jobsMartin Klozik5-20/+24
VSPERF by default requires allocation of hugepages with total size of 10GB. However for MERGE and VERIFY jobs less memory is required and default size of 10GB can cause issues. Thus amount of memory was limited and other minor enhancements were introduced: * sysstat system package is installed at nodes running VERIFY and MERGE jobs * WHITELIST_NICS was set to empty list by default to avoid automatic bind of NICs to DPDK. Old default value could cut off network connection to DUT. * imports were fixed at both integration.py and testcase.py JIRA: VSPERF-391 Change-Id: Ic07d68f4591ae697c1b8edeae6c0cffe47c065ce Signed-off-by: Martin Klozik <martinx.klozik@intel.com> Reviewed-by: Al Morton <acmorton@att.com> Reviewed-by: Christian Trautman <ctrautma@redhat.com> Reviewed-by: Bill Michalowski <bmichalo@redhat.com> Reviewed-by: Antonio Fischetti <antonio.fischetti@intel.com>
2016-11-18Rhel_scl_python: Modify python build in place to scl usageChristian Trautman3-32/+19
Previously Rhel install script would build python 3 in place using downloaded bits. It was suggested to change this to use scl method instead. This patch modifies the build in place to use scl method as per Centos scripts. JIRA: VSPERF-258 Change-Id: I5b6d7b8fd7f96a315d04e1ccdfd381908e0d1ad0 Signed-off-by: Christian Trautman <ctrautma@redhat.com>
2016-11-11INFO: modified committer listMaryam Tahhan1-1/+0
Change-Id: I709dd316b1c53fa632c1a6ff192b13d1756669d0 Signed-off-by: Maryam Tahhan <maryam.tahhan@intel.com>
2016-11-11Merge "cli: Modify configuration via CLI"Martin Klozik23-170/+257
2016-11-09cli: Modify configuration via CLIMartin Klozik23-170/+257
In the past, only a few configuration parameters could be modified via --test-params CLI argument and it was not easy to find out their complete list. This patch adds support for generic modification of any configuration parameter via CLI argument --test-params or by "Parameters" section of testcase definition. Thus it is possible to customize a vsperf configuration environment per testcase or for each vsperf execution. Old CLI parameters duration, pkt_sizes, rfc2544_tests and rfc2889_trials were renamed to TRAFFICGEN_DURATION, TRAFFICGEN_PKT_SIZES, TRAFFICGEN_RFC2544_TESTS and TRAFFICGEN_RFC2889_TRIALS to be consistent with other configuration parameters. JIRA: VSPERF-375 Change-Id: I50a1f4ff7250d754aa8af0295a9c7c1be8151175 Signed-off-by: Martin Klozik <martinx.klozik@intel.com> Reviewed-by: Al Morton <acmorton@att.com> Reviewed-by: Christian Trautman <ctrautma@redhat.com> Reviewed-by: Bill Michalowski <bmichalo@redhat.com> Reviewed-by: Antonio Fischetti <antonio.fischetti@intel.com> Reviewed-by: <sridhar.rao@spirent.com>
2016-11-04bugfix: Trafficgen Ixia does not workMartin Klozik4-6/+16
IXIA traffic generator can be controlled by two different VSPERF's wrappers IxNet (preferred) and Ixia (legacy and outdated). It has been found, that Ixia wrapper can't be used because of missing "packetsize" traffic item. Also only IXIA OS 6.60 was supported and never IXIA OS versions were not working. Both limitations were fixed. Also reported results were fixed to show correct values for MBPS items. JIRA: VSPERF-417 Change-Id: I191aa9fee2683877ce373b6aa7cd1c72e9847568 Signed-off-by: Martin Klozik <martinx.klozik@intel.com> Reviewed-by: Al Morton <acmorton@att.com> Reviewed-by: Christian Trautman <ctrautma@redhat.com> Reviewed-by: Bill Michalowski <bmichalo@redhat.com> Reviewed-by: Christo Kleu <christo.kleu@netronome.com>
2016-10-27teststeps: Generic support of step driven testsMartin Klozik13-1008/+1055
In the past, step driven testcases were supported only by integration testcases. This patch adds generic support of TestSteps for both integration and performance testcases. Step driven test were improved to support modification of existing deployment. As part of the patch a refactoring of traffic controllers were performed. Traffic controllers were modified to support trafficgen-off and trafficgen-pause modes in all possible ways of trafficgen invocation. JIRA: VSPERF-362 Change-Id: Ic8b7a9b0e7165f0a15a52279ed0f0952da9fedb8 Signed-off-by: Martin Klozik <martinx.klozik@intel.com> Reviewed-by: Maryam Tahhan <maryam.tahhan@intel.com> Reviewed-by: Al Morton <acmorton@att.com> Reviewed-by: Christian Trautman <ctrautma@redhat.com> Reviewed-by: Bill Michalowski <bmichalo@redhat.com> Reviewed-by: Antonio Fischetti <antonio.fischetti@intel.com> Reviewed-by: Sridhar K. N. Rao <sridhar.rao@spirent.com>
2016-10-24guest_binding: Add dpdk driver binding options for guestsChristian Trautman3-8/+79
Adds uio_pci_generic and vfio_no_iommu options for guest driver binding. In case of SR-IOV tests with guests attached and uio_pci_generic is selected the option will be modified to use igb_uio instead as uio_pci_generic is not supported. JIRA: VSPERF-397 Change-Id: I56003addacc8bf0d024cce35d41b00dd0baa8cbc signed-off-by: Christian Trautman <ctrautma@redhat.com>
2016-10-21Merge "ci: Enhance verify and merge jobs"Martin Klozik2-22/+139
2016-10-20ci: Enhance verify and merge jobsMartin Klozik2-22/+139
Verify and merge jobs will execute real vsperf TCs, which won't require neither physical NICs nor traffic generator. Script ./build-vsperf.sh will take care about creation, update and activation of python virtual environment. It will also install required system packages at nodes running merge and verify jobs. Additional improvements: * set of simple sanity checks was added * two new integration TCs were added; However test with VNF is not used now, because it requires a VM image. * detailed logs are shown in case of failure JIRA: VSPERF-391 Change-Id: I33e75e762fdc62656de92dc34f0ad7a484623603 Signed-off-by: Martin Klozik <martinx.klozik@intel.com> Reviewed-by: Maryam Tahhan <maryam.tahhan@intel.com> Reviewed-by: Al Morton <acmorton@att.com> Reviewed-by: Christian Trautman <ctrautma@redhat.com> Reviewed-by: Bill Michalowski <bmichalo@redhat.com> Reviewed-by: Fatih Degirmenci <fatih.degirmenci@ericsson.com>
2016-10-18doc: fix copy-paste error in Moongen configuration sectionOtto Sabart1-2/+2
JIRA: VSPERF-414 Change-Id: I1924c8a0c949695b4ec0699a206b9e39ee2ef724 Signed-off-by: Otto Sabart <osabart@redhat.com>
2016-10-18Merge "testpmd: Simplify GUEST's testpmd configuration"Martin Klozik3-172/+123
2016-10-17testpmd: Simplify GUEST's testpmd configurationMartin Klozik3-172/+123
Testpmd has a lot of parameters and vsperf was able to modify only a few of them through dedicated GUEST's specific configuration options. Old configuration options were replaced by one generic GUEST_TESTPMD_PARAMS, which allows to modify any of existing testpmd parameters. Detection of testpmd execution was changed to be independent on TXQ flags setting. Documentation was modified to reflect GUEST_TESTPMD change. Also doc formatting was fixed at several places. JIRA: VSPERF-380 Change-Id: Ie0bf290320f3b22ef6be6b55ed553235bbcb4aff Signed-off-by: Martin Klozik <martinx.klozik@intel.com> Reviewed-by: Maryam Tahhan <maryam.tahhan@intel.com> Reviewed-by: Al Morton <acmorton@att.com> Reviewed-by: Christian Trautman <ctrautma@redhat.com> Reviewed-by: Bill Michalowski <bmichalo@redhat.com> Reviewed-by: Antonio Fischetti <antonio.fischetti@intel.com>
2016-10-14licenses: Dedicated directory for non Apache filesMartin Klozik9-7/+10
All files, which do not comply to Apache 2.0 license, are moved into dedicated 3rd_party directory. This will simplify license checks performed on vsperf code. It is not required to move l2fwd module from its current location. JIRA: VSPERF-413 Change-Id: I6b4bd6bb5542e6db9a7ef91ee3f5f2907f93e9b8 Signed-off-by: Martin Klozik <martinx.klozik@intel.com> Reviewed-by: Maryam Tahhan <maryam.tahhan@intel.com> Reviewed-by: Al Morton <acmorton@att.com> Reviewed-by: Christian Trautman <ctrautma@redhat.com> Reviewed-by: Bill Michalowski <bmichalo@redhat.com>
2016-10-14Merge "IETF Draft: Comments from IETF-96"Maryam Tahhan1-0/+1027
2016-10-13report: [fix] remove upper border of a process tableOtto Sabart1-1/+0
According to Markdown Tables extension specification, there should be no upper border in the table. See for example python implementation of Markdown Tables extension [0][1]. [0] https://pythonhosted.org/Markdown/extensions/tables.html [1] https://michelf.ca/projects/php-markdown/extra/#table JIRA: VSPERF-411 Change-Id: I2843dbeb4544a1d1fe0a5f1a6b1028ae788a28ee Signed-off-by: Otto Sabart <osabart@redhat.com>
2016-10-11vsperf: launch should not depend on current $PWDOtto Sabart6-9/+17
JIRA: VSPERF-392 Change-Id: I44866b7d3298617003b87b015eb08bf32c4014f7 Signed-off-by: Otto Sabart <osabart@redhat.com>
2016-10-11Merge "integration: Test vHost User numa awareness"Martin Klozik7-14/+387
2016-10-10IETF Draft: Comments from IETF-96Al Morton1-0/+1027
JIRA: VSPERF-410 x Ramki on OVS features - the scope of benchmarking does not include the ever-growing list of OVS features, only the general and switch-agnostic features will be assessed. x Justify the length of SOAK tests (with variability allowed), mention that the goal is stability characterization, not the typical short term benchmarks of performance. x Fix the LTD Reference to point to Brahmaputra version (which is frozen in the release docs) Change-Id: I2f795cd42e7ec2e06e5cd35bbf0c1f336a5e43ca Signed-off-by: Al Morton <acmorton@att.com> Reviewed-by: Maryam Tahhan <maryam.tahhan@intel.com> Reviewed-by: Billy O'Mahony<billy.o.mahony@intel.com> Reviewed-by: Christian Trautman <ctrautma@redhat.com>
2016-10-09CLI: add Multiqueue params.Antonio Fischetti4-3/+59
This patch implements the following new CLI parameters that can be used in the --test-params list. 1. guest_nic_queues, which overrides all GUEST_NIC_QUEUES values 2. guest_testpmd_txq, which overrides all GUEST_TESTPMD_TXQ 3. guest_testpmd_rxq, which overrides all GUEST_TESTPMD_RXQ 4. guest_testpmd_nb_cores, which overrides all GUEST_TESTPMD_NB_CORES values 5. guest_testpmd_cpu_mask, which overrides all GUEST_TESTPMD_CPU_MASK values 6. vswitch_dpdk_multi_queues, which overrides VSWITCH_DPDK_MULTI_QUEUES 7. guest_smp, which overrides all GUEST_SMP values 8. guest_core_binding, which overrides all GUEST_CORE_BINDING values When they are present in the CLI the corresponding settings from the configuration files will be overridden. As an example a usage can be: ./vsperf --test-params "guest_nic_queues=2;guest_testpmd_txq=1;\ guest_testpmd_rxq=1;guest_testpmd_nb_cores=1"... v2: rebase + rework to add other CLI params as suggested and update doc. v3: changes in 'testusage.rst' doc. JIRA: VSPERF-371 Change-Id: I140d6e068c1653d21aaa0df27532a48c4a12c151 Signed-off-by: Antonio Fischetti <antonio.fischetti@intel.com> Reviewed-by: Maryam Tahhan <maryam.tahhan@intel.com> Reviewed-by: Martin Klozik <martinx.klozik@intel.com>
2016-10-09Merge "Integration Test: 4 serial VMs testcases."Maryam Tahhan1-0/+139
2016-10-09Rebase to fuel 10.0 for fuel@opnfv D releaseGuo Ruijing1-3/+3
Change-Id: I3ebe6876bd0f04218489d2c7d21dcd401a2ee48a Signed-off-by: Guo Ruijing <ruijing.guo@intel.com>
2016-10-05integration: Test vHost User numa awarenessMartin Klozik7-14/+387
Open vSwitch with DPDK can optimize memory usage in case of NUMA architecture to avoid unnecessary memory access across NUMA slots. In a nutshell, PMD threads serving virtual NICs are co-located at the same NUMA slot as QEMU instance, which is using these NICs. This patch adds new (functional) integration testcase, which verifies OVS vHost User numa awareness feature. Step driven test objects were updated to allow a call of OS utilies and evaluation of conditions. Also the documentation was updated with the list of supported test objects and their methods. JIRA: VSPERF-377 Change-Id: I184e71e066d27b5b9fc9e6a9f7e240e2d1b5a0fa Signed-off-by: Martin Klozik <martinx.klozik@intel.com> Reviewed-by: Maryam Tahhan <maryam.tahhan@intel.com> Reviewed-by: Ciara Loftus <ciara.loftus@intel.com> Reviewed-by: Al Morton <acmorton@att.com> Reviewed-by: Christian Trautman <ctrautma@redhat.com> Reviewed-by: Bill Michalowski <bmichalo@redhat.com> Reviewed-by: Antonio Fischetti <antonio.fischetti@intel.com>
2016-10-04Merge "pkt_gen: Spirent Testcenter RFC 2889 Support"Martin Klozik8-1/+595
2016-10-04Merge "cmd_timeout: Add ovs command timeout configuration option"Martin Klozik2-2/+6
2016-10-03cmd_timeout: Add ovs command timeout configuration optionChristian Trautman2-2/+6
Adds option for configurable timeout for ovs commands. JIRA: VSPERF-396 Change-Id: Ie73dfea1a088a5c92bef705f1fe874ddeeaec5a7 Signed-off-by: Christian Trautman <ctrautma@redhat.com>
2016-10-03bugfix: Correct VM handling by integration testsMartin Klozik2-6/+23
Patch with multi VM support has changed the way how data are copied into the shared folder. Also new support of GUEST_ options expansion requires proper initialization with exact number of VMs involved in the test. Code of class specific to integration tests was updated to initialize both GUEST_ options and VM shared dir correctly. Original values of all GUEST_ options are restored after the testcase execution. So other TCs can use original values for configuration expansion to required number of VMs. JIRA: VSPERF-361 Change-Id: Ic1149fbc73f73a66982bb64173b2217e55597200 Signed-off-by: Martin Klozik <martinx.klozik@intel.com> Reviewed-by: Maryam Tahhan <maryam.tahhan@intel.com> Reviewed-by: Al Morton <acmorton@att.com> Reviewed-by: Christian Trautman <ctrautma@redhat.com> Reviewed-by: Bill Michalowski <bmichalo@redhat.com> Reviewed-by: Antonio Fischetti <antonio.fischetti@intel.com>
2016-09-29ci: Update default DPDK and OVS versionsMartin Klozik1-4/+2
VSPERF was updated to use DPDK16.07 and OVS 2.6.90 by default. This change should improve a performance. It will also solve failures of VSPERF verify and merge jobs at OPNFV Jenkins, because newer OVS version is compatible with Linux Kernel 4.4. JIRA: VSPERF-378 Change-Id: I636dd96facd3f6357f215290eb2382c9cc16150e Signed-off-by: Martin Klozik <martinx.klozik@intel.com> Reviewed-by: Maryam Tahhan <maryam.tahhan@intel.com> Reviewed-by: Al Morton <acmorton@att.com> Reviewed-by: Christian Trautman <ctrautma@redhat.com> Reviewed-by: Bill Michalowski <bmichalo@redhat.com>