diff options
| author |   Christian Trautman <ctrautma@redhat.com> | 2016-04-20 15:30:42 -0400 |
|---|---|---|
| committer | Christian Trautman <ctrautma@redhat.com> | 2016-05-04 09:10:46 -0400 |
| commit | 47875a6f01fa9dc1738d4c4a29ad75e12e251077 (patch) | |
| tree | cc53a18eb151cafb200493057b0bfc89c870c44d /tools/pkt_gen | |
| parent | 25969600ac9508ecc54a25d7b0f628e0713a82a2 (diff) | |
bidirectional value: Fix inconsistency for bidir param
Fixes bi-directional param and enforces string type in
testcase configuration. Modifies all instance where bi
directional value is used to string.
* Changes documentation to specify value type as needed
* Changes traffic defaults to use string for bidir value
* Fixes testcases configuration files to use bidir as str
* Change testcase conf documentation to note enforcement
of string type
* Sets bidir to title format to keep consitency in traffic
profile when passed to traffic generators
* Fix pvp/pvvp check for bidir value
* Raise exception if testcase configuration is not set
as str for bidir value
* Change Xena bi-dir check to string compare instead of
typecasting to boolean to compare.
JIRA: VSPERF-282
Change-Id: I7c91fcd7333a1d1e1371bfd31700c01d7da268b5
Signed-off-by: Christian Trautman <ctrautma@redhat.com>
Diffstat (limited to 'tools/pkt_gen')
| -rw-r--r-- | tools/pkt_gen/trafficgen/trafficgenhelper.py | 2 | ||||
| -rwxr-xr-x | tools/pkt_gen/xena/xena.py | 2 |
2 files changed, 2 insertions, 2 deletions
diff --git a/tools/pkt_gen/trafficgen/trafficgenhelper.py b/tools/pkt_gen/trafficgen/trafficgenhelper.py index 0a240579..90c77b09 100644 --- a/tools/pkt_gen/trafficgen/trafficgenhelper.py +++ b/tools/pkt_gen/trafficgen/trafficgenhelper.py @@ -23,7 +23,7 @@ CMD_PREFIX = 'gencmd : ' TRAFFIC_DEFAULTS = { 'traffic_type' : 'rfc2544', 'frame_rate' : 100, - 'bidir' : False, + 'bidir' : 'False', # will be passed as string in title format to tgen 'multistream' : 0, 'stream_type' : 'L4', 'pre_installed_flows' : 'No', # used by vswitch implementation diff --git a/tools/pkt_gen/xena/xena.py b/tools/pkt_gen/xena/xena.py index 67ac5652..d29fc362 100755 --- a/tools/pkt_gen/xena/xena.py +++ b/tools/pkt_gen/xena/xena.py @@ -182,7 +182,7 @@ class Xena(ITrafficGenerator): flows=self._params['traffic']['multistream'], multistream_layer=self._params['traffic']['stream_type']) # set duplex mode - if bool(self._params['traffic']['bidir']): + if self._params['traffic']['bidir'] == "True": j_file.set_topology_mesh() else: j_file.set_topology_blocks() |