diff options
| author |   spisarski <s.pisarski@cablelabs.com> | 2017-07-27 10:27:14 -0600 |
|---|---|---|
| committer | spisarski <s.pisarski@cablelabs.com> | 2017-07-27 10:27:14 -0600 |
| commit | ca276f452540f68c08cb3df9049e9e7876364dac (patch) | |
| tree | ce26c5fb721f10402669bf761c4e69317d3f3eca /snaps/openstack/tests/create_instance_tests.py | |
| parent | fdcd5600bade294ae2a2207ef01da92f22f64327 (diff) | |
Ensure library and tests close all necessary resources.
The SNAPS-OO library and tests had left open files, ssh, and scp
connections. These have all now been wrapped with try/finally
blocks.
JIRA: SNAPS-152
Change-Id: I43e09978b5c075bd78ff3279c0799556b8758878
Signed-off-by: spisarski <s.pisarski@cablelabs.com>
Diffstat (limited to 'snaps/openstack/tests/create_instance_tests.py')
| -rw-r--r-- | snaps/openstack/tests/create_instance_tests.py | 5 |
1 files changed, 4 insertions, 1 deletions
diff --git a/snaps/openstack/tests/create_instance_tests.py b/snaps/openstack/tests/create_instance_tests.py index 75b0ed3..1922146 100644 --- a/snaps/openstack/tests/create_instance_tests.py +++ b/snaps/openstack/tests/create_instance_tests.py @@ -1717,7 +1717,10 @@ def validate_ssh_client(instance_creator): if ssh_active: ssh_client = instance_creator.ssh_client() if ssh_client: - out = ssh_client.exec_command('pwd')[1] + try: + out = ssh_client.exec_command('pwd')[1] + finally: + ssh_client.close() else: return False |