diff options
| author |   spisarski <s.pisarski@cablelabs.com> | 2017-07-26 15:12:16 -0600 |
|---|---|---|
| committer | spisarski <s.pisarski@cablelabs.com> | 2017-07-26 15:12:16 -0600 |
| commit | cd6bc05b6e1998993cc646004eae53f2e6c4e4f4 (patch) | |
| tree | cdeaaf146715ba08ce51a0c77ac96dad8621ea7e /snaps/domain | |
| parent | 1b28433d121e6fd31a0524995595f6f269cfd420 (diff) | |
Expand OpenStackSecurityGroup class tests.
Improved validation and added another test case.
JIRA: SNAPS-148
Change-Id: I249ac0fcce502dd91c82cc2bfb54ca22da5e33bb
Signed-off-by: spisarski <s.pisarski@cablelabs.com>
Diffstat (limited to 'snaps/domain')
| -rw-r--r-- | snaps/domain/network.py | 1 | ||||
| -rw-r--r-- | snaps/domain/test/network_tests.py | 10 |
2 files changed, 8 insertions, 3 deletions
diff --git a/snaps/domain/network.py b/snaps/domain/network.py index 68889f1..2c71db8 100644 --- a/snaps/domain/network.py +++ b/snaps/domain/network.py @@ -130,6 +130,7 @@ class SecurityGroup: """ self.name = kwargs.get('name') self.id = kwargs.get('id') + self.description = kwargs.get('description') self.project_id = kwargs.get('project_id', kwargs.get('tenant_id')) def __eq__(self, other): diff --git a/snaps/domain/test/network_tests.py b/snaps/domain/test/network_tests.py index 592090b..4fd20d4 100644 --- a/snaps/domain/test/network_tests.py +++ b/snaps/domain/test/network_tests.py @@ -133,10 +133,11 @@ class SecurityGroupDomainObjectTests(unittest.TestCase): def test_construction_proj_id_kwargs(self): sec_grp = SecurityGroup( - **{'name': 'name', 'id': 'id', - 'project_id': 'foo'}) + **{'name': 'name', 'id': 'id', 'project_id': 'foo', + 'description': 'test desc'}) self.assertEqual('name', sec_grp.name) self.assertEqual('id', sec_grp.id) + self.assertEqual('test desc', sec_grp.description) self.assertEqual('foo', sec_grp.project_id) def test_construction_tenant_id_kwargs(self): @@ -146,11 +147,14 @@ class SecurityGroupDomainObjectTests(unittest.TestCase): self.assertEqual('name', sec_grp.name) self.assertEqual('id', sec_grp.id) self.assertEqual('foo', sec_grp.project_id) + self.assertIsNone(sec_grp.description) def test_construction_named(self): - sec_grp = SecurityGroup(tenant_id='foo', id='id', name='name') + sec_grp = SecurityGroup(description='test desc', tenant_id='foo', + id='id', name='name') self.assertEqual('name', sec_grp.name) self.assertEqual('id', sec_grp.id) + self.assertEqual('test desc', sec_grp.description) self.assertEqual('foo', sec_grp.project_id) |