diff options
| author |   spisarski <s.pisarski@cablelabs.com> | 2017-07-28 13:48:06 -0600 |
|---|---|---|
| committer | spisarski <s.pisarski@cablelabs.com> | 2017-07-28 13:48:06 -0600 |
| commit | 9faae5becd270c6f98bff1079754dac2ee2fb76d (patch) | |
| tree | 81ec465e2dd2fae8f11f888e94432a058990551c | |
| parent | ca276f452540f68c08cb3df9049e9e7876364dac (diff) | |
Remove TODOs from create_router.py
Determined not to support the optional router attributes:
'enable_snat' & 'external_fixed_ips' at this time.
JIRA: SNAPS-150
Change-Id: I68445fb055668f4cb5f2a2ff80499da0f4160043
Signed-off-by: spisarski <s.pisarski@cablelabs.com>
| -rw-r--r-- | snaps/openstack/create_router.py | 6 |
1 files changed, 2 insertions, 4 deletions
diff --git a/snaps/openstack/create_router.py b/snaps/openstack/create_router.py index acf6602..335be2c 100644 --- a/snaps/openstack/create_router.py +++ b/snaps/openstack/create_router.py @@ -81,8 +81,9 @@ class OpenStackRouter: self.__internal_subnets.append(internal_subnet) if internal_subnet and not cleanup and not existing: logger.debug('Adding router to subnet...') - self.__internal_router_interface = neutron_utils.add_interface_router( + router_intf = neutron_utils.add_interface_router( self.__neutron, self.__router, subnet=internal_subnet) + self.__internal_router_interface = router_intf else: raise RouterCreationError( 'Subnet not found with name ' + internal_subnet_name) @@ -262,9 +263,6 @@ class RouterSettings: 'Could not find the external network named - ' + self.external_gateway) - # TODO: Enable SNAT option for Router - # TODO: Add external_fixed_ips Tests - return {'router': out} |