summaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorspisarski <s.pisarski@cablelabs.com>2017-07-21 08:08:30 -0600
committerspisarski <s.pisarski@cablelabs.com>2017-07-21 08:08:30 -0600
commit7c3bbf62df8553475b787ffd234cd3df3fa0c90b (patch)
tree49998ce00b494461786cd06eee271e9c411d71d0
parentb0af6e93bb5cc338c289577aad5c4b1bf8de7053 (diff)
Created new class ProjectSettingsError.
Raising ProjectSettingsError in ProjectSettings instead of Exception. JIRA: SNAPS-135 Change-Id: I5169dd196775453466ea8d7fe9fa0c8d82b2382a Signed-off-by: spisarski <s.pisarski@cablelabs.com>
-rw-r--r--snaps/openstack/create_project.py8
-rw-r--r--snaps/openstack/tests/create_project_tests.py7
2 files changed, 11 insertions, 4 deletions
diff --git a/snaps/openstack/create_project.py b/snaps/openstack/create_project.py
index 0384ccc..a20033e 100644
--- a/snaps/openstack/create_project.py
+++ b/snaps/openstack/create_project.py
@@ -131,5 +131,11 @@ class ProjectSettings:
self.enabled = True
if not self.name:
- raise Exception(
+ raise ProjectSettingsError(
"The attribute name is required for ProjectSettings")
+
+
+class ProjectSettingsError(Exception):
+ """
+ Exception to be thrown when project settings attributes are incorrect
+ """
diff --git a/snaps/openstack/tests/create_project_tests.py b/snaps/openstack/tests/create_project_tests.py
index 3c6b2d1..f2af0d9 100644
--- a/snaps/openstack/tests/create_project_tests.py
+++ b/snaps/openstack/tests/create_project_tests.py
@@ -15,7 +15,8 @@
import unittest
import uuid
-from snaps.openstack.create_project import OpenStackProject, ProjectSettings
+from snaps.openstack.create_project import (
+ OpenStackProject, ProjectSettings, ProjectSettingsError)
from snaps.openstack.create_security_group import OpenStackSecurityGroup
from snaps.openstack.create_security_group import SecurityGroupSettings
from snaps.openstack.create_user import OpenStackUser
@@ -32,11 +33,11 @@ class ProjectSettingsUnitTests(unittest.TestCase):
"""
def test_no_params(self):
- with self.assertRaises(Exception):
+ with self.assertRaises(ProjectSettingsError):
ProjectSettings()
def test_empty_config(self):
- with self.assertRaises(Exception):
+ with self.assertRaises(ProjectSettingsError):
ProjectSettings(**dict())
def test_name_only(self):