aboutsummaryrefslogtreecommitdiffstats
AgeCommit message (Collapse)AuthorFilesLines
2018-08-29Bug fix: Bad usage of positional argumentManuel Buil1-2/+2
av_zone is passed as a positional argument, however, the create_instance method does not define av_zone as positional: https://github.com/opnfv/sfc/blob/master/sfc/lib/openstack_utils.py#L136-L137 so we should not pass it as a positional argument Change-Id: I035012ef3ffce3318e0bece712cb6bdad8e8cdd0 Signed-off-by: Manuel Buil <mbuil@suse.com>
2018-08-29Flake8 fixesManuel Buil3-14/+3
When running flake8 I am getting several errors. This patch fixes them Change-Id: I4d32b4b214ca61e98da6fc28a4de44201c4c1cdc Signed-off-by: Manuel Buil <mbuil@suse.com>
2018-08-29Change the test result comparison in 'test_odl_utils.py' #L103Venkata Harshavardhan Reddy Allu1-1/+1
When 'get_active_rsps_on_ports' is executed, it returns a list of unordered dictionaries, sorting the result to verify the return value would fix the test assertion. Change-Id: Id39dc8d15f9efb0ef76168f823d7d52333474e16 Signed-off-by: Venkata Harshavardhan Reddy Allu <venkataharshavardhan_ven@srmuniv.edu.in>
2018-08-22Added unit tests for 'odl_utils.py' moduleVenkata Harshavardhan Reddy Allu1-0/+775
JIRA: SFC-123 Change-Id: I49b8dae157816ef04a45dea188cc7dbe3aa72d4a Signed-off-by: Venkata Harshavardhan Reddy Allu <venkataharshavardhan_ven@srmuniv.edu.in>
2018-08-13Added unit tests for 'openstack_utils.py' moduleVenkata Harshavardhan Reddy Allu1-0/+1715
JIRA: SFC-123 Change-Id: Ia41ec596d1c2247b2c86d88672a07e50021b3bc0 Signed-off-by: Venkata Harshavardhan Reddy Allu <venkataharshavardhan_ven@srmuniv.edu.in>
2018-08-08Fix UnboundLocalError in 'odl_utils.py'#L420Venkata Harshavardhan Reddy Allu1-0/+1
When an exception is raised from find_compute in #L411, the compute variable is not created and it raises an error < UnboundLocalError: local variable 'compute' referenced before assignment > at #L420. Change-Id: I48cff435dc3a03b30b7a8d24aa605611e30938de Signed-off-by: Venkata Harshavardhan Reddy Allu <venkataharshavardhan_ven@srmuniv.edu.in>
2018-08-05formatting the log message in odl_utils.py #413Venkata Harshavardhan Reddy Allu1-1/+1
Change-Id: I32f826fbb2c0a339264b8b316666ddf7f241570c Signed-off-by: Venkata Harshavardhan Reddy Allu <venkataharshavardhan_ven@srmuniv.edu.in>
2018-07-19Added parentheses in 'openstack_utils.py' line#476Venkata Harshavardhan Reddy Allu1-1/+1
Parentheses were added around the arguments in line#476 for proper formatting the Exception message in line#475 Change-Id: I3b2233aea10ff5afd23da00a837b976456274a51 Signed-off-by: Venkata Harshavardhan Reddy Allu <venkataharshavardhan_ven@srmuniv.edu.in>
2018-07-02Merge "Fix Update README.tests"Dimitrios Markou1-8/+29
2018-06-28Merge "Added unit tests for 'test_utils.py' module"Manuel Buil1-0/+528
2018-06-28Fix Update README.testsspiritus721-8/+29
When looking at the different testcases in the functest directory TEST SYMMETRIC is outdated and TEST DELETION is missing in the README. This patch is an update to README.tests for the latest changes that have been done the to those two testcases. Change-Id: I54fceac85f45212ed45efca1a6f30d4ba092e0c1 Signed-off-by: spiritus72 <billmorrissonjr@gmail.com>
2018-06-27Update release notes for Fraser 6.2Manuel Buil1-3/+3
Change-Id: I0d56aa4d5f494a25db92e61415a24b4257c71a04 Signed-off-by: Manuel Buil <mbuil@suse.com>
2018-06-27Added unit tests for 'test_utils.py' moduleVenkata Harshavardhan Reddy Allu1-0/+528
Jira: SFC-123 Change-Id: Ib8e3e748f3992d9030db1308a728a2576e7957ed Signed-off-by: Venkata Harshavardhan Reddy Allu <venkataharshavardhan_ven@srmuniv.edu.in>
2018-06-26Merge "Move the yamllint check to tox"Manuel Buil2-1/+10
2018-06-25Remove side_effect method in 'test_cleanup.py' moduleVenkata Harshavardhan Reddy Allu1-2/+0
The side_effect method under test_delete_openstack_objects_exception method in 'test_cleanup.py' module is not needed. In fact, it won't be called at all. It should have been detected in [pylint] W0612. So when we run the nosetest, side_effect from Mock instances of mock_creator_obj_one and mock_creator_obj_two were called. Change-Id: Ibad6c8ebe14c320ef31c2133635ecd45fd011835 Signed-off-by: Venkata Harshavardhan Reddy Allu <venkataharshavardhan_ven@srmuniv.edu.in>
2018-06-21Move the yamllint check to toxDimitrios Markou2-1/+10
Until now we were executing the yamllint check through shell commands contained to a builder in the releng repo [0]. This patch moves that check to the tox framework. Additional changes should be done to the sfc jobs in the releng repo. [0]: https://github.com/opnfv/releng/blob/master/jjb/sfc/sfc-project-jobs.yaml#L73 Change-Id: Ie42113087a8c1494593d5510cdf367abe99a7f5b Signed-off-by: Dimitrios Markou <mardim@intracom-telecom.com>
2018-06-21Create unit tests for 'cleanup.py' moduleDimitrios Markou7-1/+394
This is the first attempt to add unit testing capabilities to OPNFV/SFC project. Also we are following the contraints.txt logic which helps in the direction of simulating a test env which will be as much as close to the real env that the SFC testcases are running. Jira: SFC-127 Jira: SFC-129 Change-Id: I938d28f9f85614cdefa163949c4ec9f06f5d27b4 Signed-off-by: Dimitrios Markou <mardim@intracom-telecom.com>
2018-06-18[Bug fix] Fix broken urlsDimitrios Markou3-4/+4
Change-Id: Ide4d6f8a2a54f70522a01a7467bddcd69daf8531 Signed-off-by: Dimitrios Markou <mardim@intracom-telecom.com>
2018-06-15Fix "Remove the annoying WARNINGS when using XCI"Bill Morrisson5-1/+25
When executing the SFC tests in XCI, we constantly get a whole bunch of annoying "InsecureRequestWarning" messages which does not allow to follow what is going on in the test. This patch filters all those errors leaving the output of the functest results clean. Change-Id: I3bd9519676222d00ee4a2c8d47084737cd9768aa Signed-off-by: Bill Morrisson <billmorrissonjr@gmail.com>
2018-06-12Bug fix: pass variables in the class constructorManuel Buil1-2/+2
The Testcase class requires parameters in the constructor. We should pass them or otherwise we get an error: https://github.com/opnfv/functest-xtesting/blob/master/xtesting/core/testcase.py#L48 ERROR: TypeError: "__init__() got an unexpected keyword argument 'project_name'" Change-Id: I6f4b62b7ff201bf6878004e3fb452778c6b55f0e Signed-off-by: Manuel Buil <mbuil@suse.com>
2018-06-12Remove the pike specific filesManuel Buil10-315/+21
We are already preparing for Gambia release and that means Openstack Queens for the traditional release track. Therefore, we can remove the specific configs for Openstack Pike Change-Id: Ib49a53e73ae1020aaead8a897dff8733147d87ac Signed-off-by: Manuel Buil <mbuil@suse.com>
2018-06-12Rethink the clean up processPanagiotis Karalis6-18/+58
Using the '--nocleanup' parameter as part of command, the cleanup mechanism could be disable. Otherwise, the cleanup method is executed even if a exception has been raised. Change-Id: I9638369900f599793393feb5184c30b74f1b7c7e Signed-off-by: Panagiotis Karalis <pkaralis@intracom-telecom.com>
2018-06-12Merge "Enable local documentation builds"Dimitrios Markou8-0/+77
2018-06-07Provide support for VNFsManuel Buil3-0/+26
Currently it is not possible to define different images for client/server and VNFs. This functionality is important to have in order to test different VNFs Change-Id: Ibc3b3f1102d52529701748d37f795cdf05269410 Signed-off-by: Manuel Buil <mbuil@suse.com>
2018-06-06Enable local documentation buildsTrevor Bramwell8-0/+77
Adds a local conf.py and conf.yaml (using lfdocs-conf), to enable local docs build. Change-Id: Iaab750983f02476d9bccb6c9bcf2b38544d54d8c Signed-off-by: Trevor Bramwell <tbramwell@linuxfoundation.org>
2018-06-04Provide support for local imagesManuel Buil1-2/+13
There might be cases where we want to test local images and the image location in config.yml is locally Change-Id: I29f115de5c80db187ecc2b260c386b377fafd6d2 Signed-off-by: Manuel Buil <mbuil@suse.com>
2018-06-01Fix the logging to be compatible with functestPanagiotis Karalis13-38/+38
In order to collect logs from SFC test scenarios running through functest framework (mainly for troubleshooting purposes), the logging mechanism has been updated accordingly. JIRA: SFC-125 Change-Id: Ide7c32519afa6ece299d0ac1dcb168609a2e3945 Signed-off-by: Panagiotis Karalis <pkaralis@intracom-telecom.com>
2018-05-23Update the release notesManuel Buil1-3/+3
Change-Id: I31506971cf57d761f966841029e3a878d2a0d284 Signed-off-by: Manuel Buil <mbuil@suse.com>
2018-05-22Fix symmetric test case result summaryJaime Caamaño Ruiz2-6/+10
Correctly print in test summary whether we are testing HTTP uplink or HTTP uplink. Change-Id: Ib8d4cc4a5e794384720d7023032c5340039e2ff1 Signed-off-by: Jaime Caamaño Ruiz <jcaamano@suse.com>
2018-05-21Merge "Revert "Add iteritems() when parsing dict in Python 2.x""Manuel Buil1-1/+1
2018-05-21Increase loggingManuel Buil1-0/+1
Apex deployments are currently failing and it could be because it uses the wrong config file. We are currently not logging what file it is fetched and that's what this patch tries to fix Change-Id: I441beee9d3ad5d918ed4b8dc0164456b39e53b56 Signed-off-by: Manuel Buil <mbuil@suse.com>
2018-05-21Improve logging and unify how to read from yamlManuel Buil1-4/+6
vnffgd and vnfd are being parsed in different ways, we should parse them in the same way. We could do it directly with safe_load, however, the returned object is not easy to read. If we use read() instead, the resturned object is easy to read/log. Therefore, this patch combines both options Change-Id: I3416933801569a6f57962cd9906726229923136d Signed-off-by: Manuel Buil <mbuil@suse.com>
2018-05-21Revert "Add iteritems() when parsing dict in Python 2.x"Manuel Buil1-1/+1
This reverts commit e29fe40e0c98d6c3b619de7f99f0a8fb9e4a9d7b. acl_types_names is not a dictionary but a list of tuples: (Pdb) pp acl_types_names [(u'ietf-access-control-list:ipv4-acl', u'04a5ce7c-6aac-4f26-b3f9-a19749d814f3'), (u'ietf-access-control-list:ipv4-acl', u'75737a58-c894-46d9-9319-8d2b4785b0f3'), (u'ietf-access-control-list:ipv4-acl', u'bb422318-c3a3-4356-a67c-f44e8874edf6')] (Pdb) type(acl_types_names) <type 'list'> (Pdb) type(acl_types_names[0]) <type 'tuple'> Therefore, this patch introduces an error Change-Id: I7f7e69fb1855c7915b2c17d80a5b7ea76aaa8694 Signed-off-by: Manuel Buil <mbuil@suse.com>
2018-05-18Merge "Clean up Test Case code"Manuel Buil7-1019/+870
2018-05-16Merge "Add iteritems() when parsing dict in Python 2.x"Brady Johnson1-1/+1
2018-05-15Clean up Test Case codePanagiotis Karalis7-1019/+870
Too much of duplicated code has been obeserved in test cases. With this patch a small refactoring is necessery to our test cases code. So they can be more generic and more flexible. To achieve that the addition of new parent class is essential, hence all the rest test case classes will inherit from the aforementioned parent class. Change-Id: I6a50d8330a06321742b3bb03cc999682d4a4e6a1 Signed-off-by: Panagiotis Karalis <pkaralis@intracom-telecom.com>
2018-05-14Add latest_release as default6.0.1Manuel Buil1-1/+1
If nothing is specified, let's deploy with the latest release which we know works correctly Change-Id: Ia38e4b5e5c32b886dfdd5ab76654241b495d6863 Signed-off-by: Manuel Buil <mbuil@suse.com>
2018-05-10Merge "Lookup ODL_VERSION variable"Manuel Buil2-0/+7
2018-05-09Add iteritems() when parsing dict in Python 2.xDimitrios Markou1-1/+1
The SFC code still runs with Python 2.x version and that means that when a dictionary is getting parsed it should use the iteritems() function. Change-Id: I44f1c9cb916e7b76b277e376c8f524a99aa01f26 Signed-off-by: Dimitrios Markou <mardim@intracom-telecom.com>
2018-05-09Add more logs to the codeManuel Buil5-6/+16
It is hard to understand what is going on in the SFC executions Change-Id: I5c9688e68b03c59d6d39290faee8683513a60440 Signed-off-by: Manuel Buil <mbuil@suse.com>
2018-05-08Lookup ODL_VERSION variableManuel Buil2-0/+7
We require that variable to select different ODL versions Change-Id: I37aca357a7a5e0772529dac70ec8ee81b52f3cf8 Signed-off-by: Manuel Buil <mbuil@suse.com>
2018-05-03Bug fix: Use opnfv.logger objectManuel Buil12-59/+39
JIRA: SFC-125 If we don't use the opnfv.logger from functest, logs are not printed when exeucting tests through the functest framework Change-Id: I6d58ff3977fd94221720eea978e0efde07a576a2 Signed-off-by: Manuel Buil <mbuil@suse.com>
2018-05-02Fix version in setup.cfgCédric Ollivier1-1/+0
Selecting another tag than the official ones (opnfv-xxx) breaks all Functest builds because pbr requirements are unmet [1]. [1] https://build.opnfv.org/ci/job/functest-features-docker-build-amd64-master/219/console Change-Id: I8a6a603c9f4e976c8bcdcce865850b46f6e69453 Signed-off-by: Cédric Ollivier <cedric.ollivier@orange.com>
2018-04-25Update docs for FraserManuel Buil7-247/+61
Change-Id: Ie53eb812c9111a2f75342470b10ef3376e43b5fb Signed-off-by: Manuel Buil <mbuil@suse.com>
2018-04-18Track the indirectly created security groupsManuel Buil2-1/+18
networking-odl creates a security group when creating a router. This security group is not tracked by SNAPs and thus it never gets removed when running the clean up. We need this workaround until the following bug is fixed: https://bugs.launchpad.net/networking-odl/+bug/1763705 Change-Id: I15b939609e815f24ef0c1dcc0aeb9f4471f351f0 Signed-off-by: Manuel Buil <mbuil@suse.com>
2018-04-16Merge "Provide support for different ODL versions"Dimitrios Markou7-4/+40
2018-04-13Fix symmetric testcase configManuel Buil2-4/+4
One patch was merged without rebasing and it reverted some accepted changes Change-Id: Ia64cef60df1ceb72d8789d122cf1bbb820819aa2 Signed-off-by: Manuel Buil <mbuil@suse.com>
2018-04-13Merge "Updated from global requirements"Manuel Buil1-3/+3
2018-04-12Changing README6.0.0Manuel Buil1-55/+4
Change-Id: Ia2112794ef542ff91af1a547d814a0f0c737dd54 Signed-off-by: Manuel Buil <mbuil@suse.com>
2018-04-12Provide support for different ODL versionsManuel Buil7-4/+40
We should be able to deploy with different ODL versions if the user defines the ODL_VERSION variable when deploying XCI. Change-Id: Ied20959116fed19bf4445f1544883ed0dc579dfb Signed-off-by: Manuel Buil <mbuil@suse.com>