diff options
| author |   Markos Chandras <mchandras@suse.de> | 2018-03-26 10:23:13 +0100 |
|---|---|---|
| committer | Markos Chandras <mchandras@suse.de> | 2018-03-26 20:47:17 +0100 |
| commit | 9e1d3d6e62abf5d0da26a296bcd235f37a54d9c6 (patch) | |
| tree | fc2fb9d8056786b4543379977fb8e72de3f2125b /xci/playbooks/roles/prepare-functest/tasks/main.yml | |
| parent | 8f3c33c97acc5fc10a83e7cc7635da67e2460769 (diff) | |
xci: playbooks: Fixes various ansible-lint warnings
In preparation for adding support for the 'ansible-lint' tool we fix
various problems in our playbooks to make the tool happy before we make
it mandatory.
Some of the problems that are fixed here are
- [ANSIBLE0011] All tasks should be named
- [ANSIBLE0012] Commands should not change things if nothing needs doing
- [ANSIBLE0013] Use shell only when shell functionality is required
- [ANSIBLE0010] Package installs should not use latest
installer-type:osa
deploy-scenario:os-nosdn-nofeature
Change-Id: I66c759d3932a414b81b2846393d2d98ce80c0b6d
Signed-off-by: Markos Chandras <mchandras@suse.de>
Diffstat (limited to 'xci/playbooks/roles/prepare-functest/tasks/main.yml')
| -rw-r--r-- | xci/playbooks/roles/prepare-functest/tasks/main.yml | 2 |
1 files changed, 2 insertions, 0 deletions
diff --git a/xci/playbooks/roles/prepare-functest/tasks/main.yml b/xci/playbooks/roles/prepare-functest/tasks/main.yml index 2797ce43..ad578bfd 100644 --- a/xci/playbooks/roles/prepare-functest/tasks/main.yml +++ b/xci/playbooks/roles/prepare-functest/tasks/main.yml @@ -30,9 +30,11 @@ shell: "ip a | grep {{ gateway_ip }}" register: gateway_ip_result ignore_errors: True + changed_when: False - name: add public network gateway command: "ip addr add {{ gateway_ip_mask }} brd {{ broadcast_ip }} dev {{ gateway_interface }}" + changed_when: False when: gateway_ip_result|failed - name: prepare environment file for functest |