diff options
| author |   Yujun Zhang <zhang.yujunz@zte.com.cn> | 2016-12-07 16:25:18 +0800 |
|---|---|---|
| committer | Yujun Zhang <zhang.yujunz@zte.com.cn> | 2016-12-07 16:25:18 +0800 |
| commit | 1ff65ed841b3f848ebf44ea8e3bd608220150ebf (patch) | |
| tree | 601fdd0e7c6caca156aa91409dd7e12cd36cbcc9 | |
| parent | 1ce534f64402fd7b2fd85328dda12af9b2ba0c18 (diff) | |
Fix bugs in `runner/benchmark`
- should inherit `object` for common methods
- should use instance class in abstract method
Change-Id: I78c08476da544402851e4b53e2d45c32a7f86722
Signed-off-by: Yujun Zhang <zhang.yujunz@zte.com.cn>
| -rw-r--r-- | qtip/runner/benchmark.py | 4 | ||||
| -rw-r--r-- | tests/unit/runner/perftest_test.py | 1 | ||||
| -rw-r--r-- | tests/unit/runner/suite_test.py | 1 | ||||
| -rw-r--r-- | tests/unit/runner/testplan_test.py | 1 |
4 files changed, 5 insertions, 2 deletions
diff --git a/qtip/runner/benchmark.py b/qtip/runner/benchmark.py index 56b5b30e..58e5a8d9 100644 --- a/qtip/runner/benchmark.py +++ b/qtip/runner/benchmark.py @@ -18,7 +18,7 @@ class Property: ABSPATH = 'abspath' -class Benchmark: +class Benchmark(object): """Abstract class of QTIP benchmarks""" _paths = [path.join(path.dirname(__file__), path.pardir, path.pardir, @@ -40,7 +40,7 @@ class Benchmark: def list_all(cls): """list all available benchmarks""" names = chain.from_iterable([listdir(p) for p in cls._paths]) - return [Benchmark(name).describe() for name in names] + return [cls(name).describe() for name in names] def describe(self): """description of benchmark""" diff --git a/tests/unit/runner/perftest_test.py b/tests/unit/runner/perftest_test.py index b3e6e8e2..1f0b5631 100644 --- a/tests/unit/runner/perftest_test.py +++ b/tests/unit/runner/perftest_test.py @@ -39,3 +39,4 @@ class TestPerfTest: assert Property.NAME in desc assert Property.DESCRIPTION in desc assert Property.ABSPATH in desc + assert Property.ABSPATH is not None diff --git a/tests/unit/runner/suite_test.py b/tests/unit/runner/suite_test.py index 5d2f1066..10205801 100644 --- a/tests/unit/runner/suite_test.py +++ b/tests/unit/runner/suite_test.py @@ -39,3 +39,4 @@ class TestSuite: assert Property.NAME in suite_desc assert Property.DESCRIPTION in suite_desc assert Property.ABSPATH in suite_desc + assert Property.ABSPATH is not None diff --git a/tests/unit/runner/testplan_test.py b/tests/unit/runner/testplan_test.py index 2700d385..de8bf1e1 100644 --- a/tests/unit/runner/testplan_test.py +++ b/tests/unit/runner/testplan_test.py @@ -39,3 +39,4 @@ class TestTestPlan: assert Property.NAME in desc assert Property.DESCRIPTION in desc assert Property.ABSPATH in desc + assert Property.ABSPATH is not None |