diff options
| author |   Yujun Zhang <zhang.yujunz@zte.com.cn> | 2017-01-09 16:49:06 +0800 |
|---|---|---|
| committer | Yujun Zhang <zhang.yujunz@zte.com.cn> | 2017-01-09 16:51:57 +0800 |
| commit | 5c58e73fb903be6cf6ee17d0b572757e4be6ea2b (patch) | |
| tree | f4c3221b5b16564bbb66410f40fa2be5bdcfcce4 | |
| parent | 2a3a0aec933566bc676ad259ca51e6eaa1f8ab76 (diff) | |
Add proposal of Fast Track review rule
Change-Id: Ia0a95a5ee16547870eef49905db8adfd3b342ae0
Signed-off-by: Yujun Zhang <zhang.yujunz@zte.com.cn>
| -rw-r--r-- | CONTRIBUTING.md | 21 |
1 files changed, 16 insertions, 5 deletions
diff --git a/CONTRIBUTING.md b/CONTRIBUTING.md index 93c8bc9d..ad693d36 100644 --- a/CONTRIBUTING.md +++ b/CONTRIBUTING.md @@ -13,13 +13,24 @@ Peer review is the most important communication channel between developers. Every subtle change to the code or document **MUST** be reviewed before submission. -Add group `qtip-reviewers` in [gerrit][gr] when you consider a patch set is ready. +Add group `qtip-reviewers` in [gerrit][gr] when you consider a patch set is +ready. -Please make sure there is at least one `+1` or `+2` from others before -submitting a patch set. -Note: only members in `ldap/opnfv-gerrit-qtip-submitters` have permission -to submit. The current members are listed in [INFO][if]. +Rule for Submit +--------------- + +Only members in `ldap/opnfv-gerrit-qtip-submitters`, i.e. committers have +permission to submit. The current committers are listed in [INFO][if]. + +Before submitting a patch set, please make sure one of the following criteria is +met: + +* **Normal**: at least one `+2` from others +* **Fast Track**: no objection from other committers for one or more working day + +NOTE: we introduce **fast track** because currently there are not enough active +committers reviewing the patch sets. Active Reviewers ---------------- |