summaryrefslogtreecommitdiffstats
path: root/docs
AgeCommit message (Collapse)AuthorFilesLines
2017-09-11Update git submodulesAlexandru Avadanii1-0/+0
* Update docs/submodules/armband from branch 'master' - u/fuel: Bump & rebase for multiarch reclass Change-Id: I3de41645b7424195b9c8d5884a7c9de1fabf68cb Signed-off-by: Alexandru Avadanii <Alexandru.Avadanii@enea.com>
2017-09-11Update git submodulesAlexandru Avadanii1-0/+0
* Update docs/submodules/fuel from branch 'master' - salt master, maas: Move mcpcontrol to 10.20.0.0/24 Use INSTALLER_IP Jenkins param instead of SALT_MASTER_IP, allowing us to drop SALT_MASTER_IP completely from releng. mcpcontrol IP changes: - 192.168.10.100 becomes 10.20.0.2 (align with legacy Fuel master); - 192.168.10.3 becomes 10.20.0.3 (baremetal MaaS address); JIRA: FUEL-285 Change-Id: I6e2d44c3a8b43846196bd64191735214167a76ce Signed-off-by: Alexandru Avadanii <Alexandru.Avadanii@enea.com>
2017-09-11Update git submodulesAric Gardner1-0/+0
* Update docs/submodules/releng from branch 'master' - Merge "fuel, armband: Remove SALT_MASTER_IP param" - fuel, armband: Remove SALT_MASTER_IP param Fuel@OPNFV mcpcontrol network (equiv to old admin/PXE net) has been configured to use 192.168.10.0/24 during E release cycle. However, due to overlapping with Ericsson-pod1 networks, we decided to re-use the old CIDR Fuel used before E release (10.20.0.0/24). This allows reusing the INSTALLER_IP param instead of recently added SALT_MASTER_IP param. Current change refactors all usage of SALT_MASTER_IP in favor of old INSTALLER_IP, thus reducing complexity and providing a familiar env to leagcy Fuel users. JIRA: FUEL-285 Change-Id: I1e89cca08ce4cb9bf3a82a06043c91ee26aa0794 Signed-off-by: Alexandru Avadanii <Alexandru.Avadanii@enea.com>
2017-09-11Update git submodulesAric Gardner1-0/+0
* Update docs/submodules/releng from branch 'master' - Merge "Fix Yamllint Violations for jjb/bottlenecks" - Fix Yamllint Violations for jjb/bottlenecks JIRA: RELENG-254 Change-Id: I56e1b6e776cac44afc17cf73db09cf8220d1b5f0 Signed-off-by: Trevor Bramwell <tbramwell@linuxfoundation.org>
2017-09-11Update git submodulesAric Gardner1-0/+0
* Update docs/submodules/releng from branch 'master' - Merge "Fix Yamllint Violations for jjb/ovn4nfv" - Fix Yamllint Violations for jjb/ovn4nfv JIRA: RELENG-254 Change-Id: If3c2d8b469c97997a3fdcbcaf4750acb61c82d75 Signed-off-by: Trevor Bramwell <tbramwell@linuxfoundation.org>
2017-09-11Update git submodulesAric Gardner1-0/+0
* Update docs/submodules/releng from branch 'master' - Merge "Fix Yamllint Violations for jjb/nfvbench" - Fix Yamllint Violations for jjb/nfvbench JIRA: RELENG-254 Change-Id: Ibfda27a637ee448862ae2df5884b88093210ed4d Signed-off-by: Trevor Bramwell <tbramwell@linuxfoundation.org>
2017-09-11Update git submodulesAric Gardner1-0/+0
* Update docs/submodules/releng from branch 'master' - Merge "Fix Yamllint Violations for jjb/orchestra" - Fix Yamllint Violations for jjb/orchestra JIRA: RELENG-254 Change-Id: I9a68c230464bb60087e8a909a2d59021f3acd272 Signed-off-by: Trevor Bramwell <tbramwell@linuxfoundation.org>
2017-09-11Update git submodulesAric Gardner1-0/+0
* Update docs/submodules/releng from branch 'master' - Merge "Fix Yamllint Violations for jjb/opnfvdocs" - Fix Yamllint Violations for jjb/opnfvdocs JIRA: RELENG-254 Change-Id: I0e168d0ce619df20480f6da92cdfa470dca713b1 Signed-off-by: Trevor Bramwell <tbramwell@linuxfoundation.org>
2017-09-11Update git submodulesAric Gardner1-0/+0
* Update docs/submodules/releng from branch 'master' - Merge "Fix Yamllint Violations for jjb/opera" - Fix Yamllint Violations for jjb/opera JIRA: RELENG-254 Change-Id: I73fa2c56f7adf2a5dabcc9c0fd9db85c2cfa82a0 Signed-off-by: Trevor Bramwell <tbramwell@linuxfoundation.org>
2017-09-11Update git submodulesAric Gardner1-0/+0
* Update docs/submodules/releng from branch 'master' - Merge "Fix Yamllint Violations for jjb/3rd_party_ci" - Fix Yamllint Violations for jjb/3rd_party_ci JIRA: RELENG-254 Change-Id: I118b0dc0bb58919bc7d25f5d6a8247731e58c409 Signed-off-by: Trevor Bramwell <tbramwell@linuxfoundation.org>
2017-09-11Update git submodulesAric Gardner1-0/+0
* Update docs/submodules/releng from branch 'master' - Merge "Fix Yamllint Violations for jjb/cperf" - Fix Yamllint Violations for jjb/cperf JIRA: RELENG-254 Change-Id: I8c644ac0bce05f66b1b878e39a00342c857d23f0 Signed-off-by: Trevor Bramwell <tbramwell@linuxfoundation.org>
2017-09-11Update git submodulesAric Gardner1-0/+0
* Update docs/submodules/releng from branch 'master' - Merge "Fix Yamllint Violations for jjb/ci_gate_security" - Fix Yamllint Violations for jjb/ci_gate_security JIRA: RELENG-254 Change-Id: If4bfdc2ddaadb4e17d0bc0dc2948780bcbbb10ae Signed-off-by: Trevor Bramwell <tbramwell@linuxfoundation.org>
2017-09-11Update git submodulesAric Gardner1-0/+0
* Update docs/submodules/releng from branch 'master' - Merge "Fix Yamllint Violations for jjb/joid" - Fix Yamllint Violations for jjb/joid JIRA: RELENG-254 Change-Id: Ib7a7db3dc0d463bae6fc159a7c0ade7be51f4e1b Signed-off-by: Trevor Bramwell <tbramwell@linuxfoundation.org>
2017-09-11Update git submodulesMarkos Chandras1-0/+0
* Update docs/submodules/releng from branch 'master' - Merge "Disable functest for xci until xci is ready" - Disable functest for xci until xci is ready The external network, docker installation and other parts need to be fixed in OPNFV host before functest can be enabled. Change-Id: I42a3adf2e36f91e6425d49e2578003b52ca4f101 Signed-off-by: Fatih Degirmenci <fatih.degirmenci@ericsson.com>
2017-09-11Add releng-xci as a submoduleagardner1-0/+0
Change-Id: I70f8a66404be63c595df5c7026cfe4806b079315 Signed-off-by: agardner <agardner@linuxfoundation.org>
2017-09-11Update git submodulesTrevor Bramwell1-0/+0
* Update docs/submodules/releng from branch 'master' - Fix Yamllint Violations for jjb/barometer JIRA: RELENG-254 Change-Id: Iab88e0adffb84b5eead7991035dc064b6017b5b5 Signed-off-by: Trevor Bramwell <tbramwell@linuxfoundation.org>
2017-09-11Update git submodulesAlexandru Avadanii1-0/+0
* Update docs/submodules/fuel from branch 'master' - Merge changes from topic 'multiarch-image-defaults' * changes: reclass: virtual: Factor out VM interface naming reclass: Multiarch support for arch specific param - reclass: virtual: Factor out VM interface naming Define two groups of VM interface naming: - ens3..ens6 - used by infra VMs, virtual node VMs; - ens2..ens3 - used by VCP VMs (spawned by salt.control); Parametrize newly defined interface names throughout the cluster models. While at it, add AArch64 default values for above iface names. NOTE: baremetal clusters will be parametrized later, after common config is factored out into <baremetal-mcp-ocata-common>. Change-Id: I89aba9aaf85b585cc510302eb76d7810fbf60679 Signed-off-by: Alexandru Avadanii <Alexandru.Avadanii@enea.com> - reclass: Multiarch support for arch specific param Introduce a simple mechanism that simulates an 'if-arch-then' cond for reclass models: - add new <all-mcp-ocata-common> class hierarchy; - at runtime (via <salt.sh>) make 'all-mcp-ocata-common.arch' point to 'all-mcp-ocata-common.$(uname -i)' dynamically; - inherit new 'arch' class in all cluster models; - factor out current x86_64 default for "salt_control_xenial_image"; - add AArch64 default for param "salt_control_xenial_image"; Change-Id: I3b239b28d0fd1cc2ced8579e2e93b764eb71ffc3 Signed-off-by: Alexandru Avadanii <Alexandru.Avadanii@enea.com>
2017-09-11Update git submodulesMark Beierl1-0/+0
* Update docs/submodules/storperf from branch 'master' - Merge "Creating intermediate page for the single-data-json files JIRA: STORPERF-163" - Creating intermediate page for the single-data-json files JIRA: STORPERF-163 Change-Id: I401073eed70b298ae0c2fa60b2548e4a38d96fbb Signed-off-by: saksham115 <saksham.agrawal@research.iiit.ac.in>
2017-09-11Update git submodulesCarlos Goncalves1-0/+0
* Update docs/submodules/doctor from branch 'master' - Merge "add python test indication" - add python test indication Change-Id: I2c56ce653e05727d13a26bf7bdd2595107a6ffba Signed-off-by: dongwenjuan <dong.wenjuan@zte.com.cn>
2017-09-11Update git submodulesjulien zhang1-0/+0
* Update docs/submodules/pharos from branch 'master' - Merge "Fix Booking API" - Fix Booking API This fixes a server error for the booking REST api and some html errors. Change-Id: I86475967bbc8cd4c8f82f62e03789f1c9752d446 Signed-off-by: maxbr <maxbr@mi.fu-berlin.de>
2017-09-11Update git submodulesTrevor Bramwell1-0/+0
* Update docs/submodules/releng from branch 'master' - Merge "Fix Expermental JJB Job Diff Commenting" - Fix Expermental JJB Job Diff Commenting This change fixes the following issues: 1) 'nounset' will cause the script to fail when activating a virtualenv since the activation of a virtualenv unsets variables 2) There are not artifacts available from releng-merge-jjb and copying them would save minimal time over re-running jjb Change-Id: Ifc4297947c8fe235987a507ead932841480165a7 Signed-off-by: Trevor Bramwell <tbramwell@linuxfoundation.org>
2017-09-11Update git submodulesManuel Buil1-0/+0
* Update docs/submodules/sfc from branch 'master' - Merge "Allign the SFC testcases to the new Tacker API" - Allign the SFC testcases to the new Tacker API In this patch [0] we adapt the Tacker library which is located to the SFC repo to the new Tacker API With the current patch we allign the testcases to the aforementioned API [0] https://gerrit.opnfv.org/gerrit/#/c/40839/ Change-Id: I07f8bcefbda7d058e9322465df38077ac0346d83 Signed-off-by: Dimitrios Markou <mardim@intracom-telecom.com>
2017-09-11Update git submodulesManuel Buil1-0/+0
* Update docs/submodules/sfc from branch 'master' - Merge "Adapt functionality to the new Tacker API" - Adapt functionality to the new Tacker API Change-Id: I078e9f26d3040cf04120abd425f03cb4f2e8daef Signed-off-by: Dimitrios Markou <mardim@intracom-telecom.com>
2017-09-11Update git submodulesAlexandru Avadanii1-0/+0
* Update docs/submodules/fuel from branch 'master' - README files: Convert from markdown to RST Change-Id: I176f583e8adb7ba717932de7c27283f696ded548 Signed-off-by: Alexandru Avadanii <Alexandru.Avadanii@enea.com>
2017-09-11Update git submodulesRyota Mibu1-0/+0
* Update docs/submodules/doctor from branch 'master' - Merge "Add host specific VM list to inspector design guide line" - Add host specific VM list to inspector design guide line JIRA: DOCTOR-73 Change-Id: I163b97ec87761538594034e926055646223af327 Signed-off-by: Yujun Zhang <zhang.yujunz@zte.com.cn>
2017-09-11Update git submodulesMark Beierl1-0/+0
* Update docs/submodules/storperf from branch 'master' - Merge "Changing Daily to Docker Pull" - Changing Daily to Docker Pull Changes the daily job to pull images from Docker.io instead of using docker-compose build to build the image from local sources. Reduces the default run time to ~30 minutes unless overridden in the job definition. Change-Id: Ib153b66454363f91813dc9c946f6b46156c502bd JIRA: STORPERF-204 Signed-off-by: mbeierl <mark.beierl@dell.com>
2017-09-11Update git submodulesShrenik1-0/+0
* Update docs/submodules/storperf from branch 'master' - Remove 8000 as exposed port from documentation After using http-frontend 8000 is no longer exposed. JIRA: STORPERF-207 Change-Id: I419d28ac36faa7a2231ff382c79feb5322ef9be0 Signed-off-by: Shrenik <shrenik.jain@research.iiit.ac.in>
2017-09-11Update git submodulesMorgan Richomme1-0/+0
* Update docs/submodules/releng from branch 'master' - Switch daily job to Alpine containers The following alpine containers will be launched one after the others: - healthcheck - smoke - features - vnf Old container is kept for suite (which could be refactored later) Jenkins exit condition (return_value) and push_test_logs to be checkeded. Regarding the return condition, I did not reapply the mechanism that returns false when one of the test suite is FAIL. This was misleading for lots of people as for them, red means functest is FAIL.The argument was, if functest jenkins status is blue, people believe that tests are PASS and do not consider the results, which may be FAIL, which may be also misleading... Due to the refactoring I think we can be more Functest Centric and consider that if we succeeded in running the test, our CI status shall be PASS (same behavior than other test projects..HA test FAIL in yardstick do not prevent blue status). Scenario owner must have a look at the reportign page to get more details. Functest PASS means that tests have been succesfully launched, so they know that there are available results To summarize previously Functest OK but 1 or more tests FAIL => red status in Jenkins currently Functest OK but 1 or more tests FAIL => blue status in Jenkins Regarding the push to artifacts, it should be transparent (volume) but the last log links listed on huawei-virtual5 are broken [1] [1]: https://build.opnfv.org/ci/view/functest/job/functest-alpine-compass-huawei-virtual5-daily-master/27/consoleFull Change-Id: I4ed036dda3daae3d46726e5946f9d04897bab9bb Signed-off-by: Morgan Richomme <morgan.richomme@orange.com>
2017-09-11Update git submodulesJuha Kosonen1-0/+0
* Update docs/submodules/functest from branch 'master' - Remove volume type handling Rally scenarios don't require volume type to exist as a precondition. Change-Id: Id735346e062af084635fd8f76f3686005b9b8add Signed-off-by: Juha Kosonen <juha.kosonen@nokia.com>
2017-09-11Update git submodulesMaryam Tahhan1-0/+0
* Update docs/submodules/barometer from branch 'master' - src: add pmu-tools to the src build Change-Id: Ia9e0cbf6793a6ce5be5253f65cabd0813ff1e968 Signed-off-by: Maryam Tahhan <maryam.tahhan@intel.com>
2017-09-11Update git submodulesAlexandru Avadanii1-0/+0
* Update docs/submodules/fuel from branch 'master' - Merge "Add & fix licensing in README.rst files, align ext" - Add & fix licensing in README.rst files, align ext Rename all variations of README files to README.rst. Fix license headers according to OPNFV Contribution Guidelines [1]. Markdown syntax will be switched to rst in an ulterior change. [1] https://wiki.opnfv.org/display/DEV/Contribution+Guidelines Change-Id: I2c71fd62b38f218545507c79c39e07dbd35f7c88 Signed-off-by: Alexandru Avadanii <Alexandru.Avadanii@enea.com>
2017-09-11Update git submodulesZhijiang Hu1-0/+0
* Update docs/submodules/daisy from branch 'master' - Add developer doc for deployment detail Change-Id: I03c283222060677f7ce7b5ddb0241db78e52b481 Signed-off-by: Zhijiang Hu <hu.zhijiang@zte.com.cn>
2017-09-11Update git submodulestomsou1-0/+0
* Update docs/submodules/sdnvpn from branch 'master' - Fix the config.yaml including for each testcase At each testcase, adapt the way config.yaml is included via sdnvpn.lib.config.TestcaseConfig(). The full path should be included, instead of just the testcase name JIRA: SDNVPN-180 Change-Id: I34828cc3681f08b843db49c6a221602b5b2022bf Signed-off-by: tomsou <soth@intracom-telecom.com>
2017-09-11Update git submodulesMorgan Richomme1-0/+0
* Update docs/submodules/releng from branch 'master' - Merge "Change nginx configuration" - Change nginx configuration Since landing page have changed from reporting2 to testing, the nginx configuration need some adoption. If the pre url change again, we need to config the base_url when start our docker container. For example: docker run -itd -p 8084:8000 -e SERVER_URL testresults.opnfv.org/xxx/api opnfv/reporting:latest Change-Id: If3c9f9af76fcfc8047b5b9559fcc8bd45740d4d2 Signed-off-by: chenjiankun <chenjiankun1@huawei.com>
2017-09-11Update git submodulesMichael Polenchuk1-0/+0
* Update docs/submodules/fuel from branch 'master' - Merge "os_cacert: Parametrize VIP used in path by cp.push" - os_cacert: Parametrize VIP used in path by cp.push JIRA: FUEL-274 Change-Id: Ia77948ba3e99c47aa86fcca20c67d80e2e761208 Signed-off-by: Alexandru Avadanii <Alexandru.Avadanii@enea.com>
2017-09-11Update git submodulesMichael Polenchuk1-0/+0
* Update docs/submodules/fuel from branch 'master' - Merge "scenario: Add AArch64 defaults" - scenario: Add AArch64 defaults Move scenario defaults.yml out of virtual/baremetal dirs, unifying them into a single, arch-specific defaults configuration file. Add AArch64 equivalent config, and arch-qualify default filename. For AArch64, bump VCPU number from 2 to 6. Change-Id: If9b39850af96e4c46e868b1d532bd301f9fd9f26 Signed-off-by: Alexandru Avadanii <Alexandru.Avadanii@enea.com>
2017-09-11Update git submodulesMichael Polenchuk1-0/+0
* Update docs/submodules/fuel from branch 'master' - Merge "reclass: virtual: Factor out common infra config" - reclass: virtual: Factor out common infra config Change-Id: I669a81cf46a4ac988a1ea04c3b9d297ae67a0a62 Signed-off-by: Alexandru Avadanii <Alexandru.Avadanii@enea.com>
2017-09-11Update git submodulesMichael Polenchuk1-0/+0
* Update docs/submodules/fuel from branch 'master' - Merge "log.sh: Collect /var/log from cluster nodes" - log.sh: Collect /var/log from cluster nodes Bring back <ci/deploy.sh> parameter `-L`, which is already passed by releng deploy script. Since we need to enable file_recv on salt master, do so by adding a new class in <virtual-mcp-ocata-common/infra/config.yml>, which will be inherited by all scenario reclass models. JIRA: FUEL-288 Change-Id: I9b649315984fb8580b63883d0e06c1e1efd11057 Signed-off-by: Alexandru Avadanii <Alexandru.Avadanii@enea.com>
2017-09-11Update git submodulesAlexandru Avadanii1-0/+0
* Update docs/submodules/fuel from branch 'master' - bash scripts: Fix remaining shellcheck warn/errs Fix/silence all shellcheck errors, except for scripts in <prototypes/sfc_tacker>. Change-Id: Idc317cdba0f69b78299f2d3665e72ffc19dd8af5 Signed-off-by: Alexandru Avadanii <Alexandru.Avadanii@enea.com>
2017-09-11Update git submodulesMorgan Richomme1-0/+0
* Update docs/submodules/releng from branch 'master' - Merge "Leverage on pbr (Python Build Reasonableness)" - Leverage on pbr (Python Build Reasonableness) pbr can inject requirements into the install_requires, tests_require and/or dependency_links arguments to setup. It finishes cleaning the requirements management [1] for all OPNFV projects integrated by Functest. [1] https://wiki.opnfv.org/display/functest/Requirements+management Change-Id: I30b76db8dcaba809e0b314fbd06ae04d24c8baca Signed-off-by: Cédric Ollivier <cedric.ollivier@orange.com>
2017-09-11Update git submodulesMorgan Richomme1-0/+0
* Update docs/submodules/releng from branch 'master' - Merge "run Functest daily in xci" - run Functest daily in xci Functest daily is based on the functest alpine dockers: - healthcheck - smoke - features - vnf Change-Id: I922f3a5946e8bc06229fb03a959abd2bfead132b Signed-off-by: Morgan Richomme <morgan.richomme@orange.com>
2017-09-11Update git submodulesCedric Ollivier1-0/+0
* Update docs/submodules/functest from branch 'master' - Merge "Allow live migration related tests to run" - Allow live migration related tests to run For tempest or rally, if there are more than 1 compute node, live migration related tests should not be skipped or blacklisted if shared storage is enabled via ceph. Change-Id: Ic93e4f508b597c657abe8d246f0cf9c2b5dfd020 Signed-off-by: Linda Wang <wangwulin@huawei.com>
2017-09-11Update git submodulesCedric Ollivier1-0/+0
* Update docs/submodules/functest from branch 'master' - Merge "Remove Parser from the former Container" - Remove Parser from the former Container A dedicated Alpine container has been built for running the Parser testcase as it requires stable/pike instead of stable/ocata. Change-Id: Ifece75c64c1ed860eca7d0524ca581f41fc89276 Signed-off-by: Cédric Ollivier <cedric.ollivier@orange.com>
2017-09-11Update git submodulesCedric Ollivier1-0/+0
* Update docs/submodules/functest from branch 'master' - Merge "Remove get_repo_tag" - Remove get_repo_tag Not in use after removal of multisite support [1]. [1] https://gerrit.opnfv.org/gerrit/#/c/39569/ Change-Id: I1346c78743690a2e5279d3b1883501dfe19078e3 Signed-off-by: Juha Kosonen <juha.kosonen@nokia.com>
2017-09-11Update git submoduleshu xinhui1-0/+0
* Update docs/submodules/compass4nfv from branch 'master' - Add k8s support JIRA: - Add a new k8s scenario for compass Change-Id: Ic5f58a6152315333684e4f2752aaa0d5d870d9ee Signed-off-by: hu xinhui <xinhui_hu@foxmail.com>
2017-09-11Update git submodulesJun Li1-0/+0
* Update docs/submodules/releng from branch 'master' - Merge "Use dovetail cvp.0.6.0 to run Dovetail test" - Use dovetail cvp.0.6.0 to run Dovetail test Change-Id: I63e361eebe1345a34086ecbe99aba4504cb0f5bc Signed-off-by: xudan <xudan16@huawei.com>
2017-09-11Update git submodulesKubi1-0/+0
* Update docs/submodules/yardstick from branch 'master' - Merge "change outage_time from 20 to 30s" - change outage_time from 20 to 30s Change-Id: I255c71a75d748f8e7401815a2a5890111a1ee2f5 Signed-off-by: rexlee8776 <limingjiang@huawei.com>
2017-09-11Update git submodulesRex Lee1-0/+0
* Update docs/submodules/yardstick from branch 'master' - Merge "Add API(v1) to get real time log" - Add API(v1) to get real time log JIRA: YARDSTICK-805 We need to get real time log if we use API(v1) run test case. API: /yardstick/tasks/<task_id>/log For example: http://ip:port/yardstick/tasks/14795be8-f144-4f54-81ce-43f4e3eab33f/log?index=0 Change-Id: Ic0bf10f26f4f07d3264f2415c4923a1bfded2f81 Signed-off-by: chenjiankun <chenjiankun1@huawei.com>
2017-09-11Update git submoduleshongbo tian1-0/+0
* Update docs/submodules/dovetail from branch 'master' - Merge "Clarify criteria for testcase inclusion as running in Functest/CI And additional clarifications." - Clarify criteria for testcase inclusion as running in Functest/CI And additional clarifications. JIRA: DOVETAIL-477 Replace tabs. Further clarify testing programs and optionality criteria. Change-Id: I8eebdf215fb7cc75a6da9748629b1a73d0b71d19 Signed-off-by: Bryan Sullivan <bryan.sullivan@att.com>
2017-09-11Update git submodulesSerena Feng1-0/+0
* Update docs/submodules/releng from branch 'master' - Merge "Updating reporting url and fixed a bug" - Updating reporting url and fixed a bug Changing the url of the reporting to the original one. Change-Id: I2973a4b7d28cbdd725a4764dffbf777c3fc2e937 Signed-off-by: Sakala Venkata Krishna Rohit <rohitsakala@gmail.com>