summaryrefslogtreecommitdiffstats
path: root/docs
AgeCommit message (Collapse)AuthorFilesLines
2017-03-30Refactor documentsShubhamRathi4-74/+10
1. Remove projects not part of Danube from release notes 2. Remove redundant content about Test Frameworks from Installation Instroduction 3. Remove Yardstick from Testing Dev guide Change-Id: I8b14d76f2b43c89ebdf8d9e6a62ff3c4a22eae30 Signed-off-by: ShubhamRathi <shubhamiiitbackup@gmail.com> (cherry picked from commit c9c30dd37265769bca4f4460b965557be3dd4e33)
2017-03-30Update git submodulesJose Lausuch1-0/+0
* Update docs/submodules/functest from branch 'stable/danube' - Merge "Clean up Tempest blacklist" into stable/danube - Clean up Tempest blacklist This list has been generated in Colorado and there are some scenarios that are deprecated and there is no need to list them here. Change-Id: I62a30b5026ed1df65ebdb7a68a6acf3364469865 Signed-off-by: jose.lausuch <jose.lausuch@ericsson.com> (cherry picked from commit 69de5300f0a5b75aed99a24a809f852498dc0695)
2017-03-30Update git submodulesGeorg Kunz1-0/+0
* Update docs/submodules/functest from branch 'stable/danube' - Disable tempest server reboot test for SDNVPN and Gluon Bug report: https://bugs.opendaylight.org/show_bug.cgi?id=5586 As a result, floating IPs are not working in Apex at the moment. Change-Id: I437c10b53dc01810ed757f040d3378c92320274b Signed-off-by: Georg Kunz <georg.kunz@ericsson.com> Signed-off-by: Nikolas Hermanns <nikolas.hermanns@ericsson.com> (cherry picked from commit 9fba4aed6b8f2ef1c939498d866f2cae57b89246)
2017-03-30Update git submodulesYujun Zhang1-0/+0
* Update docs/submodules/qtip from branch 'stable/danube' - Add more content to developer overview - copy "Coding Style" from `CONTRIBUTING.md` - copy "Testing" from `DEVELOP.md` - add links of primary packages Change-Id: Ia4da2c610a3ceb41ec710904e9437b0449d0a46f Signed-off-by: Yujun Zhang <zhang.yujunz@zte.com.cn> (cherry picked from commit 540f711b71976c587417b0a3a04a89b79cf465d4)
2017-03-30Update git submoduleschenjiankun1-0/+0
* Update docs/submodules/yardstick from branch 'stable/danube' - Bugfix: improper license header in swagger docs JIRA: YARDSTICK-609 In the patch: https://gerrit.opnfv.org/gerrit/#/c/28833/ It update the license header, but it is improper to swagger yaml file. The license information will show in swagger docs. So I remove it. Change-Id: Ib87f0f43a95e3b2145c4b59059c4573000f1997c Signed-off-by: chenjiankun <chenjiankun1@huawei.com> (cherry picked from commit 6e77001bcd07f30f9edcf4103528002f4c4ec536)
2017-03-30Update git submodulesjoehuang1-0/+0
* Update docs/submodules/multisite from branch 'stable/danube' - Update the Colorado description to Danube There is still Colorado description in multisite.kingbird.installation.rst, need to update it. Change-Id: I9b4b0d4524d12f0a160d31d4f59c60a13f48596b Signed-off-by: joehuang <joehuang@huawei.com> (cherry picked from commit 22d48a744158d5aafa7e2a999704eb877a77992b)
2017-03-30Update git submodulesUlas Kozat1-0/+0
* Update docs/submodules/domino from branch 'stable/danube' - Merge "Revert "Revert "Adding Labels""" into stable/danube - Revert "Revert "Adding Labels"" This reverts commit 4d87450c06558534c48846cc302e31e06c873d27. Change-Id: Ic7fd1397a868ec715e691f35f4526dae34db5d26 Signed-off-by: Ulas Kozat <ulas.kozat@gmail.com>
2017-03-30Update git submodulesUlas Kozat1-0/+0
* Update docs/submodules/domino from branch 'stable/danube' - Merge "Revert "Adding Labels"" into stable/danube - Revert "Adding Labels" This reverts commit 915987ceffbd35b61013e2aec57b9a53384d2de7. Change-Id: I42a188ec5e0dac05380cbe19f0577ea4c39b4ed7 Signed-off-by: Ulas Kozat <ulas.kozat@gmail.com>
2017-03-30Update git submodulesUlas Kozat1-0/+0
* Update docs/submodules/domino from branch 'stable/danube' - Merge "Revert "Adding Labels"" into stable/danube - Revert "Adding Labels" This reverts commit 915987ceffbd35b61013e2aec57b9a53384d2de7. Change-Id: Ie39cea0edad5fb294288c80b79ee564b9b710023 Signed-off-by: Ulas Kozat <ulas.kozat@gmail.com>
2017-03-30Update git submodulesTim Rozet1-0/+0
* Update docs/submodules/apex from branch 'stable/danube' - Pins ODL L3 VPP/HC packages JIRA: APEX-421 Change-Id: I18a1624af96be772820938e3138666c51b10301c Signed-off-by: Tim Rozet <trozet@redhat.com> (cherry picked from commit 621bfd97aa74877177039ada39c0c8f9578a0220)
2017-03-29Update git submodulesUlas Kozat1-0/+0
* Update docs/submodules/domino from branch 'stable/danube' - JIRA DOMINO-26: Add exit 0 to test scripts Change-Id: I71bb0abc7b9683330fcaa03c02827b261f13f3ae Signed-off-by: Ulas Kozat <ulas.kozat@gmail.com> (cherry picked from commit 07f6ad3c89a2c2a2df5997824330cb9d7f9b51f1)
2017-03-29Update git submodulesUlas Kozat1-0/+0
* Update docs/submodules/domino from branch 'stable/danube' - JIRA DOMINO-23: Documentation update Change-Id: I8d996f750e607b0ac4202ae705fff558ca2062e5 Signed-off-by: Ulas Kozat <ulas.kozat@gmail.com>
2017-03-29Updating composite docs with links, information and versions.ChristopherPrice6-347/+40
Comments welcome. Change-Id: I1c6bca795d0d638e0867a59fa6b1fd0a17e5333c Signed-off-by: ChristopherPrice <christopher.price@ericsson.com> (cherry picked from commit 1db1bd89db4cffe08845f3042af6fc0989a71d5f)
2017-03-29Update git submodulesShubhamRathi1-0/+0
* Update docs/submodules/domino from branch 'stable/danube' - Adding Labels Labels serve as anchors/ refs when referenced from other documents This patch adds labels to docs/*/*/index.rst Change-Id: Ic47af71d73c89cf09f9803b67ecab6dfbc8d6874 Signed-off-by: ShubhamRathi <shubhamiiitbackup@gmail.com> (cherry picked from commit d7a964fbf1775a60461d6f43b1fda4a32eb7cfff)
2017-03-29Update git submodulesUlas Kozat1-0/+0
* Update docs/submodules/domino from branch 'stable/danube' - JIRA DOMINO-23: Corrections Change-Id: I61b9d62204c6dfc4df920888de40c24a8a1d44d5 Signed-off-by: Ulas Kozat <ulas.kozat@gmail.com>
2017-03-29Update git submodulesAlexandru Avadanii1-0/+0
* Update docs/submodules/armband from branch 'stable/danube' - fuel: deploy: SFC scenarios: 4.8 krn, no vhost_net FIXME: Put patch in `upstream-backports` dir for now, so we don't have to edit other patches, to be moved to a more fit location later. Change-Id: Ia2e6e4800844dda0abc19347768a0927e0c3db9f Signed-off-by: Alexandru Avadanii <Alexandru.Avadanii@enea.com>
2017-03-29Expand CPerf overview docsDaniel Farrell1-1/+5
Change-Id: I82a53de2447b26e8fcfcc7ce556a318ce6f88cd7 Signed-off-by: Daniel Farrell <dfarrell07@gmail.com> (cherry picked from commit 9726ddbc27f12f3b8e18a1088490659c9051beff)
2017-03-29Update Testing ecosystem documentationMorgan Richomme5-111/+43
- new ecosystem figure - add reporting figure - indicate next steps for Danube 2.0 pending question (cperf) Change-Id: I3dcf5a4874f0585f433a693117764641aab8faf8 Signed-off-by: Morgan Richomme <morgan.richomme@orange.com> (cherry picked from commit 8a4427306c179cbf469d9d6e689a6e5427d50ea4)
2017-03-29Update git submodulesAlexandru Avadanii1-0/+0
* Update docs/submodules/armband from branch 'stable/danube' - Merge "Update armband documentation for Danube" into stable/danube - Update armband documentation for Danube JIRA: ARMBAND-243 Change-Id: If44f1a9f820793c9b04610fd4db7c05a6675f065 Signed-off-by: Cristina Pauna <cristina.pauna@enea.com> (cherry picked from commit b32f9425f4bc80fac6db3f71a17de7be87199e5b)
2017-03-29Update git submodulesAlexandru Avadanii1-0/+0
* Update docs/submodules/armband from branch 'stable/danube' - deploy-cache: Use `mco` to set up authorized_keys JIRA: ARMBAND-242 Change-Id: I1e8335289a253f5fa2ebb4fb2620b25f10e1b1e9 Signed-off-by: Alexandru Avadanii <Alexandru.Avadanii@enea.com> (cherry picked from commit 6b5e1a9bc6c1f260e15e0f5698382d8feb992caa)
2017-03-29Update git submodulesAlexandru Avadanii1-0/+0
* Update docs/submodules/armband from branch 'stable/danube' - submodules: Pin stable branches for Danube/Fuel 10 Change-Id: Ia9e9d45733db0a4e5f8157dda2b9b2bbc6cb072e Signed-off-by: Alexandru Avadanii <Alexandru.Avadanii@enea.com>
2017-03-29Update git submodulesAlexandru Avadanii1-0/+0
* Update docs/submodules/armband from branch 'stable/danube' - f-l: Refresh after upstream reverted cobbler rm Remove our revert patches since upstream applied the same changes. Update patch context where needed. JIRA: ARMBAND-237 Change-Id: I6007484ad23f0fceabd8f8ec7625e598aee280c7 Signed-off-by: Alexandru Avadanii <Alexandru.Avadanii@enea.com> (cherry picked from commit 71b44345b89e802c549d3415da65b5502effbaeb)
2017-03-29Update git submodulesNarinder Gupta1-0/+0
* Update docs/submodules/joid from branch 'stable/danube' - Merge "changing the user guide draft version." into stable/danube - changing the user guide draft version. Change-Id: Ia3dca995bcfd181353919535e071d7a5302eb32a Signed-off-by: Narinder Gupta <narinder.gupta@canonical.com> (cherry picked from commit 36a495e8d20149811d13f6ba944ecc30a393aed4)
2017-03-29Update git submodulesNikolas Hermanns1-0/+0
* Update docs/submodules/sdnvpn from branch 'stable/danube' - Reduce overview Change-Id: Ifb8915d62ea26f44f29c4d3b84beecd78dceae9e Signed-off-by: Nikolas Hermanns <nikolas.hermanns@ericsson.com> (cherry picked from commit c063e49cec6afa6ba1ab743a86482768fe1cc28e)
2017-03-29Update git submodulesNikolas Hermanns1-0/+0
* Update docs/submodules/sdnvpn from branch 'stable/danube' - Changing to new docs structure Change-Id: I4c15e1635981b2b5fe5473be89b5abab78bfabd5 Signed-off-by: Nikolas Hermanns <nikolas.hermanns@ericsson.com> (cherry picked from commit 0f8220d5d96cc0a45be00e937c73ab938133e587)
2017-03-29Updating the submodules HEADs manualySofia Wallin7-0/+0
Change-Id: If182c2eaf4cc3a4aa7a4da51c375cf25fd011a1b Signed-off-by: Sofia Wallin <sofia.wallin@ericsson.com>
2017-03-29Updated VSPERF description and fixed Wiki links to projectTrevor Cooper2-5/+7
Change-Id: Ic71f8004621dbb99715907ba3d82acd0f20e2291 Signed-off-by: Trevor Cooper <trevor.cooper@intel.com> (cherry picked from commit b54f4712cea42b96d5a6c5a63066119f6e90470e)
2017-03-29Fix search form overflowShubhamRathi1-0/+8
Search input in the navbar overflowed to the next line in the navbar in certain pages. Change-Id: Ica9b01c6051cb2649f773a90a506ab89a8d74ac3 Signed-off-by: ShubhamRathi <shubhamiiitbackup@gmail.com> (cherry picked from commit dc9acd0ae17c4be0f7ad0f059b175d99185b0268)
2017-03-29Merge "Adding the submdules directory for DoveTail." into stable/danubeSofia Wallin1-0/+0
2017-03-29Adding the submdules directory for DoveTail.ChristopherPrice1-0/+0
Can be cherry picked to stable, the content will not be linked in docs.opnfv.org at this time. Change-Id: Iae4ab8e9bc902c2726b69386b3ecf611f7890dee Signed-off-by: ChristopherPrice <christopher.price@ericsson.com>
2017-03-29Show master branch as 'Latest'ShubhamRathi1-2/+3
Documentation built on RTD shows the branch name of the latest (master) branch as Danube. This patch fixes the branch name to 'Latest' Change-Id: I3d52fda5992fbb3e5fb17c9784d7a98396c0ebdc Signed-off-by: ShubhamRathi <shubhamiiitbackup@gmail.com> (cherry picked from commit e0ec89a74253d01f3fa9b471fcfd6ca247710345)
2017-03-29Re-order testing user guide index pageYujun Zhang1-4/+4
Testing tools needs to be configured before use. Change-Id: I04862af1c9d2ee8d9fdb91397c3e18da2207a964 Signed-off-by: Yujun Zhang <zhang.yujunz@zte.com.cn> (cherry picked from commit b775f4fca6cfa580f71dc338dcf063e3397a80cf)
2017-03-29Remove Moon, Add PromiceShubhamRathi1-76/+387
Moon has been deferred until E release. Promice was erroneously removed, re-adding. Change-Id: Ia5c5989f9aa9811998755f4c0802756e1b088c67 Signed-off-by: ShubhamRathi <shubhamiiitbackup@gmail.com> (cherry picked from commit bdefaca3c0136edfeb0b00817d72a69b768fb0a5)
2017-03-29Remove Moon & OVSNFV documentationShubhamRathi1-4/+0
Change-Id: I87026f857af1c589426158bb89db6b1f9324e2e1 Signed-off-by: ShubhamRathi <shubhamiiitbackup@gmail.com> (cherry picked from commit 61f47cdee31c3c8e14475b07ea5a991a8e8ad474)
2017-03-29Updated vsperf doc refs for release-notes and testingTrevor Cooper3-3/+21
Change-Id: I736ff7c5699e5be929ebe9104a0dfc619ef0ebc8 Signed-off-by: Trevor Cooper <trevor.cooper@intel.com> (cherry picked from commit cb5d501a339ef5b8ce262efd17d5b1729d95757a)
2017-03-29Update git submodulesyuyang1-0/+0
* Update docs/submodules/bottlenecks from branch 'stable/danube' - bugfix: bottlenecks devguide in docs.opnfv.org JIRA: BOTTLENECK-149 Adjust the directory structure to make Bottlenecks devguide on docs.opnfv.org. Change-Id: Ib773a26ca5f4eaee94834ff641ec45531ef3025c Signed-off-by: yuyang <Gabriel.yuyang@huawei.com> (cherry picked from commit 3480c32bb5113a8a5f56b7e1db82c3a9236418fb)
2017-03-29Update git submodulesyuyang1-0/+0
* Update docs/submodules/bottlenecks from branch 'stable/danube' - bugfix: fix bugs for running 'teststory run' JIRA: BOTTLENECK-144 utils/parser.py:56 has incorrect var:cls which cause pass more var to testcase_read function. Change-Id: I2d4b93f95d19a205e537515529746f6d9e13fe2c Signed-off-by: yuyang <Gabriel.yuyang@huawei.com> (cherry picked from commit 1760c89637ac71b877a17896e5768640a20360c3)
2017-03-29Update git submodulesyuyang1-0/+0
* Update docs/submodules/bottlenecks from branch 'stable/danube' - Add docker clean-up for run test JIRA: BOTTLENECK-148 Currently, only OPNFV CI includes env-cleanup for Bottlenecks. It is preferable to also include the operation locally for test automation and repeatability. Changes: 1. Translate tab into 4 spaces Change-Id: I9f4efb95c155e442afd3141c00f707421c61b2da Signed-off-by: yuyang <Gabriel.yuyang@huawei.com> (cherry picked from commit fe83578bd2fe1a09f8334f85e30a0afbb68cc5cc)
2017-03-29Update git submodulesTrevor Cooper1-0/+0
* Update docs/submodules/vswitchperf from branch 'stable/danube' - Fixed indexes Change-Id: I5e10d9b2469ed7ec7fbced12b041e659bd568c2d Signed-off-by: Trevor Cooper <trevor.cooper@intel.com>
2017-03-29Update git submodulesTrevor Cooper1-0/+0
* Update docs/submodules/vswitchperf from branch 'stable/danube' - Updated index Change-Id: I9e180eff666c3ca98eb51d9c958e3b1410ddddd5 Signed-off-by: Trevor Cooper <trevor.cooper@intel.com>
2017-03-29Update git submodulesTrevor Cooper1-0/+0
* Update docs/submodules/vswitchperf from branch 'stable/danube' - Removed Indices Change-Id: I57420dfca1a2113ebc35faded3084116c670dbc1 Signed-off-by: Trevor Cooper <trevor.cooper@intel.com>
2017-03-28Update git submodulesUlas Kozat1-0/+0
* Update docs/submodules/domino from branch 'stable/danube' - JIRA 23: Fix line break in configuration section Change-Id: I9866e50dba2e36b97b5f0b1930609ffcb77dc8d2 Signed-off-by: Ulas Kozat <ulas.kozat@gmail.com>
2017-03-28Update git submodulesBin Hu1-0/+0
* Update docs/submodules/ipv6 from branch 'stable/danube' - Fix typo issue Change-Id: If4d0bad9d2ce0e90dd59f11a4bec7484307feacc Signed-off-by: Bin Hu <bh526r@att.com> (cherry picked from commit 087c95c300b0c6599a1c9d39151d06df1352789c) - Final 1.0.0 for Release Notes Change-Id: I2494a6c28233d6667ebab5db97c7366a1762f817 Signed-off-by: Bin Hu <bh526r@att.com> (cherry picked from commit 4ee9deb73423eafc67f37c076fc7e2de9535efd2) - Split Gap Analysis into 2 files One for OpenStack Newton, and the other for ODL Boron. Change-Id: Ic2e7d67c44e33009a402e02ea27d9c0fe38485ef Signed-off-by: Bin Hu <bh526r@att.com> (cherry picked from commit 951f066001be8a3184084a759f3a9ef4d2fcfa20) - Update the reference URL of OPNFV Releases Change-Id: I010074952edb8f5ef100cd48414c8cc6f518a76b Signed-off-by: Bin Hu <bh526r@att.com> (cherry picked from commit e136eed871db256c4ffbcd21eb0eeef1e2735d7a) - Draft of Release Notes Change-Id: I76d4390f3916bb9eff14ef477e6274d47d501d67 Signed-off-by: Bin Hu <bh526r@att.com> (cherry picked from commit 6805a791acbbaa26d3363dc8dabcdff4c7a1d99a)
2017-03-28Update git submoduleskalyanreddy1-0/+0
* Update docs/submodules/kvmfornfv from branch 'stable/danube' - Update documentation structure. This patch includes adjusting docs directory structure for kvmfornfv project. Change-Id: Ic2f992cd5e8f6808ca3ba088172eb6da342182ba Signed-off-by: Gundarapu Kalyan Reddy <reddyx.gundarapu@intel.com>
2017-03-28Update git submodulesMichael Polenchuk1-0/+0
* Update docs/submodules/fuel from branch 'stable/danube' - Revert "Revert: Blueprint "bp/distributed-serialization"" This reverts commit 8b28c44a4be6beef8a71e672f543001bcc0a080f. The issue has been fixed in upstream. Change-Id: Id4ad8fb7b1ec887f8d8d1d5b18a9b33a73bda10c Signed-off-by: Michael Polenchuk <mpolenchuk@mirantis.com> (cherry picked from commit 4a360c5076f839c8b700638f9b85c3e630894826)
2017-03-28Update git submodulesSofia Wallin1-0/+0
* Update docs/submodules/joid from branch 'stable/danube' - Updated release name and release date Change-Id: I64d1c3abb1b5556bf81fb2a637614f02cb92d679 Signed-off-by: Sofia Wallin <sofia.wallin@ericsson.com> (cherry picked from commit 2c03acdb23144b72ed9c8b5f9b85c8646172a057) - Add interface renaming on maas for heterogeneous hardware config Change-Id: I7b26821802f1843d738a116082b70bd27b35b35b Signed-off-by: Blaisonneau David <david.blaisonneau@orange.com> (cherry picked from commit 4afffb76ced3bafae18e92a80137c25f969898f2) - correct of maas deploy and orange pod2 update MAAS deploy correction to manage heterogeneous hardware (different interfaces mapping or naming amoung nodes, and configuration of a VLAN on an interface without network_cidr) Change-Id: Ib3825bd8600cf62637cee85779d9ee0a55f896c4 Signed-off-by: Blaisonneau David <david.blaisonneau@orange.com> - Add labels for scenario docs Change-Id: I6e0e3fbc51b6d164144e22b236705eebb79050ba Signed-off-by: ShubhamRathi <shubhamiiitbackup@gmail.com> (cherry picked from commit 9cb4fd572a2cf6966adc4c94ce1a606a4ca94774) - configure the VIP accordingly and also change the sequence. Remove the admin-openrc file. Change-Id: I8a14dc6de22d0f0de346d69e6d02a7e9c295ece1 Signed-off-by: Narinder Gupta <narinder.gupta@canonical.com> (cherry picked from commit 0c50df832b79dc06fa44dfd918d78ceb894ffd64) - fix for mutiple block devices for lxd containers. Change-Id: I4e7cb6b8505d0c2c395adf0345cbf22e63a73853 Signed-off-by: Narinder Gupta <narinder.gupta@canonical.com> (cherry picked from commit c44406f505cb49858caf1a2b1c2f2606cf935d92) - modfiied to corner the concerns of Orange labs. Change-Id: I82125424714ce5083f045224f8fc9fa4c7a0edc2 Signed-off-by: Narinder Gupta <narinder.gupta@canonical.com> (cherry picked from commit cb6d37a8b4f7762fbd254e9870a19c2c4d865553) - Updated the documentation as per latest devlopment. Change-Id: If62157368de79c7c44adc3e27945e1bf6dbf6b2c Signed-off-by: Narinder Gupta <narinder.gupta@canonical.com>
2017-03-28Update git submoduleskalyanreddy1-0/+0
* Update docs/submodules/kvmfornfv from branch 'stable/danube' - Update documentation structure. This patch is used to update documentation structure. Change-Id: I50d4ef4256ccfc57a0434123e7532a50000582cf Co-Authored by:Srinivas <srinivas.atmakuri@tcs.com> Co-Authored by:RajithaY<rajithax.yerrumsetty@intel.com> Co-Authored by:shravani paladugula <shravanix.paladugula@intel.com> Co-Authored by:Navya Bathula <navyax.bathula@intel.com> Signed-off-by: Gundarapu Kalyan Reddy <reddyx.gundarapu@intel.com> (cherry picked from commit f1f3cc27f23bdde81c37d8142d4288d811bd5e45)
2017-03-28Update git submodulesGeorg Kunz1-0/+0
* Update docs/submodules/netready from branch 'stable/danube' - Fixing broken links in documentation Using rst references to link to other documentation pages instead of relative HTML links. Change-Id: Id8164a4f50f4fd39c996f5ae354b22f3c960fb08 Signed-off-by: Georg Kunz <georg.kunz@ericsson.com> (cherry picked from commit 0c59ca9234d712a74fa01c1eaba676dfb0080052) - Adding further documentation for the Gluon scenario Change-Id: I4926ab30223312b91b6349b798f652615d70001e Signed-off-by: Georg Kunz <georg.kunz@ericsson.com> (cherry picked from commit 8a3e022acdcab14bd1f51cf08f4a26004dda49e7)
2017-03-28Few minor edits plus used the SPDX license identifierRay Paik1-10/+10
Change-Id: Ibdd3c700bdf0ed8f67d5cd794568a99c2d0efab9 Signed-off-by: Ray Paik <rpaik@linuxfoundation.org> (cherry picked from commit 9bce0476fec83c40e5fb1e60134d44f44151743f)
2017-03-28Update git submodulesShubhamRathi1-0/+0
* Update docs/submodules/fds from branch 'stable/danube' - Add Scenario Documentation Labels Change-Id: Icff2c400c054d960c3c4ec32bc2c69c561c5bf1d Signed-off-by: ShubhamRathi <shubhamiiitbackup@gmail.com> (cherry picked from commit 03210b90f9208a2e2d80f9f31d6132e7b2ca576f)