summaryrefslogtreecommitdiffstats
path: root/docs
AgeCommit message (Collapse)AuthorFilesLines
2018-02-27Update git submodulesYifei Xue1-0/+0
* Update docs/submodules/compass4nfv from branch 'master' - Merge "Enable CSI plugin for Stor4nfv scenario" - Enable CSI plugin for Stor4nfv scenario JIRA: - Add some configurations to enable CSI plugin in k8s v1.9 which is used by Stor4nfv scenario. Change-Id: I78e0b39f31ff666eace50921c691107154dcb249 Signed-off-by: Yifei Xue <xueyifei@huawei.com>
2018-02-27Update git submodulesMarkos Chandras1-0/+0
* Update docs/submodules/releng-xci from branch 'master' - Merge "xci: scripts: vm: start-new-vm.sh: Re-arrange debug messages" - xci: scripts: vm: start-new-vm.sh: Re-arrange debug messages This also improves (again!) the check for parallel packages managers to print some useful messages for debugging. Change-Id: I7756db80aa3ed42cd3ef37293f7116b5a9c150c1 Signed-off-by: Markos Chandras <mchandras@suse.de>
2018-02-27Update git submodulesCédric Ollivier1-0/+0
* Update docs/submodules/functest from branch 'master' - Remove obsolete Functest utils Only 3 functions are kept as part of our framework: - execute_command_raise() - execute_command() - get_parameter_from_yaml() Change-Id: I966a1d6122391dae85aa3c77813ad2f1698ceb45 Signed-off-by: Cédric Ollivier <cedric.ollivier@orange.com>
2018-02-27Update git submodulesFatih Degirmenci1-0/+0
* Update docs/submodules/releng from branch 'master' - Merge "xci: Enable functest healthcheck" - xci: Enable functest healthcheck Change-Id: I261bfafefcd1fb5dcfead20697759e46d3556b46 Signed-off-by: Fatih Degirmenci <fdegir@gmail.com>
2018-02-27Update git submodulesFatih Degirmenci1-0/+0
* Update docs/submodules/releng from branch 'master' - Merge "xci: Correct the gerrit project name for sdnvpn" - xci: Correct the gerrit project name for sdnvpn Change-Id: Ied1014546f6bd4d80896f29f86374a2865f95dca Signed-off-by: Fatih Degirmenci <fdegir@gmail.com>
2018-02-27Update git submoduleswutianwei1-0/+0
* Update docs/submodules/releng from branch 'master' - [compass4nfv]trigger k8s on baremetal pod 1. add the trigger k8s on baremetal 2. modify the default DEPLOY_SCENARIO Change-Id: I9d216c12905b36b4fbba7d9214fcf6fccf1d79c4 Signed-off-by: wutianwei <wutianwei1@huawei.com>
2018-02-27Update git submodulesPeriyasamy Palanisamy1-0/+0
* Update docs/submodules/sdnvpn from branch 'master' - Merge "Update the way of running tempest" - Update the way of running tempest Use 'tempest run' instead of 'run_tempest.sh', which has been removed by tempest 16.0.0 Also, 'tempest.py' has been renamed to 'run_tempest.py', to avoid package importing conflict Change-Id: I61e802e0381d1f33281610e98d05813c9b96faf9 Signed-off-by: Linda Wang <wangwulin@huawei.com>
2018-02-27Update git submodulesPeriyasamy Palanisamy1-0/+0
* Update docs/submodules/sdnvpn from branch 'master' - Merge "Stop relying on internal Functest utils" - Stop relying on internal Functest utils It switches from functest_utils.get_functest_config() to config.CONF(). download_url is now hosted in sfc as it's unused by Functest. The next functions will be considered as part of Functest framework (then it must be well covered and documented): - ft_utils.execute_command_raise() - ft_utils.execute_command() - ft_utils.get_parameter_from_yaml() Change-Id: I076c6ced430df8387de8eaeac6f3a94d93201b19 Signed-off-by: Cédric Ollivier <cedric.ollivier@orange.com>
2018-02-27Update git submodulesrexlee87761-0/+0
* Update docs/submodules/releng from branch 'master' - [Yardstick] set yardstick ci debug switch on Yardsitck CI default print INFO level message, this patch turn the DEBUG on for Fraser debug. Change-Id: I3d4436e6610648ab64439ba410f4fe07a54d6dc0 Signed-off-by: rexlee8776 <limingjiang@huawei.com>
2018-02-27Update git submoduleswutianwei1-0/+0
* Update docs/submodules/compass4nfv from branch 'master' - Add dha files Add the huawei-pod1 and huawei-pod2 k8s dha files Change-Id: Id191c6d18508f15d9032a2cb3d0f563c059a7d53 Signed-off-by: wutianwei <wutianwei1@huawei.com>
2018-02-27Update git submodulesYifei Xue1-0/+0
* Update docs/submodules/compass4nfv from branch 'master' - Merge "set the kubernetes variable" - set the kubernetes variable According to DEPLOY_SCENARIO, we set different nfvi and distro. Change-Id: I3082923fc7d4a1309c1de83f988f831d67c10d64 Signed-off-by: wutianwei <wutianwei1@huawei.com>
2018-02-27Update git submodulesHarry Huang1-0/+0
* Update docs/submodules/compass4nfv from branch 'master' - Set storage role optional JIRA: - storage_master and storage_node role are currently required in kubernetes scenario which cause scenario with no storage_master or storage_node fails to be deployed. Change-Id: I0fd28a7fd4a6161be96044382ea509832473dc71 Signed-off-by: Harry Huang <huangxiangyu5@huawei.com>
2018-02-27Update git submodulesTaseer Ahmed1-0/+0
* Update docs/submodules/qtip from branch 'master' - Add SUT option in CLI Change-Id: I43063793497ebdc8b2383c23739eb89df1ffa74b Signed-off-by: Taseer Ahmed <taseer94@gmail.com>
2018-02-27Update git submodulesPeriyasamy Palanisamy1-0/+0
* Update docs/submodules/sdnvpn from branch 'master' - comment setup quagga playbook In order to enable verify jobs in XCI for sdnvpn, commenting quagga install playbook until its upstream review (https://review.openstack.org/#/c/523907/) is merged Change-Id: Ibeded8fe458e826259f2fb1cf82843f018aa3648 Signed-off-by: Periyasamy Palanisamy <periyasamy.palanisamy@ericsson.com>
2018-02-27Update git submodulesSerena Feng1-0/+0
* Update docs/submodules/releng from branch 'master' - Merge "[QTIP] Delete Euphrates CI jobs" - [QTIP] Delete Euphrates CI jobs Delete Euphrates CI jobs. JIRA: QTIP-292 Change-Id: I6ab6055fccc2bb7de299bab5732f97565ecef808 Signed-off-by: zhihui wu <wu.zhihui1@zte.com.cn>
2018-02-27Update git submodulesAlexandru Avadanii1-0/+0
* Update docs/submodules/armband from branch 'master' - u/fuel: Bump for Pharos IDF update Change-Id: Ibe1902e631fa8dcb1d3fa3e5b3b3c298f4f0cd18 Signed-off-by: Alexandru Avadanii <Alexandru.Avadanii@enea.com>
2018-02-27Update git submodulesAlexandru Avadanii1-0/+0
* Update docs/submodules/fuel from branch 'master' - [submodule] Bump Pharos git repo for IDF updates Change-Id: I8d526d51a3e18652c59bad9d7c3c384aa6583566 Signed-off-by: Alexandru Avadanii <Alexandru.Avadanii@enea.com>
2018-02-27Update git submodulesAlexandru Avadanii1-0/+0
* Update docs/submodules/pharos from branch 'master' - [IDF] arm-pod6: Use 2M hugepages, 12 cores for nova Change-Id: I03098ca3d4a90f6420cee64985c2853931a6a870 Signed-off-by: Alexandru Avadanii <Alexandru.Avadanii@enea.com>
2018-02-27Update git submodulesmei mei1-0/+0
* Update docs/submodules/releng from branch 'master' - Merge "[Compass] Add new scenarios" - [Compass] Add new scenarios add the following scenarios and run on master 1. k8-nosdn-stor4nfv-ha 2. k8-nosdn-stor4nfv-noha Change-Id: I2c505263fbf48ea25be735ebe14e3c4d8097bf91 Signed-off-by: wutianwei <wutianwei1@huawei.com>
2018-02-27Update git submodulesJustin chi1-0/+0
* Update docs/submodules/compass4nfv from branch 'master' - Merge "doc: add arm deployment guide" - doc: add arm deployment guide Change-Id: Ib66003003ea4697e9634201802e9169bc53a8ade Signed-off-by: Yibo Cai <yibo.cai@arm.com>
2018-02-27Update git submodulesYichen Wang1-0/+0
* Update docs/submodules/nfvbench from branch 'master' - Move to tag 1.2.6 and nfvbenchvm 0.6 Change-Id: Ib38e033baca0145db3cc940ca92c5ba73d5717e7 Signed-off-by: Yichen Wang <yicwang@cisco.com>
2018-02-27Update git submoduleszhihui wu1-0/+0
* Update docs/submodules/qtip from branch 'master' - Merge "create VM via heat" - create VM via heat JIRA: QTIP-290 Change-Id: I3b87b06e7f2b134c28d9cb046150fb000070a760 Signed-off-by: zhihui wu <wu.zhihui1@zte.com.cn>
2018-02-27Update git submodulesYichen Wang1-0/+0
* Update docs/submodules/nfvbench from branch 'master' - [NFVBENCH-70] Update nfvbenchvm to 0.6 1. Update kernel to 4.4.118-1.el7.elrepo.x86_64; 2. Update to build testpmd off DPDK 18.02; 3. Update txd/rxd of testpmd to 256/1024; 4. Update VPP to 17.10-9~gd594711~b55.x86_64; Change-Id: I1321b306143d1daf81f8a984ad7739a980c5cfb9 Signed-off-by: Yichen Wang <yicwang@cisco.com>
2018-02-27Update git submodulesramamani yeleswarapu1-0/+0
* Update docs/submodules/compass4nfv from branch 'master' - Add plugin for Stor4nfv for k8s deploy - Adds 'stor4nfv' plugin which installs OpenSDS using stor4nfv. - Adds k8s-nosdn-stor4nfv-ha scenario file. - Adds k8s-nosdn-stor4nfv-noha scenario file. Change-Id: Iee718a48994ad4e55f4b7a01933bd4e7773ac67f Signed-off-by: ramamani yeleswarapu <ramamani.yeleswarapu@intel.com>
2018-02-27Update git submodulesmei mei1-0/+0
* Update docs/submodules/releng from branch 'master' - Merge "[compass4nfv] add DEPLOY_SCENARIO macro" - [compass4nfv] add DEPLOY_SCENARIO macro fix the error Unrecognized macro 'DEPLOY_SCENARIO' and deploy failed. Change-Id: Ic34a0d99c2a6026303046c2b350da205372ec78e Signed-off-by: wutianwei <wutianwei1@huawei.com>
2018-02-26Update git submodulesAlexandru Avadanii1-0/+0
* Update docs/submodules/armband from branch 'master' - u/fuel: Bump & rebase for compute parameterization While at it, enable hugepages on AArch64 by removing the patch that used to disable them. JIRA: ARMBAND-341 Change-Id: I8f5e8bbceeaa2c99a983a14d9c03da497eec64c4 Signed-off-by: Alexandru Avadanii <Alexandru.Avadanii@enea.com> Signed-off-by: Cristina Pauna <cristina.pauna@enea.com>
2018-02-26Update git submodulesMarkos Chandras1-0/+0
* Update docs/submodules/releng-xci from branch 'master' - Merge "xci: config: env-vars: Allow git urls overrides" - xci: config: env-vars: Allow git urls overrides It's useful to be able to pick alternative git repositories for the deployment. This facilitates testing in-flight features or simply save some bandwidth by keeping internal mirrors. Change-Id: I3eb2e48da1e91f6a52bb3ba14c22f0902c6cd777 Signed-off-by: Markos Chandras <mchandras@suse.de>
2018-02-26Update git submodulesAlexandru Avadanii1-0/+0
* Update docs/submodules/fuel from branch 'master' - [patch] cleanup: Drop LVM filter disable Now we explicitly add a LVM PV on /dev/sda{1,2} for Cinder storage, so we can safely drop the patch disabling LVM volume filtering. If we later move the PV to a different disk, we can just add the VG and LV definitions to linux:storage via reclass, and Salt will skip setting them up (as they're already created by MaaS), yet keep the filtering sane. While at it, fix 'nova_cpu_pinning' param expr; constructs based on reclass interpolation (e.g. '${_param:x}') do not work when parameters are passed via reclass.storage templating, so change reclass interpolation syntax with classic YAML anchors. Fixes: 672ae12 Change-Id: Ieb41635ddeb630543d7e4d1079f45d636d9a43af Signed-off-by: Alexandru Avadanii <Alexandru.Avadanii@enea.com>
2018-02-26Update git submodulesAlexandru Avadanii1-0/+0
* Update docs/submodules/pharos from branch 'master' - [IDF] arm-pod6: Fix nova_cpu_pinning param expr Constructs based on reclass interpolation (e.g. '${_param:x}') do not work when parameters are passed via reclass.storage templating, so change reclass interpolation syntax with classic YAML anchors. Change-Id: Ia974d45fc6a5869f4b30b31b947df088ea3aaf0c Signed-off-by: Alexandru Avadanii <Alexandru.Avadanii@enea.com>
2018-02-26Update git submoduleszhihui wu1-0/+0
* Update docs/submodules/qtip from branch 'master' - Adapter "installer_type" for reporting mcp is regarded as fuel in opnfv testresult reporting, but they are different tools for QTIP. so convert "mcp" to "fuel" before reporting. Change-Id: I5a90828b4583fe734beb80283734966d9ece1852 Signed-off-by: zhihui wu <wu.zhihui1@zte.com.cn>
2018-02-26Update git submodulesCristina Pauna1-0/+0
* Update docs/submodules/fuel from branch 'master' - [ovs/dpdk] Parameterize node-specific compute args - node-specific parameters (nova pinning, hugepages, dpdk) should be configurable via IDF, on a per-node basis; - keep default settings for lf-pod2, with and without DPDK, override them for virtual deploys via local-virtual1 IDF; - leave neutron_tenant_* vars hardcoded for now, as they are required on both ctl and cmp nodes - this way we'll deal stricly with cmp params, so we can nicely pass them via config.yml to reclass per-node (and not per-role), allowing mixed computes later; - add compute params for ovs/odl-noha, preparing them for deployment on baremetal later. JIRA: ARMBAND-343 Change-Id: I89a58b9565679ab3882d85f07ae817690ae85c67 Signed-off-by: Cristina Pauna <cristina.pauna@enea.com> - [ovs/dpdk] Add opnfv.route_wrapper sls - fix `route-br-ex` if-up.d script failing when route already exists by adding a wrapper around distro's '/sbin/route' binary in '/usr/local/sbin/route', exploiting default order in Ubuntu PATH; - fix 'br-prv' duplicate entry in 'interfaces.d/ifcfg-br-prv' and 'interfaces' caused by upstream bug [1]; - add barrier waiting for all baremetal nodes online before attempting reboot, trying to catch rare failures which are undetectable in logs as both a succesful reboot and a disconneted minion report 'n/c'; With the above in place, networking service should no longer fail to start on cmp nodes w/ DPDK. [1] https://github.com/saltstack/salt/issues/40262 Change-Id: I6d4895376ce323c14c997e6c9af2ea3eeeee0184 Signed-off-by: Alexandru Avadanii <Alexandru.Avadanii@enea.com>
2018-02-26Update git submodulesCedric Ollivier1-0/+0
* Update docs/submodules/functest from branch 'master' - Merge "Raise exceptions when SDN_CONTROLLER_IP is None" - Raise exceptions when SDN_CONTROLLER_IP is None Change-Id: Ia0d00a6b3c4c4936dc10602e838f507beea0c592 Signed-off-by: Cédric Ollivier <cedric.ollivier@orange.com>
2018-02-26Update git submodulesCedric Ollivier1-0/+0
* Update docs/submodules/functest from branch 'master' - Merge "Stop raising keystoneauth1 exceptions in odl unit tests" - Stop raising keystoneauth1 exceptions in odl unit tests It simply raises Exceptions to avoid depending on keystoneauth1. Snaps may also reraise another exception. Change-Id: Ib3041b2d8ff51ee098f2bf0b9918079b7945abf3 Signed-off-by: Cédric Ollivier <cedric.ollivier@orange.com>
2018-02-26Update git submodulesvalentin boucher1-0/+0
* Update docs/submodules/functest from branch 'master' - Merge "Fix KeyError of OS_AUTH_URL" - Fix KeyError of OS_AUTH_URL Change-Id: Iaaa657ebb8ed017429b640ffaaf03b6d204e887a Signed-off-by: Linda Wang <wangwulin@huawei.com>
2018-02-26Update git submodulesFatih Degirmenci1-0/+0
* Update docs/submodules/releng from branch 'master' - Merge "xci: Set appropriate permissions for the key" - xci: Set appropriate permissions for the key Change-Id: I6387ca1f7eaf107f735eab82917d77b2f3a3d90a Signed-off-by: Fatih Degirmenci <fdegir@gmail.com>
2018-02-26Update git submodulesFatih Degirmenci1-0/+0
* Update docs/submodules/releng from branch 'master' - xci: Do not set DEPLOY_SCENARIO manually Change-Id: Iccd7ef674c9b80daba511f45cc48f403ca0f3e0b Signed-off-by: Fatih Degirmenci <fdegir@gmail.com>
2018-02-26Update git submodulesFatih Degirmenci1-0/+0
* Update docs/submodules/releng from branch 'master' - xci: Move out of WORKSPACE before wiping it out and log scenario to console Change-Id: Ia2caeef24a199580a9eeb2ba6214fa2008f65c1c Signed-off-by: Fatih Degirmenci <fdegir@gmail.com>
2018-02-26Update git submodulesFatih Degirmenci1-0/+0
* Update docs/submodules/releng from branch 'master' - xci: Fix the Gerrit Trigger clone issue for external scenarios When a patch comes in for an external scenario, Gerrit Trigger injects refs for that patch for the corresponding project. With the previous configuration, job attempts to get that patch for releng-xci instead of the actual project. But switching to the right project causes Jenkins jobs to fail since the releng-xci will not be checked out to WORKSPACE. This change makes the clone for the repo/patch work and then it wipes out the WORKSPACE and clones releng-xci there to get the actual script parts to work. Change-Id: Ide31c21a209dff953118f51e9b09de1d206a3085 Signed-off-by: Fatih Degirmenci <fdegir@gmail.com>
2018-02-26Update git submodulesCédric Ollivier1-0/+0
* Update docs/submodules/functest from branch 'master' - Remove openstack utils They have been obsolete since we fully switched to snaps. The files are being moved to SDNVPN which is the last project using them [1]. [1] https://gerrit.opnfv.org/gerrit/#/c/52631/ Change-Id: I277b92a04cf6bc7b30015eed76f03f17830fad2b Signed-off-by: Cédric Ollivier <cedric.ollivier@orange.com>
2018-02-26Update git submodulesFatih Degirmenci1-0/+0
* Update docs/submodules/releng-xci from branch 'master' - Rename var XCI_LOOP to CI_LOOP to align with Functest Change-Id: I1d58f55a1bda258cc3afbfb81e2dd5a1c8e792a1 Signed-off-by: Fatih Degirmenci <fdegir@gmail.com>
2018-02-26Update git submodulesCédric Ollivier1-0/+0
* Update docs/submodules/sdnvpn from branch 'master' - Host openstack utils in SDNVPN SDNVPN is the last project using the deprecated openstack utils which are being removed from Functest tree. All methods unused by SDNVPN could be safely removed in a second change. This patch aims at publishing them asis. Change-Id: I4e479e6def2c691799c9bd86ba325e3d1544ef0d Signed-off-by: Cédric Ollivier <cedric.ollivier@orange.com>
2018-02-26Update git submodulesMartin Klozik1-0/+0
* Update docs/submodules/vswitchperf from branch 'master' - Merge "Trex_speed_improvement: Add logic for dealing with high speed cards" - Trex_speed_improvement: Add logic for dealing with high speed cards Adds configuration options and logic to detect maximum supported speed of T-Rex server side cards. 1. Adds logic to pull maximum supported speed from port info 2. Adds forcable option to have user specify maximum speed 3. If logic cannot detect speed from port_info because it is not available or the forcable option is not set it will assume 10G speeds. 4. Tested on Intel XXV25G and Mellanox ConnectX-5 cards 5. Added packet structure logging to show packet info for better debugging capabilities 6. Adds core mask to take advantage of multiple cores if server is started with more than default number of cores 7. Adds packets lost logging to RFC2544 Throughput testing JIRA: VSPERF-559 Change-Id: I7fcfda7ccc408c30830950ee3668e01b8624c20a Signed-off-by: Christian Trautman <ctrautma@redhat.com>
2018-02-26Update git submodulesFatih Degirmenci1-0/+0
* Update docs/submodules/releng from branch 'master' - xci: Fix extracting scenarios for generic scenarios Change-Id: Ib58ff1a8b093af550f86d337327114df50da4ae7 Signed-off-by: Fatih Degirmenci <fdegir@gmail.com>
2018-02-26Update git submodulesTomi Juvonen1-0/+0
* Update docs/submodules/doctor from branch 'master' - At least APEX will not work with Fraser if we do not wait 120 sec for AODH Change-Id: I4e3e510f51258e892b467f819951bd1a98625f90 Signed-off-by: Tomi Juvonen <tomi.juvonen@nokia.com>
2018-02-26Update git submodulesFatih Degirmenci1-0/+0
* Update docs/submodules/releng from branch 'master' - xci: Change project name matching to REG_EXP Change-Id: Ic706c120ac879741d5562427a6c3e90162223762 Signed-off-by: Fatih Degirmenci <fdegir@gmail.com>
2018-02-26Update git submodulesFatih Degirmenci1-0/+0
* Update docs/submodules/releng-xci from branch 'master' - Merge changes I15f5d41f,I7c7125ac * changes: Export CI_LOOP as expected by Functest Export an new var related to Energy - Export CI_LOOP as expected by Functest CI_LOOP is hardcoded to daily (the common default value) [1]. [1] https://gerrit.opnfv.org/gerrit/#/c/51981/ Change-Id: I15f5d41f7f10a5c8fddcc4a4d303552ef45c5fb2 Signed-off-by: Cédric Ollivier <cedric.ollivier@orange.com> - Export an new var related to Energy It conforms with "Unlink Energy from functest utils and constants": https://gerrit.opnfv.org/gerrit/#/c/51943/ Depends-On: Iecd5d49b4d4c961c9dc51e43e54df1fcd4027266 Change-Id: I7c7125ac2fee9a2e8f24dcf060bdaab1b39ae552 Signed-off-by: Cédric Ollivier <cedric.ollivier@orange.com>
2018-02-26Update git submodulesMarkos Chandras1-0/+0
* Update docs/submodules/releng-xci from branch 'master' - Merge "XCI: k8s: Add support for CentOS distro" - XCI: k8s: Add support for CentOS distro Kubespray already supports the CentOS distribution so make the necessary changes to allow it to work in XCI. Change-Id: I3cf1db055a5fd563b107b46456bc3e18eeafb3ab Co-authored-by: Markos Chandras <mchandras@suse.de> Signed-off-by: wutianwei <wutianwei1@huawei.com>
2018-02-26Update git submodulesFatih Degirmenci1-0/+0
* Update docs/submodules/releng from branch 'master' - Merge "Enable verify jobs for external scenarios" - Enable verify jobs for external scenarios This change extracts the scenario that is impacted by the patch which triggered the verify jobs and saves the scenario name into java properties file. This file will then be used by envInject plugin to inject the scenario name into the build environment. If the triggering change impacts multiple scenarios, the build will result in failure and the developer will be informed about a possible way to rectify the issue. Support for generic scenarios will be introduced in subsequent changes. Change-Id: I6406299c1352b6e9b8a9297c5441adf03445be33 Signed-off-by: Fatih Degirmenci <fdegir@gmail.com>
2018-02-26Update git submodulesLaura Sofia Enriquez1-0/+0
* Update docs/submodules/container4nfv from branch 'master' - Clearwater implementation for OPNFV K8S version 1.9 Clearwater deployment from source code using k8s v1.9. Tests added. Change-Id: Ifde573768721871b441ecb06a60ac25c0519b73d Signed-off-by: Laura Sofia Enriquez <lsofia.enriquez@gmail.com>
2018-02-26Update git submodulesMarkos Chandras1-0/+0
* Update docs/submodules/releng-xci from branch 'master' - Merge "xci: osa: configure-opnvhost: Set time in the opnfv node" - xci: osa: configure-opnvhost: Set time in the opnfv node Set the time properly in the opnfv node like we do for the target hosts Change-Id: I97d9f875dbb37db3cedd87e5915bc5b5f9a7a0ad Signed-off-by: Markos Chandras <mchandras@suse.de>