summaryrefslogtreecommitdiffstats
path: root/docs/submodules
AgeCommit message (Collapse)AuthorFilesLines
2018-04-04Update git submodulesahothan1-0/+0
* Update docs/submodules/nfvbench from branch 'master' - [NFVBENCH-81]With some Intel X710 NIC cards, NFVbench reports erroneous RX counters Work around this NIC FW issue by using port level stats for packets/bytes ALso fix mutliple calls to get_stats() Change-Id: Id19086d0db6bcc4417adff4ed4ce9606ffb30fe2 Signed-off-by: ahothan <ahothan@cisco.com>
2018-04-04Update git submodulesTrevor Bramwell1-0/+0
* Update docs/submodules/releng from branch 'master' - Merge "Late tagging of ms7 branch" - Late tagging of ms7 branch Change-Id: Ic8a84f6118d403bb618863b8904e78e9e9daac2b Signed-off-by: spisarski <s.pisarski@cablelabs.com>
2018-04-04Update git submodulesCédric Ollivier1-0/+0
* Update docs/submodules/functest from branch 'master' - Remove NetVirt from installer dependencies Change-Id: Idb937b3ed4896208048b90b705dc3e6db6104b60 Signed-off-by: Cédric Ollivier <cedric.ollivier@orange.com>
2018-04-04Update git submodulesCédric Ollivier1-0/+0
* Update docs/submodules/functest from branch 'master' - Remove opnfv/functest-restapi REST api server should run on top of all Functest containers by overriding the default command. We can safely remove it and meet the Docker Slicing approach. Change-Id: Ibcc56490c931ae701bd31c52650081a115183e22 Signed-off-by: Cédric Ollivier <cedric.ollivier@orange.com>
2018-04-04Update git submodulesxudan1-0/+0
* Update docs/submodules/dovetail from branch 'master' - Decoupling Functest Docker config items from source code There are some special Docker setting item when creating Functest Containers. 1. Remove the extra settings which are required by Functest Danube. 2. Remove the settings for pushing results to DB because Dovetail plans to disable this function. 3. Move the other special Functest settings to config files. JIRA: DOVETAIL-639 Change-Id: Ibc4090b5c0aafdf9ed64e65a9a92e34a12a16df5 Signed-off-by: xudan <xudan16@huawei.com>
2018-04-04Update git submodulesMoshe1-0/+0
* Update docs/submodules/dovetail from branch 'master' - Integrate dovetail with ONAP Change-Id: I6a1fa5f27df2f5127eb00156b3135dc79caf5e77 Issue-ID: DOVETAIL-629 Signed-off-by: Moshe <moshehoa@amdocs.com>
2018-04-04Update git submodulesSerena Feng1-0/+0
* Update docs/submodules/releng from branch 'master' - Merge "Add parser branch file" - Add parser branch file Change-Id: I404599185f65e0a128985552f430dc53cf47e866 Signed-off-by: shangxdy <shang.xiaodong@zte.com.cn>
2018-04-04Update git submodulesJose Lausuch1-0/+0
* Update docs/submodules/vswitchperf from branch 'master' - Add sshpass lib for Suse distros This patch completes https://gerrit.opnfv.org/gerrit/#/c/52191 Change-Id: I35259bdcbdb67237576d7b9b6957266c48f6309f Signed-off-by: Jose Lausuch <jalausuch@suse.com>
2018-04-04Update git submodulesEmma Foley1-0/+0
* Update docs/submodules/yardstick from branch 'master' - [userguide] Use literalinclude directive in 05-operation Uses literalinclude directive instead of having a copy of the file content in documentation. This means that any update to this file is detected, and the most up-to-date content is used. If a testcase is updated, the updates wil be picked up. The examples used are ones that are tested reqularly. JIRA: YARDSTICK-1066 Change-Id: I15d967eb04d1e6f4348683d8746fa9989dceda94 Signed-off-by: Emma Foley <emma.l.foley@intel.com> - [docs] update the user guide for "yardstick-operation" * Add a new chapter: operation which shows how to use Yardstick and how to create test cases * Include details on how to reuse and keep VNFs between testcases JIRA: YARDSTICK-885 JIRA: YARDSTICK-886 Change-Id: I365152e8812427a3c54259adbc18d5ddb216d775 Signed-off-by: Emma Foley <emma.l.foley@intel.com> - [docs] Move user guide chapters to make room for new chapter. * Increment the numbering on chapters * Fix some of the changes flagged by doc8 Change-Id: Ie03d165297671dfd50b9de339612cdc8bf00b988 Signed-off-by: Emma Foley <emma.l.foley@intel.com>
2018-04-04Update git submodulesSerena Feng1-0/+0
* Update docs/submodules/releng from branch 'master' - Merge "[daisy] Support doctor in daisy master branch" - [daisy] Support doctor in daisy master branch Change-Id: Ia7c76da78242f2a3906431e0d301f20aeeb460b3 Signed-off-by: Alex Yang <yangyang1@zte.com.cn>
2018-04-04Update git submodulesSerena Feng1-0/+0
* Update docs/submodules/releng from branch 'master' - Merge "[daisy]Enable jobs for stable/fraser branch" - [daisy]Enable jobs for stable/fraser branch Now we have had the stable/fraser branch in place [1]. Let's Re-arrange CI resources for it. [1] https://gerrit.opnfv.org/gerrit/#/c/54693/ Change-Id: Id596b1070c781da4edfd2496a47ea36400268614 Signed-off-by: Zhijiang Hu <hu.zhijiang@zte.com.cn>
2018-04-04Update git submodulesSerena Feng1-0/+0
* Update docs/submodules/releng from branch 'master' - Merge "[QTIP] extend the timeout" - [QTIP] extend the timeout The test execution time for VM costs around 1hr and 30 min. Need to extend the timeout. Change-Id: I6f83dc5ed8c5c1ae76b6e6e33758bfdb254aef23 Signed-off-by: zhihui wu <wu.zhihui1@zte.com.cn>
2018-04-04Update git submodulesSerena Feng1-0/+0
* Update docs/submodules/releng from branch 'master' - Merge "add a default value for SSH_KEY" - add a default value for SSH_KEY Change-Id: I6b7d3a35cf9609e983e76b8c8d76757a99bbe15f Signed-off-by: dongwenjuan <dong.wenjuan@zte.com.cn>
2018-04-04Update git submodulesMartin Klozik1-0/+0
* Update docs/submodules/vswitchperf from branch 'master' - scapy: Fix scapy import in Xena Remove unnecessary scapy import, which is causing pylint error with recent pylint version. JIRA: VSPERF-566 Change-Id: I082de0e93242486248beaed6822a8d0f30fff7e5 Signed-off-by: Martin Klozik <martinx.klozik@intel.com> Reviewed-by: Al Morton <acmorton@att.com> Reviewed-by: Christian Trautman <ctrautma@redhat.com> Reviewed-by: Sridhar Rao <sridhar.rao@spirent.com>
2018-04-04Update git submodulesQiLiang1-0/+0
* Update docs/submodules/clover from branch 'master' - Add clover initial docker image build script - install dependent deb/pip packages - install basic tools istioctl, kubectl - install clover source code - build/upload docker image script - update requirements.txt - update module import path - To use this image use need setup kube-config file. e.g. `docker run -v /root/config:/root/.kube/config -it clover bash` Change-Id: I91044bb99ce8e2b785ef03212d961a97b3d42233 Signed-off-by: QiLiang <liangqi1@huawei.com>
2018-04-04Update git submodulesZhijiang Hu1-0/+0
* Update docs/submodules/daisy from branch 'master' - upadate doc about error recovery level 3 Change-Id: Id6957830b0fa036c3b68d3ae1ef545c69cd26dce Signed-off-by: Zhijiang Hu <hu.zhijiang@zte.com.cn>
2018-04-03Update git submodulesKerim Gokarslan1-0/+0
* Update docs/submodules/nfvbench from branch 'master' - NFVBENCH-79 TRex latency stats requires at least 18B payload size Change-Id: I4add34e853d5b5a37efc877eb183a1fdc622d78a Signed-off-by: Kerim Gokarslan <kgokarsl@cisco.com>
2018-04-03Update git submodulesAlexandru Avadanii1-0/+0
* Update docs/submodules/armband from branch 'master' - p/fuel: Fix ga-16.04 MaaS kernel to be hwe-edge While at it, bump & rebase for ODL VM memory bump & Pike staging PPA, handle architecture list for pike-staging PPA. Change-Id: I13cdeef0ae2167ff1b7e6dd9c188dfbdcf18d9a1 Signed-off-by: Alexandru Avadanii <Alexandru.Avadanii@enea.com>
2018-04-03Update git submodulesTrevor Bramwell1-0/+0
* Update docs/submodules/releng from branch 'master' - Merge "Create Stable Branch Jobs for joid" - Create Stable Branch Jobs for joid Change-Id: Ia810443a15d32e58262089de30e9b88655b5a7d4 Signed-off-by: jenkins-ci <jenkins-opnfv-ci@opnfv.org> Signed-off-by: Trevor Bramwell <tbramwell@linuxfoundation.org>
2018-04-03Update git submodulesMichael Polenchuk1-0/+0
* Update docs/submodules/fuel from branch 'master' - Remove opendaylight service mask Nitrogen SR2 brought in weird behaviour into netvirt feature configuration causing malfunction tunnels between client nodes (e.g. gateway, computes). In order to work properly service of opendaylight requires an explicit restart or reload by means of salt formula. Change-Id: I277da5ad2787f1005647e500b64c7ffa6051443b Signed-off-by: Michael Polenchuk <mpolenchuk@mirantis.com>
2018-04-03Update git submodulesTrevor Bramwell1-0/+0
* Update docs/submodules/releng from branch 'master' - Merge "create stable/fraser branch for samplevnf" - create stable/fraser branch for samplevnf Change-Id: Iee00a91274057611ce1e21a8c146ad26c9ba3aae Signed-off-by: Deepak S <deepak.s@linux.intel.com>
2018-04-03Update git submodulesTim Rozet1-0/+0
* Update docs/submodules/releng from branch 'master' - Merge "Create Stable Branch Jobs for apex" - Create Stable Branch Jobs for apex Change-Id: I7f6072121c4d88192c828e2e3cf2beb5d6c22c37 Signed-off-by: jenkins-ci <jenkins-opnfv-ci@opnfv.org> Signed-off-by: Trevor Bramwell <tbramwell@linuxfoundation.org>
2018-04-03Update git submodulesTrevor Bramwell1-0/+0
* Update docs/submodules/releng from branch 'master' - Merge "[storperf] Add stable/fraser branch" - [storperf] Add stable/fraser branch Doing this on behalf of Mark Beirel at the request of David McBride. Change-Id: I2eb2be5a2d2241dac07fe41f2158cffbe97865e0 Signed-off-by: Trevor Bramwell <tbramwell@linuxfoundation.org>
2018-04-03Update git submodulesTrevor Bramwell1-0/+0
* Update docs/submodules/releng from branch 'master' - Merge "Stable branch for FDS" - Stable branch for FDS Change-Id: I19f41ba55db9aec060383d78c6a49b9e8a9f9400 Signed-off-by: Frank <fbrockne@cisco.com> Signed-off-by: Trevor Bramwell <tbramwell@linuxfoundation.org>
2018-04-03Update git submodulesTrevor Bramwell1-0/+0
* Update docs/submodules/releng from branch 'master' - Merge "Apex: Adds branch creation for Fraser" - Apex: Adds branch creation for Fraser Change-Id: I6715f6795e9a02b2f1aabee80ea79cf9fcdf732c Signed-off-by: Tim Rozet <trozet@redhat.com>
2018-04-03Update git submodulesTrevor Bramwell1-0/+0
* Update docs/submodules/releng from branch 'master' - Merge "Stable Branch Creation: vswitchperf" - Stable Branch Creation: vswitchperf Change-Id: I21c4b67e54a7af8a1ce7d9e51ffa7255c55a87d6 Signed-off-by: Sridhar K. N. Rao <sridhar.rao@spirent.com>
2018-04-03Update git submodulesTrevor Bramwell1-0/+0
* Update docs/submodules/releng from branch 'master' - Merge "created the Frasier release stable branch." - created the Frasier release stable branch. Change-Id: I08e42a0aaae6414d0614d06ca750ea3c055a26f8 Signed-off-by: Narinder Gupta <narinder.gupta@canonical.com>
2018-04-03Update git submodulesAric Gardner1-0/+0
* Update docs/submodules/releng from branch 'master' - Merge "Enable linting against the Fraser stable branch" - Enable linting against the Fraser stable branch Change-Id: I8075eee7de9a5bd1274131c5171c22e5dace5b69 Signed-off-by: Trevor Bramwell <tbramwell@linuxfoundation.org>
2018-04-03Update git submodulesTrevor Bramwell1-0/+0
* Update docs/submodules/releng from branch 'master' - Merge "[ovn4nfv] Stable branch for Fraser release." - [ovn4nfv] Stable branch for Fraser release. Change-Id: Ia303020d746ec5ebf0c4ac5771d755ba8585cf8c Signed-off-by: Trinath Somanchi <trinath.somanchi@nxp.com>
2018-04-03Update git submodulesTrevor Bramwell1-0/+0
* Update docs/submodules/releng from branch 'master' - Merge "Build opnfv/functest-x:fraser" - Build opnfv/functest-x:fraser Change-Id: I47891ae4b0f48234731043822abe9c54fc7a7655 Signed-off-by: Cédric Ollivier <cedric.ollivier@orange.com>
2018-04-03Update git submodulesManuel Buil1-0/+0
* Update docs/submodules/sfc from branch 'master' - Fix flake8 problems There was a bug in releng and pylint was not ran, some issues got merged in master because of that Change-Id: Icf3fa882f4f2b0593fa0b85edce46e49dcc303c9 Signed-off-by: Manuel Buil <mbuil@suse.com>
2018-04-03Update git submodulesmbeierl1-0/+0
* Update docs/submodules/storperf from branch 'master' - Nomination of Shrenik Jain as commiter Change-Id: Ia0ef7b449d2cf8214ef8f0e535d58c719a93d909 Signed-off-by: mbeierl <mark.beierl@dell.com>
2018-04-03Update git submodulesAaron Smith1-0/+0
* Update docs/submodules/barometer from branch 'master' - Merge "Update repo link for collectd-ceilometer-plugin" - Update repo link for collectd-ceilometer-plugin Since Ceilometer support was removed from the collectd-ceilometer-plugin[1], the repo name is misleading. So the repo name needed to be updated [2] This change updates references to the collectd-ceilometer-plugin repo to point to collectd-openstack-plugins repo: * in deployment operations * in documentation i.e. links to docs Dependencies: [1] https://review.openstack.org/#/c/490823/ [2] https://review.openstack.org/#/c/500768/ This is dependant on the repo rename Change-Id: I43facbd53bca5df3f7e51d978ae2843c187282d4 Signed-off-by: Emma Foley <emma.l.foley@intel.com>
2018-04-03Update git submodulesAric Gardner1-0/+0
* Update docs/submodules/releng from branch 'master' - Merge "Include 'opnfv-pylint-verify-stream' to job list" - Include 'opnfv-pylint-verify-stream' to job list This job was not being created because it was missing from the jobs list in the file. Change-Id: Ibd66c6b654421e63f23738d6eecdca93aecf86cc Signed-off-by: Trevor Bramwell <tbramwell@linuxfoundation.org>
2018-04-03Update git submodulesReemMahmoud1-0/+0
* Update docs/submodules/moon from branch 'master' - Rename test_models of unit_python Add licences in some files. Change-Id: I7c473efcdb228cc030501328d93b5a6265917591 Signed-off-by: ReemMahmoud <rfawzy.ext@orange.com>
2018-04-03Update git submodulesYang Yu1-0/+0
* Update docs/submodules/releng from branch 'master' - Add Bottlenecks branching file Change-Id: Iffd5695189e21f647c8109f440044079bdbc36fd Signed-off-by: Yang Yu <Gabriel.yuyang@huawei.com>
2018-04-03Update git submodulesMarkos Chandras1-0/+0
* Update docs/submodules/releng-xci from branch 'master' - Merge changes from topic 'misc-simplifications-osa' * changes: xci: bootstrap-host: Make active network interface consistent xci: osa: Simplify tasks for copying OSA configuration files xci: Use proper Ansible modules to manage SSH keys - xci: bootstrap-host: Make active network interface consistent When we run XCI for the first time, Ansible picks the first active interface as the default one. However, after we configure all the XCI bridges etc, and we try to run this role again, Ansible may have changed its mind about what interface is active and it could default to one of the bridges. This forces the role to redo the network configuration but this time the bridges are being attached to bridges so everything goes terribly wrong after that. The way to solve this would be to add a local fact about what interface should be considered as the 'real' default one so subsequent calls to this role to not destroy the network. This also drops the task which removed the network configuration files on SUSE platforms since Ansible is smart enough to not touch them if they are configured properly. Change-Id: Ic0525e934b1934a40d69e6cf977615ab9b3dac6d Signed-off-by: Markos Chandras <mchandras@suse.de> - xci: osa: Simplify tasks for copying OSA configuration files We can use a loop to copy all these files instead of multiple tasks. This simplifies the playbook quite a bit. Change-Id: I5f0d387ac090d81fc577b5ebeaeb6131e75cffa1 Signed-off-by: Markos Chandras <mchandras@suse.de> - xci: Use proper Ansible modules to manage SSH keys We can use the 'user', 'slurp' and 'authorized_key' modules to manage the various SSH configurations across the hosts instead of using command line tools. Change-Id: I2dde4d584fc336e267868607d5a58f5ee2c1feed Signed-off-by: Markos Chandras <mchandras@suse.de>
2018-04-03Update git submodulesFatih Degirmenci1-0/+0
* Update docs/submodules/releng-xci from branch 'master' - shabump: Bump SHAs to bring cinder, lxc_hosts, and pip fixes in This change brings the fix for - cinder haproxy check for ha deployments - pip related fixes - fixes for lxc_hosts Change-Id: I4af64041a4a76c10361456f73577e7c7040edf8a Signed-off-by: Fatih Degirmenci <fdegir@gmail.com>
2018-04-03Update git submodulesHarry Huang1-0/+0
* Update docs/submodules/compass4nfv from branch 'master' - Fix pip version to 9.0.1 JIRA: COMPASS-593 OpenStack Ansible install latest pip on each contoller node and the latest pip (currently 10.0.0b1) doesn't support empty package list to be passed into it. Add a user config file to fix pip version. Change-Id: Ie193389c2b4995cdc4b81876f8cdcfc512cf5ea1 Signed-off-by: Harry Huang <huangxiangyu5@huawei.com>
2018-04-03Update git submodulesMartin Klozik1-0/+0
* Update docs/submodules/vswitchperf from branch 'master' - Merge "Fix packages for SLES15" - Fix packages for SLES15 Change-Id: Id01c4f76c146a0f0630bf1926ece48aabff0bfa1 Signed-off-by: Jose Lausuch <jalausuch@suse.com>
2018-04-03Update git submodulesMartin Klozik1-0/+0
* Update docs/submodules/vswitchperf from branch 'master' - Merge "python: Pylint 1.8.2 code conformity" - python: Pylint 1.8.2 code conformity Updated master Python scripts to conform to the newer pylint 1.8.2 standard. JIRA: VSPERF-563 Change-Id: I19305a008a2e22c2f4841aa83fed85fbdc2d549c Signed-off-by: Richard Elias <richardx.elias@intel.com> Reviewed-by: Martin Klozik <martinx.klozik@intel.com> Reviewed-by: Al Morton <acmorton@att.com> Reviewed-by: Christian Trautman <ctrautma@redhat.com> Reviewed-by: Sridhar Rao <sridhar.rao@spirent.com>
2018-04-03Update git submodulesMartin Klozik1-0/+0
* Update docs/submodules/vswitchperf from branch 'master' - Merge "scapy: Fix conflict of scapy libraries" - scapy: Fix conflict of scapy libraries T-Rex requires a modified version of SCAPY library for python3 to function properly. It doesn't work with vanilla version of scapy-python3 module, which is installed within vsperf environment by pip for Xena. Currently vanilla scapy is imported by Xena and enforced to T-Rex too, which causes following issues: * missing implementation of Dot1AD causes failures * broken multistream feature in T-Rex VSPERF loads all Traffic Generator classes and thus all imports performed at module level are performed. The solution would be to import SCAPY module by Xena only in case, that Xena traffic generator is really used. Please see JIRA for additional information. JIRA: VSPERF-566 Change-Id: I8018bc0126e752cc9f966252d17dadb6a5554b37 Signed-off-by: Martin Klozik <martinx.klozik@intel.com> Reviewed-by: Al Morton <acmorton@att.com> Reviewed-by: Christian Trautman <ctrautma@redhat.com> Reviewed-by: Sridhar Rao <sridhar.rao@spirent.com>
2018-04-03Update git submodulesMartin Klozik1-0/+0
* Update docs/submodules/vswitchperf from branch 'master' - Merge "ovs: Configurable arguments of ovs-*ctl" - ovs: Configurable arguments of ovs-*ctl This patch introduces new configuration parameters OVS_OFCTL_ARGS, OVS_VSCTL_ARGS and OVS_APPCTL_ARGS, which specify default arguments passed to respective ovs-*ctl tools. So user can specify default arguments passed to these tools inside configuration file, testcase parameters or by --test-params option. For example OVS_OFCTL_ARGS can be modified to use different OpenFlow version by default. JIRA: VSPERF-567 Change-Id: Ie7448ea94a54b8044af12d0246d66514e057b7dc Signed-off-by: Martin Klozik <martinx.klozik@intel.com> Reviewed-by: Al Morton <acmorton@att.com> Reviewed-by: Christian Trautman <ctrautma@redhat.com> Reviewed-by: Sridhar Rao <sridhar.rao@spirent.com> Reviewed-by: Richard Elias <richardx.elias@intel.com>
2018-04-03Update git submodulesIgor Shaula1-0/+0
* Update docs/submodules/samplevnf from branch 'master' - Support additional MAC format in config file Add support for space-divided bytes in MAC string. Support the same format as in "pkt inline". Change-Id: I7f2136c4424c45ce4abad4082470c9c9b1b3ab05 Signed-off-by: Igor Shaula <igor.shaula@intel.com>
2018-04-03Update git submodulesGuo Ruijing1-0/+0
* Update docs/submodules/container4nfv from branch 'master' - fix deployment failure Change-Id: I6145b406450b0846999223f1e4e6783eb06bb0a9 Signed-off-by: Guo Ruijing <ruijing.guo@intel.com>
2018-04-03Update git submodulesZhijiang Hu1-0/+0
* Update docs/submodules/daisy from branch 'master' - kolla-build-vm.sh is ready for Queens This PS does: 1. Set default build target to stable/queens, but still fix to pike for OPNFV master branch, please see line:83 2. Create mappings between branch name and version number in code, since upstream kolla does not do it automatically using git tag for us start from Queens relese. Therefore, we do not need to let the user to define the version code and then check it with git tag command return value any more. So -t argument is deleted. 3. Support building Queens images. 4. Arrange patches in sub-directories name by version code so that user can use this one script to patch and build any version they want. But for OPNFV Jenkins, only the version for the current branch can be built according to the -j argument. 5. Upgrade DPDK version from 16.11 to 17.02. 6. Call cleanup_registry_server before pack_registry_data, this is resonable for keeping registry data stable. Change-Id: Ic5a7e2da261d456a2a1481ad0e765a7ce28b8121 Signed-off-by: Zhijiang Hu <hu.zhijiang@zte.com.cn>
2018-04-02Update git submodulesTrevor Bramwell1-0/+0
* Update docs/submodules/releng from branch 'master' - Merge "[daisy] Stable branch creation for fraser" - [daisy] Stable branch creation for fraser Change-Id: Id4ae29b09e909445e7a524663981d0b7aca5e5f0 Signed-off-by: Zhijiang Hu <hu.zhijiang@zte.com.cn>
2018-04-02Update git submodulesTrevor Bramwell1-0/+0
* Update docs/submodules/releng from branch 'master' - Merge "[fuel] Add stable/fraser branch" - [fuel] Add stable/fraser branch Change-Id: Ieca49ab172046d22f421eb6adb6f238c38b8e2f1 Signed-off-by: Delia Popescu <delia.popescu@enea.com>
2018-04-02Update git submodulesTrevor Bramwell1-0/+0
* Update docs/submodules/releng from branch 'master' - Merge "[armband] Add stable/fraser branch" - [armband] Add stable/fraser branch Change-Id: I619dfb48fb0cfca1b8b3a315760bb684de720f7c Signed-off-by: Delia Popescu <delia.popescu@enea.com>
2018-04-02Update git submodulesTrevor Bramwell1-0/+0
* Update docs/submodules/releng from branch 'master' - Merge "Clover project stable branch for OPNFV Fraser release" - Clover project stable branch for OPNFV Fraser release Change-Id: Ibbee8bbd4174ad3bb6d8e3c8a855263b91481712 Signed-off-by: Stephen Wong <stephen.kf.wong@gmail.com>