summaryrefslogtreecommitdiffstats
path: root/docs/submodules
AgeCommit message (Collapse)AuthorFilesLines
2018-03-13Update git submodulesLinda Wang1-0/+0
* Update docs/submodules/functest from branch 'master' - Fix tempest_custom Change-Id: I684c06eae899d9bc468e0be6a1537f9c942e86ce Signed-off-by: Linda Wang <wangwulin@huawei.com>
2018-03-13Update git submodulesManuel Buil1-0/+0
* Update docs/submodules/sfc from branch 'master' - Remove SNAPs deprecated method SNAPs is not supporting get_vm_info() anymore, we should remove it from our lib https://gerrit.opnfv.org/gerrit/#/c/53263/4 Change-Id: Idad1bb60b86c45256bb0a95b6c554e83e6bfae35 Signed-off-by: Manuel Buil <mbuil@suse.com>
2018-03-13Update git submodulesHarry Huang1-0/+0
* Update docs/submodules/auto from branch 'master' - Modify repo structure JIRA: - Work in progress Change-Id: I196753efd2da33cee5cc4afe932bbb2e07ca24d8 Signed-off-by: Harry Huang <huangxiangyu5@huawei.com>
2018-03-13Update git submodulesHarry Huang1-0/+0
* Update docs/submodules/auto from branch 'master' - Modify repo structure JIRA: - 1. keep modules in lib directory instead of auto Change-Id: Ie4c51b28554575bafbaa89c5f57309a786b903e0 Signed-off-by: Harry Huang <huangxiangyu5@huawei.com>
2018-03-13Update git submoduleszhihui wu1-0/+0
* Update docs/submodules/qtip from branch 'master' - Merge "Delete part of code under qtip/legacy" - Delete part of code under qtip/legacy These code is obsolete. Change-Id: I0fc2b12847aaa30f713cf7578a92aae912153dd6 Signed-off-by: zhihui wu <wu.zhihui1@zte.com.cn>
2018-03-13Update git submoduleszhihui wu1-0/+0
* Update docs/submodules/qtip from branch 'master' - Get Ansible to work with bare ubuntu 16.04 Bare ubuntu 16.04 doesn't have python2. [1] https://gist.github.com/gwillem/4ba393dceb55e5ae276a87300f6b8e6f. Change-Id: I677fe0b387826b0c94c8a819a6424d3f4e8a3448 Signed-off-by: zhihui wu <wu.zhihui1@zte.com.cn>
2018-03-13Update git submodulesYifei Xue1-0/+0
* Update docs/submodules/compass4nfv from branch 'master' - Merge "Modify deploy variable" - Modify deploy variable JIRA: - Under current deploy procedure, when compass containers are running, they will not be recreated during redeploy. Using DEPLOY_FIRST_TIME to determine to run the container create process when first time deploy Change-Id: Ic13fd84ed41afdad29c96f803feff3298cbbcfde Signed-off-by: Harry Huang <huangxiangyu5@huawei.com>
2018-03-13Update git submodulesRoss Brattain1-0/+0
* Update docs/submodules/yardstick from branch 'master' - Merge "Add support for VNC to VMs created by ansible" - Add support for VNC to VMs created by ansible JIRA: YARDSTICK-1017 Change-Id: I76ca53c12a6791ecbf7f546f9074b16c5f6d215a Signed-off-by: John O Loughlin <john.oloughlin@intel.com>
2018-03-13Update git submodulesRoss Brattain1-0/+0
* Update docs/submodules/yardstick from branch 'master' - Merge "[Bug Fix] Support nova create instance operation" - [Bug Fix] Support nova create instance operation Add the ability to create a nova instance through the operation perspective JIRA: YARDSTICK-1038 Change-Id: Idac141958d65cc6c53b6bd27df83ac74ae8804ec Signed-off-by: Dimitrios Markou <mardim@intracom-telecom.com>
2018-03-12Update git submodulesTim Rozet1-0/+0
* Update docs/submodules/apex from branch 'master' - Merge "Cherry-pick of L2GW environment file" - Cherry-pick of L2GW environment file It includes ODL L3 service plugin and trunk ports apex-tripleo-heat-templates: I37039207bc7cf9965d26e6dfa034e84bf9b7224d Change-Id: I29c398aabf9a2d1b98f76895ed73c01dcc008c19 Signed-off-by: Ricardo Noriega <rnoriega@redhat.com>
2018-03-12Update git submodulesAlexandru Avadanii1-0/+0
* Update docs/submodules/fuel from branch 'master' - Merge "[virtual/odl] Apply missing neutron.compute state" - [virtual/odl] Apply missing neutron.compute state Change-Id: I078e11219fb8dea4505c46e7f75c295c5a72c59b Signed-off-by: Michael Polenchuk <mpolenchuk@mirantis.com>
2018-03-12Update git submodulesAlexandru Avadanii1-0/+0
* Update docs/submodules/fuel from branch 'master' - Merge "Set volume_device_name variable" - Set volume_device_name variable This evironment variable is required by test suite to refer to an attached volume (vdb is reserved for config drive). JIRA: FUEL-353 Change-Id: I4f7c96b2344575fcd9b785e3c74b27ef4c4d64f8 Signed-off-by: Michael Polenchuk <mpolenchuk@mirantis.com>
2018-03-12Update git submodulesMichael Polenchuk1-0/+0
* Update docs/submodules/fuel from branch 'master' - Update patch with ovs bridges as L3 ifaces Apply this patch if protocol is set to static to be intended for the ip address settings action only. Change-Id: I758340ff22376c01edd2a9a3555fe0fd9db3f4a9 Signed-off-by: Michael Polenchuk <mpolenchuk@mirantis.com>
2018-03-12Update git submodulesCédric Ollivier1-0/+0
* Update docs/submodules/functest from branch 'master' - Remove orchestra testcases They are incompatible with Pike and they have to be removed without any deep update. The testcases will be re-renabled if updated before 03/16/18. Change-Id: Ibf656db6ba4177eae44feb41cd5d314b7408d4de Signed-off-by: Cédric Ollivier <cedric.ollivier@orange.com>
2018-03-12Update git submodulesFatih Degirmenci1-0/+0
* Update docs/submodules/releng-xci from branch 'master' - Merge "Combine vars setting installer type in INSTALLER_TYPE" - Combine vars setting installer type in INSTALLER_TYPE Change-Id: Ie196d1df537d09f0f91e43ab5e0305a45d543815 Signed-off-by: Fatih Degirmenci <fdegir@gmail.com>
2018-03-12Update git submodulesFatih Degirmenci1-0/+0
* Update docs/submodules/releng-xci from branch 'master' - Merge "Combine vars setting installer type in INSTALLER_TYPE" - Combine vars setting installer type in INSTALLER_TYPE Change-Id: I330bc036f901d4ba61bc94ee6e085cadf54b4d8b Signed-off-by: Fatih Degirmenci <fdegir@gmail.com>
2018-03-12Update git submodulesPeriyasamy Palanisamy1-0/+0
* Update docs/submodules/sdnvpn from branch 'master' - remove extra specs for the flavor It has problem in booting up VMs which are with custom flavor configured. So removing extra specs from the flavor which anyway is not needed. Change-Id: I38fe1449ea585a3a6db95a7f21fd1d3fca0f528e Signed-off-by: Periyasamy Palanisamy <periyasamy.palanisamy@ericsson.com>
2018-03-12Update git submodulesPeriyasamy Palanisamy1-0/+0
* Update docs/submodules/releng-xci from branch 'master' - remove .ansible directory It's needed to remove .ansible directory which could be a leftovers by some other ansible execution enviroment which would affect XCI deployment. Change-Id: Ic334ef1ca53878721762b23b238fe9a8aeefa0e0 Signed-off-by: Periyasamy Palanisamy <periyasamy.palanisamy@ericsson.com>
2018-03-12Update git submodulesspisarski1-0/+0
* Update docs/submodules/snaps from branch 'master' - Closing keystone sessions after done with them. By not closing all of the keystone sessions being created when running all of the tests, this may be the root cause to the IOError occasionally being observed: IOError: [Errno 24] Too many open files JIRA: SNAPS-285 Change-Id: I7fc7ab0c6cdd02f1ae32bb3ae4f121cb465d5693 Signed-off-by: spisarski <s.pisarski@cablelabs.com>
2018-03-12Update git submodulesCedric Ollivier1-0/+0
* Update docs/submodules/functest from branch 'master' - Merge "Stopping setting identity-feature-enabled if Patrole" - Stopping setting identity-feature-enabled if Patrole It avoids differing from all other tempest-based testcases for a useless config option. Change-Id: I02e1786f0ba3c1f7da11f258e80f57ca624247f9 Signed-off-by: Cédric Ollivier <cedric.ollivier@orange.com>
2018-03-12Update git submodulesCedric Ollivier1-0/+0
* Update docs/submodules/functest from branch 'master' - Merge changes from topic 'refactor_tempest' * changes: Rewrite refstack testcase Fix many pylint warnings - Rewrite refstack testcase It now leverages on rally to factorize code between all tempest-based testcases. refstack-client is also added as requirement. JIRA: FUNCTEST-942 Change-Id: Ieee845327f8736582d77b898edd6c9edd00667e0 Signed-off-by: Cédric Ollivier <cedric.ollivier@orange.com> - Fix many pylint warnings Only pylint warnings in vnf modules has to be fixed now. Change-Id: Ie71230072a51bb72ec0b1d4fef2652494d29948e Signed-off-by: Cédric Ollivier <cedric.ollivier@orange.com>
2018-03-12Update git submodulesCedric Ollivier1-0/+0
* Update docs/submodules/functest from branch 'master' - Merge changes from topic 'refactor_tempest' * changes: Refactor configure_tempest_patrole() Improve tempest files management - Refactor configure_tempest_patrole() Change-Id: I1c34b3bce68a7d57d63fb2e5e4b6aa003dda8f61 Signed-off-by: Cédric Ollivier <cedric.ollivier@orange.com> - Improve tempest files management Calling apply_tempest_blacklist() is no longer mandatory. Change-Id: Id9a4e970c8acca066a36be89920745127867cd63 Signed-off-by: Cédric Ollivier <cedric.ollivier@orange.com>
2018-03-12Update git submodulesspisarski1-0/+0
* Update docs/submodules/snaps from branch 'master' - Added members to VmInst that will contain the availability_zone and compute_host names while deprecating the method get_vm_info(). JIRA: SNAPS-277 Change-Id: Idc8578b3f2cf2be8ef90f52dd025dbea729b222b Signed-off-by: spisarski <s.pisarski@cablelabs.com>
2018-03-12Update git submodulesAlexandru Avadanii1-0/+0
* Update docs/submodules/fuel from branch 'master' - lib.sh: Add missing `sudo` for `losetup` Change-Id: I1c5e3d7a0dbac14bf242730d6ac8d2b1d0817907 Signed-off-by: Alexandru Avadanii <Alexandru.Avadanii@enea.com>
2018-03-12Update git submodulesMarkos Chandras1-0/+0
* Update docs/submodules/releng-xci from branch 'master' - xci: Drop the python-crypto dependency The upstream pw-token-gen tool doesn't need python-crypto anymore since e9f957861b4160640f6debb2b939084ec43b43b2 ("Make pw-token-gen.py more random") so we no longer need to install that package. Change-Id: Ib53f246db999ff8ecfed2e3f62143c780c483fbd Signed-off-by: Markos Chandras <mchandras@suse.de>
2018-03-12Update git submodulesFatih Degirmenci1-0/+0
* Update docs/submodules/releng from branch 'master' - Merge "Temporary incease functest timeout to 360 minutes" - Temporary incease functest timeout to 360 minutes Openstack APIs response call is tacking very long on ARM Work is being done on fixing the issue Temporary increase functest timeout on x86 too because of COMPASS JIRA: ARMBAND-366 JIRA: COMPASS-589 Change-Id: I355500da56c5a040324c0969237ac2decfd29edf Signed-off-by: Delia Popescu <delia.popescu@enea.com>
2018-03-12Update git submodulesPeriyasamy Palanisamy1-0/+0
* Update docs/submodules/sdnvpn from branch 'master' - testcase execution halt fix It's found that sys.exit is used in utils.py which caused testcase execution is stopped abruptly while running bgpvpn testsuite. This is now replaced with Exception. Change-Id: I69df4be705985994318f58d57b152d6db4087610 Signed-off-by: Periyasamy Palanisamy <periyasamy.palanisamy@ericsson.com>
2018-03-12Update git submodulesFatih Degirmenci1-0/+0
* Update docs/submodules/releng from branch 'master' - xci: Combine vars setting installer type in INSTALLER_TYPE Change-Id: I5312ac784b1621ce968bbdfb1532859dada0e790 Signed-off-by: Fatih Degirmenci <fdegir@gmail.com>
2018-03-12Update git submodulesHarry Huang1-0/+0
* Update docs/submodules/auto from branch 'master' - Update the docs JIRA: - On behalf of Gerard Damm to commit his codes. Keep docs in auto/docs. Change-Id: I37163bd8af7ce34af0342082fa2b9fdd9357acda Signed-off-by: Harry Huang <huangxiangyu5@huawei.com>
2018-03-12Update git submodulesAsteroide1-0/+0
* Update docs/submodules/moon from branch 'master' - Merge "remove duplicated functions" - remove duplicated functions Change-Id: Ie118fd322d1426bd5e2c434e4c56e9b08d75521b
2018-03-12Update git submodulesEmma Foley1-0/+0
* Update docs/submodules/yardstick from branch 'master' - Merge changes from topics 'delete_router', 'neutron_subnet_create', 'neutron_create' * changes: Replace neutron router deletion with shade. Replace neutron subnet creation with shade. Replace neutron network creation with shade. - Replace neutron router deletion with shade. Function delete_neutron_router now uses shade client instead of neutron client. JIRA: YARDSTICK-890 Change-Id: I5b557b640396f343b85b5f5eff415384decc083c Signed-off-by: Shobhi Jain <shobhi.jain@intel.com> - Replace neutron subnet creation with shade. Function 'create_neutron_subnet' now uses shade client instead of neutron client. JIRA: YARDSTICK-890 Change-Id: I8eb5295cecd73742bfb5a7d0764af6f45ef0685e Signed-off-by: Shobhi Jain <shobhi.jain@intel.com> - Replace neutron network creation with shade. Function create_neutron_net now uses shade client instead of neutron client. JIRA: YARDSTICK-890 Change-Id: I456078e98550901c1f736640c9f9bd0d5f9c3df6 Signed-off-by: Shobhi Jain <shobhi.jain@intel.com>
2018-03-12Update git submodulesAsteroide1-0/+0
* Update docs/submodules/moon from branch 'master' - Merge "Fix a bug in policy generation." - Fix a bug in policy generation. Change-Id: Id30decb5e8519c091f8eaa95c04c2865fcbd7091
2018-03-12Update git submodulesFatih Degirmenci1-0/+0
* Update docs/submodules/releng from branch 'master' - Merge "xci: Set installer type for the tested scenario" - xci: Set installer type for the tested scenario Variables injected by envInject are set after the job variables which results in not setting the variable correctly. The Jenkins test script now uses the variable injected by envInject to set the INSTALLER_TYPE to XCI_INSTALLER. Change-Id: Id79281a2ee22d407ffb1bd7c4be1471f6f329803 Signed-off-by: Fatih Degirmenci <fdegir@gmail.com>
2018-03-12Update git submodulesAsteroide1-0/+0
* Update docs/submodules/moon from branch 'master' - Merge "allow to have several policies in perimeter data json definition" - allow to have several policies in perimeter data json definition Change-Id: Id422a545e2495b3acc3fc6e71496e76dfc2cbd90
2018-03-12Update git submodulesFatih Degirmenci1-0/+0
* Update docs/submodules/releng from branch 'master' - xci: Skip functest healtcheck if it is Kubernetes scenario We need to work on functest healthcheck for Kubernetes scenarios. Until we get it working, healthcheck is disabled. Change-Id: If470dbe956c5859825f0829d1f8d022bdafcc242 Signed-off-by: Fatih Degirmenci <fdegir@gmail.com>
2018-03-12Update git submodulesFatih Degirmenci1-0/+0
* Update docs/submodules/releng from branch 'master' - xci: Determine impacted generic scenario Change-Id: Ifbe676cd347c2d3c68f04b5137f3ccaa83a95894 Signed-off-by: Fatih Degirmenci <fdegir@gmail.com>
2018-03-12Update git submodulesFatih Degirmenci1-0/+0
* Update docs/submodules/releng from branch 'master' - xci: Set the installer and move scenario extraction into functions The scenarios named os-* are deployed by osa and the ones named k8-* are deployed by kubespray. This change determines the installer to use by looking into the scenario name. The installers are currently hardcoded within xci-set-scenario.sh script and this needs to be fixed for other installers when they onboard to xci. Apart from setting the installer, extraction of generic and external scenarios are moved into corresponding functions. Change-Id: I19882bcd2a1260765e601ecbe517551c60401d74 Signed-off-by: Fatih Degirmenci <fdegir@gmail.com>
2018-03-12Update git submodulesvalentin boucher1-0/+0
* Update docs/submodules/functest from branch 'master' - Merge "Add patrole in opnfv/functest-restapi" - Add patrole in opnfv/functest-restapi Change-Id: I983898c27477986d9a5610e1df966fd00a8bc785 Signed-off-by: Cédric Ollivier <cedric.ollivier@orange.com>
2018-03-12Update git submodulesAbhijit Sinha1-0/+0
* Update docs/submodules/yardstick from branch 'master' - Merge "Add context name to Dummy test" - Add context name to Dummy test Since I1447fb5ed447691eaeb0a97f928c0b3333799d07, the context name is a mandatory parameter for every context. JIRA: YARDSTICK-886 Change-Id: I0ccb7e9fabdf6bc2890d2e4763f53baee06c87b2 Signed-off-by: Rodolfo Alonso Hernandez <rodolfo.alonso.hernandez@intel.com>
2018-03-12Update git submodulesEmma Foley1-0/+0
* Update docs/submodules/yardstick from branch 'master' - Merge "Reduce the log level if TRex client is no connected" - Reduce the log level if TRex client is no connected If the TRex client is no connected, the testcase will write an exception log that will be thrown to the CLI. There is no need to show the traceback in the CLI in this case. The log level is reduced to "error". JIRA: YARDSTICK-1059 Change-Id: I22a52cedd6479f4cf692ba16a8415f7b8f574ab1 Signed-off-by: Rodolfo Alonso Hernandez <rodolfo.alonso.hernandez@intel.com>
2018-03-12Update git submodulesRodolfo Alonso Hernandez1-0/+0
* Update docs/submodules/yardstick from branch 'master' - Merge "assertTrue(mock.called) -> mock.assert_called" - assertTrue(mock.called) -> mock.assert_called When checking whether a mocked method has been called, mock.assert_called or mock.assert_called_once should be used, and not unittest.assertTrue(mock.called) This change does this update. It can be verified with: grep -irn "self.assertTrue(.*called)" --exclude-dir=.tox And the replacement was done with: sed -i 's/self.assertTrue(\(.*\).called)/\1.assert_called_once()/g' <list_of_files> Change-Id: I4f26e0c736bf33e0b2413c8e8c33dbdb91f090e2 JIRA: YARDSTICK-865 Signed-off-by: Emma Foley <emma.l.foley@intel.com>
2018-03-12Update git submodulesMarkos Chandras1-0/+0
* Update docs/submodules/releng from branch 'master' - Merge "jjb: xci: Drop the VM cleanup step from the functest jobs" - jjb: xci: Drop the VM cleanup step from the functest jobs We do the VM cleanup as part of the postbuild process so we do not need to have it in the functest jobs anymore. Change-Id: I64e4b58837090df33ae529232ef15a19de8f198a Signed-off-by: Markos Chandras <mchandras@suse.de>
2018-03-12Update git submodulesMarkos Chandras1-0/+0
* Update docs/submodules/releng from branch 'master' - Merge "xci: Set options in run-functest.sh" - xci: Set options in run-functest.sh Functest healthcheck job actually fails but due to not setting options properly in run-functest.sh, we failed to notice this. Please note that this patch will enable changes to be blocked since creation of external network and associated subnet fail, due to an upstream issue. This causes functest healthcheck to fail which in turn results in Verified-1 on Gerrit. Change-Id: I32eeb422895930d039d3289ffb65e10763db9c4b Signed-off-by: Fatih Degirmenci <fdegir@gmail.com>
2018-03-12Update git submodulesRoss Brattain1-0/+0
* Update docs/submodules/yardstick from branch 'master' - Merge "Update the fuel pod.yaml" - Update the fuel pod.yaml Fuel except Controller and Compute nodes it deploys an ODL node in noHA and HA deployment and also a Gateway node in a noHA deployment. So it is essential to describe them in Fuel's pod. JIRA: YARDSTICK-1050 Change-Id: Iee6c25c5b2e2e4e661ceb0591bf2437f7f7fa7f8 Signed-off-by: Dimitrios Markou <mardim@intracom-telecom.com>
2018-03-12Update git submodulesRoss Brattain1-0/+0
* Update docs/submodules/yardstick from branch 'master' - Merge changes from topic 'YARDSTICK-1040' * changes: Fetch Nova instance's private IP Assign nova instance to security group - Fetch Nova instance's private IP Add the capability to fetch the private IP of a Nova instance through the operation perspective. JIRA: YARDSTICK-1040 Change-Id: Idc3d62bcd3f477a03a89f7dcc8d8616f3cfa2742 Signed-off-by: Dimitrios Markou <mardim@intracom-telecom.com> - Assign nova instance to security group Support the assigning of a nova instance to an existing security group through the operation perspective Change-Id: Ic1c26031c25d400fede2ecb298a66aec42dcfbc5 Signed-off-by: Dimitrios Markou <mardim@intracom-telecom.com>
2018-03-12Update git submodulesDanielMartinBuckley1-0/+0
* Update docs/submodules/yardstick from branch 'master' - Do NOT hardcode interface speed for PROX tests JIRA: YARDSTICK-1035 Do not hardcode NIC/interface speed in PROX test. Test assumes NIC used is 10Gbps. This is incorrect. It could support 1Gbps, 10Gbps, 25Gbps, 40Gbps or something else. This is used to calculate pps (Packets Per Second) In Baremetal the NIC speed could be extracted. however when run on a virtual machine this is not possible. Solution: Add in options section of test file. eg. Options: interface_speed_gbps: 10 Where 10 refers to a 10Gbps. In a setup where multiple interfaces are used. This will refer to the speed of the slowest connection. Change-Id: I89ab16479a2cdd1d79e52cbcc5a972762c60d057 Signed-off-by: Daniel Martin Buckley <daniel.m.buckley@intel.com>
2018-03-12Update git submodulesMarkos Chandras1-0/+0
* Update docs/submodules/releng from branch 'master' - Merge "jjb: xci: Add postbuild publisher script to remove clean VM" - jjb: xci: Add postbuild publisher script to remove clean VM The clean VM normally stays around after the job is completed or killed due to timeout. Unless a job for the same distro is scheduled on the same node, that VM will state around for a while consuming valuable system resources. As such, we should remove it after the job finishes to free up resources for the new jobs. Change-Id: I88b5e32797969d9378588199a7ddb013bbe740c9 Signed-off-by: Markos Chandras <mchandras@suse.de>
2018-03-12Update git submodulesThomas Duval1-0/+0
* Update docs/submodules/moon from branch 'master' - Add a generator for OpenStack default policy. Change-Id: Ibe3b60ea5f21da20e0ebd9f2fd035790fdab4b76
2018-03-12Update git submodulesMarkos Chandras1-0/+0
* Update docs/submodules/releng-xci from branch 'master' - Merge "xci: Fix warning about missing inventory file" - xci: Fix warning about missing inventory file We no longer have a global inventory file and we don't need one right now since the bootstrapping opearations happen on the localhost anyway so we could be explicit and get rid of the following warning: [WARNING]: Host file not found: inventory [WARNING]: provided hosts list is empty, only localhost is available Change-Id: I5cfe7b0971397665cf9eae9c54985c44c4506449 Signed-off-by: Markos Chandras <mchandras@suse.de>
2018-03-12Update git submodulesMarkos Chandras1-0/+0
* Update docs/submodules/releng-xci from branch 'master' - Merge "xci: roles: configure-network: Avoid passing empty string to module" - xci: roles: configure-network: Avoid passing empty string to module The package module gets upset if we pass it an empty string as a package name Mar 09 15:15:33 TASK [configure-network : Ensure networking packages are present] ************** Mar 09 15:15:49 fatal: [opnfv]: FAILED! => {"changed": false, "failed": true, "msg": "No package matching '' found available, installed or updated", "rc": 126, "results": ["iproute-3.10.0-87.el7.x86_64 providing iproute is already installed", "No package matching '' found available, installed or updated"]} As such, lets pass an existing package for non-Debian distros to make the module happy. Change-Id: Ib1128057097193278cfe50f79daf35332b54e781 Signed-off-by: Markos Chandras <mchandras@suse.de>