summaryrefslogtreecommitdiffstats
AgeCommit message (Collapse)AuthorFilesLines
2017-09-22Update git submodulesFeng Pan1-0/+0
* Update docs/submodules/apex from branch 'master' - Merge "Fixes removing inventory keys" - Fixes removing inventory keys Inventory keys that we want to delete were not being removed for instackenv.json. Also fixes unit tests. Change-Id: I7d6c752342db050d651953633f18e236f60334e3 Signed-off-by: Tim Rozet <trozet@redhat.com>
2017-09-22Update git submodulesMarkos Chandras1-0/+0
* Update docs/submodules/releng-xci from branch 'master' - Merge "Override ansible role versions only if OSA version is not master" - Override ansible role versions only if OSA version is not master If OSA version is set to master, we should use the role versions directly from upstream to ensure we do not cause issues by the use of wrong role versions. Change-Id: I26005d23944445bf287384f90c7f2e139224ab23 Signed-off-by: Fatih Degirmenci <fatih.degirmenci@ericsson.com>
2017-09-22Update git submodulesMarkos Chandras1-0/+0
* Update docs/submodules/releng-xci from branch 'master' - Merge changes from topic 'split-variable-creation-to-task' * changes: xci: playbooks: Include distribution var files dynamically bifrost: scripts: Look for virtualbmc on bifrost virtualenv xci: Gain elevated privileges to remove the XCI_DEVEL_ROOT directory xci: Move VM provisioning to xci-deploy.sh - xci: playbooks: Include distribution var files dynamically This is a continuation of I0a49e2ed8d811bb40a99612462752f8691133e0f We need to convert these two plays to include the variable files dynamically similar to the rest of the playbook. Change-Id: I43203651ccafb03e015bfe4d1b075a7ee96b5adc Signed-off-by: Markos Chandras <mchandras@suse.de> - bifrost: scripts: Look for virtualbmc on bifrost virtualenv Since I94874d600a29247b7826324cc111901995df90dc, bifrost installs pip packages in virtualenv so we need to look there for virtualbmc if it's not currently installed on the host. Change-Id: Ia4c7e8a75c020dc00b920956495831cc77457876 Signed-off-by: Markos Chandras <mchandras@suse.de> - xci: Gain elevated privileges to remove the XCI_DEVEL_ROOT directory This is similar to 0927671781f6875926dac2e5f4bb10816e67070c. We need elevated privileges to remove the XCI_DEVEL_ROOT directory so move this role to its own play. Change-Id: Ice4f030eeb28cd24a6166f11a5a792ab3df8880c Signed-off-by: Markos Chandras <mchandras@suse.de> - xci: Move VM provisioning to xci-deploy.sh The bifrost-provision.sh script will provision machines using Ansible playbooks. If we run this script in an Ansible playbook, that means that we will run Ansible with Ansible and this can only lead to further confusion when debugging issues. As such, since we already have a script to provision machines, lets use it directly from the xci-deploy.sh script. This also reverts 3f04e1fd72b14420788af64b14c35a5f74727f82 which added virtualenv support in bifrost since that causes more problems than it fixes for the time being. Change-Id: Id82b7c06a2af28b66f64f1966227888227ec276f Signed-off-by: Markos Chandras <mchandras@suse.de>
2017-09-22Update git submoduleswutianwei1-0/+0
* Update docs/submodules/releng-xci from branch 'master' - Add the internal_vip(172.29.236.222) to used_ip The IP in used_ip will not be used later otherwise internal_vip may be assigned to lxc container, which will cause issue during deploying Change-Id: I9834dfa9b218b4dd23e20c8d57e05bb806dafa7b Signed-off-by: wutianwei <wutianwei1@huawei.com>
2017-09-22Update git submodulesMorgan Richomme1-0/+0
* Update docs/submodules/releng from branch 'master' - Merge "[Functest] Support functest-suite with Alpine containers" - [Functest] Support functest-suite with Alpine containers Updated all the jobs that use functest-suite. For single test cases, we need to know to which docker image the test belongs to. Change-Id: If7db231ccc891233423f2f2bc3aa5b95d048b30a Signed-off-by: Jose Lausuch <jalausuch@suse.com>
2017-09-22Update git submodulesRyota Mibu1-0/+0
* Update docs/submodules/doctor from branch 'master' - Merge "Add parallel execution and shortcut notification to inspector design guideline" - Add parallel execution and shortcut notification to inspector design guideline JIRA: DOCTOR-73 Change-Id: Ic412b0c5e966f4391bc0f9e5e71d64e23e2eba68 Signed-off-by: Yujun Zhang <zhang.yujunz@zte.com.cn>
2017-09-22Update git submodulesFatih Degirmenci1-0/+0
* Update docs/submodules/releng from branch 'master' - Merge "kvmfornfv: Disable jobs running on intel-pod10" - kvmfornfv: Disable jobs running on intel-pod10 Change-Id: I418f4f2b5f4b28acb9ed39f4f512dc59a4a6f012 Signed-off-by: Fatih Degirmenci <fatih.degirmenci@ericsson.com>
2017-09-22Update git submodulesMorgan Richomme1-0/+0
* Update docs/submodules/releng from branch 'master' - Merge "Bugfix: Change http_pass to proxy_pass" - Bugfix: Change http_pass to proxy_pass http_pass is wrong for nginx, we need to change it to proxy_pass Change-Id: Ib679b36a4a139c02647564719e1cfc49a9f376a2 Signed-off-by: chenjiankun <chenjiankun1@huawei.com>
2017-09-22Update git submodulesCedric Ollivier1-0/+0
* Update docs/submodules/functest from branch 'master' - Merge "Support https when testing ODL" - Support https when testing ODL It conforms with the last change on ODL tests [1]. Neutron endpoint is passed via robot args instead of Neutron ip. Keystone url (based on OS_AUTH_URL) is passed too to replace Keystone ip. [1] https://git.opendaylight.org/gerrit/#/c/63293/ Change-Id: Ie44f55304a438b1b0289ec69ac2241664be70e80 Signed-off-by: Cédric Ollivier <cedric.ollivier@orange.com>
2017-09-22Update git submodulesSharada Shiddibhavi1-0/+0
* Update docs/submodules/barometer from branch 'master' - Modyfying method to get env variables in Barometer This patch adds changes to get the environment variables into the baroneter tests Change-Id: I93f18d64d6db25885987b702b36f6d2403bcb24d Signed-off-by: Sharada Shiddibhavi <sharada.shiddibhavi@intel.com>
2017-09-22Update git submodulesKerim Gokarslan1-0/+0
* Update docs/submodules/nfvbench from branch 'master' - NFVBENCH-32 Check nan result values before integer casting Change-Id: Ia675672b40f93d7503ebe5a355896a084e3d0cbf Signed-off-by: Kerim Gokarslan <kgokarsl@cisco.com>
2017-09-21Update git submodulesTrevor Bramwell1-0/+0
* Update docs/submodules/releng from branch 'master' - Run CI Security Gate Check on all OPNFV Builders Enable the security gating check to run on all machines labled 'opnfv-build'. This will allow the job to run as long as one of these machines are online. JIRA: RELENG-313 Change-Id: Icc792f7732c6cc3ca49bd8db32027fc146f8b1cd Signed-off-by: Trevor Bramwell <tbramwell@linuxfoundation.org>
2017-09-21Update git submodulesTrevor Bramwell1-0/+0
* Update docs/submodules/releng from branch 'master' - Change Anteater Report Directory Permissions Setting this to allow all users to read/write the permissions enable the container to write to the volume mounted reports directory even though it is owned by the Jenkins user. JIRA: RELENG-313 Change-Id: Ib26e9b98cd17607c98a180888593c42376458f7f Signed-off-by: Trevor Bramwell <tbramwell@linuxfoundation.org>
2017-09-21Update git submodulesAlexandru Avadanii1-0/+0
* Update docs/submodules/pharos from branch 'master' - config/pod1.yaml: Typo fixes, add 3 new nodes In order to be able to check the PDF template against the current installer adapters, we need to fill in all 5 nodes info. While at it, perform some cleanup: - s/remoteparas/remote_paramsg/ (installers use this directly ...); - s/remote_mangement/remote_management/g; - s/pod owner/pod_owner/; - minor typo fixes; - fixed one IP overlap between 2 existing nodes; NOTE: Data for the 3 new nodes is bogus (random MACs, addresses). Change-Id: I63c6318659678771c34e139dd1db630c6b81b214 Signed-off-by: Alexandru Avadanii <Alexandru.Avadanii@enea.com>
2017-09-21Update git submodulesCharalampos Kominos1-0/+0
* Update docs/submodules/armband from branch 'master' - Fixed Hash of patch file for nova-libvirt-ACPI-AAVMF JIRA: ARMBAND-312 Change-Id: I77b9d38dd7e18bf464e30bfabce3111ac47e8bd7 Signed-off-by: Charalampos Kominos <Charalampos.Kominos@enea.com>
2017-09-21Update git submodulesTim Rozet1-0/+0
* Update docs/submodules/apex from branch 'master' - Merge "Revert "Adds Calipso scenario"" - Revert "Adds Calipso scenario" This reverts commit 433961f8c0b816f19aa858654261fa87d2f02a19. Change-Id: Ic8a14d2e0ad8d1006625af401fde2f365890650b Signed-off-by: Tim Rozet <trozet@redhat.com>
2017-09-21Update git submodulesMichael Polenchuk1-0/+0
* Update docs/submodules/fuel from branch 'master' - [virtual] Alter haproxy entry type of odl rest api Change-Id: Iedb9a57f7ed4b7483bf629225fb2f3470e7de97e Signed-off-by: Michael Polenchuk <mpolenchuk@mirantis.com>
2017-09-21Update git submodulesMichael Polenchuk1-0/+0
* Update docs/submodules/snaps from branch 'master' - Reduce flavor resources of heat template In order to pass the HeatUtilsCreateComplexStackTests request an affordable amount of compute resources. Change-Id: I7d99435ce9500cc96e2e25828f1a804687df69e0 Signed-off-by: Michael Polenchuk <mpolenchuk@mirantis.com>
2017-09-21Update git submodulesRoss Brattain1-0/+0
* Update docs/submodules/yardstick from branch 'master' - Merge "tg_rfc2544_ixia: use traffic id from JSON to update mac" - tg_rfc2544_ixia: use traffic id from JSON to update mac we were using raw sort index of the interfaces to set the MAC address, but we should be using the traffic id from the static JSON instead. Change-Id: I13284db04abb3eaf8c9826974a9e5aa1c37b3891 Signed-off-by: Ross Brattain <ross.b.brattain@intel.com>
2017-09-21Update git submodulesDan Radez1-0/+0
* Update docs/submodules/apex from branch 'master' - Merge "Adds Calipso scenario" - Adds Calipso scenario Calipso uses docker containers and is post deployment feature that can be used to monitor pieces of the stack. This patch installs it to the undercloud rather than the jumphost as it is easier to manage for cleanup and dependencies. Change-Id: Ie2dacc4f14b391a864fafb2e75ebcd15facb19f1 Signed-off-by: Tim Rozet <trozet@redhat.com>
2017-09-21Update git submodulesFeng Pan1-0/+0
* Update docs/submodules/apex from branch 'master' - Merge "Improves clean to cleanup virsh nets and and other bridges" - Improves clean to cleanup virsh nets and and other bridges Currently only the admin and external bridges will be removed from the jumphost which is only really clean for a baremetal deployment. Virtual deployments will leave br-tenant, br-api, br-storage. This patch removes those as well as deletes all Apex virsh networks from libvirt. Also checks if authorized_keys exists before trying to edit it. Change-Id: I1affe2733ba1dc38fd3b91fb14398454137f00a4 Signed-off-by: Tim Rozet <trozet@redhat.com>
2017-09-21Update git submodulesMorgan Richomme1-0/+0
* Update docs/submodules/releng from branch 'master' - Merge "bugfix: autoupdate failed due to mingle with watchdog" - bugfix: autoupdate failed due to mingle with watchdog 1. In the original design, if the auto-job starts soon after the watchdog starts, the auto update might be mingled with connectivity check, which may lead to update failure. so instead, the connectivity is checked first, if failed and module is not in deploying, restart module. 2. only automate-docker-deploy job will impact the container status during auto-job, so substitue auto-job status check with automate-docker-deploy's 3. the watchdog is not only for testapi, but also for reporting, and all docker container server deployed in testresults.opnfv.org, so move it under utils/test/opts, which is leveraged to store tool-sets employed for testing tools. Change-Id: I766f3a534a3d510ce7509d4e742150150ccd8f54 Signed-off-by: SerenaFeng <feng.xiaowei@zte.com.cn>
2017-09-21Update git submodulesSerena Feng1-0/+0
* Update docs/submodules/releng from branch 'master' - Merge "refactor one click deployment in testapi" - refactor one click deployment in testapi substitue docker-compose.template with string description, so that user can wget deploy.py and execute directly. Change-Id: I9703a1c8dfbdc46470561d54c6663e3728540162 Signed-off-by: SerenaFeng <feng.xiaowei@zte.com.cn>
2017-09-21Update git submodulesMorgan Richomme1-0/+0
* Update docs/submodules/functest from branch 'master' - Merge "Adding orchestra test cases to orchestra project" - Adding orchestra test cases to orchestra project Orchestra introduced 2 VNF test cases: * orchestra_openims * orchestra_clearwaterims In the configuration, the 2 projects are still assigned to functest project This patch associate the cases with their real project Change-Id: I81f6d6fb473916f0f91a5b3795b3ed433c283fb4 Signed-off-by: Morgan Richomme <morgan.richomme@orange.com>
2017-09-21Merge "infra: Add proposal for including infra documentation"Fatih Degirmenci2-4/+25
2017-09-21Update git submodulesjuraj.linkes1-0/+0
* Update docs/submodules/fds from branch 'master' - Updated functest sim script Change-Id: Iacfb7b801c75cb85fafff2ff3082266220f17525 Signed-off-by: juraj.linkes <jlinkes@cisco.com>
2017-09-21Update git submodulesNarinder Gupta1-0/+0
* Update docs/submodules/joid from branch 'master' - fix the timing issue where download is slow. Change-Id: Ia57f9bd4d76efbeb2dee35fc41e90001698c39ec Signed-off-by: Narinder Gupta <narinder.gupta@canonical.com>
2017-09-21Update git submodulesMartin Klozik1-0/+0
* Update docs/submodules/vswitchperf from branch 'master' - Merge "trex: RFC2544 Throughput bugfixing" - trex: RFC2544 Throughput bugfixing Changes introduced by patch: * Ensure that correct results with given lossreate are returned * Add threshold value to specify the accurancy of RFC2544 Throughput measurement. Default value is 0.05. JIRA: VSPERF-530 Change-Id: I8148deba9039c3a0feb6394d6671aa10c5afaf0a Signed-off-by: Martin Goldammer <martin.goldammer6@gmail.com> Reviewed-by: Martin Klozik <martinx.klozik@intel.com> Reviewed-by: Al Morton <acmorton@att.com> Reviewed-by: Christian Trautman <ctrautma@redhat.com> Reviewed-by: Trevor Cooper <trevor.cooper@intel.com>
2017-09-21Update git submodulesNarinder Gupta1-0/+0
* Update docs/submodules/joid from branch 'master' - Merge "Revert "pull in heat bug fix."" - Revert "pull in heat bug fix." This reverts commit 533dfeac9078ec05bc1c755078b4da74e8c5266d. Change-Id: Icf04741d6ee463155d1d58274884deca8a625975 Signed-off-by: Narinder Gupta <narinder.gupta@canonical.com>
2017-09-21Update git submodulesNarinder Gupta1-0/+0
* Update docs/submodules/joid from branch 'master' - Revert "modfiied to adjust timings as it seems download the container image is slow like few kbps." This reverts commit 16c95e3ff61446c5cac0e1e683f8c3c72e0ad553. Change-Id: I6bca3a73ff16f21d4f53dedf7523f9d14aca369f Signed-off-by: Narinder Gupta <narinder.gupta@canonical.com>
2017-09-21Update git submodulesJuha Kosonen1-0/+0
* Update docs/submodules/functest from branch 'master' - Remove void return value mocks in rally unit tests Change-Id: I369b98fb9120830b1868f438c7da2a039a60d890 Signed-off-by: Juha Kosonen <juha.kosonen@nokia.com>
2017-09-21Update git submodulesJose Lausuch1-0/+0
* Update docs/submodules/releng from branch 'master' - Merge "Functest: Introduce building image job for euphrates" - Functest: Introduce building image job for euphrates To build apline images for euphrates Change-Id: I63d77c99306aed263e220c2a0cd27ee2cca1ecb9 Signed-off-by: Linda Wang <wangwulin@huawei.com>
2017-09-21Update git submodulesSerena Feng1-0/+0
* Update docs/submodules/releng from branch 'master' - Merge "[QTIP]Enable qtip validate jobs for euphrates" - [QTIP]Enable qtip validate jobs for euphrates Change-Id: I8a138d6cdcfa055260fc25fa909b28d192d5c98f Signed-off-by: zhihui wu <wu.zhihui1@zte.com.cn>
2017-09-21Update git submodulesJing Lu1-0/+0
* Update docs/submodules/yardstick from branch 'master' - Merge "Add host&targer in scenario['options']['server_name'] support" - Add host&targer in scenario['options']['server_name'] support JIRA: YARDSTICK-810 Currently host, target is in scenario, but as a input, we prefer it in scenario['options']. So I add support for under scenario['options']['server_name'] If we write host in scenario['options']['server_name'], the host ip info will be written in context. Change-Id: I90df20467ef5da772d22e9f272a2cac250f822e0 Signed-off-by: chenjiankun <chenjiankun1@huawei.com>
2017-09-21Update git submodulesRoss Brattain1-0/+0
* Update docs/submodules/yardstick from branch 'master' - Merge "requirements: bump Ansible version to 2.3" - requirements: bump Ansible version to 2.3 Change-Id: Ib429ba24d2b7287b6ec4e749386da0e1242d6a20 Signed-off-by: Ross Brattain <ross.b.brattain@intel.com>
2017-09-21Update git submodulesRoss Brattain1-0/+0
* Update docs/submodules/yardstick from branch 'master' - Merge "Introduced timeout to post method of HttpClient" - Introduced timeout to post method of HttpClient We seen cases where grafana container bring-up code would fail, because of too quick access to the http api. Added 10sec timeout for the first query of the API. Change-Id: Ifc95a626d0ab5552a1f26fb167fc3f65791392d7 Signed-off-by: Maciej Skrocki <maciej.skrocki@intel.com>
2017-09-21Update git submodulesSharada Shiddibhavi1-0/+0
* Update docs/submodules/barometer from branch 'master' - Adding improvements to SNMP testcases This patch contains improvements to testcases for Hugepages, Intel_RDT and mcelog verification using SNMP Change-Id: I3451e0acd9c791e6145bb15e7ba8f3525bc0f0e8 Signed-off-by: Sharada Shiddibhavi <sharada.shiddibhavi@intel.com>
2017-09-21Update git submodulesRoss Brattain1-0/+0
* Update docs/submodules/yardstick from branch 'master' - Merge "tg_rfc2544_ixia: renamed traffic_profile.execute to traffic_profile.execute_traffic tg_rfc2544_ixia: pass ports to generate_samples" - tg_rfc2544_ixia: renamed traffic_profile.execute to traffic_profile.execute_traffic tg_rfc2544_ixia: pass ports to generate_samples Change-Id: I90d12fa2ce8cd4d1c2a18bdcf70027f6d9e3f77f Signed-off-by: Ross Brattain <ross.b.brattain@intel.com>
2017-09-21Update git submodulesMaciej Skrocki1-0/+0
* Update docs/submodules/yardstick from branch 'master' - Bumped samplevnfs flavor disk size to 6G. Since we increased the images size the 4G is not sufficient anymore. Change-Id: Iae25cf4cfb7a6cc69c8d28771c183a2342ac38d0 Signed-off-by: Maciej Skrocki <maciej.skrocki@intel.com>
2017-09-21Update git submodulesTim Rozet1-0/+0
* Update docs/submodules/apex from branch 'master' - Merge "Set aarch64 deploys to UEFI" - Set aarch64 deploys to UEFI Change-Id: I6b037ccd38fa68e5f863566a1c9a3ed4399bab84 Signed-off-by: Dan Radez <dradez@redhat.com>
2017-09-20Update git submodulesCédric Ollivier1-0/+0
* Update docs/submodules/functest from branch 'master' - Remove false hooks for functest-parser Change-Id: I58f186b249083fc13e4bcfc4e933fd11f5d4b20e Signed-off-by: Cédric Ollivier <cedric.ollivier@orange.com>
2017-09-20Update git submodulesAlec Hothan1-0/+0
* Update docs/submodules/nfvbench from branch 'master' - Merge "NFVBENCH-30 check_traffic_time_sec not working as expected" - NFVBENCH-30 check_traffic_time_sec not working as expected Change-Id: I7d82b6b3c95df0ad5e1b95cb35e8f84d00717a3a Signed-off-by: Kerim Gokarslan <kgokarsl@cisco.com>
2017-09-20Update git submodulesKerim Gokarslan1-0/+0
* Update docs/submodules/nfvbench from branch 'master' - NFVBENCH-31 Build container with the VM image in it Change-Id: Ia6870ee63b50e677e00c1f91649e7c590288b44d Signed-off-by: Kerim Gokarslan <kgokarsl@cisco.com>
2017-09-20Update git submodulesRoss Brattain1-0/+0
* Update docs/submodules/yardstick from branch 'master' - Merge "nsb_setup.sh: update to Ansible 2.3.2" - nsb_setup.sh: update to Ansible 2.3.2 Change-Id: I2f700fbb169d02d126fe7ea22721bebf127c1206 Signed-off-by: Ross Brattain <ross.b.brattain@intel.com>
2017-09-20Update git submodulesRoss Brattain1-0/+0
* Update docs/submodules/yardstick from branch 'master' - Merge "cgnapt: mock time.sleep in unitests" - cgnapt: mock time.sleep in unitests Change-Id: I26957977e6dcd0392078a543a6907a550711c702 Signed-off-by: Ross Brattain <ross.b.brattain@intel.com>
2017-09-20Update git submodulesRoss Brattain1-0/+0
* Update docs/submodules/yardstick from branch 'master' - heat: fixup unittest block with pkey get pkey after we have found the node Change-Id: I0e67834b87ed5ba268ea9cb5cffb6c214aedeebb Signed-off-by: Ross Brattain <ross.b.brattain@intel.com>
2017-09-20Update git submodulesAric Gardner1-0/+0
* Update docs/submodules/releng from branch 'master' - Merge "fuel, armband: Enable Euphrates jobs & triggers" - fuel, armband: Enable Euphrates jobs & triggers Change-Id: Id47f61c950e1cc036e32e8efe2e2b55193e7c49e Signed-off-by: Alexandru Avadanii <Alexandru.Avadanii@enea.com>
2017-09-20Update git submodulesRoss Brattain1-0/+0
* Update docs/submodules/yardstick from branch 'master' - Merge "Generate pod.yaml from current context" - Generate pod.yaml from current context We want to generate pod.yaml from Heat contexts so we can re-use the context without destroying it. But we don't have node role information and it doesn't make sense in this case, so make the role optional. Since we changed Heat to use pkey instead of key_filename, we can embed the pkey into the pod.yaml, but we have to make sure to convert the pkey to string, in case it is a RSAKey object Change-Id: Ibefcfbd8236e68013a704c39964cb870da825da8 Signed-off-by: Ross Brattain <ross.b.brattain@intel.com>
2017-09-20Update git submodulesRoss Brattain1-0/+0
* Update docs/submodules/yardstick from branch 'master' - Merge "Heat: use pkey from string instead of key_filename" - Heat: use pkey from string instead of key_filename Instead of using a key_filename for Heat, we can read the key as a string directly using pkg_resources.resource_string() This will enable us to save Heat stacks as pod.yaml, because we can embedded the key into the pod.yaml directly. Change-Id: I16baaba17dab845ee0846f97678733bae33cb463 Signed-off-by: Ross Brattain <ross.b.brattain@intel.com> Signed-off-by: Edward MacGillivray <edward.s.macgillivray@intel.com>
2017-09-20Update git submodulesRoss Brattain1-0/+0
* Update docs/submodules/yardstick from branch 'master' - Merge "ansible: resize VNF image" - ansible: resize VNF image When compiling Trex, DPDK, collectd and all the SampleVNFs we use more than the 2.2GB size of the original Ubuntu cloud image. Accordingly we need to resize the image. If we were not inside a docker container we would use virt-resize to automatically handle all the cases, but virt-resize launches qemu. Instead we can use qemu-img to add extra space, then luckily we can use parted to resize the partition and finally resize2fs to resize the filesystem. This limits us to only ext3/4 images, but if we need to we could add support for other filesystems by checking file system type. Change-Id: Iac84b8e6967af5be64c280a7b1eaaf09f5d6b3aa Signed-off-by: Ross Brattain <ross.b.brattain@intel.com>