summaryrefslogtreecommitdiffstats
AgeCommit message (Collapse)AuthorFilesLines
2017-07-17Update git submodulesRoss Brattain1-0/+0
* Update docs/submodules/yardstick from branch 'master' - Merge "pktgen: speedup unittest, mock time.sleep" - pktgen: speedup unittest, mock time.sleep Change-Id: I0c6f6b68b30ae72887666a3b9e994dabf7c6a71d Signed-off-by: Ross Brattain <ross.b.brattain@intel.com>
2017-07-17Update git submodulesDeepak S1-0/+0
* Update docs/submodules/samplevnf from branch 'master' - Merge "[UDP_Replay] fixing of compiler warning" - [UDP_Replay] fixing of compiler warning removes the nb_lcores as its no longer used. Change-Id: I13020585afb6d1e0758f1efc6578740dd3502d72 Signed-off-by: Vishwesh M Rudramuni <vishwesh.m.rudramuni@intel.com>
2017-07-17Update git submodulesRoss Brattain1-0/+0
* Update docs/submodules/yardstick from branch 'master' - Merge "tg: speedup unittests, mock time.sleep" - tg: speedup unittests, mock time.sleep Change-Id: Ia6207c898653c3ba21b22e9c309e7abb25d5cd32 Signed-off-by: Ross Brattain <ross.b.brattain@intel.com>
2017-07-17Update git submodulesRoss Brattain1-0/+0
* Update docs/submodules/yardstick from branch 'master' - Merge "test_pktgen_dpdk_throughput: speedup unittest, mock time.sleep()" - test_pktgen_dpdk_throughput: speedup unittest, mock time.sleep() Change-Id: I74bbdee1a503ef9bad32db7d4444921f6730f465 Signed-off-by: Ross Brattain <ross.b.brattain@intel.com>
2017-07-17Update git submodulesRoss Brattain1-0/+0
* Update docs/submodules/yardstick from branch 'master' - test_heat: ipaddress expects unicode inputs weird error E AddressValueError: '10.20.0.0/15' does not appear to be an IPv4 or IPv6 network. Did you pass in a bytes (str in Python 2) instead of a unicode object? I guess we need to convert the stack.outputs mock to unicode FAILED tests/unit/benchmark/contexts/test_heat.py:137 (HeatContextTestCase.test_add_server_port) self = <tests.unit.benchmark.contexts.test_heat.HeatContextTestCase testMethod=test_add_server_port> def test_add_server_port(self): network1 = mock.MagicMock() network1.vld_id = 'vld111' network2 = mock.MagicMock() network2.vld_id = 'vld777' self.test_context.name = 'foo' self.test_context.stack = mock.MagicMock() self.test_context.networks = { 'a': network1, 'c': network2, } self.test_context.stack.outputs = { 'b': '10.20.30.45', 'b-subnet_id': 1, 'foo-a-subnet-cidr': '10.20.0.0/15', 'foo-a-subnet-gateway_ip': '10.20.30.1', 'b-mac_address': '00:01', 'b-device_id': 'dev21', 'b-network_id': 'net789', 'd': '40.30.20.15', 'd-subnet_id': 2, 'foo-c-subnet-cidr': '40.30.0.0/18', 'foo-c-subnet-gateway_ip': '40.30.20.254', 'd-mac_address': '00:10', 'd-device_id': 'dev43', 'd-network_id': 'net987', } server = mock.MagicMock() server.ports = OrderedDict([ ('a', {'stack_name': 'b'}), ('c', {'stack_name': 'd'}), ]) expected = { "private_ip": '10.20.30.45', "subnet_id": 1, "subnet_cidr": '10.20.0.0/15', "network": '10.20.0.0', "netmask": '255.254.0.0', "gateway_ip": '10.20.30.1', "mac_address": '00:01', "device_id": 'dev21', "network_id": 'net789', "network_name": 'a', "local_mac": '00:01', "local_ip": '10.20.30.45', "vld_id": 'vld111', } > self.test_context.add_server_port(server) tests/unit/benchmark/contexts/test_heat.py:186: _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ yardstick/benchmark/contexts/heat.py:307: in add_server_port network_name, port['stack_name'], self.stack.outputs) yardstick/benchmark/contexts/heat.py:315: in make_interface_dict subnet_ip = ipaddress.ip_network(subnet_cidr) _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ address = '10.20.0.0/15', strict = True def ip_network(address, strict=True): """Take an IP string/int and return an object of the correct type. Args: address: A string or integer, the IP network. Either IPv4 or IPv6 networks may be supplied; integers less than 2**32 will be considered to be IPv4 by default. Returns: An IPv4Network or IPv6Network object. Raises: ValueError: if the string passed isn't either a v4 or a v6 address. Or if the network has host bits set. """ try: return IPv4Network(address, strict) except (AddressValueError, NetmaskValueError): pass try: return IPv6Network(address, strict) except (AddressValueError, NetmaskValueError): pass if isinstance(address, bytes): raise AddressValueError( '%r does not appear to be an IPv4 or IPv6 network. ' 'Did you pass in a bytes (str in Python 2) instead of' > ' a unicode object?' % address) E AddressValueError: '10.20.0.0/15' does not appear to be an IPv4 or IPv6 network. Did you pass in a bytes (str in Python 2) instead of a unicode object? ../../yardstick/yardstick_venv/lib/python2.7/site-packages/ipaddress.py:199: AddressValueError Change-Id: Ie3b087a26a054203573eaa9b13c3e90152bba6a9 Signed-off-by: Ross Brattain <ross.b.brattain@intel.com>
2017-07-17Update git submodulesRoss Brattain1-0/+0
* Update docs/submodules/yardstick from branch 'master' - Merge "test_tg_rfc2544_trex: speedup unittest, set time.sleep(0)" - test_tg_rfc2544_trex: speedup unittest, set time.sleep(0) Change-Id: I6fdae629bdbd45cba715a838c41613b914a3abcb Signed-off-by: Ross Brattain <ross.b.brattain@intel.com>
2017-07-17Update git submodulesYu Yang (Gabriel)1-0/+0
* Update docs/submodules/bottlenecks from branch 'master' - Merge "Add test monitoring module" - Add test monitoring module JIRA: BOTTLENECK-172 Add the monitoring module for Bottlenecks testing. Merging into the framework will be in another patch since framework is under refactoration. Change-Id: I72eb1b6cabac6a9d1d0ef1fb6430f364e8ad76df Signed-off-by: yuyang <Gabriel.yuyang@huawei.com>
2017-07-17Update git submodulesRoss Brattain1-0/+0
* Update docs/submodules/yardstick from branch 'master' - test_delete_all_calls_delete: fix delete mock we need to mock HeatStack.delete() before we instantiate otherwise we can't reach the instantiated objects delete() method we need to patch the class so we patch all instances Change-Id: I36f9476dcfb83e2d583c5a9f72dc27fce57258eb Signed-off-by: Ross Brattain <ross.b.brattain@intel.com>
2017-07-17Update git submodulesRoss Brattain1-0/+0
* Update docs/submodules/yardstick from branch 'master' - test_heat: don't waste 2 seconds in unittest remove duration checks and test with sleep 0 Change-Id: I22516cde56ac3a02358ca9c3e652cead10580d76 Signed-off-by: Ross Brattain <ross.b.brattain@intel.com>
2017-07-17Update git submoduleswutianwei1-0/+0
* Update docs/submodules/releng from branch 'master' - [Compass] Move cacert docker copy after chown in fetch_os_creds sometimes it can't copy os_cacert but copy opnfv_openrc. it cause an issue and didn't execute the command chown. so the opnfv_openrc will belong to root, which will cause errors next time. Change-Id: I2955ba347d399d65c9e5cd566235be06fb7c30af Signed-off-by: wutianwei <wutianwei1@huawei.com>
2017-07-17Update git submodulesJing Lu1-0/+0
* Update docs/submodules/yardstick from branch 'master' - Merge "Bugfix: kubernetes context do not implement _get_network" - Bugfix: kubernetes context do not implement _get_network Since kubernetes context do not implement _get_network, so when run unit test case, we will get a error: TypeError: Can't instantiate abstract class KubernetesContext with abstract methods _get_network Change-Id: Ib56abe7c580ef8a6fc9f52f3fcd566d0fa70e1cc Signed-off-by: chenjiankun <chenjiankun1@huawei.com>
2017-07-17Update git submodulesRoss Brattain1-0/+0
* Update docs/submodules/yardstick from branch 'master' - Merge "apexlake: speed unittest, mock time.sleep" - apexlake: speed unittest, mock time.sleep Change-Id: I40cbcd1963bbb2481282c34b2360c77a5bef109b Signed-off-by: Ross Brattain <ross.b.brattain@intel.com>
2017-07-17Update git submodulesRoss Brattain1-0/+0
* Update docs/submodules/yardstick from branch 'master' - Merge "test_attacker_baremetal: don't run local commands" - test_attacker_baremetal: don't run local commands these tests were failing to mock subprocess.check_output and thus were trying to run sudo commands on the local system. This is dangerous. Add the subprocess mock. Also mock the LOG object so we don't print bogus Runtime error tracebacks in the unittest logs when we test assertRaises() Change-Id: I01535f9952fbd95ce2f5972b641c51ff836e7e8c Signed-off-by: Ross Brattain <ross.b.brattain@intel.com>
2017-07-17Update git submodulesliyin1-0/+0
* Update docs/submodules/bottlenecks from branch 'master' - Add frame support of elk one docker support JIRA: BOTTLENECK-171 Add support of Bottlenecks docker frame refact, After this patch we will provide the ability of several installer. Add Yardstick_TAG to adjust yardstick docker version Change-Id: Ib431f8acf4a76b59f9d5e8783bcc7d2e5be208ae Signed-off-by: liyin <liyin11@huawei.com>
2017-07-17Update git submodulesJing Lu1-0/+0
* Update docs/submodules/yardstick from branch 'master' - Merge "Kubernetes (k8s) support" - Kubernetes (k8s) support JIRA: YARDSTICK-682 We decide to support k8s in E release. We need to discuss with openretriver team and then rewrite the ping test case under k8s as the first step. Change-Id: I3f81ebca8de5c1f3a8b7d42581cd7342dc320239 Signed-off-by: chenjiankun <chenjiankun1@huawei.com>
2017-07-17Update git submodulesRex Lee1-0/+0
* Update docs/submodules/yardstick from branch 'master' - Merge "add network info to topology" - add network info to topology we need to know which network each port is connected to so we can find VLAN or VXLAN ID. To do this we implement a new method for Contexts, Context.get_network(). This method is similar to Context.get_server(), it searches for a given network name in all the contexts. From this we generate a context_cfg["networks"] dict that stores all the network info for the nodes in the scenario. Then when we generate the topology for VNFD, we can lookup a given network by the vld_id and get the network_type, segmentation_id, etc. Then if we need to for example generated traffic on a given VLAN or VXLAN, we have this info available. Define default nd_route_tbl for ACL VNF we need default empty nd_route_tbl for IPv6 route. Change-Id: I9f9cfbd6acabeb4ae4675ca7354390efa57b29e7 Signed-off-by: Ross Brattain <ross.b.brattain@intel.com> Signed-off-by: Edward MacGillivray <edward.s.macgillivray@intel.com>
2017-07-17Update git submodulesYujun Zhang1-0/+0
* Update docs/submodules/qtip from branch 'master' - Merge "Add Authentication and Basic CRUD for Repos" - Add Authentication and Basic CRUD for Repos - Map urls to the CRUD views - Add html templates for the views - Set authentication settings Change-Id: Ifcfe39a8341d44376e322d195e995fcaa1716d7d Signed-off-by: akhilbatra898 <akhil.batra@research.iiit.ac.in>
2017-07-17Update git submodulesYujun Zhang1-0/+0
* Update docs/submodules/qtip from branch 'master' - Merge "Beautify table and figure output" - Beautify table and figure output - use qgrid for interactive grid - add legend to figures - enlarge figures Change-Id: I18cc58e1cbf64d4dda0593ebad55067fd6cdcfd3 Signed-off-by: Yujun Zhang <zhang.yujunz@zte.com.cn>
2017-07-16Update git submodulesAlexandru Avadanii1-0/+0
* Update docs/submodules/armband from branch 'master' - p/fuel: lib.sh: Revert to virtio-mmio for PXE net virtio-pci-net seems to have issues with more than three (3) interfaces attached to the same guest, even on separate PCI buses. To bypass this limitation, for now, we will use virtio-mmio for PXE, and virtio-pci-net for the rest. This keeps the guest eth order consistent and predictable, and allows udev to assign predictable interface names for 3 out of 4 guest network interfaces (enp2sX), thus ensuring PXE will always get the "eth0" designator. Change-Id: I0d0cb8148cd87313e67f8f27793eb2414c1e90e3 Signed-off-by: Alexandru Avadanii <Alexandru.Avadanii@enea.com>
2017-07-15Update git submodulesJose Lausuch1-0/+0
* Update docs/submodules/functest from branch 'master' - Merge "Release notes for Danube.3.0" - Release notes for Danube.3.0 Change-Id: I528b4ef11b5957856c36c0f18c0aa28a38d450a4 Signed-off-by: jose.lausuch <jose.lausuch@ericsson.com>
2017-07-15Update git submodulesCedric Ollivier1-0/+0
* Update docs/submodules/functest from branch 'master' - Merge "Correct odl port for compass installer" - Correct odl port for compass installer For the port 8181 has been used by OSA repo LXC in compass deployment. So we change the port here in functest to 8080. Change-Id: Ia262319f7513497db6e849521de6be6328ec97ba Signed-off-by: Yifei Xue <xueyifei@huawei.com>
2017-07-15Update git submodulesHarry Huang1-0/+0
* Update docs/submodules/compass4nfv from branch 'master' - Adjust redeploy When deployment is interrupted (e.g. ctrl+c kill deploy.sh), ansible processes in compass-tasks are still running. Redeploy at this situation new ansible process will be affacted by remained ones which cause errors. Change-Id: I821445bd53397c7030145bf6dc925032cb42519c Signed-off-by: Harry Huang <huangxiangyu5@huawei.com>
2017-07-15Update git submodulesRoss Brattain1-0/+0
* Update docs/submodules/yardstick from branch 'master' - add release date Change-Id: Icf12b7a59144754f65f67ed54a5c455a64c5042f Signed-off-by: Ross Brattain <ross.b.brattain@intel.com>
2017-07-15Update git submodulesRoss Brattain1-0/+0
* Update docs/submodules/yardstick from branch 'master' - Danube 3.1 release notes Change-Id: I7032dd2348dd7212484a4a3cbd40e1d7698c8668 Signed-off-by: Ross Brattain <ross.b.brattain@intel.com>
2017-07-15Update git submodulesCNlucius1-0/+0
* Update docs/submodules/onosfw from branch 'master' - update scenarios link to index.rst Change-Id: Ib2ea7d49c437ca1afb7ca7a0b76c3f96d3ba5960 Signed-off-by: CNlucius <lukai1@huawei.com>
2017-07-14Update git submodulesAlexandru Avadanii1-0/+0
* Update docs/submodules/armband from branch 'master' - reclass: system: AArch64: Remove mcelog Change-Id: I7cc5162359347ac9472127a8d27730c96050915e Signed-off-by: Guillermo Herrero <Guillermo.Herrero@enea.com> Signed-off-by: Alexandru Avadanii <Alexandru.Avadanii@enea.com>
2017-07-14Update git submodulesAlexandru Avadanii1-0/+0
* Update docs/submodules/armband from branch 'master' - p/fuel: Rebase after upstream vCPU count rework Change-Id: Ic4066acc2716e5f3f497fba9799691e0258d3011 Signed-off-by: Alexandru Avadanii <Alexandru.Avadanii@enea.com>
2017-07-14Merge "Added onosfw user & config guidAdded onosfw user & config guie"Aric Gardner1-0/+2
2017-07-14Update git submodulesNarinder Gupta1-0/+0
* Update docs/submodules/joid from branch 'master' - modfied to use public IP for keystone. Change-Id: Id0bcd86ee00b81de4e15722038e0e5e985772971 Signed-off-by: Narinder Gupta <narinder.gupta@canonical.com>
2017-07-14Update git submodulesNarinder Gupta1-0/+0
* Update docs/submodules/joid from branch 'master' - by default moving to public End point. Change-Id: Idfcdc337d2a497e286b79a0cd933f6bbc3753b99 Signed-off-by: Narinder Gupta <narinder.gupta@canonical.com>
2017-07-14Update git submodulesNarinder Gupta1-0/+0
* Update docs/submodules/joid from branch 'master' - Merge "Fix pip warnings" - Fix pip warnings 1) `sudo pip` causes permission issues with the cache directory. 2) `pip list` without specifying format raises deprecation warning. Change-Id: If1c1941cce6195603231706776c0b73d5255e9cc Signed-off-by: Martin Kulhavy <martin.kulhavy@nokia.com>
2017-07-14Added onosfw user & config guidAdded onosfw user & config guieSofia Wallin1-0/+2
Change-Id: I036d0c3cabc2c45787dfc1ff8f9d502273b52cb6 Signed-off-by: Sofia Wallin <sofia.wallin@ericsson.com>
2017-07-14Update git submodulesspisarski1-0/+0
* Update docs/submodules/snaps from branch 'master' - Created domain classes for networks and subnets. Created Network and Subnet domain classes so neutron_utils.py functions returning these types of objects will not be leaking out implementation details as each API version can change these data structures which is now being handled by the SNAPS neutron utility. JIRA: SNAPS-113 Change-Id: Id95dd0f8c2618c20a1a73a428abb95686dfa8251 Signed-off-by: spisarski <s.pisarski@cablelabs.com>
2017-07-14Update git submodulesManuel Buil1-0/+0
* Update docs/submodules/sfc from branch 'master' - Update release notes for Danube 3.0 Change-Id: I5c4185c41b8baf3e243152b31322a326a07a5d5e Signed-off-by: Manuel Buil <mbuil@suse.com>
2017-07-14Update git submodulesDeepak S1-0/+0
* Update docs/submodules/samplevnf from branch 'master' - Adding dpdk version for non-interactive vnf_build options. Change-Id: I95c6778fd216c6f7e3eee97c83f93726bb4298d0 Signed-off-by: Deepak S <deepak.s@linux.intel.com>
2017-07-14Update git submodulesDeepak S1-0/+0
* Update docs/submodules/samplevnf from branch 'master' - Adding PROX(Packet pROcessing eXecution engine) VNF to sampleVNF JIRA: SAMPLEVNF-55 PROX is a DPDK-based application implementing Telco use-cases such as a simplified BRAS/BNG, light-weight AFTR... It also allows configuring finer grained network functions like QoS, Routing, load-balancing... (We are moving PROX version v039 to sampleVNF https://01.org/intel-data-plane-performance-demonstrators/prox-overview) Change-Id: Ia3cb02cf0e49ac5596e922c197ff7e010293d033 Signed-off-by: Deepak S <deepak.s@linux.intel.com>
2017-07-14Update git submodulesSerenaFeng1-0/+0
* Update docs/submodules/releng from branch 'master' - leverage tox and pytest to execute unit test Change-Id: I20856e1b445587f0d8ee23e792793af863743252 Signed-off-by: SerenaFeng <feng.xiaowei@zte.com.cn>
2017-07-14Update git submodulesAnand B Jyoti1-0/+0
* Update docs/submodules/samplevnf from branch 'master' - VNFs: Correcting default traffic_type to IPv4 JIRA: SAMPLEVNF-54 The default traffic_type value needs to be set to IPv4 instead of MIX type which is not supported. Change-Id: Ibe8ec31bc7a435fd97aaae0e9e664d0eb70ee30c Signed-off-by: Anand B Jyoti <anand.b.jyoti@intel.com>
2017-07-14Update git submodulesJustin chi1-0/+0
* Update docs/submodules/compass4nfv from branch 'master' - Merge "change the public endpoint protocol with https" - change the public endpoint protocol with https Fetch the os_cacerts for funtest replace the internalURL with publicURL Change-Id: Iff4fe2c998f3b5e723e826cf27e8901208988785 Signed-off-by: wutianwei <wutianwei1@huawei.com>
2017-07-14Update git submodulesJose Lausuch1-0/+0
* Update docs/submodules/functest from branch 'master' - Merge "Use decorators for mock patching" - Use decorators for mock patching Instead of using the `with` clause, mock patching is prepended to each testing method as a decorator. Change-Id: Ieb962d6fd0b9a6cdc649c44e39f69b543426dce9 Signed-off-by: Martin Kulhavy <martin.kulhavy@nokia.com>
2017-07-14Update git submodulesCNlucius1-0/+0
* Update docs/submodules/onosfw from branch 'master' - add onos-sfc link update Change-Id: I1751feea6e8b7b0cf5dace4d53412a24a89f9dfb Signed-off-by: CNlucius <lukai1@huawei.com>
2017-07-14Update git submodulesVishwesh M Rudramuni1-0/+0
* Update docs/submodules/samplevnf from branch 'master' - [UDP_Replay] adding Makefile for dynamic arp THis patch modifies the Makefile to comprehend the dynamic arp support Change-Id: I92f03554b387c883840449014acf1a08b774b8fa Signed-off-by: Vishwesh M Rudramuni <vishwesh.m.rudramuni@intel.com>
2017-07-14Update git submodulesCNlucius1-0/+0
* Update docs/submodules/onosfw from branch 'master' - add onos-sfc scenario Change-Id: I6e82d36484b229cfa017bff247f5ac9544eb591a Signed-off-by: CNlucius <lukai1@huawei.com>
2017-07-14Update git submodulesJose Lausuch1-0/+0
* Update docs/submodules/functest from branch 'master' - Merge "Release notes for Danube 2.0" - Release notes for Danube 2.0 Change-Id: Ibe121dad771f0df36ffa15ec13d637b835cf09a8 Signed-off-by: jose.lausuch <jose.lausuch@ericsson.com>
2017-07-14Update git submodulesjose.lausuch1-0/+0
* Update docs/submodules/parser from branch 'master' - Make use of existing cirros image in the Functest container Once [1] is merged, the image needed for this test case will be available in /home/opnfv/functest/images/ So, no need to download again. [1] https://gerrit.opnfv.org/gerrit/#/c/37393/ Change-Id: I219fc38cdf5e929ecdba1631d6315f6d076ae5d0 Signed-off-by: jose.lausuch <jose.lausuch@ericsson.com>
2017-07-14Update git submodulesJose Lausuch1-0/+0
* Update docs/submodules/releng from branch 'master' - Merge "testapi: bugfix of tox" - testapi: bugfix of tox error log https://gerrit.opnfv.org/gerrit/#/c/37053/ https://build.opnfv.org/ci/job/testapi-verify-master/220/console Change-Id: Id278edad06c2852c662392d75fd3cf4041b03451 Signed-off-by: MatthewLi <lijun_1203@126.com>
2017-07-14Update git submodulesJing Lu1-0/+0
* Update docs/submodules/yardstick from branch 'master' - Merge "Initial all url of api v2" - Initial all url of api v2 JIRA: YARDSTICK-648 Change-Id: I915889a974da9c49188c25fe2443ece481987ecb Signed-off-by: chenjiankun <chenjiankun1@huawei.com>
2017-07-14Update git submodulesDeepak S1-0/+0
* Update docs/submodules/samplevnf from branch 'master' - Merge "vFW: Remove unused pkt_type parameter from example cfg files" - vFW: Remove unused pkt_type parameter from example cfg files JIRA: SAMPLEVNF-53 Removing the unused pkt_type parameter. The traffic_type is used to identify the traffic type as IPv4 or IPv6. Change-Id: I22654ab9f04e2d0aa9ede3a83c68398ac2c83c63 Signed-off-by: Anand B Jyoti <anand.b.jyoti@intel.com>
2017-07-14Update git submodulesRoss Brattain1-0/+0
* Update docs/submodules/yardstick from branch 'master' - Merge "test_monitor_command: mock LOG so we don't output error" - test_monitor_command: mock LOG so we don't output error Don't print fake tracebacks to the unittest logs Change-Id: I8a468b8c6566f02be88a9dd222567c14c66b0956 Signed-off-by: Ross Brattain <ross.b.brattain@intel.com>
2017-07-14Update git submodulesVishwesh M Rudramuni1-0/+0
* Update docs/submodules/samplevnf from branch 'master' - [UDP_Replay] Adding the dynamic arp support This patch adds dynamic arp support to UDP Replay VNF. This patch fixes the performance issue observed with arp support for UDP replay. The arp support can be simply not used by not providing the "-s option" which will revert to a plain UDP replay functionality Change-Id: I565eb83cd825470d4603ed5cb8fbe32f311eb0af Signed-off-by: Vishwesh M Rudramuni <vishwesh.m.rudramuni@intel.com>