summaryrefslogtreecommitdiffstats
AgeCommit message (Collapse)AuthorFilesLines
2018-02-24Update git submodulesCédric Ollivier1-0/+0
* Update docs/submodules/functest from branch 'master' - Print env vars and env_file It simply eases detecting wrong inputs [1]. [1] https://build.opnfv.org/ci/view/functest/job/functest-apex-baremetal-daily-master/796/console Change-Id: I0784c29265c69a6ba4a049226196bcdd70b0a572 Signed-off-by: Cédric Ollivier <cedric.ollivier@orange.com>
2018-02-24Update git submodulesCédric Ollivier1-0/+0
* Update docs/submodules/functest from branch 'master' - Automatically download defcore.txt It stops writing files in Functest package dirs and cleans instance variables in refstack modules too. Change-Id: Iaddbe4fbaf12d1af207b86d4e44258efdc6d6f3a Signed-off-by: Cédric Ollivier <cedric.ollivier@orange.com>
2018-02-24Update git submodulesCédric Ollivier1-0/+0
* Update docs/submodules/functest from branch 'master' - Update Functest to meet last snaps updates It removes obsolete mockey patches in Rally unit tests and adds keystone client as params when needed in orchestra_*ims.py [1]. [1] https://gerrit.opnfv.org/gerrit/#/c/52473/ Change-Id: Id02954d16f5f54cc0c390fadb498e14c6bab6ff9 Signed-off-by: Cédric Ollivier <cedric.ollivier@orange.com>
2018-02-24Update git submodulesCedric Ollivier1-0/+0
* Update docs/submodules/functest from branch 'master' - Merge "Use functest repo variable" - Use functest repo variable related to: https://gerrit.opnfv.org/gerrit/#/c/52509/ JIRA: FUNCTEST-917 Change-Id: I79512253b37254b9247fda083500e160dba66d6f Signed-off-by: Delia Popescu <delia.popescu@enea.com>
2018-02-24Update git submoduleszhihui wu1-0/+0
* Update docs/submodules/qtip from branch 'master' - Use a fixed ubuntu 16.04 image Use a fixed ubuntu 16.04 image Change-Id: I2eeeb647c6fa55af2c0149022e03326cb03a26a5 Signed-off-by: zhihui wu <wu.zhihui1@zte.com.cn>
2018-02-24Update git submodulesYang Yu1-0/+0
* Update docs/submodules/bottlenecks from branch 'master' - bug-fix: python mimic source method JIRA: BOTTLENECK-222 Details could be referred to the above JIRA ticket Change-Id: I07d89ee85e18a78d060959cfac5ded82aa83ef32 Signed-off-by: Yang Yu <Gabriel.yuyang@huawei.com>
2018-02-24Update git submodulesSerena Feng1-0/+0
* Update docs/submodules/releng from branch 'master' - Merge "Update the postscriptbuild usage" - Update the postscriptbuild usage when we want to trigger the scipt only when previous builders fail, we should also set the other macro 'script-only-if-succeeded' to false, the default value is true. script-only-if-succeeded: false script-only-if-failed: true Change-Id: Ifdca24ea8d076dd4e16ef466705e0167b97cf1df Signed-off-by: Julien <zhang.jun3g@zte.com.cn>
2018-02-24Update git submodulesYifei Xue1-0/+0
* Update docs/submodules/compass4nfv from branch 'master' - Merge "build/arm64: separate compass-tasks" - build/arm64: separate compass-tasks Follow up https://gerrit.opnfv.org/gerrit/51227/ Change-Id: I9d86af5fe0c74b4fb06e018e783220ee6b8728ee Signed-off-by: Yibo Cai <yibo.cai@arm.com>
2018-02-24Update git submodulesGeorg Kunz1-0/+0
* Update docs/submodules/dovetail from branch 'master' - Removal of Dave Neary from the list of committers Change-Id: I06b1e53bca44f5486a64977edef8b0e53072c625 Signed-off-by: Georg Kunz <georg.kunz@ericsson.com>
2018-02-24Update git submodulesxudan1-0/+0
* Update docs/submodules/dovetail from branch 'master' - Add Functest cloudify_ims test case into proposed_tests test suite Add cloudify_ims test case into proposed_tests test suite. Then this test case can be run by Dovetail on CI. JIRA: DOVETAIL-603 Change-Id: I5ab832002388f0916e04beef9d630de2cb37df59 Signed-off-by: xudan <xudan16@huawei.com>
2018-02-24Update git submodulesJing Lu1-0/+0
* Update docs/submodules/yardstick from branch 'master' - Merge "Bug Fix: Move heat_timeout variable higher" - Bug Fix: Move heat_timeout variable higher If a heat_template was used by a testcase the heat_timeout variable was not getting initialized and that caused errors in the Shade python module. JIRA: YARDSTICK-1027 Change-Id: Ic0bf15b13cc00595964a97f8150dc5e6f2b7e1d7 Signed-off-by: Dimitrios Markou <mardim@intracom-telecom.com>
2018-02-24Update git submodulesJingLu51-0/+0
* Update docs/submodules/yardstick from branch 'master' - Add 'ANSIBLE_ROLES_PATH' in ansible_env JIRA: YARDSTICK-1024 This work adds the 'ANSIBLE_ROLES_PATH' as one of the Ansible environment variables. This 'ANSIBLE_ROLES_PATH' is set to the roles directory in Yardstick repo. By adding this variable, Ansible will first searches the local project for a role, then searches the roles_path. It will let the users of the plugin projects to able to use a relative role path for any of their own roles in ansible playbook. Change-Id: I0926ab0c0fa5c6cc37c4fe560db5b2aec3fe6eb1 Signed-off-by: JingLu5 <lvjing5@huawei.com>
2018-02-23Update git submodulesAaron Smith1-0/+0
* Update docs/submodules/barometer from branch 'master' - Merge "ansible: add ansible scripts to configure .conf file on collectd nodes" - ansible: add ansible scripts to configure .conf file on collectd nodes Change-Id: I7349582f7412088f4d303ca52eabf40afea3f5fe Signed-off-by: gordonkelly <gordon.kelly@intel.com>
2018-02-23Update git submodulesEddie Arrage1-0/+0
* Update docs/submodules/dovetail from branch 'master' - Update OVP logo and branding guide link - Update the OPNFV Verified logo for OVP portal home page - Update branding guide link in OVP portal left side navigation Change-Id: I77ead3e68b34d30d55fd07f0e4a176c5ae71852e Signed-off-by: Eddie Arrage <eddie.arrage@huawei.com>
2018-02-23Update git submodulesagardner1-0/+0
* Update docs/submodules/releng from branch 'master' - Fix naming for ansible build server stuff Botched that last change Change-Id: If44039052332738a575d62c57faae95462b489a8 Signed-off-by: agardner <agardner@linuxfoundation.org>
2018-02-23Update git submodulesagardner1-0/+0
* Update docs/submodules/releng from branch 'master' - include vars was mis named - build server ansible fix name Change-Id: I0b58dbad8bb0618623e44ffa4049fccdd80b5547 Signed-off-by: agardner <agardner@linuxfoundation.org>
2018-02-23Update git submodulesagardner1-0/+0
* Update docs/submodules/releng from branch 'master' - Disable noop for ansible build server config Time to go live. If this breaks I have shell on these machine and can fix but should be fine Change-Id: I616797cd3512b594d1daa846308e7a8643fb9cb0 Signed-off-by: agardner <agardner@linuxfoundation.org>
2018-02-23Update git submodulesagardner1-0/+0
* Update docs/submodules/releng from branch 'master' - Fix slave monitor job. must be run on the same builder each time. output goes to /tmp/ its just a textfile per slave. hasetbin stopped working, so I turend off the silly graphs. Change-Id: I7300710c338f74e5426ab3cd2e2707ac2553f982 Signed-off-by: agardner <agardner@linuxfoundation.org>
2018-02-23Update git submodulesCharalampos Kominos1-0/+0
* Update docs/submodules/fuel from branch 'master' - [MaaS] Force Maas to use a fixed ip packet size Maas uses a tftp library during commisioning which in turn uses another library which tries to find the best packet size to use. For some reason during commisioning the library uses smaller sizes than the infrastructure can handle and therefore takes a lot of time to deploy. JIRA: ARMBAND-351 Change-Id: I9b3083a059c04b118e8b7f0f2723af67d96d2aad Signed-off-by: Charalampos Kominos <charalampos.kominos@enea.com>
2018-02-23Update git submodulesCédric Ollivier1-0/+0
* Update docs/submodules/functest from branch 'master' - Switch from CONST to CONF It also removes constants.CONST and env.Environment which are now useless. Depends-On: I764a0a2a24447c941d1e726f3116593b29dd1c1e Depends-On: I6cfa832466dcefd737314633d807512e46267a69 Change-Id: Ife41c59d9f2e6ec4e49df38af962039f99554bc5 Signed-off-by: Cédric Ollivier <cedric.ollivier@orange.com>
2018-02-23Update git submodulesMarkos Chandras1-0/+0
* Update docs/submodules/releng-xci from branch 'master' - xci: scripts: start-new-vm.sh: Disable nested virtualization in clean VM When using the clean VM for the tests, we will end up with 3 levels of virtualization when functest is executed (1st level = clean vm, 2nd level = compute node, 3rd level = functest VMs). This makes the functest VM terribly slow leading to all sorts of random failures. It appears that KVM can't handle this case, so we need to switch to the QEMU interpreter instead which is slower but functional. This only affects the Jenkins jobs, so deployments on baremetal will still use 2 levels of nested KVM virtualization which should work fine. Change-Id: If274129fbf347526982ac4cf577d216173eb4d1b Signed-off-by: Markos Chandras <mchandras@suse.de> - xci: scripts: start-new-vm: Set pipefail option In commit I75a8cb8c05957bb205e63210d6cafaf54d989f32 the 'ts' utility was added in order to print timestamps for deployment. However, this breaks the exit code since 'pipefail' was not set so every job was returning 'success'. Change-Id: Ia5f47ea96a4a5be9ed0664f5c7100accc30cde51 Signed-off-by: Markos Chandras <mchandras@suse.de>
2018-02-23Update git submodulesspisarski1-0/+0
* Update docs/submodules/snaps from branch 'master' - Changed pattern on how objects lookup themselves by name and project. The pattern being replaced has unwittingly added the requirement that all creator credentials must be of type 'admin' as when looking up the associated project ID required a call to keystone.projects.list(). As the SNAPS integration tests were always creating users with an 'admin' role, this issue was not caught. As part of this patch, integration test users will no longer be admin. JIRA: SNAPS-274 Change-Id: I02957f69e31a9d4dfa63362d371f061687e59fbf Signed-off-by: spisarski <s.pisarski@cablelabs.com>
2018-02-23Update git submodulesPeriyasamy Palanisamy1-0/+0
* Update docs/submodules/sdnvpn from branch 'master' - Merge "Fixing return value in tempest test suite" - Fixing return value in tempest test suite The result processing framework of the SDNVPN project expects "FAIL" as value for failed sub-tests to determine the overall result. The value returned by the tempest sub-tests was "FAILED", causing incorrect reporting to Functest. Change-Id: I320e6f1fb1fc7ee540813e454484b11bd5b227b2 Signed-off-by: Georg Kunz <georg.kunz@ericsson.com>
2018-02-23Update git submodulesAric Gardner1-0/+0
* Update docs/submodules/releng from branch 'master' - Merge "Revert "Update Functest jobs"" - Revert "Update Functest jobs" This reverts commit 7b9734aaca2fb04d1d8750b755a2880d60176889. Change-Id: I5926d8013e57f2f0a68985b91aa8ab746bbbf1ab
2018-02-23Update git submodulesCédric Ollivier1-0/+0
* Update docs/submodules/sdnvpn from branch 'master' - Switch from CONST to CONF CONST is not the right Functest object to get config data. Change-Id: I764a0a2a24447c941d1e726f3116593b29dd1c1e Signed-off-by: Cédric Ollivier <cedric.ollivier@orange.com>
2018-02-23Update git submodulesMarkos Chandras1-0/+0
* Update docs/submodules/releng from branch 'master' - jjb: xci: xci-start-new-vm.sh: Set pipefail option In commit I77d5d66c0146f943d805612ca5b47e2eed3ffc41 the 'ts' utility was added in order to print timestamps for deployment. However, this breaks the exit code since 'pipefail' was not set so every job was returning 'success'. Change-Id: I2625a655a7334b1e43b690618821e69377075ed1 Signed-off-by: Markos Chandras <mchandras@suse.de>
2018-02-23Update git submodulesThomas Duval1-0/+0
* Update docs/submodules/moon from branch 'master' - Add unit tests in Jenkins CI Change-Id: I9a46a6b7400d92d31e99be383a37de44e3459d80
2018-02-23Update git submodulesGeorg Kunz1-0/+0
* Update docs/submodules/dovetail from branch 'master' - Committer promotion Dan Xu and removal of Leo Wang Contributions Dan Xu: Dan Xu has been almost exclusively doing the development for the Dovetail tool, CI integration, and the practical validation of test case candidates. https://gerrit.opnfv.org/gerrit/#/q/owner:%22Dan+Xu+%253Cxudan16%2540huawei.com%253E%22 Leo Wang has announced that he is stepping down as committer from the project. Thank you for your contributions to the project. https://lists.opnfv.org/pipermail/opnfv-tsc/2018-February/004130.html Change-Id: I14032657b057bdd3da1f9c3514b3c27e34dbafc0 Signed-off-by: Georg Kunz <georg.kunz@ericsson.com>
2018-02-23Update git submodulesManuel Buil1-0/+0
* Update docs/submodules/sfc from branch 'master' - Merge "Switch from CONST to CONF" - Switch from CONST to CONF CONST is not the right Functest object to get config data. It also updates the way to get constants as proposed by Functest [1]. [1] https://gerrit.opnfv.org/gerrit/#/c/52389/ Depends-On: Ie23c0ef90efc839d60f0f3a9754c58746b1f3a00 Change-Id: I6cfa832466dcefd737314633d807512e46267a69 Signed-off-by: Cédric Ollivier <cedric.ollivier@orange.com>
2018-02-23Update git submodulesXuan Jia1-0/+0
* Update docs/submodules/container4nfv from branch 'master' - Merge "Clearwater Helm Chart" - Clearwater Helm Chart Custom chart to deploy Clearwater with k8s. This patch depends of gerrit #50467 Change-Id: I5621909d768e6d91668aad9aae70869ae10acecf JIRA: CONTAINER-22 Signed-off-by: Laura Sofia Enriquez <lsofia.enriquez@gmail.com>
2018-02-23Update git submodulesTaseer Ahmed1-0/+0
* Update docs/submodules/qtip from branch 'master' - Add QTIP flavor creation/deletion JIRA: QTIP-291 Change-Id: I4f5bea70605c4f9d4451961a3aa6db3a1fb078e4 Signed-off-by: Taseer Ahmed <taseer94@gmail.com>
2018-02-23Update git submodulesAlec Hothan1-0/+0
* Update docs/submodules/nfvbench from branch 'master' - Merge "Fix for bug with external chain and no arp" - Fix for bug with external chain and no arp The validation of MAC addresses was placed incorrectly Change-Id: I9a0e1f06699eadd0dff091078c132c5664aeea56 Signed-off-by: Michael Pedersen <michael.soelvkaer@gmail.com>
2018-02-23Update git submodulesAce Lee1-0/+0
* Update docs/submodules/bottlenecks from branch 'master' - Merge "Testcase to find storage bottlenecks using Yardstick for Multistack" - Testcase to find storage bottlenecks using Yardstick for Multistack JIRA: BOTTLENECK-217 This patch is used to find storage bottlenecks while using yardstick for multistack. Change-Id: I8e64ff4145244a4aa822cf63c82d3a90a6579486 Signed-off-by: Shubham Agarwal <shubham.agarwal.coder@gmail.com>
2018-02-23Update git submodulesTim Rozet1-0/+0
* Update docs/submodules/apex from branch 'master' - Merge "barometer: fix barometer apex build" - barometer: fix barometer apex build apex-tripleo-heat-templates: I3250b57316b4ec85e0558f1b512f6f3ed7c349fb apex-puppet-tripleo: I95698d69c58e0c36ae88cc2687073a05b514592c Change-Id: I5f33cd2a2842051a77c89cb11f97e8e37d1d0185 Signed-off-by: Maryam Tahhan <maryam.tahhan@intel.com>
2018-02-22Update git submodulesYichen Wang1-0/+0
* Update docs/submodules/nfvbench from branch 'master' - [NFVBENCH-68] Skip bonding interfaces for interface discovery Change-Id: I446f02366a7d1801dc6740657bfea23f73bc27c7 Signed-off-by: Yichen Wang <yicwang@cisco.com>
2018-02-22Update git submodulesFatih Degirmenci1-0/+0
* Update docs/submodules/releng-xci from branch 'master' - Merge "xci: osa: Do not wipe cinder volumes" - xci: osa: Do not wipe cinder volumes When a volume is removed, cinder will fill the entire disk with 0s. This can slow down the volume removal process. Since we do not care what happens with the volume after it's being removed, we don't need to wipe it at all. Change-Id: I5ef1b01a18cdf2694252b450ca4f1c6a37090f71 Link: https://docs.openstack.org/cinder/latest/sample_config.html Signed-off-by: Markos Chandras <mchandras@suse.de>
2018-02-22Update git submodulesDan Radez1-0/+0
* Update docs/submodules/apex from branch 'master' - Typo fix for disabling ipxe JIRA: APEX-535 Change-Id: If1d074d01246407b322d5a4bc27dfde35349e9db Signed-off-by: Dan Radez <dradez@redhat.com>
2018-02-22Update git submodulesManuel Buil1-0/+0
* Update docs/submodules/sfc from branch 'master' - Bump SHAs for Pike Change-Id: I0b0aabffb2a5995364051fa34d218b2ebc649d4e Signed-off-by: Manuel Buil <mbuil@suse.com>
2018-02-22Update git submodulesAric Gardner1-0/+0
* Update docs/submodules/releng from branch 'master' - Merge "Jenkins not reporting lint results to gerrit" - Jenkins not reporting lint results to gerrit I set -x in a test and then it did report. not sure what's going on here, I thought this was fixed. May as well cat the violation log as we debug Change-Id: I142fb3855ebc000ee90aa24e0ecb336bb9b313df Signed-off-by: agardner <agardner@linuxfoundation.org>
2018-02-22Update git submodulesFatih Degirmenci1-0/+0
* Update docs/submodules/releng from branch 'master' - Merge "Update Pharos Dashboard Deploy Job and Disable" - Update Pharos Dashboard Deploy Job and Disable Copying the keys required for talking to JIRA and disabling the job until chages can be tested to ensure a deploy runs successfully. Change-Id: Ib3602338cfe06d5507f5d3f5b853906feb39f4c5 Signed-off-by: Trevor Bramwell <tbramwell@linuxfoundation.org>
2018-02-22Update git submodulesFatih Degirmenci1-0/+0
* Update docs/submodules/releng from branch 'master' - Merge "jjb: xci: Use the 'ts' utility to print timestamps on executed steps." - jjb: xci: Use the 'ts' utility to print timestamps on executed steps. We can use the 'ts' utility to print timestamps on every executed command so we can keep track on the duration of each task and the job overall. Change-Id: I77d5d66c0146f943d805612ca5b47e2eed3ffc41 Signed-off-by: Markos Chandras <mchandras@suse.de>
2018-02-22Update git submodulesFatih Degirmenci1-0/+0
* Update docs/submodules/releng from branch 'master' - Merge "Fix SFC Email PTL Macro" - Fix SFC Email PTL Macro Includes the name of the PTL but should be just the email. Change-Id: If6ef3b7c15defd44c6f86a24d6250840c37dd24b Signed-off-by: Trevor Bramwell <tbramwell@linuxfoundation.org>
2018-02-22Update git submodulesFatih Degirmenci1-0/+0
* Update docs/submodules/releng from branch 'master' - Merge "Update Functest jobs" - Update Functest jobs Add support for functest tier with multijob Add publishers separate for fetures and all other functest tiers Run functest features suits in a mutijob Since there are no arm specific requirements, remove arm-daily builders and jobs JIRA: FUNCTEST-917 Change-Id: I92e3d7ca378dd6d293520c679c741de4bf336639 Signed-off-by: Delia Popescu <delia.popescu@enea.com>
2018-02-22Update git submodulesEmma Foley1-0/+0
* Update docs/submodules/barometer from branch 'master' - Update mcelog.conf.erb template The <Memory> tag is required for MCELog. This was not updated in the puppet templates used by Apex. Co-Authored-By: Aaron Smith <aasmith@redhat.com> Co-Authored-By: Gordon Kelly <gordon.kelly@intel.com> Change-Id: I6b0793b33099ef448316b9abcd4f0293d7518e29 Signed-off-by: Emma Foley <emma.l.foley@intel.com>
2018-02-22Update git submodulesAlexandru Avadanii1-0/+0
* Update docs/submodules/fuel from branch 'master' - [noHA] Add dedicated cinder volume for virtual cmp Replace loop device LVM-backed cinder volume with a dedicated /dev/vdb drive. This is another small step towards bringing noHA to baremetal. Change-Id: I80f9c2bee42e933a36ab7a8f9b4c5247d1652b42 Signed-off-by: Alexandru Avadanii <Alexandru.Avadanii@enea.com>
2018-02-22Update git submodulesManuel Buil1-0/+0
* Update docs/submodules/releng-xci from branch 'master' - Update the .gitignore in roles THe prepare-functest role changed the name but .gitignore is still using the old name Change-Id: I67e962704a62756663abdc721fb8b9a9ac8648a2 Signed-off-by: Manuel Buil <mbuil@suse.com>
2018-02-22Update git submodulesMarkos Chandras1-0/+0
* Update docs/submodules/releng-xci from branch 'master' - xci: roles: configure-network: Determine host NIC from Ansible facts Hardcoding the interface as a variable is very fragile since it varies from host to host. We could use the Ansible facts to find out the interface name and then use that to configure all the VLANs and networking. Change-Id: Ie7e2409d638625b9bede23b6c1fe33dc36f81840 Signed-off-by: Markos Chandras <mchandras@suse.de>
2018-02-22Update git submodulesCedric Ollivier1-0/+0
* Update docs/submodules/functest from branch 'master' - Merge "Use constants for Functest config file" - Use constants for Functest config file env_file can't be defined in a config file simply because it's an entry point (Jenkins jobs, end users) Change-Id: Ie23c0ef90efc839d60f0f3a9754c58746b1f3a00 Signed-off-by: Cédric Ollivier <cedric.ollivier@orange.com>
2018-02-22Update git submodulesRodolfo Alonso Hernandez1-0/+0
* Update docs/submodules/yardstick from branch 'master' - Merge "Fix error in address input format in "_ip_range_action_partial"" - Fix error in address input format in "_ip_range_action_partial" IP address format introduced in [1] should be unicode instead of string. "ipaddress.IPv4Address(min_value)" doesn't parse correctly the input parameter unless the parameter is in unicode format; this is valid both for Python version 2 and 3. Execution error if the parameter is a string: >>> int(ipaddress.IPv4Address('10.0.3.2')) Traceback (most recent call last): File "<stdin>", line 1, in <module> File "/usr/local/lib/python2.7/dist-packages/ipaddress.py", line 1391, in __init__ self._check_packed_address(address, 4) File "/usr/local/lib/python2.7/dist-packages/ipaddress.py", line 554, in _check_packed_address expected_len, self._version)) ipaddress.AddressValueError: '10.0.3.2' (len 8 != 4) is not permitted as an IPv4 address. Did you pass in a bytes (str in Python 2) instead of a unic [1]https://github.com/opnfv/yardstick/blob/e5775e7efbc55f116b4d4ac11ff87b8d8553247e/yardstick/network_services/traffic_profile/traffic_profile.py#L87-L88 JIRA: YARDSTICK-996 Change-Id: Ic727a79044834b181c99789f0f5efc21c68f0ff2 Signed-off-by: Rodolfo Alonso Hernandez <rodolfo.alonso.hernandez@intel.com>
2018-02-22Update git submodulesMartin Klozik1-0/+0
* Update docs/submodules/vswitchperf from branch 'master' - Merge "LTD: Expand requirements of Soak/Long Duration Tests" - LTD: Expand requirements of Soak/Long Duration Tests In Project discussion on Jan 17, 2018 including review of RFC 8204, we identified the following five areas to improve the Soak tests. See the JIRA ticket for details. JIRA: VSPERF-557 Change-Id: I5314c283a383c57d99863fcf7262c4f28e1c12a8 Signed-off-by: Al Morton <acmorton@att.com> Reviewed-by: Martin Klozik <martinx.klozik@intel.com> Reviewed-by: Maryam Tahhan <maryam.tahhan@intel.com> Reviewed-by: Christian Trautman <ctrautma@redhat.com> Reviewed-by: Sridhar Rao <sridhar.rao@spirent.com> Reviewed-by: Trevor Cooper <trevor.cooper@intel.com> Reviewed-by: Richard Elias <richardx.elias@intel.com>