summaryrefslogtreecommitdiffstats
AgeCommit message (Collapse)AuthorFilesLines
2017-10-05Update git submodulesMarkos Chandras1-0/+0
* Update docs/submodules/releng-xci from branch 'master' - Merge changes from topics 'copy-hidden-skip-verify', 'xci-cache-skip-verify' * changes: xci: scripts: start-new-vm.sh: Copy hidden files and directories xci: scripts: vm: Add ability to use cached images for clean VM - xci: scripts: start-new-vm.sh: Copy hidden files and directories Fix the rsync command to also copy the hidden files and directories. Copying the .git directory allows us to quickly inspect any file changes when investigating bug reports and other problems. Change-Id: I4e6feeea77d5c3b23362a216206c5970b4900169 Signed-off-by: Markos Chandras <mchandras@suse.de> - xci: scripts: vm: Add ability to use cached images for clean VM Make it possible to use the hosted dib images from artifacts.opnfv.org instead of building a new one on every CI run. This way, we can reduce the time it takes to start the actual XCI deployment. Change-Id: Idb1f5e3929cc14502c3f7383a61d2fbd0a6eefaf Signed-off-by: Markos Chandras <mchandras@suse.de>
2017-10-05Update git submodulesMarkos Chandras1-0/+0
* Update docs/submodules/releng from branch 'master' - Merge "jjb: xci: Use pre-built dib images for CI runs" - jjb: xci: Use pre-built dib images for CI runs We make use of the pre-built dib images hosted on artifacts.opnfv.org instead of building a new one on every CI build. This makes the CI jobs somewhat faster since we start with the XCI deployment straight away This patchset depends on https://gerrit.opnfv.org/gerrit/#/c/44049/ Signed-off-by: Markos Chandras <mchandras@suse.de> Change-Id: Id2ccee8882cd20590a4cd27d4e512dc414d7b40e
2017-10-05Update git submodulesMarkos Chandras1-0/+0
* Update docs/submodules/releng-xci from branch 'master' - xci: file: ansible-role-requirements.yml: Bump SHA for lxc_hosts Bump the SHA for lxc_hosts so we can start using lxc-2.X.X on SUSE hosts. Change-Id: Ia4830996a66b5694a9d22f8cd067ca12163939a3 Signed-off-by: Markos Chandras <mchandras@suse.de>
2017-10-05Update git submodulesMartin Klozik1-0/+0
* Update docs/submodules/vswitchperf from branch 'master' - Merge "doc_review: Review docs for accuracy and grammar" - doc_review: Review docs for accuracy and grammar Fix issues with grammar and accuracy. JIRA: VSPERF-536 Change-Id: Ia703d306bb7a14b11e09ab4077b8adfa5fb5e6af Signed-off-by: Christian Trautman <ctrautma@redhat.com>
2017-10-05Update git submodulesAric Gardner1-0/+0
* Update docs/submodules/releng from branch 'master' - Merge "Revert "fetch_os_creds.sh: Fix unbound BUILD_TAG"" - Revert "fetch_os_creds.sh: Fix unbound BUILD_TAG" This reverts commit 3f27c8b519e42295bd76ace5506903f265e48560. Change-Id: I024ba8c0b960387138a71be9bc19f6d1b72030ca
2017-10-05Update git submodulesAric Gardner1-0/+0
* Update docs/submodules/releng from branch 'master' - Merge "Fix Yamllint violations for jjb/apex" - Fix Yamllint violations for jjb/apex JIRA: RELENG-254 Change-Id: I354d7064c560d4b23e361d556b7fe269d7fb5d26 Signed-off-by: Trevor Bramwell <tbramwell@linuxfoundation.org>
2017-10-04Update git submodulesMaciej Skrocki1-0/+0
* Update docs/submodules/yardstick from branch 'master' - Making sure yardstick container uses hosts timezone This is required for influxdb results being reported "in the future" when the timezones do not match. Change-Id: Ic41e19d26c46b6ccfa6dacddb595236af19e437a Signed-off-by: Maciej Skrocki <maciej.skrocki@intel.com>
2017-10-04Update git submodulesAlexandru Avadanii1-0/+0
* Update docs/submodules/releng from branch 'master' - armband: Fix Fuel collect job reference Armband uses different 'pod' naming/labeling, so instead of Fuel's 'baremetal' reference, we have 'armband-baremetal', leading to unresolved job references for the recently added log collection. Fix that by adding a new 'deploy-type' variable, which corresponds to either 'baremetal' or 'virtual', aligning with Fuel naming. While at it, slightly refactor our pod definitions to use the new var. Change-Id: Ie84c40a5c208072da2e4766233a844f2670d4f87 Signed-off-by: Alexandru Avadanii <Alexandru.Avadanii@enea.com>
2017-10-04Update git submodulesAlexandru Avadanii1-0/+0
* Update docs/submodules/armband from branch 'master' - u/fuel: Bump for jump bridge configuration rework Change-Id: I23100e3fd9854cd1ffd52961a0260d3c23875dd1 Signed-off-by: Alexandru Avadanii <Alexandru.Avadanii@enea.com>
2017-10-04Update git submodulesAric Gardner1-0/+0
* Update docs/submodules/releng from branch 'master' - Merge "fuel, armband: Add post mortem log collection" - fuel, armband: Add post mortem log collection Debugging test suite failures is often hard without physical access to the POD, and even then the environment might be automatically redeployed before successfully debugging the problem. So, collect all contents of </var/log> from all cluster nodes (including the Salt Master node) after all test suites have been executed as part of the CI job. Change-Id: Ie5e2526c74f4ed21be9c76c6f6101eb3f434be36 Signed-off-by: Alexandru Avadanii <Alexandru.Avadanii@enea.com>
2017-10-04Update git submodulesAlexandru Avadanii1-0/+0
* Update docs/submodules/fuel from branch 'master' - Merge "ci/deploy.sh: Move global vars to separate file" - ci/deploy.sh: Move global vars to separate file log.sh should also work as standalone script, so factor out global variables from <ci/deploy.sh> into <mcp/scripts/globals.sh>, which should be sourced by log.sh when required variables are not set. Change-Id: I5a5bb85ee5835f567d6910b11c137d95e2147714 Signed-off-by: Alexandru Avadanii <Alexandru.Avadanii@enea.com>
2017-10-04Update git submodulesAlexandru Avadanii1-0/+0
* Update docs/submodules/fuel from branch 'master' - Merge "Identify jump host bridges based on IDF / PDF nets" - Identify jump host bridges based on IDF / PDF nets - minor refactor of runtime templates parsing to allow var expansion; - parse <pod_config.yml> into shell vars, match dynamically networks from PDF to IP addresses on bridges of current jumphost; - keep old '-B' parameter in <ci/deploy.sh>, use it for providing fallback values in case there's no bridge name specified via IDF and no IP on the jumphost for one or more of the PDF networks; - re-enable dry-run to ease testing of the above; - add sample 'idf-pod1.yaml' to <mcp/config/labs/local>; The new behavior will try to determine the jump host bridge names: 1. Based on IDF mapping, if available 2. Based on PDF network matching with IP addrs on jumphost; 3. Fallback to values passed via '-B'; 4. Fallback to default values hardcoded in the deploy script; Later, we will drop MaaS network env vars in favor of PDF vars, once the PDF template is generating them. Change-Id: If9cd65d310c02965b2e2bfa06a0d7e0f97f1dd48 Signed-off-by: Alexandru Avadanii <Alexandru.Avadanii@enea.com>
2017-10-04Update git submodulesAlexandru Avadanii1-0/+0
* Update docs/submodules/releng from branch 'master' - fetch_os_creds.sh: Fix unbound BUILD_TAG Fuel baremetal deployments provide a certificate, which should be copied over to test containers. Virtual deployments do not, hence the need to determine the deployment type and decide whether the certificate should be transferred in the first place. However, the Docker args we contruct will try to map the certificate file no matter what, so we will instead try to transfer the cert from Salt Master in all deployments, and just create an empty file in case it does not exist. Change-Id: I3d3fe6cabf552a88841c529ce38446b2e54b3053 Signed-off-by: Alexandru Avadanii <Alexandru.Avadanii@enea.com>
2017-10-04Update git submodulesDeepak S1-0/+0
* Update docs/submodules/yardstick from branch 'master' - Disable VNF deploy by default Change-Id: I27bcc41c855f34fb1fd0332fc24e7bf0b2af4ec2 Signed-off-by: Deepak S <deepak.s@linux.intel.com> Signed-off-by: Ross Brattain <ross.b.brattain@intel.com>
2017-10-04Update git submodulesTim Rozet1-0/+0
* Update docs/submodules/apex from branch 'master' - Merge "Pass flags to allow domain undefine with NVRAM" - Pass flags to allow domain undefine with NVRAM Change-Id: I8365dd327d4bf7abebc72922e030b3049cd66de9 Signed-off-by: Dan Radez <dradez@redhat.com>
2017-10-04Update git submodulesAric Gardner1-0/+0
* Update docs/submodules/releng from branch 'master' - Merge "Fix minor yamllint violation in jjb/moon/moon.yml" - Fix minor yamllint violation in jjb/moon/moon.yml Without a '|' after the shell builder declaration yamllint will think the bash directive is a comment. JIRA: RELENG-254 Change-Id: Ib4e9802dbceeac1356936510ffa2efeca648076d Signed-off-by: Trevor Bramwell <tbramwell@linuxfoundation.org>
2017-10-04Update git submodulesAric Gardner1-0/+0
* Update docs/submodules/releng from branch 'master' - Merge "Fix Yamllint violations for jjb/dovetail" - Fix Yamllint violations for jjb/dovetail JIRA: RELENG-254 Change-Id: I63bb14821b5d1798fccc313a07191e5f3dec160e Signed-off-by: Trevor Bramwell <tbramwell@linuxfoundation.org>
2017-10-04Update git submodulesAric Gardner1-0/+0
* Update docs/submodules/releng from branch 'master' - Merge "Fix Yamllint violations for jjb/daisy4nfv" - Fix Yamllint violations for jjb/daisy4nfv JIRA: RELENG-254 Change-Id: I71f2879dd04cc56dc8023fc7163871e94de78eb6 Signed-off-by: Trevor Bramwell <tbramwell@linuxfoundation.org>
2017-10-04Update git submodulesAric Gardner1-0/+0
* Update docs/submodules/releng from branch 'master' - Merge "Fix Yamllint violations for jjb/calipso" - Fix Yamllint violations for jjb/calipso JIRA: RELENG-254 Change-Id: I9391e0537d2c0904daa966f56d99c96d445d00d9 Signed-off-by: Trevor Bramwell <tbramwell@linuxfoundation.org>
2017-10-04Update git submodulesAric Gardner1-0/+0
* Update docs/submodules/releng from branch 'master' - Merge "Fix Yamllint violations for jjb/xci" - Fix Yamllint violations for jjb/xci JIRA: RELENG-254 Change-Id: Iaf58cc822eb616711c0dc081f5b0154fe881646c Signed-off-by: Trevor Bramwell <tbramwell@linuxfoundation.org>
2017-10-04Update git submodulesAric Gardner1-0/+0
* Update docs/submodules/releng from branch 'master' - Merge "Fix Yamllint violations for jjb/sfc" - Fix Yamllint violations for jjb/sfc JIRA: RELENG-254 Change-Id: I3f878f50de8e0e60d3332ab8cd0ef8224524d38e Signed-off-by: Trevor Bramwell <tbramwell@linuxfoundation.org>
2017-10-04Update git submodulesAric Gardner1-0/+0
* Update docs/submodules/releng from branch 'master' - Merge "Fix Yamllint violations: jjb/vnf_forwarding_graph" - Fix Yamllint violations: jjb/vnf_forwarding_graph JIRA: RELENG-254 Change-Id: If660d0bedee12c00e385aa1f42ed3c1acc9aeb27 Signed-off-by: Trevor Bramwell <tbramwell@linuxfoundation.org>
2017-10-04Update git submodulesAric Gardner1-0/+0
* Update docs/submodules/releng from branch 'master' - Merge "Fix Yamllint violations for jjb/functest" - Fix Yamllint violations for jjb/functest JIRA: RELENG-254 Change-Id: I89043a1149360d587588e8c887f88cc5192c1692 Signed-off-by: Trevor Bramwell <tbramwell@linuxfoundation.org>
2017-10-04Update git submodulesRyota Mibu1-0/+0
* Update docs/submodules/doctor from branch 'master' - Merge "fix the way to get log filename" - fix the way to get log filename Change-Id: I9ce494c408c99e1a76a6b485db29a72c3134e487 Signed-off-by: Ryota MIBU <r-mibu@cq.jp.nec.com>
2017-10-04Update git submodulesAlexandru Avadanii1-0/+0
* Update docs/submodules/armband from branch 'master' - u/fuel: Bump for second neutron formula fixup Change-Id: I52cb9720a452c4fa7b71a9135de700f5c601132d Signed-off-by: Alexandru Avadanii <Alexandru.Avadanii@enea.com>
2017-10-04Update git submodulesTim Rozet1-0/+0
* Update docs/submodules/apex from branch 'master' - Merge "baro: update collectd-openstack branch" - baro: update collectd-openstack branch COLLECTD_OPENSTACK_GIT_BRANCH has been updated to stable/pike so that aodh changes will be picked up Previously, the branch was not actually being checked out, but was being used as a name for a new branch. This behaviour has been corrected. Change-Id: I516c4311d2a0cedcca6ec293b62c21234b1e1975 Signed-off-by: Emma Foley <emma.l.foley@intel.com>
2017-10-04Update git submodulesmbeierl1-0/+0
* Update docs/submodules/storperf from branch 'master' - Fixing test results. Change-Id: I13ea847491f2758fd2003c0b206ec7a1356f3fb2 JIRA: STORPERF-216 Signed-off-by: mbeierl <mark.beierl@dell.com>
2017-10-04Update git submodulesBertrand Souville1-0/+0
* Update docs/submodules/promise from branch 'master' - Added support for Keystone v3 JIRA: PROMISE-80 Change-Id: I5e904da373e2d5309456a6ce7ec56e724a62791f Signed-off-by: Bertrand Souville <souville@docomolab-euro.com>
2017-10-04Documentation updates for EuphratesSofia Wallin3-43/+61
Installer projects/PTLs and scenario owners Should review the installation instruction to make sure that relevant documentation is included. Feature projects/PTLs Should review the configuration guide and user guide to make sure that relevant documentation is included. All projects (participating in the Euphrates release) Should review the release notes to make sure that project specific release notes are included. Change-Id: I9d72070a22d77545225b07019a1133fcfd57257f Signed-off-by: Sofia Wallin <sofia.wallin@ericsson.com>
2017-10-04Update git submodulesDelia Popescu1-0/+0
* Update docs/submodules/releng from branch 'master' - Add OPNRC file to Yardstick container for fuel installer type OPNRC file (openstack.creds) is needed to call openstack services It was not added any longer because we added a specific case for fuel installer to send SSH_KEY, OPNRC file and OS_CACERT to the container Change-Id: I235b138a77e06cded86a0b163ef383c1c37a0469 Signed-off-by: Delia Popescu <delia.popescu@enea.com>
2017-10-04Update git submodulesFatih Degirmenci1-0/+0
* Update docs/submodules/releng-xci from branch 'master' - Fix the figure size in user guide Change-Id: I550860f574765a3035e9025e254f6d7ba110e0e4 Signed-off-by: Fatih Degirmenci <fatih.degirmenci@ericsson.com>
2017-10-04Update git submodulesMichael Polenchuk1-0/+0
* Update docs/submodules/fuel from branch 'master' - [ovs/dpdk] Add missing rootwrap sudoers policy Append required sudoers rule since uca package version of neutron has no policy for neutron-rootwrap-daemon. Change-Id: Id8ea5b1b6aadb9eca879d72ce4d158a7bc01060e Signed-off-by: Michael Polenchuk <mpolenchuk@mirantis.com>
2017-10-04Update git submodulesDeepak S1-0/+0
* Update docs/submodules/samplevnf from branch 'master' - Merge "Docs: Review and update the docs for E-release" - Docs: Review and update the docs for E-release JIRA: SAMPLEVNF-82 Review and update the the E-release docsuments. Change-Id: I1eeb0dead18559b8f05039b81512d944a862bbb4 Signed-off-by: Anand B Jyoti <anand.b.jyoti@intel.com>
2017-10-04Update git submodulesVishwesh M Rudramuni1-0/+0
* Update docs/submodules/samplevnf from branch 'master' - l2l3_stack: fixing the arp_route_tbl/nd_route_tbl This patch adds the dest ip back into the parsing logic so that legacy usage is maintained intact. Change-Id: I1e479064d7b324d871d3d5f2c166de60165c3495 Signed-off-by: Vishwesh M Rudramuni <vishwesh.m.rudramuni@intel.com>
2017-10-04Update git submodulesMarkos Chandras1-0/+0
* Update docs/submodules/releng-xci from branch 'master' - xci: scripts: start-new-vm.sh: Set JENKINS_HOME on local runs If we are creating a new virtual machine for local testing, then we should set JENKINS_HOME since some playbooks use this variable to determine if the deployment happens on a CI or not. That script aims to simulate a CI deployment so it should have this variable set. Change-Id: I1165c8b2cd467ba92fcf6f6c178a69b07834894e Signed-off-by: Markos Chandras <mchandras@suse.de>
2017-10-04Update git submodulesFeng Pan1-0/+0
* Update docs/submodules/apex from branch 'master' - Merge "Install honeycomb and vpp in a single step" - Install honeycomb and vpp in a single step We currently install Honeycomb and VPP in 2 steps, this could potentially cause version conflicts. Change-Id: I1e54a576bced07f5115b12fef3bbdf2e95e9ab90 Signed-off-by: Feng Pan <fpan@redhat.com>
2017-10-03Update git submodulesRoss Brattain1-0/+0
* Update docs/submodules/yardstick from branch 'master' - Merge "NSB PROX test hang fixes" - NSB PROX test hang fixes The PROX tests were hanging in the duration runner. These are fixes for various errors: raise error in collect_kpi if VNF is down move prox dpdk_rebind after collectd stop fix dpdk nicbind rebind to group by drivers prox: raise error in collect_kpi if the VNF is down prox: add VNF_TYPE for consistency sample_vnf: debug and fix kill_vnf pkill is not matching some executable names, add some debug process dumps and try switching back to killall until we can find the issue sample_vnf: add default timeout, so we can override default 3600 SSH timeout collect_kpi is the point at which we check the VNFs and TGs for failures or exits queues are the problem make sure we aren't silently blocking on non-empty queues by canceling join thread in subprocess fixup duration runner to close queues and other attempt to stop duration runner from hanging VnfdHelper: memoize port_num resource: fail if ssh can't connect at the end of 3600 second test our ssh connection is dead, so we can't actually stop collectd unless we reconnect fix stop() logic to ignore ssh errors Change-Id: I6c8e682a80cb9d00362e2fef4a46df080f304e55 Signed-off-by: Ross Brattain <ross.b.brattain@intel.com>
2017-10-03Update git submodulesFatih Degirmenci1-0/+0
* Update docs/submodules/releng from branch 'master' - Create euphrates jobs for remaining projects Change-Id: I1aee6c882b863ab69393ba906ae8b067a426fc3b Signed-off-by: Fatih Degirmenci <fatih.degirmenci@ericsson.com>
2017-10-03Update git submodulesAric Gardner1-0/+0
* Update docs/submodules/releng from branch 'master' - Merge "Fix Yamllint violations for jjb/fuel" - Fix Yamllint violations for jjb/fuel JIRA: RELENG-254 Change-Id: I685f8ffd22e9083ac79655ff490ca0cc5d825c9d Signed-off-by: Trevor Bramwell <tbramwell@linuxfoundation.org>
2017-10-03Update git submodulesAric Gardner1-0/+0
* Update docs/submodules/releng from branch 'master' - Merge "Fix minor yamllint violation for jjb/bottlenecks" - Fix minor yamllint violation for jjb/bottlenecks JIRA: RELENG-254 Change-Id: I9ea829209b3b2613bad5fcec10ffba743fe52ee8 Signed-off-by: Trevor Bramwell <tbramwell@linuxfoundation.org>
2017-10-03Update git submodulesAric Gardner1-0/+0
* Update docs/submodules/releng from branch 'master' - Merge "Fix Yamllint violation for jjb/doctor" - Fix Yamllint violation for jjb/doctor JIRA: RELENG-254 Change-Id: I8d9264a1bc69e5c2578886fa1a0112e19cf835b4 Signed-off-by: Trevor Bramwell <tbramwell@linuxfoundation.org>
2017-10-03Update git submodulesAric Gardner1-0/+0
* Update docs/submodules/releng from branch 'master' - Merge "Add CACERT file to Yardstick Container for fuel installer" - Add CACERT file to Yardstick Container for fuel installer CACERT file is needed for authentication to and between openstack services. Change-Id: Ic6c48ad0ac6f16c2dca82214f5b44d2f8dcac4fc Signed-off-by: Delia Popescu <delia.popescu@enea.com>
2017-10-03Update git submodulesTrevor Bramwell1-0/+0
* Update docs/submodules/releng from branch 'master' - Fix Security Scan Shortlog Format The current Anteater shortlog output still contains single and double quotes, causing comments to not be posted to Gerrit. So instead of trying to escape the quotations they should be removed entirely. JIRA: RELENG-272 Change-Id: I8a2565c85763d7617ced73702a12e28bf634678a Signed-off-by: Trevor Bramwell <tbramwell@linuxfoundation.org>
2017-10-03Update git submodulesRoss Brattain1-0/+0
* Update docs/submodules/yardstick from branch 'master' - Merge "exec_tests: remove releng clone code" - exec_tests: remove releng clone code we bind-mount the credentials into the container so we don't need to clone releng Change-Id: I838745a1470015a693f1801c93b930e8df06ef4b Signed-off-by: Ross Brattain <ross.b.brattain@intel.com>
2017-10-03Update git submodulesRoss Brattain1-0/+0
* Update docs/submodules/yardstick from branch 'master' - Merge "Ensure that at least one handler is available" - Ensure that at least one handler is available https://jira.opnfv.org/browse/YARDSTICK-773?filter=-3 Remove dependency of yardstick on utils methods Change-Id: Iadf502364a7f08c279a8f0d17d7e45e8047f4066 Signed-off-by: Edward MacGillivray <edward.s.macgillivray@intel.com>
2017-10-03Update git submodulesMichael Polenchuk1-0/+0
* Update docs/submodules/fuel from branch 'master' - Apply neutron formula patch after formula update Change-Id: I8dba3676adc8cc49731d91db7cc028a9c5b1627d Signed-off-by: Michael Polenchuk <mpolenchuk@mirantis.com>
2017-10-03Update git submodulesMarkos Chandras1-0/+0
* Update docs/submodules/releng-xci from branch 'master' - xci: xci-deploy.sh: Extend regexp when collecting env variables Not all variables start with XCI, OPNFV or OPENSTACK so extend the regexp to look for more variables. Change-Id: If3693d65eec697f6c81c608da3be5799333c28d7 Signed-off-by: Markos Chandras <mchandras@suse.de> - xci: scripts: start-new-vm.sh: Do not break on idle SSH connections Add ServerAliveInterval and ServerAliveCountMax directives in order to try and keep SSH connections alive. This aims to solve ssh timeouts like the following one on busy hypervisors: packet_write_wait: Connection to UNKNOWN port 0: Broken pipe Change-Id: I58029b41226098d6a44181434ad8653f72384e9d Signed-off-by: Markos Chandras <mchandras@suse.de>
2017-10-03Update git submodulesFatih Degirmenci1-0/+0
* Update docs/submodules/releng from branch 'master' - Merge "fuel, armband: Hard set dovetail stream to master" - fuel, armband: Hard set dovetail stream to master Fuel and Armband Euphrates jobs are always marked as failed, even when at least one sub-job passes, due to missing Dovetail job for that respective stream. Change-Id: Ibcdde75d70111e82f8498114deabaf7808cc6d74 Signed-off-by: Alexandru Avadanii <Alexandru.Avadanii@enea.com>
2017-10-03Update git submodulesTim Rozet1-0/+0
* Update docs/submodules/apex from branch 'master' - Merge "Updating the iso build to CentOS 7.4" - Updating the iso build to CentOS 7.4 JIRA: APEX-522 Change-Id: I03efc6ccad708d12f3fdabd9ace9935edb31d4bb Signed-off-by: Dan Radez <dradez@redhat.com>
2017-10-03Update git submodulesMartin Klozik1-0/+0
* Update docs/submodules/vswitchperf from branch 'master' - Merge "Removed drafts of test specificaiton now published as RFC8204. Also removed IETF license notice and added a file with link to RFC8204" - Removed drafts of test specificaiton now published as RFC8204. Also removed IETF license notice and added a file with link to RFC8204 Change-Id: I44b4cb75afeff74a58f402a7cb8816ddfbe52b87 Signed-off-by: Trevor Cooper <trevor.cooper@intel.com>