summaryrefslogtreecommitdiffstats
AgeCommit message (Collapse)AuthorFilesLines
2018-11-02Update git submodulesAric Gardner1-0/+0
* Update docs/submodules/releng from branch 'master' - Merge "Enable odl-bgpvpn-noha daily job on fuel" - Enable odl-bgpvpn-noha daily job on fuel JIRA: FUEL-393 This patch enables odl-bgpvpn-noha scenario on daily jjbs for fuel installer. Change-Id: I89e85ee004c08aea07714e678fb223a7721b29ec Signed-off-by: Stamatis Katsaounis <mokats@intracom-telecom.com>
2018-11-02Update git submodulesTim Rozet1-0/+0
* Update docs/submodules/releng from branch 'master' - Apex: Fix functest docker tag in gate job Fixes passing quotes as the value for the variable, so now what is passed is just an empty string. Change-Id: I9abb681374934fe4cf7c8024118278674880f7e9 Signed-off-by: Tim Rozet <trozet@redhat.com>
2018-11-01Update git submodulesAric Gardner1-0/+0
* Update docs/submodules/releng from branch 'master' - Merge "[builde servers] Update manifest-tool URL" - [builde servers] Update manifest-tool URL The fact returned for 'ansible_architecture' is 'x86_64' for non-ARM servers. Hard coding this now in order to pull the correct URL of the manifest tool. When arm build servers are included in this list we'll set a fact for the architecture needed in the URL. Change-Id: I1c89e8a87cc7f2ae386973f3f1088f881ae5df71 Signed-off-by: Trevor Bramwell <tbramwell@linuxfoundation.org>
2018-11-01Update git submodulesTrevor Bramwell1-0/+0
* Update docs/submodules/releng from branch 'master' - Merge "Update Pharos Dashboard Jobs" - Update Pharos Dashboard Jobs Moves the pharos dashboard jobs to their own file sperate and deploys the dashboard when changes are merged to master. Note: this may need to be manually triggered due to the timing between the container being built and it being availble to be pulled. Also includes the following changes to the job: - Uploads backups to Google Storage - Remove sudo usage as docker can be ran as the Jenkins user - Renames jobs to match general naming scheme JIRA: PHAROS-394 Change-Id: I516c4414d7b0158f1f8478214c10f0aa7d176739 Signed-off-by: Trevor Bramwell <tbramwell@linuxfoundation.org>
2018-11-01Update git submodulesTrevor Bramwell1-0/+0
* Update docs/submodules/releng from branch 'master' - Merge "Add builds for Barometer DMA docker image" - Add builds for Barometer DMA docker image Push OPNFV docker builds for barometer-dma image Change-Id: I50373233254b8315c48544bae916ccf8485e640d Signed-off-by: Tomofumi Hayashi <tohayash@redhat.com>
2018-11-01Update git submodulesAric Gardner1-0/+0
* Update docs/submodules/releng from branch 'master' - Merge "Disable jobs on zte-virtual5" - Disable jobs on zte-virtual5 This node has been offline for some time. Disabling the jobs queued for it to reduce the queue until it comes back online. Change-Id: I305dc0376c331d244599dbb4edda2e3b880383be Signed-off-by: Trevor Bramwell <tbramwell@linuxfoundation.org>
2018-11-01Update git submodulesxudan1-0/+0
* Update docs/submodules/dovetail from branch 'master' - Update classes in testcase.py 1. Remove the functions which are not called anywhere 2. Change some class methods to be static methods and instance methods Change-Id: I2e754cdff61aa34ffe899e352653ff767d4ac69d Signed-off-by: xudan <xudan16@huawei.com>
2018-10-31Update git submodulesTrevor Bramwell1-0/+0
* Update docs/submodules/releng from branch 'master' - Merge "Remove References to Securedlab" - Remove References to Securedlab PDF/IDFs have been moved out of securedlab to the Pharos repo. Any references to pulling the files from securedlab have been changed to look in pharos. Change-Id: I04608da51afdbe9ec55e3dd23c501c99946b58bb Signed-off-by: Trevor Bramwell <tbramwell@linuxfoundation.org>
2018-10-31Update git submodulesTim Rozet1-0/+0
* Update docs/submodules/releng from branch 'master' - Merge "Disable Flex jobs" - Disable Flex jobs Both flex PODs have been offline for a while. Disabling the Apex jobs scheduled on them will reduce the queue and they can be re-enabled once they come back online. Change-Id: I2f82379225ae6fc728fc655680e5ee8799a4bbbb Signed-off-by: Trevor Bramwell <tbramwell@linuxfoundation.org>
2018-10-31Update git submodulesAric Gardner1-0/+0
* Update docs/submodules/releng from branch 'master' - Merge "[fuel] Handle CI DEBUG mode" - [fuel] Handle CI DEBUG mode Change-Id: Id169e19cd465d264525bfde843e7764d4f4d5d16 Signed-off-by: Michael Polenchuk <mpolenchuk@mirantis.com>
2018-10-31Update git submodulesTrevor Bramwell1-0/+0
* Update docs/submodules/releng from branch 'master' - Merge "joid: Disable jobs" - joid: Disable jobs This change disables JOID jobs to keep build queue shorter than it is now. They can be enabled back once its situation is clarified. Change-Id: I5acdb60e5a827899fd86084a949e940d69b0a7ac Signed-off-by: Fatih Degirmenci <fdegir@gmail.com>
2018-10-31Update git submodulesCédric Ollivier1-0/+0
* Update docs/submodules/releng from branch 'master' - Set tags for first gambia and hunter releases Change-Id: Ia48c3dce052de255fb15ecbfc02656b9ed3e7f52 Signed-off-by: Cédric Ollivier <cedric.ollivier@orange.com>
2018-10-31Update git submodulesxudan1-0/+0
* Update docs/submodules/dovetail from branch 'master' - Update class in container.py Change-Id: I4fb24f86c6d15aea5a62baaca20531b2891437ff Signed-off-by: xudan <xudan16@huawei.com> - CI verify jobs failed due to the update of tox The LF pod used to run the CI verify jobs have updated the version of tox. So the CI verify jobs failed. See https://build.opnfv.org/ci/view/dovetail/job/dovetail-merge-master/476/console Fix the python format errors Ignore error 'W503 line break before binary operator'. Change-Id: Ic2df070447bbea39c877ce7a394d733a95064bb1 Signed-off-by: xudan <xudan16@huawei.com>
2018-10-30Update git submodulesCédric Ollivier1-0/+0
* Update docs/submodules/releng from branch 'master' - Revert "Avoid jenkins substitutions" This reverts commit 00431827b1a41f55fb700e69bfb229ccebc9c3f0. Change-Id: I77f0500b5e712745799dc9a7c7b94ce840e1f148 Signed-off-by: Cédric Ollivier <cedric.ollivier@orange.com>
2018-10-30Update git submodulesTrevor Bramwell1-0/+0
* Update docs/submodules/releng from branch 'master' - [Apex] Move Functest Scenario selection to script When using 'shell' builder directly '{}' is interpreted as a JJB substitution. This can be escaped with '{{}}' but breaks due to Apex use of Jinja2. Moving the entire script to a shell fixes this issue. Change-Id: I874a45cf25ca69373275849f98c89c534f3de0bb Signed-off-by: Trevor Bramwell <tbramwell@linuxfoundation.org>
2018-10-30Update git submodulesAric Gardner1-0/+0
* Update docs/submodules/releng from branch 'master' - Merge "Fix ODL restconf port if Compass" - Fix ODL restconf port if Compass It conforms with the previous port which was hardcoded in odl.py. The default value (8181) seems wrong [1]. [1] https://build.opnfv.org/ci/view/functest/job/functest-compass-baremetal-daily-gambia/7/console Change-Id: I9142d4f20a29b1f46b06bb1fed5569a299f55eff Signed-off-by: Cédric Ollivier <cedric.ollivier@orange.com>
2018-10-30Update git submodulesTim Rozet1-0/+0
* Update docs/submodules/releng from branch 'master' - Merge "Write the right default values in DOCKER_TAG" - Write the right default values in DOCKER_TAG It avoids facing with wrong substitutions [1] [1] https://build.opnfv.org/ci/job/functest-apex-baremetal-daily-gambia/23/console Change-Id: I4b8c990add51024d7984cd10668a33dd7c50c395 Signed-off-by: Cédric Ollivier <cedric.ollivier@orange.com>
2018-10-30Update git submodulesTrevor Bramwell1-0/+0
* Update docs/submodules/releng from branch 'master' - Merge "Avoid jenkins substitutions" - Avoid jenkins substitutions It's currently failing as DOCKER_TAG is replaced by '' [1]. [1] https://build.opnfv.org/ci/job/functest-apex-baremetal-daily-gambia/21/console Change-Id: I3737c683fd85f6c426fdf2720b016f3452eab0b6 Signed-off-by: Cédric Ollivier <cedric.ollivier@orange.com>
2018-10-30Update git submodulesAric Gardner1-0/+0
* Update docs/submodules/releng from branch 'master' - Merge "Create Stable Branch Jobs for bottlenecks" - Create Stable Branch Jobs for bottlenecks Change-Id: I1ddfca1afcaecf5068814276c64d312cf40455b4 Signed-off-by: jenkins-ci <jenkins-opnfv-ci@opnfv.org> Signed-off-by: Trevor Bramwell <tbramwell@linuxfoundation.org>
2018-10-30Update git submodulesFatih Degirmenci1-0/+0
* Update docs/submodules/releng from branch 'master' - Merge "Add the huawei-pod8 into CI pod list" - Add the huawei-pod8 into CI pod list Add huawei-pod8 into CI pod list for running the functest-kubernetes. Remove the arm-virtual3 pod from CI pod list. Change-Id: I0aec57f41fc4a49302e687a2600417eea6c29a0b Signed-off-by: Jingzhao Ni <jingzhao.ni@arm.com>
2018-10-30Update git submodulesCédric Ollivier1-0/+0
* Update docs/submodules/releng from branch 'master' - Fix param serialization in apex jjbs DEPLOY_SCENARIO wrongly contains DOCKER_TAG [1]. [1] https://build.opnfv.org/ci/job/functest-apex-baremetal-daily-gambia/20/console Change-Id: I85ddd47e4c15b36f507684d6d7fb9b0d90347507 Signed-off-by: Cédric Ollivier <cedric.ollivier@orange.com>
2018-10-29Update git submodulesearrage1-0/+0
* Update docs/submodules/releng from branch 'master' - Modify clovisor name to fit naming convention - Edit name of container from clovisor to clover-clovisor to match naming convention Change-Id: I37a7e6f4cdb5295bd8a0e92dcc3f8c43605adcb8 Signed-off-by: earrage <eddie.arrage@huawei.com>
2018-10-29Update git submodulesearrage1-0/+0
* Update docs/submodules/releng from branch 'master' - Add builds for Clover Spark and Clovsior - Push OPNFV docker builds for clover-spark, clover-spark-submit, and clovisor containers. Change-Id: If42ab565a48569137153511aa109bbaeeb6968aa Signed-off-by: earrage <eddie.arrage@huawei.com>
2018-10-29Update git submodulesTrevor Bramwell1-0/+0
* Update docs/submodules/releng from branch 'master' - Merge "bottlenecks gambia branch" - bottlenecks gambia branch Add Gambia branch to Bottlenecks project Change-Id: Ie698b459abcb066ac767dee72f957b9c96c7eabd Signed-off-by: Yang (Gabriel) Yu <Gabriel.yuyang@huawei.com> Signed-off-by: Trevor Bramwell <tbramwell@linuxfoundation.org>
2018-10-29Update git submodulesTrevor Bramwell1-0/+0
* Update docs/submodules/releng from branch 'master' - Merge "Create Stable Branch Jobs for auto" - Create Stable Branch Jobs for auto Change-Id: I1541a0e277891b526a671953bf33daab842b524e Signed-off-by: jenkins-ci <jenkins-opnfv-ci@opnfv.org> Signed-off-by: Trevor Bramwell <tbramwell@linuxfoundation.org>
2018-10-29Update git submodulesTrevor Bramwell1-0/+0
* Update docs/submodules/releng from branch 'master' - Merge "Run Doctor fault management and maintenance in baremetal" - Run Doctor fault management and maintenance in baremetal Run also fault management in Nokia POD to have baremetal results Change-Id: I55afee4c42365ca5d302c8ead4cbf0ad3b956e74 Signed-off-by: Tomi Juvonen <tomi.juvonen@nokia.com>
2018-10-29Update git submodulesTrevor Bramwell1-0/+0
* Update docs/submodules/releng from branch 'master' - Merge "[fuel] Define Docker tag for stable branches" - [fuel] Define Docker tag for stable branches Change-Id: Ic3c99eee282641eb15880fe18578cbee534308e5 Signed-off-by: Michael Polenchuk <mpolenchuk@mirantis.com>
2018-10-29Update git submodulesTim Rozet1-0/+0
* Update docs/submodules/releng from branch 'master' - Merge "Write tempest_conf.yaml for all OPNFV installers" - Write tempest_conf.yaml for all OPNFV installers It follows "Move tempest logics in tempest_conf.yaml" [1] and then allows passing tempest_full and tempest_scenario in OPNFV gates. It set all params for all OPNFV installers according to their last runs [2][3][4]. Live migration is out of that custom params as it's currently considered as a key feature [5]. tempest_conf.yaml should be installer-centric and shouldn't take scenarios into account. It's unclear which installers support glance API v1 which is deprecated. Any installer can ask for testing it if supported. At least Apex doesn't support it [6]. Shelve is currenlty disabled because testing it could fail the whole tempest run if unsupported. We are missing data about which installer may support it. [1] https://gerrit.opnfv.org/gerrit/#/c/64067 [2] Apex: https://artifacts.opnfv.org/logs/functest/lf-pod1/2018-10-25_02-17-25/tempest_full/tempest-report.html [3] Compass: https://artifacts.opnfv.org/logs/functest/huawei-virtual9/2018-10-24_04-54-25/tempest_full/tempest-report.html [4] Fuel: https://artifacts.opnfv.org/logs/functest/lf-pod2/gambia/2018-10-25_05-57-54/tempest_full/tempest-report.html [5] https://artifacts.opnfv.org/logs/functest/ericsson-pod1/gambia/2018-10-27_06-10-07/tempest_full/tempest-report.html [6] https://artifacts.opnfv.org/logs/functest/lf-pod1/gambia/2018-10-23_10-34-07/tempest_full/tempest-report.html Change-Id: I17c8a2d738daaf1c2e97755c99f8886da8a531aa Signed-off-by: Cédric Ollivier <cedric.ollivier@orange.com>
2018-10-29Update git submodulesCédric Ollivier1-0/+0
* Update docs/submodules/releng from branch 'master' - Define DOCKER_TAG in Functest daily job It defines DOCKER_TAG as parameter in Functest daily job. It also fixes DOCKER_TAG default value in properties files and then complete the previous commit [1]. It should fix the current gate issues [2]. [1] https://gerrit.opnfv.org/gerrit/#/c/64069/ [2] https://build.opnfv.org/ci/view/functest/job/functest-apex-baremetal-daily-gambia/18/console Change-Id: Ia531ca68a455cc20294e123286062265b9b79d6f Signed-off-by: Cédric Ollivier <cedric.ollivier@orange.com>
2018-10-26Update git submodulesCédric Ollivier1-0/+0
* Update docs/submodules/releng from branch 'master' - Set empty strings in DOCKER_TAG by default It let functest-alpine process branches right after [1]. [1] https://build.opnfv.org/ci/job/functest-apex-virtual-suite-master/241/console Change-Id: I6ed804fe9f3628f67421157433e09da3bcbf585c Signed-off-by: Cédric Ollivier <cedric.ollivier@orange.com> Signed-off-by: Tim Rozet <trozet@redhat.com>
2018-10-26Update git submodulesmei mei1-0/+0
* Update docs/submodules/releng from branch 'master' - Merge "[compass4nfv]Add missing jobs" - [compass4nfv]Add missing jobs This patch add the bottlenecks and dovetail jobs for compass Gambia branch. Change-Id: If5e4180c69c14042a075c68373a4262388f20da0 Signed-off-by: wutianwei <wutianwei1@huawei.com>
2018-10-25Update git submodulesTim Rozet1-0/+0
* Update docs/submodules/releng from branch 'master' - Apex: Fix functest docker tag injection The file needs to at least exist for the inject to work in the case where the scenario is not rocky. Change-Id: I2fca0574d69c08a13d0cc797741b276281eb3600 Signed-off-by: Tim Rozet <trozet@redhat.com>
2018-10-25Update git submodulesxudan1-0/+0
* Update docs/submodules/dovetail from branch 'master' - Stop redefine testcases.yaml for some test cases 1. For Functest healthcheck, patrole, refstack_defcore, neutron_trunk and vping test cases, stop to redefine testcases.yaml. 2. For VNF and bgpvpn, they still have scenario dependencies for Functest. How to handle them are still under consideration. 3. For other tempest test cases, they rely on tempest_custom. Leave them under discussion. JIRA: DOVETAIL-673 Change-Id: Ibd10c9883d8df3749f4a93e280deaca77fe6bc00 Signed-off-by: xudan <xudan16@huawei.com>
2018-10-24Update git submodulesTrevor Bramwell1-0/+0
* Update docs/submodules/releng from branch 'master' - Merge "Remove OPNFV Docs Euphrates Jobs" - Remove OPNFV Docs Euphrates Jobs The release is now two past and we don't need to continue building these docs. Change-Id: I072d22b69d73c06245a4efcf14661e0c7acacefc Signed-off-by: Trevor Bramwell <tbramwell@linuxfoundation.org>
2018-10-24Update git submodulesTrevor Bramwell1-0/+0
* Update docs/submodules/releng from branch 'master' - Merge "Create Stable Branch Jobs for opnfvdocs" - Create Stable Branch Jobs for opnfvdocs Change-Id: If835ce2ab7586fc503843089541d50344ce8c19e Signed-off-by: jenkins-ci <jenkins-opnfv-ci@opnfv.org> Signed-off-by: Trevor Bramwell <tbramwell@linuxfoundation.org>
2018-10-24Update git submodulesTrevor Bramwell1-0/+0
* Update docs/submodules/releng from branch 'master' - Merge "Create stable/gambia branch for docs" - Create stable/gambia branch for docs Change-Id: Ib5d5734536869dc08a787ad6624849913b8d5f4b Signed-off-by: Sofia Wallin <sofia.wallin@ericsson.com> Signed-off-by: Trevor Bramwell <tbramwell@linuxfoundation.org>
2018-10-24Update git submodulesAric Gardner1-0/+0
* Update docs/submodules/releng from branch 'master' - Create Stable Branch Jobs for storperf Changed all instances of fraser to gambia in the storperf directory Change-Id: I1f28617bfe018c0fb56753bbb9c0e939aeff3073 Signed-off-by: Aric Gardner <agardner@linuxfoundation.org>
2018-10-24Update git submodulesTim Rozet1-0/+0
* Update docs/submodules/releng from branch 'master' - Apex: Change CSIT promotion start times Moving these jobs to start earlier so that the entire EST daytime job queue isn't full. Change-Id: I2cbf8f8fa448a7447b59230abe59d9e559b518c7 Signed-off-by: Tim Rozet <trozet@redhat.com>
2018-10-23Update git submodulesAric Gardner1-0/+0
* Update docs/submodules/releng from branch 'master' - Dummy Change to releng I have deleted apex-rtd-verify-master Merging this will re-create the job. Worth a shot. Change-Id: I67809fed7e097fbc992ed090cc85e84a9ff81992 Signed-off-by: Aric Gardner <agardner@linuxfoundation.org>
2018-10-23Update git submodulesTim Rozet1-0/+0
* Update docs/submodules/releng from branch 'master' - Merge "Run Functest hunter containers if Apex Rocky" - Run Functest hunter containers if Apex Rocky It replaces Queens logics as it should be useless since new gambia jjbs have been created. From the time being, Apex jjbs run master containers which should work thanks to backward compatibility but vnfs are falsy skipped. [1]. It updates verify-jobs to run the right container (hunter in case of rocky). [1] https://build.opnfv.org/ci/view/functest/job/functest-apex-baremetal-daily-master/373/console Change-Id: I0df483eb78092e8155dd288d3c86d10b7762e433 Signed-off-by: Cédric Ollivier <cedric.ollivier@orange.com>
2018-10-23Update git submodulesTrevor Bramwell1-0/+0
* Update docs/submodules/releng from branch 'master' - Merge "[armband] Add RTD Build Jobs" - [armband] Add RTD Build Jobs Change-Id: I48a7b8a36be7a9a56110bfa4c84caf954a85fe18 Signed-off-by: Trevor Bramwell <tbramwell@linuxfoundation.org>
2018-10-23Update git submodulesCédric Ollivier1-0/+0
* Update docs/submodules/releng from branch 'master' - Set STORAGE_PROTOCOL=ceph if compass Change-Id: If5b25041933cb7f16793d440783ec14122f568e4 Signed-off-by: Cédric Ollivier <cedric.ollivier@orange.com>
2018-10-22Update git submodulesAric Gardner1-0/+0
* Update docs/submodules/releng from branch 'master' - Merge "Stop running tempest full and scenario if healthcheck fails" - Stop running tempest full and scenario if healthcheck fails JIRA: FUNCTEST-1010 Change-Id: I7a39fb38ecfb325c249224a9283d7db353668ccf Signed-off-by: Cédric Ollivier <cedric.ollivier@orange.com>
2018-10-22Update git submodulesTim Rozet1-0/+0
* Update docs/submodules/releng from branch 'master' - Merge "Allow overriding DOCKER_TAG in functest-alpine.sh" - Allow overriding DOCKER_TAG in functest-alpine.sh It's mainly required by functest-apex-baremetal-daily-master which runs vs OpenStack master and OpenStack Rocky. Change-Id: I5e32f5b507fbe79a02bf5c61e67aa7f8c24f7789 Signed-off-by: Cédric Ollivier <cedric.ollivier@orange.com>
2018-10-22Update git submodulesmei mei1-0/+0
* Update docs/submodules/releng from branch 'master' - Merge "[Compass4nfv]add missing jobs" - [Compass4nfv]add missing jobs This patch add the Functest and Yardstick jobs for compass Gambia branch. Change-Id: Icf4504841b7fe28b7ec29ae44aad01be24a691ef Signed-off-by: wutianwei <wutianwei1@huawei.com>
2018-10-22Update git submodulesTim Rozet1-0/+0
* Update docs/submodules/releng from branch 'master' - Merge "Set STORAGE_PROTOCOL=ceph if Apex" - Set STORAGE_PROTOCOL=ceph if Apex It should fix most of errors raised by tempest_full [1]. [1] https://artifacts.opnfv.org/logs/functest/lf-pod1/2018-10-20_12-23-41/tempest_full/tempest-report.html Change-Id: Ie93fe14d687a28185ac28b8c35636265a4fb4be2 Signed-off-by: Cédric Ollivier <cedric.ollivier@orange.com>
2018-10-22Update git submodulesTim Rozet1-0/+0
* Update docs/submodules/releng from branch 'master' - Merge "Revert "Select the right Functest repos when master"" - Revert "Select the right Functest repos when master" This reverts commit 751002f537007f35a536959e4180ce7c48e18bf1. Change-Id: I4c7cef7f4296686fda70011e9bf840b114f11845 Signed-off-by: Cédric Ollivier <cedric.ollivier@orange.com>
2018-10-22Update git submodulesTim Rozet1-0/+0
* Update docs/submodules/releng from branch 'master' - Merge "Revert "Apex: Enable OS master clients with Tempest"" - Revert "Apex: Enable OS master clients with Tempest" This reverts commit 2e1815d026f209e46fcc7eb29a7d4a28a48b2354. Change-Id: Idff665fdc88c0936bf7b4fb0bb895d90553ca835 Signed-off-by: Cédric Ollivier <cedric.ollivier@orange.com>
2018-10-22Update git submodulesGeorg Kunz1-0/+0
* Update docs/submodules/dovetail from branch 'master' - New PTL for Dovetail This patch is used as a basis for voting on the new Dovetail PTL. After the nomination period [1] has ended, there is one candidate [2]. In order to complete the PTL election process, all Dovetail committers shall review this patch and cast a vote (-1, +1). The voting period ends in a week from now on October 24. The vote passes if a majority of committers +1 this patch. [1] https://lists.opnfv.org/g/opnfv-tech-discuss/message/22133 [2] https://lists.opnfv.org/g/opnfv-tech-discuss/message/22145 Change-Id: Iacf53f5c0bbe7e0c5f3c47131569be72ed8623ec Signed-off-by: Georg Kunz <georg.kunz@ericsson.com>
2018-10-21Update git submodulesTim Rozet1-0/+0
* Update docs/submodules/releng from branch 'master' - Apex: Fix GS_URL path for snapshots The URL should not include the gs:// prefix Change-Id: I09d7c650f665379813eea5fbbfdbe91c1de2fabf Signed-off-by: Tim Rozet <trozet@redhat.com>