summaryrefslogtreecommitdiffstats
AgeCommit message (Collapse)AuthorFilesLines
2018-10-30Update git submodulesCédric Ollivier1-0/+0
* Update docs/submodules/releng from branch 'master' - Fix param serialization in apex jjbs DEPLOY_SCENARIO wrongly contains DOCKER_TAG [1]. [1] https://build.opnfv.org/ci/job/functest-apex-baremetal-daily-gambia/20/console Change-Id: I85ddd47e4c15b36f507684d6d7fb9b0d90347507 Signed-off-by: Cédric Ollivier <cedric.ollivier@orange.com>
2018-10-29Update git submodulesearrage1-0/+0
* Update docs/submodules/releng from branch 'master' - Modify clovisor name to fit naming convention - Edit name of container from clovisor to clover-clovisor to match naming convention Change-Id: I37a7e6f4cdb5295bd8a0e92dcc3f8c43605adcb8 Signed-off-by: earrage <eddie.arrage@huawei.com>
2018-10-29Update git submodulesearrage1-0/+0
* Update docs/submodules/releng from branch 'master' - Add builds for Clover Spark and Clovsior - Push OPNFV docker builds for clover-spark, clover-spark-submit, and clovisor containers. Change-Id: If42ab565a48569137153511aa109bbaeeb6968aa Signed-off-by: earrage <eddie.arrage@huawei.com>
2018-10-29Update git submodulesTrevor Bramwell1-0/+0
* Update docs/submodules/releng from branch 'master' - Merge "bottlenecks gambia branch" - bottlenecks gambia branch Add Gambia branch to Bottlenecks project Change-Id: Ie698b459abcb066ac767dee72f957b9c96c7eabd Signed-off-by: Yang (Gabriel) Yu <Gabriel.yuyang@huawei.com> Signed-off-by: Trevor Bramwell <tbramwell@linuxfoundation.org>
2018-10-29Update git submodulesTrevor Bramwell1-0/+0
* Update docs/submodules/releng from branch 'master' - Merge "Create Stable Branch Jobs for auto" - Create Stable Branch Jobs for auto Change-Id: I1541a0e277891b526a671953bf33daab842b524e Signed-off-by: jenkins-ci <jenkins-opnfv-ci@opnfv.org> Signed-off-by: Trevor Bramwell <tbramwell@linuxfoundation.org>
2018-10-29Update git submodulesTrevor Bramwell1-0/+0
* Update docs/submodules/releng from branch 'master' - Merge "Run Doctor fault management and maintenance in baremetal" - Run Doctor fault management and maintenance in baremetal Run also fault management in Nokia POD to have baremetal results Change-Id: I55afee4c42365ca5d302c8ead4cbf0ad3b956e74 Signed-off-by: Tomi Juvonen <tomi.juvonen@nokia.com>
2018-10-29Update git submodulesTrevor Bramwell1-0/+0
* Update docs/submodules/releng from branch 'master' - Merge "[fuel] Define Docker tag for stable branches" - [fuel] Define Docker tag for stable branches Change-Id: Ic3c99eee282641eb15880fe18578cbee534308e5 Signed-off-by: Michael Polenchuk <mpolenchuk@mirantis.com>
2018-10-29Update git submodulesTim Rozet1-0/+0
* Update docs/submodules/releng from branch 'master' - Merge "Write tempest_conf.yaml for all OPNFV installers" - Write tempest_conf.yaml for all OPNFV installers It follows "Move tempest logics in tempest_conf.yaml" [1] and then allows passing tempest_full and tempest_scenario in OPNFV gates. It set all params for all OPNFV installers according to their last runs [2][3][4]. Live migration is out of that custom params as it's currently considered as a key feature [5]. tempest_conf.yaml should be installer-centric and shouldn't take scenarios into account. It's unclear which installers support glance API v1 which is deprecated. Any installer can ask for testing it if supported. At least Apex doesn't support it [6]. Shelve is currenlty disabled because testing it could fail the whole tempest run if unsupported. We are missing data about which installer may support it. [1] https://gerrit.opnfv.org/gerrit/#/c/64067 [2] Apex: https://artifacts.opnfv.org/logs/functest/lf-pod1/2018-10-25_02-17-25/tempest_full/tempest-report.html [3] Compass: https://artifacts.opnfv.org/logs/functest/huawei-virtual9/2018-10-24_04-54-25/tempest_full/tempest-report.html [4] Fuel: https://artifacts.opnfv.org/logs/functest/lf-pod2/gambia/2018-10-25_05-57-54/tempest_full/tempest-report.html [5] https://artifacts.opnfv.org/logs/functest/ericsson-pod1/gambia/2018-10-27_06-10-07/tempest_full/tempest-report.html [6] https://artifacts.opnfv.org/logs/functest/lf-pod1/gambia/2018-10-23_10-34-07/tempest_full/tempest-report.html Change-Id: I17c8a2d738daaf1c2e97755c99f8886da8a531aa Signed-off-by: Cédric Ollivier <cedric.ollivier@orange.com>
2018-10-29Update git submodulesCédric Ollivier1-0/+0
* Update docs/submodules/releng from branch 'master' - Define DOCKER_TAG in Functest daily job It defines DOCKER_TAG as parameter in Functest daily job. It also fixes DOCKER_TAG default value in properties files and then complete the previous commit [1]. It should fix the current gate issues [2]. [1] https://gerrit.opnfv.org/gerrit/#/c/64069/ [2] https://build.opnfv.org/ci/view/functest/job/functest-apex-baremetal-daily-gambia/18/console Change-Id: Ia531ca68a455cc20294e123286062265b9b79d6f Signed-off-by: Cédric Ollivier <cedric.ollivier@orange.com>
2018-10-26Update git submodulesCédric Ollivier1-0/+0
* Update docs/submodules/releng from branch 'master' - Set empty strings in DOCKER_TAG by default It let functest-alpine process branches right after [1]. [1] https://build.opnfv.org/ci/job/functest-apex-virtual-suite-master/241/console Change-Id: I6ed804fe9f3628f67421157433e09da3bcbf585c Signed-off-by: Cédric Ollivier <cedric.ollivier@orange.com> Signed-off-by: Tim Rozet <trozet@redhat.com>
2018-10-26Update git submodulesmei mei1-0/+0
* Update docs/submodules/releng from branch 'master' - Merge "[compass4nfv]Add missing jobs" - [compass4nfv]Add missing jobs This patch add the bottlenecks and dovetail jobs for compass Gambia branch. Change-Id: If5e4180c69c14042a075c68373a4262388f20da0 Signed-off-by: wutianwei <wutianwei1@huawei.com>
2018-10-25Update git submodulesTim Rozet1-0/+0
* Update docs/submodules/releng from branch 'master' - Apex: Fix functest docker tag injection The file needs to at least exist for the inject to work in the case where the scenario is not rocky. Change-Id: I2fca0574d69c08a13d0cc797741b276281eb3600 Signed-off-by: Tim Rozet <trozet@redhat.com>
2018-10-25Update git submodulesxudan1-0/+0
* Update docs/submodules/dovetail from branch 'master' - Stop redefine testcases.yaml for some test cases 1. For Functest healthcheck, patrole, refstack_defcore, neutron_trunk and vping test cases, stop to redefine testcases.yaml. 2. For VNF and bgpvpn, they still have scenario dependencies for Functest. How to handle them are still under consideration. 3. For other tempest test cases, they rely on tempest_custom. Leave them under discussion. JIRA: DOVETAIL-673 Change-Id: Ibd10c9883d8df3749f4a93e280deaca77fe6bc00 Signed-off-by: xudan <xudan16@huawei.com>
2018-10-24Update git submodulesTrevor Bramwell1-0/+0
* Update docs/submodules/releng from branch 'master' - Merge "Remove OPNFV Docs Euphrates Jobs" - Remove OPNFV Docs Euphrates Jobs The release is now two past and we don't need to continue building these docs. Change-Id: I072d22b69d73c06245a4efcf14661e0c7acacefc Signed-off-by: Trevor Bramwell <tbramwell@linuxfoundation.org>
2018-10-24Update git submodulesTrevor Bramwell1-0/+0
* Update docs/submodules/releng from branch 'master' - Merge "Create Stable Branch Jobs for opnfvdocs" - Create Stable Branch Jobs for opnfvdocs Change-Id: If835ce2ab7586fc503843089541d50344ce8c19e Signed-off-by: jenkins-ci <jenkins-opnfv-ci@opnfv.org> Signed-off-by: Trevor Bramwell <tbramwell@linuxfoundation.org>
2018-10-24Update git submodulesTrevor Bramwell1-0/+0
* Update docs/submodules/releng from branch 'master' - Merge "Create stable/gambia branch for docs" - Create stable/gambia branch for docs Change-Id: Ib5d5734536869dc08a787ad6624849913b8d5f4b Signed-off-by: Sofia Wallin <sofia.wallin@ericsson.com> Signed-off-by: Trevor Bramwell <tbramwell@linuxfoundation.org>
2018-10-24Update git submodulesAric Gardner1-0/+0
* Update docs/submodules/releng from branch 'master' - Create Stable Branch Jobs for storperf Changed all instances of fraser to gambia in the storperf directory Change-Id: I1f28617bfe018c0fb56753bbb9c0e939aeff3073 Signed-off-by: Aric Gardner <agardner@linuxfoundation.org>
2018-10-24Update git submodulesTim Rozet1-0/+0
* Update docs/submodules/releng from branch 'master' - Apex: Change CSIT promotion start times Moving these jobs to start earlier so that the entire EST daytime job queue isn't full. Change-Id: I2cbf8f8fa448a7447b59230abe59d9e559b518c7 Signed-off-by: Tim Rozet <trozet@redhat.com>
2018-10-23Update git submodulesAric Gardner1-0/+0
* Update docs/submodules/releng from branch 'master' - Dummy Change to releng I have deleted apex-rtd-verify-master Merging this will re-create the job. Worth a shot. Change-Id: I67809fed7e097fbc992ed090cc85e84a9ff81992 Signed-off-by: Aric Gardner <agardner@linuxfoundation.org>
2018-10-23Update git submodulesTim Rozet1-0/+0
* Update docs/submodules/releng from branch 'master' - Merge "Run Functest hunter containers if Apex Rocky" - Run Functest hunter containers if Apex Rocky It replaces Queens logics as it should be useless since new gambia jjbs have been created. From the time being, Apex jjbs run master containers which should work thanks to backward compatibility but vnfs are falsy skipped. [1]. It updates verify-jobs to run the right container (hunter in case of rocky). [1] https://build.opnfv.org/ci/view/functest/job/functest-apex-baremetal-daily-master/373/console Change-Id: I0df483eb78092e8155dd288d3c86d10b7762e433 Signed-off-by: Cédric Ollivier <cedric.ollivier@orange.com>
2018-10-23Update git submodulesTrevor Bramwell1-0/+0
* Update docs/submodules/releng from branch 'master' - Merge "[armband] Add RTD Build Jobs" - [armband] Add RTD Build Jobs Change-Id: I48a7b8a36be7a9a56110bfa4c84caf954a85fe18 Signed-off-by: Trevor Bramwell <tbramwell@linuxfoundation.org>
2018-10-23Update git submodulesCédric Ollivier1-0/+0
* Update docs/submodules/releng from branch 'master' - Set STORAGE_PROTOCOL=ceph if compass Change-Id: If5b25041933cb7f16793d440783ec14122f568e4 Signed-off-by: Cédric Ollivier <cedric.ollivier@orange.com>
2018-10-22Update git submodulesAric Gardner1-0/+0
* Update docs/submodules/releng from branch 'master' - Merge "Stop running tempest full and scenario if healthcheck fails" - Stop running tempest full and scenario if healthcheck fails JIRA: FUNCTEST-1010 Change-Id: I7a39fb38ecfb325c249224a9283d7db353668ccf Signed-off-by: Cédric Ollivier <cedric.ollivier@orange.com>
2018-10-22Update git submodulesTim Rozet1-0/+0
* Update docs/submodules/releng from branch 'master' - Merge "Allow overriding DOCKER_TAG in functest-alpine.sh" - Allow overriding DOCKER_TAG in functest-alpine.sh It's mainly required by functest-apex-baremetal-daily-master which runs vs OpenStack master and OpenStack Rocky. Change-Id: I5e32f5b507fbe79a02bf5c61e67aa7f8c24f7789 Signed-off-by: Cédric Ollivier <cedric.ollivier@orange.com>
2018-10-22Update git submodulesmei mei1-0/+0
* Update docs/submodules/releng from branch 'master' - Merge "[Compass4nfv]add missing jobs" - [Compass4nfv]add missing jobs This patch add the Functest and Yardstick jobs for compass Gambia branch. Change-Id: Icf4504841b7fe28b7ec29ae44aad01be24a691ef Signed-off-by: wutianwei <wutianwei1@huawei.com>
2018-10-22Update git submodulesTim Rozet1-0/+0
* Update docs/submodules/releng from branch 'master' - Merge "Set STORAGE_PROTOCOL=ceph if Apex" - Set STORAGE_PROTOCOL=ceph if Apex It should fix most of errors raised by tempest_full [1]. [1] https://artifacts.opnfv.org/logs/functest/lf-pod1/2018-10-20_12-23-41/tempest_full/tempest-report.html Change-Id: Ie93fe14d687a28185ac28b8c35636265a4fb4be2 Signed-off-by: Cédric Ollivier <cedric.ollivier@orange.com>
2018-10-22Update git submodulesTim Rozet1-0/+0
* Update docs/submodules/releng from branch 'master' - Merge "Revert "Select the right Functest repos when master"" - Revert "Select the right Functest repos when master" This reverts commit 751002f537007f35a536959e4180ce7c48e18bf1. Change-Id: I4c7cef7f4296686fda70011e9bf840b114f11845 Signed-off-by: Cédric Ollivier <cedric.ollivier@orange.com>
2018-10-22Update git submodulesTim Rozet1-0/+0
* Update docs/submodules/releng from branch 'master' - Merge "Revert "Apex: Enable OS master clients with Tempest"" - Revert "Apex: Enable OS master clients with Tempest" This reverts commit 2e1815d026f209e46fcc7eb29a7d4a28a48b2354. Change-Id: Idff665fdc88c0936bf7b4fb0bb895d90553ca835 Signed-off-by: Cédric Ollivier <cedric.ollivier@orange.com>
2018-10-22Update git submodulesGeorg Kunz1-0/+0
* Update docs/submodules/dovetail from branch 'master' - New PTL for Dovetail This patch is used as a basis for voting on the new Dovetail PTL. After the nomination period [1] has ended, there is one candidate [2]. In order to complete the PTL election process, all Dovetail committers shall review this patch and cast a vote (-1, +1). The voting period ends in a week from now on October 24. The vote passes if a majority of committers +1 this patch. [1] https://lists.opnfv.org/g/opnfv-tech-discuss/message/22133 [2] https://lists.opnfv.org/g/opnfv-tech-discuss/message/22145 Change-Id: Iacf53f5c0bbe7e0c5f3c47131569be72ed8623ec Signed-off-by: Georg Kunz <georg.kunz@ericsson.com>
2018-10-21Update git submodulesTim Rozet1-0/+0
* Update docs/submodules/releng from branch 'master' - Apex: Fix GS_URL path for snapshots The URL should not include the gs:// prefix Change-Id: I09d7c650f665379813eea5fbbfdbe91c1de2fabf Signed-off-by: Tim Rozet <trozet@redhat.com>
2018-10-20Update git submodulesCédric Ollivier1-0/+0
* Update docs/submodules/releng from branch 'master' - Increase verify jobs timeout Verify durations have mostly been doubled without changes in Functest. Increasing the timeout allows bypassing the releng issues and falsy -1. Change-Id: I8e6244f358f18705716cf379f4ddfe8d6014a578 Signed-off-by: Cédric Ollivier <cedric.ollivier@orange.com>
2018-10-19Update git submodulesTrevor Bramwell1-0/+0
* Update docs/submodules/releng from branch 'master' - Merge "[docs] local docs building for missing submodules" - [docs] local docs building for missing submodules Some projects already moved away from OPNFV Docs git submodules. The proposed hack has a couple of problems: - it still downloads all of OPNFV docs + submodules (recursively!); - it uses Jenkins to handle gerrit clone/fetch, just to nuke it and clone the current project again; But: - it is a small change, to be replaced when global-jjb will support gsutil upload for docs preview; - it provides a locally built preview document instead of the old (complete) doc preview; Change-Id: I7426679187eb1cfabb181c59da61f3b794e50e5f Signed-off-by: Alexandru Avadanii <Alexandru.Avadanii@enea.com>
2018-10-18Update git submodulesAric Gardner1-0/+0
* Update docs/submodules/releng from branch 'master' - Remove skip vote from passing jobs. I ran all the rtd jobs that were just created all the ones that got a +1 I have removed the skip vote these jobs will vote going forward Change-Id: Ia9a7749f758b96cf1b6a46f00d08a5de7f7d9bbe Signed-off-by: Aric Gardner <agardner@linuxfoundation.org>
2018-10-18Update git submodulesAric Gardner1-0/+0
* Update docs/submodules/releng from branch 'master' - RTD jobs for all projects RTD jobs for all active projects All jobs start as non-voting. All rtd jobs are in their own file to faciliate future bulk changes: jjb/$project/$project-rtd-jobs.yaml All project have rtd pages https://opnfv-$project.readthedocs.io Change-Id: I776e41f968d38f08cb3187f743f69d5d6b697e8e Signed-off-by: Aric Gardner <agardner@linuxfoundation.org> Signed-off-by: Trevor Bramwell <tbramwell@linuxfoundation.org>
2018-10-18Update git submodulesTrevor Bramwell1-0/+0
* Update docs/submodules/releng from branch 'master' - Merge "Add arm-virtual3 pod into CI pod list" - Add arm-virtual3 pod into CI pod list Add arm-virtual3 pod into CI pod list for running the functest-kubernetes cases on arm platform. Change-Id: Iae1881320956795304896d8ea2c1790430f919da Signed-off-by: Jingzhao Ni <jingzhao.ni@arm.com>
2018-10-18Update git submodulesTrevor Bramwell1-0/+0
* Update docs/submodules/releng from branch 'master' - Merge "[dovetail] refactor the part of getting pod.yaml" - [dovetail] refactor the part of getting pod.yaml This patch should be merged after https://gerrit.opnfv.org/gerrit/#/c/63305/ Change-Id: Ic809d8de200ba1b55e18c3079587404e4077cea0 Signed-off-by: xudan <xudan16@huawei.com>
2018-10-18Update git submodulesTim Rozet1-0/+0
* Update docs/submodules/releng from branch 'master' - Functest, Yardstick, Apex: Fix missing jobs Functest/yardstick jobs are missing for Gambia. This patch adds them. Change-Id: If65bc5927dba745ff5dbd858b4e612c0f48e1ab1 Signed-off-by: Tim Rozet <trozet@redhat.com>
2018-10-18Update git submodulesAric Gardner1-0/+0
* Update docs/submodules/releng from branch 'master' - Merge "Configure daily gambia jobs for fuel installer" - Configure daily gambia jobs for fuel installer Add fuel CI PODs and armband CI PODs for gambia stream in yardstick-daily jobs Change-Id: I1b685ca4859eb476f56ceddb4368215605ad7ae5 Signed-off-by: Cristina Pauna <cristina.pauna@enea.com>
2018-10-18Update git submodulesAric Gardner1-0/+0
* Update docs/submodules/releng from branch 'master' - Merge "Fix duplicate IMAGE_PROPERTIES env variable in functest run" - Fix duplicate IMAGE_PROPERTIES env variable in functest run Update envs only once with IMAGE_PROPERTIES and FLAVOR_EXTRA_SPECS if installer type is fuel or deploy scenario is ovs or fdio Change-Id: I7c1e997cf95d30972688e697574458a3a0f1e55c Signed-off-by: Delia Popescu <delia.popescu@enea.com>
2018-10-18Update git submodulesTim Rozet1-0/+0
* Update docs/submodules/releng from branch 'master' - Apex: Do not use apex branch in promote gs path When we promote artifacts we do not want to include the apex branch (for example "gambia") in the gs path URL for where snapshots are uploaded. We may use a different apex branch to promote older OS versions of snapshots, but we still want a unified url of just apex/<os_version>/<topology> for our snapshot artifacts. Change-Id: I7dfe40558ce05d04e1805884cd6a47c82220581e Signed-off-by: Tim Rozet <trozet@redhat.com>
2018-10-17Update git submodulesTrevor Bramwell1-0/+0
* Update docs/submodules/releng from branch 'master' - Merge "Update Global-jjb to master" - Update Global-jjb to master This brings in: Skip vote for releng-rtd from gerrit trigger and three changes after it that are either innocuous or important. xmldiff: https://hastebin.com/zutufehafa.diff Change-Id: Ic5c67ff5d6aebc6fc2149b212acc3bcf7cf9951b Signed-off-by: Aric Gardner <agardner@linuxfoundation.org>
2018-10-17Update git submodulesTim Rozet1-0/+0
* Update docs/submodules/releng from branch 'master' - Apex: Adds ability to force snapshot promotion We want the ability to be able to force a promotion and skip CSIT. This patch introduces a variable we can use when manually triggering a promotion job to force promotion. The use case here is for HA scenarios we have no snapshots because CSIT always fails. We want to be able to force promotions for this case to at least have some snapshot available. Change-Id: I7e81b458f4169596929f032e9394695477fbb940 Signed-off-by: Tim Rozet <trozet@redhat.com>
2018-10-17Update git submoduleswutianwei1-0/+0
* Update docs/submodules/releng from branch 'master' - [compass4nfv] correct the compass branch docker tag Change-Id: Id789121634fc1a009878b61bcf4756ee4009c99d Signed-off-by: wutianwei <wutianwei1@huawei.com>
2018-10-17Update git submodulesmei mei1-0/+0
* Update docs/submodules/releng from branch 'master' - Merge "[dovetail] Bugfix: incorrectly exit when file doesn't exist" - [dovetail] Bugfix: incorrectly exit when file doesn't exist When checking files, it shouldn't exit when getting an non-zero results. However, the scripts set -e at the begining. In order to continue the following steps when the file doesn't exists, replace all "return 0" or "return 1" to be "echo 0/1". Change-Id: I28ea81d52182d4dc5db56d47abbfbc1761f17d81 Signed-off-by: xudan <xudan16@huawei.com>
2018-10-16Update git submodulesTrevor Bramwell1-0/+0
* Update docs/submodules/releng from branch 'master' - Merge "Create Stable Branch Jobs for doctor" - Create Stable Branch Jobs for doctor Change-Id: I2120546e49bb0a12325d299c6a3b9b54004dc569 Signed-off-by: jenkins-ci <jenkins-opnfv-ci@opnfv.org> Signed-off-by: Trevor Bramwell <tbramwell@linuxfoundation.org>
2018-10-16Update git submodulesTrevor Bramwell1-0/+0
* Update docs/submodules/releng from branch 'master' - Merge "Add builds for Clover modsecurity docker image" - Add builds for Clover modsecurity docker image Push OPNFV docker builds for clover-ns-modsecurity-crs image Change-Id: I134108d78d84de8a04bb7372c49314d0491a1248 Signed-off-by: JingLu5 <lvjing5@huawei.com>
2018-10-16Update git submodulesTrevor Bramwell1-0/+0
* Update docs/submodules/releng from branch 'master' - Merge "[storperf] Create stable/gambia branch" - [storperf] Create stable/gambia branch Change-Id: I388d5b46d206655990f3fb2723a90e8ed4397c89 Signed-off-by: Emma Foley <emma.l.foley@intel.com>
2018-10-16Update git submodulesTrevor Bramwell1-0/+0
* Update docs/submodules/releng from branch 'master' - Set JJB version in Releng CI Jobs Moves the jjb-version configuration from globals to releng CI jobs. This was not being pulled into the '{project-name}-ci-jobs' configuration and kept our JJB version at 2.2.1. Change-Id: I33a62e639bbca6d519957515af591615543d27b7 Signed-off-by: Trevor Bramwell <tbramwell@linuxfoundation.org>
2018-10-16Update git submodulesTim Rozet1-0/+0
* Update docs/submodules/releng from branch 'master' - Apex: Fix csit job blocking apex-virtual-{stream} is not being blocked and running at the same time while csit tests are running. This should stop it from running until the promotion job is finished. Change-Id: Ie164bbee08253a7e79892d36780b66fe0ad2cf97 Signed-off-by: Tim Rozet <trozet@redhat.com>
2018-10-16Update git submodulesTrevor Bramwell1-0/+0
* Update docs/submodules/releng from branch 'master' - Merge "Update Jenkins Job Builder to 2.5.0" - Update Jenkins Job Builder to 2.5.0 We need the fix: 'Allow running only on one of nodes with label parameter' https://review.openstack.org/#/c/590356/ This fix is present in 2.5.0 Change-Id: Iff9e9e6357573db382d94b688b7cfe7d42d4023c Signed-off-by: Aric Gardner <agardner@linuxfoundation.org>