summaryrefslogtreecommitdiffstats
AgeCommit message (Collapse)AuthorFilesLines
2018-08-29Update git submodulesCedric Ollivier1-0/+0
* Update docs/submodules/functest from branch 'master' - Merge "Support pre-Provisioned credentials" - Support pre-Provisioned credentials If USE_DYNAMIC_CREDENTIALS = False, Functest is expected for /home/opnfv/functest/data/accounts.yaml which contains the set of pre-existing credentials to use for testing [1]. It also sets admin_domain_scope and default_credentials_domain_name. [1] https://docs.openstack.org/tempest/latest/configuration.html Change-Id: Ie7b81f0c56049260ca99b8e3a6d58cb8a2660659 Signed-off-by: Cédric Ollivier <cedric.ollivier@orange.com>
2018-08-29Merge "Adding Dovetail documentation"Sofia Wallin2-0/+19
2018-08-29Update git submodulesFatih Degirmenci1-0/+0
* Update docs/submodules/releng from branch 'master' - xci: Remove leftover VMs before proceeding with the deployment Change-Id: I12e1dc7d79ca74df1ba02e16e55e91f4f47a818c Signed-off-by: Fatih Degirmenci <fdegir@gmail.com>
2018-08-29Update git submodulesGeorg Kunz1-0/+0
* Update docs/submodules/dovetail from branch 'master' - Updating test case requirements Updating the test case requirements document to match the new test case naming convention which was introduced for the 2018.08 release. Additionally, minor syntactic fixes. Change-Id: I34b4b90eb4f8bab4f59df2415c98c27169e98332 Signed-off-by: Georg Kunz <georg.kunz@ericsson.com>
2018-08-29Update git submodulesdimitris.tsiolakis1-0/+0
* Update docs/submodules/dovetail from branch 'master' - Release notes for OVP 2018.08 release JIRA: DOVETAIL-700 Change-Id: I6835a6d6987d8e45c85fab851304a455db3ab0d6 Signed-off-by: dimitris.tsiolakis <dmts@intracom-telecom.com>
2018-08-29Update git submodulesAlexandru Avadanii1-0/+0
* Update docs/submodules/fuel from branch 'master' - [jump vnet] Workaround MTU set race condition Older libvirt (1.x, 2.x, even older 3.x) try to enforce their own MTU (1500), overriding it back to 1500 after the udev rule finished. Delay link modification with 1 second and extend its patten to also include libvirt's own tap interfaces (<network name>-nic). Change-Id: I3050c11de7f376df02cbf203e9106b61c560683f Signed-off-by: Alexandru Avadanii <Alexandru.Avadanii@enea.com>
2018-08-29Update git submodulesrexlee87761-0/+0
* Update docs/submodules/yardstick from branch 'master' - Bugfix: ansible version should be the same both in Dockerfile and requirements.txt Because Dockerfile is using ansible script to install yardstick requirements. Or it may lead to exception when installing Yardstick. Change-Id: Ia83cf76675a7f3f1d0aa5c311e7b72be5c7ca5c3 Signed-off-by: rexlee8776 <limingjiang@huawei.com>
2018-08-29Update git submodulesmei mei1-0/+0
* Update docs/submodules/releng from branch 'master' - Merge "Add option --deploy-scenario <deploy_scenario_name> to support DPDK" - Add option --deploy-scenario <deploy_scenario_name> to support DPDK JIRA: DOVETAIL-729 Change-Id: I78c464300e329a9356cffa81e53263912486c2c2 Signed-off-by: xudan <xudan16@huawei.com>
2018-08-29Update git submodulesmei mei1-0/+0
* Update docs/submodules/releng from branch 'master' - Merge "Bottlenecks results dir has been changed" - Bottlenecks results dir has been changed Change-Id: I18a5b51c7c72a33db9864caf2635b2fcde3e8de6 Signed-off-by: xudan <xudan16@huawei.com>
2018-08-28Update git submodulesGerard Damm1-0/+0
* Update docs/submodules/auto from branch 'master' - Merge "First draft of script for Daisy installer for Auto" - First draft of script for Daisy installer for Auto JIRA: AUTO-54 Work in progress: Currently fails on the last step (oslo-config module issue). This is to capture the script in the Auto repo, for further edits. OS: CentOS. Deployment type: virtual. Change-Id: I8a0655951f227c48bf5174acbeaa02f4da6625d2 Signed-off-by: Gerard Damm <gerard.damm@wipro.com>
2018-08-28Update git submodulesCedric Ollivier1-0/+0
* Update docs/submodules/functest from branch 'master' - Merge "Remove installer type from rally blacklist" - Remove installer type from rally blacklist Enables utilization of blacklist also on non-OPNFV environments since there is no link to installer type. JIRA: FUNCTEST-1008 Change-Id: I3eb4377af153480794c1a71c5d7ef3e78dacacb9 Signed-off-by: Juha Kosonen <juha.kosonen@nokia.com>
2018-08-28Update git submodulesCedric Ollivier1-0/+0
* Update docs/submodules/functest from branch 'master' - Merge "Remove installer type from tempest blacklist" - Remove installer type from tempest blacklist Enables utilization of blacklist also on non-OPNFV environments since there is no link to installer type. JIRA: FUNCTEST-1008 Change-Id: I3a012b8b7e7dbd049f8794dff3c9d56dcc1cadad Signed-off-by: Juha Kosonen <juha.kosonen@nokia.com>
2018-08-28Adding Dovetail documentationGeorg Kunz2-0/+19
Change-Id: Iaa7187eee352a342349b2ca0bc57dddbcd1020cc Signed-off-by: Georg Kunz <georg.kunz@ericsson.com>
2018-08-28Update git submodulesCedric Ollivier1-0/+0
* Update docs/submodules/functest from branch 'master' - Merge "Allow adding a specific role to users created by tempest" - Allow adding a specific role to users created by tempest It may allow bypassing RBAC policies if required. Change-Id: I3b7ad44d7b80f8ea757846afdcd787b686c52856 Signed-off-by: Cédric Ollivier <cedric.ollivier@orange.com>
2018-08-28Update git submodulesRyota Mibu1-0/+0
* Update docs/submodules/releng from branch 'master' - Merge "remove congress test in Daisy" - remove congress test in Daisy As Daisy don't support congress currently. Change-Id: I1d70c01ef12555622d3e2800d2eba12b652fb23b Signed-off-by: dongwenjuan <dong.wenjuan@zte.com.cn>
2018-08-28Update git submodulesFatih Degirmenci1-0/+0
* Update docs/submodules/releng from branch 'master' - Merge "xci: Create virtual daily jobs for scenarios" - xci: Create virtual daily jobs for scenarios Change-Id: I2cb52d85a86bf70dfaf151606138d671e618e5d0 Signed-off-by: Fatih Degirmenci <fdegir@gmail.com>
2018-08-28Update git submodulesCedric Ollivier1-0/+0
* Update docs/submodules/functest from branch 'master' - Merge "Protect vs TypeErrors when cleaning stacks" - Protect vs TypeErrors when cleaning stacks It protects vs exceptions raised by shade when cleaning stacks. Traceback (most recent call last): File "/usr/lib/python2.7/site-packages/functest/opnfv_tests/vnf/ims/heat_ims.py", line 226, in clean self.cloud.delete_stack(self.stack.id, wait=True) File "/usr/lib/python2.7/site-packages/shade/openstackcloud.py", line 1416, in delete_stack marker=marker) File "/usr/lib/python2.7/site-packages/shade/_heat/event_utils.py", line 90, in poll_for_events stack_status = stack['stack_status'] TypeError: 'NoneType' object has no attribute '__getitem__' Change-Id: I1a0ed0cd669d5234ca1ff3b6bbc9d1b13f14b02f Signed-off-by: Cédric Ollivier <cedric.ollivier@orange.com>
2018-08-28Update git submodulesFatih Degirmenci1-0/+0
* Update docs/submodules/releng-xci from branch 'master' - Merge "Move OSM variables to os-nosdn-osm scenario" - Move OSM variables to os-nosdn-osm scenario This change removes OSM variables from releng-xci repo since they are declared in os-nosdn-osm scenario itself in releng-xci-scenarios repo. In order for this change to be verified, below change must be submitted. https://gerrit.opnfv.org/gerrit/#/c/61205/ installer-type:osa deploy-scenario:os-nosdn-osm Change-Id: I9f3a1dbdfecfb2bb08cc215758bdc52aefcdf697 Signed-off-by: Fatih Degirmenci <fdegir@gmail.com>
2018-08-28Update git submodulesxudan1-0/+0
* Update docs/submodules/dovetail from branch 'master' - Change Bottlenecks volume mapping If mapping to host's /tmp, it won't clean all .log and .out files before run a new test. It causes the results file including all previous results. See https://build.opnfv.org/ci/view/dovetail/job/dovetail-apex-baremetal-default-mandatory-master/26/artifact/results/stress_logs/bottlenecks.stress.ping.out/*view*/ It will affect the results check. Mapping to DOVETAIL_HOME/results/bottlenecks, which will always be cleaned before running another test. Change-Id: I22bfc871d6f041ae38308bf8e8f685993a376973 Signed-off-by: xudan <xudan16@huawei.com>
2018-08-28Update git submodulesRex Lee1-0/+0
* Update docs/submodules/yardstick from branch 'master' - Merge "Bugfix: openstack router list broken in Yardstick container - dovetail" - Bugfix: openstack router list broken in Yardstick container - dovetail Dependancy of python-openstackclient is not constrained. This patch specify openstacksdk and openstackclient's version according to [1]. This patch apply for bugfix and need to backported to fraser stable branch. Continual work need to be done in Gambia according to YARDSTICK-1398. [1] https://github.com/openstack/requirements/blob/stable/pike/upper-constraints.txt JIRA: DOVETAIL-728 Change-Id: I57c718e192699ac322150458d18508b06c93d22b Signed-off-by: rexlee8776 <limingjiang@huawei.com>
2018-08-28Update git submodulesCédric Ollivier1-0/+0
* Update docs/submodules/functest from branch 'master' - Fix snaps commit id Snaps is part of main Functest testcases (Healthcheck). A fixed version has to be pulled. We will switch later to snaps packages instead of commit ids. Change-Id: Ibbc3f1009233ccfb67463b49203b756ea86d3121 Signed-off-by: Cédric Ollivier <cedric.ollivier@orange.com>
2018-08-28Update git submodulesYibo Cai1-0/+0
* Update docs/submodules/releng from branch 'master' - container4nfv: fix command line syntax error Change-Id: Ib4bbf639c3a1c80eec9a9e3d52c17e934a465ce1 Signed-off-by: Yibo Cai <yibo.cai@arm.com>
2018-08-27Update git submodulesGeorg Kunz1-0/+0
* Update docs/submodules/dovetail from branch 'master' - Shortening headings and testing building of docs This patch shortens the headings and is used to test if the docs tool chain builds the right version. Change-Id: Ibc162be1b46ff787a90510c360881234391c5ba7 Signed-off-by: Georg Kunz <georg.kunz@ericsson.com>
2018-08-27Update git submodulesCédric Ollivier1-0/+0
* Update docs/submodules/functest from branch 'master' - Support VIO (VMware in OpenStack) It allows converting all images to vmdk and then patching all testcases. DEPLOY_SCENARIO should match vio to do so. convert_images.sh has to be called as prerequisite. JIRA: FUNCTEST-992 JIRA: FUNCTEST-993 Change-Id: Ie35bf80af1cd9610a8c416ec01b81b61c6148cfe Signed-off-by: Cédric Ollivier <cedric.ollivier@orange.com>
2018-08-27Update git submodulesCédric Ollivier1-0/+0
* Update docs/submodules/functest from branch 'master' - Use only one image in heat_ims It calls VmReady2.run instead of publishing alt image. Change-Id: If24741fbc5bf7fa3f61ef39a054b148ce53fc4fc Signed-off-by: Cédric Ollivier <cedric.ollivier@orange.com> - Avoid duplicating jjb names It allows loading functest and functest-kubernetes jjbs in one Jenkins. Change-Id: Ia52e84583bc25aad0d1508096b536cbd5585d261 Signed-off-by: Cédric Ollivier <cedric.ollivier@orange.com>
2018-08-27Update git submodulesRodolfo Alonso Hernandez1-0/+0
* Update docs/submodules/yardstick from branch 'master' - Merge "Change tc_trex files to execute standalone tests" - Change tc_trex files to execute standalone tests Changes made in test cases for trex TG files to be able to run tests for standalone setup (OVS-DPDK/SRIOV). - tg__0: trafficgen_1 Changes to improve templates for tc_trex: - flavor: images: changed to default name: yardstick-nsb-image.img - default path for files under contexts section - RAM size JIRA: YARDSTICK-1368 Change-Id: Ida85de219acd566840de1a94975b8050c7f59b9b Signed-off-by: Stepan Andrushko <stepanx.andrushko@intel.com>
2018-08-27Update git submodulesAlexandru Avadanii1-0/+0
* Update docs/submodules/fuel from branch 'master' - [jump vnet] Fix udev rule event for older libvirt Older libvirt seems to raise 'change' events instead of 'add', so the MTU bump of the libvirt managed tap interfaces was not properly applied. Change-Id: Ie1a4f1c4f235ad4f83bf9ee218a40dcedc1ce914 Signed-off-by: Alexandru Avadanii <Alexandru.Avadanii@enea.com>
2018-08-27Update git submodulesRodolfo Alonso Hernandez1-0/+0
* Update docs/submodules/yardstick from branch 'master' - Merge "Make TRex IMIX traffic mode configurable" - Make TRex IMIX traffic mode configurable Enable TRex IMIX generation using two modes: - Distribution in packages. - Distribution in byes. The default one will be distribution in packages, like the default one in IxNetwork. JIRA: YARDSTICK-1397 Change-Id: I86b2527968496218b0515349fc0a2680a84261e5 Signed-off-by: Rodolfo Alonso Hernandez <rodolfo.alonso.hernandez@intel.com>
2018-08-27Update git submodulesManuel Buil1-0/+0
* Update docs/submodules/releng-xci from branch 'master' - Align idfs and separate admin and management According to OpenStack admin is the network for pxe boot and mgmt is the network for OpenStack services to communicate. We were using both in XCI indistinctly Change-Id: I3959e767098ac2be7161a5e84735fde9ab129784 Signed-off-by: Manuel Buil <mbuil@suse.com>
2018-08-27Update git submodulesCédric Ollivier1-0/+0
* Update docs/submodules/functest from branch 'master' - Set juju wait version It's mandatory before releasing. Change-Id: Iac7b49fb1061b39ee6683e7b30f163cfc2060a95 Signed-off-by: Cédric Ollivier <cedric.ollivier@orange.com> - Set Neutron and Barbican tempest plugins commit ids They are mandatory before releasing. Change-Id: I2980536e28d183343ff0a9520ca9ee663e437fee Signed-off-by: Cédric Ollivier <cedric.ollivier@orange.com> - Remove INSTALLER_TYPE logics in odl JIRA: APEX-621 JIRA: COMPASS-606 Change-Id: I76dde66aefc67f80b40496f705f2864ea9355dcf Signed-off-by: Cédric Ollivier <cedric.ollivier@orange.com> - Update pip to last version It allows downloading refs (gerrit reviews). Change-Id: I303f9b753f560fdf945997c7a86e1e29fbd59a06 Signed-off-by: Cédric Ollivier <cedric.ollivier@orange.com>
2018-08-27Update git submodulesrexlee87761-0/+0
* Update docs/submodules/yardstick from branch 'master' - ping bottlenecks failed when security group rule do not support ipv6 - dovetail JIRA: YARDSTICK-1380 Change-Id: I2163eeb9ab17e4f0216ddaed688e78acdf51a1ff Signed-off-by: rexlee8776 <limingjiang@huawei.com>
2018-08-27Update git submodulesYibo Cai1-0/+0
* Update docs/submodules/compass4nfv from branch 'master' - Merge "build: add harbor tgz for arm64" - build: add harbor tgz for arm64 Currently, it's only an empty file to satisfy build.sh. Will update when harbor arm64 image ready. Change-Id: Iebb327912c4c7997eddaa28d9738137f8de0ee9e Signed-off-by: Yibo Cai <yibo.cai@arm.com>
2018-08-27Update git submodulesJing Lu1-0/+0
* Update docs/submodules/yardstick from branch 'master' - Merge "Make security group configurable - dovetail" - Make security group configurable - dovetail Make sercurity group can be configured via the context. The format would be: context: name: demo image: yardstick-image flavor: yardstick-flavor user: ubuntu security_group: rules: - remote_ip_prefix: "0.0.0.0/0" protocol: "tcp" port_range_min: 1 port_range_max: 65535 - remote_ip_prefix: "0.0.0.0/0" protocol: "udp" port_range_min: 1 port_range_max: 65535 - remote_ip_prefix: "0.0.0.0/0" protocol: "icmp" JIRA: YARDSTICK-1360 Change-Id: I00c45767ee2d70b790590e824599d5a4c274bced Signed-off-by: rexlee8776 <limingjiang@huawei.com>
2018-08-27Update git submodulesHarry Huang1-0/+0
* Update docs/submodules/compass4nfv from branch 'master' - Merge "Ignore patch osa error" - Ignore patch osa error JIRA: - Rerun patching will cause error which can be ignored Change-Id: I29846f9d7768836a4b5221d2a7e3f70a4fda8219 Signed-off-by: Harry Huang <huangxiangyu5@huawei.com>
2018-08-27Update git submodulesHarry Huang1-0/+0
* Update docs/submodules/compass4nfv from branch 'master' - Add entry for stor4nfv scenario JIRA: - opensds.yml will always be execuated even if it's not stor4nfv scenario because of no condition check. Add an entry to control all stor4nfv tasks Change-Id: I329acb674dab5bc5644127a1d6846cf0b2e3522a Signed-off-by: Harry Huang <huangxiangyu5@huawei.com>
2018-08-27Update git submodulesGuo Ruijing1-0/+0
* Update docs/submodules/container4nfv from branch 'master' - fix timeout issue and disalbe kubeadm_basic & kubeadm_istio Change-Id: I9aabbdbe4c0805498f104d8eafabc8da0d258ad2 Signed-off-by: Guo Ruijing <ruijing.guo@intel.com>
2018-08-25Update git submodulesCédric Ollivier1-0/+0
* Update docs/submodules/functest from branch 'master' - Fully remove CreateInstanceSingleNetworkTests It's linked to a specific configuration on purpose which doesn't meet all OpenStack deployments [1]. JIRA: SNAPS-322 Change-Id: I372f8ed56600e1846383d1da76720a0d3783e901 Signed-off-by: Cédric Ollivier <cedric.ollivier@orange.com>
2018-08-25Update git submodulesCedric Ollivier1-0/+0
* Update docs/submodules/functest from branch 'master' - Merge "Auto Generated INFO.yaml file" - Auto Generated INFO.yaml file INFO.yaml meant to be machine readable. This file was auto generated from an ldap lookup and your projects INFO file. Meeting times are not currently filled out. please ammend this patchset to complete Going forward comitter promotions should be done against this file. PTLs: Must be merged for you to gain delete access on testresults.opnfv.org Change-Id: Icbe20cdc100c37203a305617fa931ef9e76e4e12 Signed-off-by: agardner <agardner@linuxfoundation.org>
2018-08-25Update git submodulesCedric Ollivier1-0/+0
* Update docs/submodules/functest from branch 'master' - Merge "Integrate Stor4NFV feature openstack test case" - Integrate Stor4NFV feature openstack test case Change-Id: I245d0fbe8f026a24138ede4041caae4dccc15cc0 Signed-off-by: Qiaowei Ren <qiaowei.ren@intel.com>
2018-08-25Update git submodulesAlexandru Avadanii1-0/+0
* Update docs/submodules/fuel from branch 'master' - [build.sh] Fix quotes, missing deb arch for repo JIRA: FUEL-383 Change-Id: Ie4374d44993bd738b90e9b6e357014d0c5657da0 Signed-off-by: Alexandru Avadanii <Alexandru.Avadanii@enea.com>
2018-08-24Update git submodulesAlexandru Avadanii1-0/+0
* Update docs/submodules/fuel from branch 'master' - [build.sh] Use pipenv run instead of shell JIRA: FUEL-383 Change-Id: Ia1b58f9e7eefd9f3efc4b5241ec496c545ccee25 Signed-off-by: Alexandru Avadanii <Alexandru.Avadanii@enea.com>
2018-08-24Update git submodulesTim Rozet1-0/+0
* Update docs/submodules/releng from branch 'master' - Merge "Revert "CPERF: Fix csit odltools install"" - Revert "CPERF: Fix csit odltools install" This reverts commit 38ca028551d2e498fdfe41627f8bf79a43a6a0fa. Change-Id: If37f0d40a50b410004d563bed5887f8237110d44
2018-08-24Update git submodulesAlexandru Avadanii1-0/+0
* Update docs/submodules/fuel from branch 'master' - [build.sh] Add local python bin dir to PATH JIRA: FUEL-383 Change-Id: I5596ed6139317d72fceae3af89e71181aefbd6a3 Signed-off-by: Alexandru Avadanii <Alexandru.Avadanii@enea.com>
2018-08-24Update git submodulesAlexandru Avadanii1-0/+0
* Update docs/submodules/fuel from branch 'master' - [build.sh] Enable push, minor fixes * default to enable pushing to public docker registry; * fix prerequisites path; * fix unknown terminal in Jenkins jobs; JIRA: FUEL-383 Change-Id: Ie27dfbca6965c218475060da390a82921799b044 Signed-off-by: Alexandru Avadanii <Alexandru.Avadanii@enea.com>
2018-08-24Update git submodulesAlexandru Avadanii1-0/+0
* Update docs/submodules/armband from branch 'master' - u/fuel: Bump & rebase for OVS 2.9 Change-Id: I46241d5820c907df447717eb04e4508cc89a8aa9 Signed-off-by: Alexandru Avadanii <Alexandru.Avadanii@enea.com>
2018-08-24Update git submodulesTim Rozet1-0/+0
* Update docs/submodules/apex from branch 'master' - Adds deployment via snapshot New arguments are added to allow snapshot deployment: --snapshot, --snap-cache The previous tripleo-quickstart code has been removed/replaced with the snapshot option. Snapshot deployments are supported on CentOS and Fedora, and snapshot artifacts use a similar caching system as the standard deployment. Snapshots are produced daily by Apex, and include latest as well as n-1 OpenStack versions. The os-odl-nofeature scenario is used for the snapshots. Additionally multiple topology verions of Snapshots are available. The Snapshot pulled at deploy time depends on the deploy-settings and number of virtual-computes used at deploy time. Since there is only one network used with snapshot deployments (admin), there is no reason to pass in network settings for snapshot deployments. That argument is now optional. Previously we required even in Standard virtual deployments that the network settings be provided. However that is also unnecessary, as we can default to the virtual network settings. Includes minor fix to the tox.ini to allow specifying test cases to run (useful for developers writing tests). Default behavior of tox is unchanged. JIRA: APEX-548 Change-Id: I1e08c4e54eac5aae99921f61ab7f69693ed12b47 Signed-off-by: Tim Rozet <trozet@redhat.com>
2018-08-24Update git submodulesvalentin boucher1-0/+0
* Update docs/submodules/functest from branch 'master' - Merge "Create new project/user for snaps tests" - Create new project/user for snaps tests JIRA: FUNCTEST-1003 Change-Id: Ic55998977386f95f619a355d22bd285782fe81f0 Signed-off-by: Juha Kosonen <juha.kosonen@nokia.com>
2018-08-24Update git submodulesFatih Degirmenci1-0/+0
* Update docs/submodules/releng from branch 'master' - xci: Adjust build blockers and fix functest preparation Functest preparation is moved into the deployment job to ensure things are prepared before we are done and functest job gets triggered. Making the preparation in functest job will cause us to either reinitialize venv or depend on deployment job directory. Apart from that, the env vars necessary for functest are available within deployment job anyways so reusing that will make running functest simpler. See the comments in xci-daily-jobs.yaml builder macros. Change-Id: I4c5bbe5f4b31bb620986d75ba78de6c0fe442975 Signed-off-by: Fatih Degirmenci <fdegir@gmail.com>
2018-08-24Update git submodulesMichael Polenchuk1-0/+0
* Update docs/submodules/fuel from branch 'master' - [noha] Get OVS 2.9 & DPDK 17.11 from UCA repo Align all noha scenarios to install OVS 2.9 which doesn't drop packets on bridge with netdev datapath type at initial stage. Change-Id: Iab204828ac7acefcb26647cdbc27805871904f2c Signed-off-by: Michael Polenchuk <mpolenchuk@mirantis.com>
2018-08-24Update git submodulesVenkata Harshavardhan Reddy Allu1-0/+0
* Update docs/submodules/sfc from branch 'master' - Added unit tests for 'odl_utils.py' module JIRA: SFC-123 Change-Id: I49b8dae157816ef04a45dea188cc7dbe3aa72d4a Signed-off-by: Venkata Harshavardhan Reddy Allu <venkataharshavardhan_ven@srmuniv.edu.in>