summaryrefslogtreecommitdiffstats
AgeCommit message (Collapse)AuthorFilesLines
2018-03-29Update git submodulesChristian Trautman1-0/+0
* Update docs/submodules/vswitchperf from branch 'master' - rhel_epel_fix: Fix installation of spel for sshpass RHEL does not have an epel-release package available from default repos. Removes this install to use fedora epel release to allow sshpass to install correctly. Change-Id: Ie313857420cb4eb2342128b5d11e769670ae70a0 Signed-off-by: Christian Trautman <ctrautma@redhat.com>
2018-03-29Update git submodulesQiLiang1-0/+0
* Update docs/submodules/clover from branch 'master' - CI add timeout for k8s+istio deployment Issue link: https://build.opnfv.org/ci/view/clover/job/clover-daily-deploy-master/13/ Clover daily job often failed, which is caused by bad network at utc 12:OO. (Heavy ci job running in huawei lab at that time.) Find another time slot for clover daily job. https://gerrit.opnfv.org/gerrit/#/c/54589/ Change-Id: I0a9eb3ba0c63a3c440627a7af5afb302dbdaebb5 Signed-off-by: QiLiang <liangqi1@huawei.com>
2018-03-29Update git submodulesSerena Feng1-0/+0
* Update docs/submodules/releng from branch 'master' - Merge "Allow zte-pod9 pushing results to artifacts" - Allow zte-pod9 pushing results to artifacts For the new scenario 'os-nosdn-ovs_dpdk-noha' for daisy in Fraser. Change-Id: I331e276c2355d37d54ac0b7436593d8e0f049dfa Signed-off-by: Alex Yang <yangyang1@zte.com.cn>
2018-03-29Update git submodulesMichael Polenchuk1-0/+0
* Update docs/submodules/fuel from branch 'master' - [odl] Setup manager target after ovs host config Change-Id: Ia517b7cf1723a5afaf43cb0709716f3a67a29e9f Signed-off-by: Michael Polenchuk <mpolenchuk@mirantis.com>
2018-03-28Update git submodulesBertrand Souville1-0/+0
* Update docs/submodules/doctor from branch 'master' - Merge "support MCP installer" - support MCP installer 1.support MCP installer 2.optimize the installer code JIRA: DOCTOR-121 Change-Id: I8675c2652944575a8f73d0d1e2dafaad5a3e88e3 Signed-off-by: dongwenjuan <dong.wenjuan@zte.com.cn>
2018-03-28Update git submodulesMarkos Chandras1-0/+0
* Update docs/submodules/releng-xci from branch 'master' - Merge "xci: bifrost: Only use libvirt as DNS server if using proxy servers" - xci: bifrost: Only use libvirt as DNS server if using proxy servers Commit 0d332a80cf731e5927c81c9f6929a8b83d43cddd ("Add proxy support") switched the default DNS server to the libvirt bridge. However, we only need to override the default DNS if we are behind a proxy server. Change-Id: I7d8fe8c10a1aba2db4a703a81e74ef76fa593d95 Signed-off-by: Markos Chandras <mchandras@suse.de>
2018-03-28Update git submodulesMarkos Chandras1-0/+0
* Update docs/submodules/releng-xci from branch 'master' - Merge "xci: Check XCI playbooks using ansible-lint" - xci: Check XCI playbooks using ansible-lint The ansible-lint tool can help with maintaining consistency across all the XCI playbooks, so lets introduce it early in the process to capture common mistakes before the actual XCI deployment is executed. This however needs to run after all the scenarios repositories have been cloned and configured. Change-Id: I28104429e3ac0cdbc48a003b163f4fb8c3acd8a7 Link: https://github.com/willthames/ansible-lint Signed-off-by: Markos Chandras <mchandras@suse.de>
2018-03-28Update git submodulesMarkos Chandras1-0/+0
* Update docs/submodules/releng-xci from branch 'master' - Merge "xci: playbooks: Fixes various ansible-lint warnings" - xci: playbooks: Fixes various ansible-lint warnings In preparation for adding support for the 'ansible-lint' tool we fix various problems in our playbooks to make the tool happy before we make it mandatory. Some of the problems that are fixed here are - [ANSIBLE0011] All tasks should be named - [ANSIBLE0012] Commands should not change things if nothing needs doing - [ANSIBLE0013] Use shell only when shell functionality is required - [ANSIBLE0010] Package installs should not use latest installer-type:osa deploy-scenario:os-nosdn-nofeature Change-Id: I66c759d3932a414b81b2846393d2d98ce80c0b6d Signed-off-by: Markos Chandras <mchandras@suse.de>
2018-03-28Update git submodulesMarkos Chandras1-0/+0
* Update docs/submodules/releng-xci from branch 'master' - Merge "xci: get-opnfv-scenario-requirements: Use checksum for rsync updates" - xci: get-opnfv-scenario-requirements: Use checksum for rsync updates Rsync will update modification times on transferred files so Ansible marks the task as 'changed' all the time even though the source and destination files are the same. This is confusing for XCI developers because they may think that there are local changes to the scenarios which is not always the case. As such, compare the 'checksums' of the actual files to determine if there are any changes that need to be copied over. This requires us to turn off the 'archive' option and use the individual options directly. This fixes the following problem where in a typical XCI job, all inbound scenarios appear to have changes which is not true. Mar 26 15:10:24 TASK [Synchronize local changes to scenarios' master branch] ******************* Mar 26 15:10:24 ok: [localhost] => (item=os-odl-sfc) Mar 26 15:10:25 changed: [localhost] => (item=os-nosdn-nofeature) Mar 26 15:10:25 changed: [localhost] => (item=os-odl-nofeature) Mar 26 15:10:25 changed: [localhost] => (item=k8-nosdn-nofeature) Mar 26 15:10:26 ok: [localhost] => (item=os-odl-bgpvpn) Change-Id: I14f446c341a675b286e971f0b5c0be14d04abb9d Signed-off-by: Markos Chandras <mchandras@suse.de>
2018-03-28Update git submodulesMarkos Chandras1-0/+0
* Update docs/submodules/releng-xci from branch 'master' - xci: infra: bifrost: Make sure XCI variables are defined first It's best to define all the XCI variables before everything else to ensure that all subsequent bifrost variables are properly defined. Change-Id: Id4a9e0c89e8dd32b852cfef6b9bb336c4b75f5a7 Signed-off-by: Markos Chandras <mchandras@suse.de>
2018-03-28Update git submodulesRicardo Noriega1-0/+0
* Update docs/submodules/apex from branch 'master' - Generalization of recursive function Now, SDN_MAP is not needed to have a boolean true value, but it will check internally posible value formats such dicts and tuples. Change-Id: Idaf492952a7dd9e48e16f42dcbf5c59d981dd535 Signed-off-by: Ricardo Noriega <rnoriega@redhat.com>
2018-03-28Update git submodulesTim Rozet1-0/+0
* Update docs/submodules/releng from branch 'master' - Apex: Updates promotion jobs Change-Id: I37c7b8b6e4bd19ef94b9b42fe2e5e89cc3e2da21 Signed-off-by: Tim Rozet <trozet@redhat.com>
2018-03-28Update git submodulesTim Rozet1-0/+0
* Update docs/submodules/releng from branch 'master' - Apex: Adds parsing scenario on artifact download Download was not properly being skipped on upstream scenarios because the scenario was not being detected and was set as "gate". Change-Id: I38533ad8140be48726aa2cb1c106d7ef6ca9afd5 Signed-off-by: Tim Rozet <trozet@redhat.com>
2018-03-28Update git submodulesRoss Brattain1-0/+0
* Update docs/submodules/yardstick from branch 'master' - Merge "restore Heat stack failure logs for CI" - restore Heat stack failure logs for CI We need to see what Heat failures occured so that we can debug CI failures. The only way to do this seems to be to use the private event_utils.get_events function to query for all failures Also since we had a failure go ahead and dump the Heat template that failed. Sample output: 2018-03-25 23:50:08,765 [INFO] yardstick.orchestrator.heat heat.py:629 Creating stack 'yardstick-460ed969' START 2018-03-25 23:50:21,932 [ERROR] yardstick.orchestrator.heat heat.py:644 Resource CREATE failed: BadRequest: resources.yardstick-460ed969-xe1: Invalid input for operation: physical_network 'nosuch' unknown for flat provider network. Neutron server returns request_ids: ['req-6f981f1e-a9e2-4114-af84-1ee528aed51b'] 2018-03-25 23:50:21,933 [ERROR] yardstick.orchestrator.heat heat.py:644 BadRequest: resources.yardstick-460ed969-xe1: Invalid input for operation: physical_network 'nosuch' unknown for flat provider network. Neutron server returns request_ids: ['req-6f981f1e-a9e2-4114-af84-1ee528aed51b'] 2018-03-25 23:50:21,972 [ERROR] yardstick.orchestrator.heat heat.py:645 {'description': '\n' 'All referred generated resources are prefixed with the ' 'template\n' 'name (i.e. yardstick-460ed969).\n', 'heat_template_version': '2013-05-23', 'outputs': {'trafficgen_1.yardstick-460ed969': {'description': 'VM UUID', 'value': {'get_resource': 'trafficgen_1.yardstick-460ed969'}}, 'trafficgen_1.yardstick-460ed969-fip': {'description': 'floating ' 'ip ' JIRA: YARDSTICK-998 Change-Id: Ia8f4e5ba7e280fb9086519680d5ee90a2b442e6b Signed-off-by: Ross Brattain <ross.b.brattain@intel.com>
2018-03-28Update git submodulesQiLiang1-0/+0
* Update docs/submodules/clover from branch 'master' - Add Functest test hook Change-Id: Idbe25c162fb19c59ad4e57fd32a749d1d5a29f63 Signed-off-by: QiLiang <liangqi1@huawei.com>
2018-03-28Update git submodulesLuc Provoost1-0/+0
* Update docs/submodules/samplevnf from branch 'master' - Replaced heat stack yaml files by individual server creation There is now a new file (rapidVMs.vms) describing how many VMs need to be created. You can specify the same flavor values in the [DEFAULT] section or specify specific flavors per VM. The heat stack yaml files are removed. Change-Id: Ic5ec485e8344a35e9ac9f6e8347adbc70520d10a Signed-off-by: Luc Provoost <luc.provoost@intel.com>
2018-03-28Update git submodulesNarinder Gupta1-0/+0
* Update docs/submodules/joid from branch 'master' - using the admin bridge on jumphost. Change-Id: Iced282c4024b9ed523e13b3df6b635df1a7af24e Signed-off-by: Narinder Gupta <narinder.gupta@canonical.com>
2018-03-28Update git submodulesCédric Ollivier1-0/+0
* Update docs/submodules/functest from branch 'master' - Allow check and verify as CI_LOOP values It's required by the new promotion model [1]. [1] https://gerrit.opnfv.org/gerrit/#/c/54501/ Change-Id: Ie12aae1c24e05a61b2afd5bbf92a97f2c71fd395 Signed-off-by: Cédric Ollivier <cedric.ollivier@orange.com>
2018-03-28Update git submodulesNarinder Gupta1-0/+0
* Update docs/submodules/joid from branch 'master' - for fraser release. Change-Id: I221bf7e0d9862cce484fe4456cfcb0f26120ab93 Signed-off-by: Narinder Gupta <narinder.gupta@canonical.com>
2018-03-28Update git submodulesRex Lee1-0/+0
* Update docs/submodules/yardstick from branch 'master' - Merge "Replace neutron create security group rule with shade." - Replace neutron create security group rule with shade. Rename create_secgroup_rule with create_security_group_rule. Function create_security_group_rule now uses shade client. JIRA: YARDSTICK-890 Change-Id: Ie0ebac67a281e55dc95c0e3e33ba43de80aba9ec Signed-off-by: Shobhi Jain <shobhi.jain@intel.com>
2018-03-28Merge "Removing broken link"Sofia Wallin1-1/+0
2018-03-28Update git submodulesRex Lee1-0/+0
* Update docs/submodules/yardstick from branch 'master' - Merge "Dashboard for TC056" - Dashboard for TC056 This is dashboard for Yardstick test case TC056. JIRA: YARDSTICK-1085 Change-Id: I8bf2149f8dd9081022deb280101815cb1dd417ec Signed-off-by: Mika Rautakumpu <mika.rautakumpu@nokia.com>
2018-03-27Removing broken linkSofia Wallin1-1/+0
Change-Id: Id20dc62e151ed3954b0334224a81a19cf026e68f Signed-off-by: Sofia Wallin <sofia.wallin@ericsson.com>
2018-03-27Update git submodulesAaron Smith1-0/+0
* Update docs/submodules/barometer from branch 'master' - Merge "Fix docs for container deployment" - Fix docs for container deployment Change-Id: I4a610d8686d758913d73ca684db41616daf391bd Signed-off-by: John O Loughlin <john.oloughlin@intel.com>
2018-03-27Merge "Add opnfvdocs build container"Sofia Wallin3-0/+79
2018-03-27Update git submodulesRodolfo Alonso Hernandez1-0/+0
* Update docs/submodules/yardstick from branch 'master' - Merge "Improve "Libvirt.virsh_destroy_vm" function" - Improve "Libvirt.virsh_destroy_vm" function Read the command exit code and log a warning in case the VM destroy process went wrong. JIRA: YARDSTICK-943 Change-Id: I2750b8d4a8f67af081c1988510cf5aca848a2cf1 Signed-off-by: Rodolfo Alonso Hernandez <rodolfo.alonso.hernandez@intel.com>
2018-03-27Update git submodulesRodolfo Alonso Hernandez1-0/+0
* Update docs/submodules/yardstick from branch 'master' - Merge "Improve "Libvirt.virsh_create_vm" function" - Improve "Libvirt.virsh_create_vm" function Read the command exit code and raise an exception in case the VM boot process went wrong. JIRA: YARDSTICK-941 Change-Id: Ibabaae8983213a33799ad00fa4d9541bbabea857 Signed-off-by: Rodolfo Alonso Hernandez <rodolfo.alonso.hernandez@intel.com>
2018-03-27Update git submodulesRodolfo Alonso Hernandez1-0/+0
* Update docs/submodules/yardstick from branch 'master' - Merge "Improve NSB Standalone XML generation" - Improve NSB Standalone XML generation Delayed the generation of the XML file until the last step. The following functions will return a XML string insted: - Libvirt.build_vm_xml - SriovContext._enable_interfaces - OvsDpdkContext._enable_interfaces The XML file will be written just before copying the file to the compute hosting the VMs. JIRA: YARDSTICK-939 Change-Id: Icc80f4741903bbe335db4ebccab395b72fa87e82 Signed-off-by: Rodolfo Alonso Hernandez <rodolfo.alonso.hernandez@intel.com>
2018-03-27Update git submodulesRodolfo Alonso Hernandez1-0/+0
* Update docs/submodules/yardstick from branch 'master' - Merge "Improve OVS-DPDK setup process" - Improve OVS-DPDK setup process Improved OVS-DPDK setup process: - Added log string for each command executed. - Removed unnecessary 'kill' command. - Check if commands are executed correctly. JIRA: YARDSTICK-922 Change-Id: I09fba96ffa39cde1e000a3c4382d474219c99985 Signed-off-by: Rodolfo Alonso Hernandez <rodolfo.alonso.hernandez@intel.com>
2018-03-27Update git submodulesRodolfo Alonso Hernandez1-0/+0
* Update docs/submodules/yardstick from branch 'master' - Merge "Improve OVS-DPDK boot process" - Improve OVS-DPDK boot process Check if hugepages are present in the system. Check if every command executed during the boot up process exits correctly. JIRA: YARDSTICK-917 Change-Id: Ic0c8a72199ad80e3a65488cc88d0692863751284 Signed-off-by: Rodolfo Alonso Hernandez <rodolfo.alonso.hernandez@intel.com>
2018-03-27Update git submodulesRodolfo Alonso Hernandez1-0/+0
* Update docs/submodules/yardstick from branch 'master' - Merge "Replace neutron floating ip deletion with shade." - Replace neutron floating ip deletion with shade. Function delete_floating_ip now uses shade client. JIRA: YARDSTICK-890 Change-Id: I960630926b664266afbe7be00bb1352243b41be0 Signed-off-by: Shobhi Jain <shobhi.jain@intel.com>
2018-03-27Update git submodulesRodolfo Alonso Hernandez1-0/+0
* Update docs/submodules/yardstick from branch 'master' - Merge "Replace neutron floating ip creation with shade." - Replace neutron floating ip creation with shade. Function create_floating_ip now uses shade client instead of neutron client. JIRA: YARDSTICK-890 Change-Id: I3defd691dad998cebf98442b52f0555b176f1af4 Signed-off-by: Shobhi Jain <shobhi.jain@intel.com>
2018-03-27Update git submodulesRodolfo Alonso Hernandez1-0/+0
* Update docs/submodules/yardstick from branch 'master' - Merge "Replace neutron router interface deletion with shade." - Replace neutron router interface deletion with shade. Function remove_interface_router now uses shade client instead of neutron client. JIRA: YARDSTICK-890 Change-Id: I6bd36e35a339cce64dfa8b69c1e7b56cd70af956 Signed-off-by: Shobhi Jain <shobhi.jain@intel.com>
2018-03-27Update git submodulesFatih Degirmenci1-0/+0
* Update docs/submodules/releng from branch 'master' - xci: Set content-type of promotion properties file to text/html Change-Id: I609b796c629c68df214634ced5e9e6bda8ac2607 Signed-off-by: Fatih Degirmenci <fdegir@gmail.com>
2018-03-27Update git submodulesAlexandru Avadanii1-0/+0
* Update docs/submodules/fuel from branch 'master' - Merge "[doc] installation guide update: PDF section" - [doc] installation guide update: PDF section Update PDF section to: 1. describe "net_config" section in IDF. 2. describe compute parameterizaion required in IDF for both DPDK and non-DPDK scenario. JIRA: ARMBAND-361 Change-Id: I63fbe79c5cc3a4ee5244e6a0efad57eb89aad7d2 Signed-off-by: ting wu <ting.wu@enea.com>
2018-03-27Update git submodulesMarkos Chandras1-0/+0
* Update docs/submodules/releng-xci from branch 'master' - Merge "xci: infra: bifrost: Define more XCI variables for bifrost jobs" - xci: infra: bifrost: Define more XCI variables for bifrost jobs This is similar to eeb906a553d6ddf70ffc5af1acadb33a13ff5990 ("xci: infra: bifrost: Set XCI_DISTRO if it's not defined") so we need to define more XCI variables if we are running the standalone bifrost jobs. Change-Id: I112cfbfdda677174bdb0d0afef73f035c74cb79e Signed-off-by: Markos Chandras <mchandras@suse.de>
2018-03-27Update git submodulesxiaodong shang1-0/+0
* Update docs/submodules/parser from branch 'master' - Merge "Auto Generated INFO.yaml file" - Auto Generated INFO.yaml file INFO.yaml meant to be machine readable. This file was auto generated from an ldap lookup and your projects INFO file. Meeting times are not currently filled out. please ammend this patchset to complete Going forward comitter promotions should be done against this file. PTLs: Must be merged for you to gain delete access on testresults.opnfv.org If project_lead: is missing (my script could not parse) please amend with same from commiters section eg: project_lead: &opnfv_$project_ptl name: 'Lead Name' email: 'lead email' id: 'lead lfid' company: 'lead company' Change-Id: Id3dea3ab924bb3069aa3580848c682d8b1277fc6 Signed-off-by: agardner <agardner@linuxfoundation.org>
2018-03-27Update git submodulesRodolfo Alonso Hernandez1-0/+0
* Update docs/submodules/yardstick from branch 'master' - Merge "env: validate installer_ip from environment" - env: validate installer_ip from environment validate installer_ip is proper IPv4 address in case of user error Change-Id: Ib01916bc85ec411c159af1564f5142177f464047 Signed-off-by: Ross Brattain <ross.b.brattain@intel.com>
2018-03-27Update git submodulesRuan HE1-0/+0
* Update docs/submodules/moon from branch 'master' - Merge "As Ruan leaves the project, we need a new PTL. Please add a +2 if you agree." - As Ruan leaves the project, we need a new PTL. Please add a +2 if you agree. Change-Id: I7d574dc7b8a69c72101f3e78a935757bd80f91bf
2018-03-26Merge "Improvements for landing page"Sofia Wallin1-0/+2
2018-03-26Update git submodulesAlexandru Avadanii1-0/+0
* Update docs/submodules/armband from branch 'master' - u/fuel: Bump & rebase for ODL fixes Change-Id: I0cd2b8a0315c3dd71435138963927e4648d0ef6f Signed-off-by: Alexandru Avadanii <Alexandru.Avadanii@enea.com>
2018-03-26Update git submodulesMarkos Chandras1-0/+0
* Update docs/submodules/releng-xci from branch 'master' - xci: get-opnfv-scenario-requirements: Fix local scenario sync Commit 07747a53901e550280afb421b6fcbebc8994e93a ("xci: playbooks: Fix synchronization of external scenarios") fixed copying of external scenarios but broke internal ones because the regexp was wrong. The variable was not evaluated properly so nothing was replaced for internal scenarios. This also fixes a problem when the scenario and the role names differ so we make sure that the role with the correct name is created. Change-Id: Idd7590d972841b5c03286b34757d7325b863c6bf Signed-off-by: Markos Chandras <mchandras@suse.de>
2018-03-26Update git submodulesTrevor Bramwell1-0/+0
* Update docs/submodules/releng from branch 'master' - Merge "Auto project stable branch for OPNFV Fraser release" - Auto project stable branch for OPNFV Fraser release on behalf of Tina Tsou PTL Change-Id: Ib3779a67a09025b2433520566af060516ab6dc43 Signed-off-by: Gerard Damm <gerard.damm@wipro.com>
2018-03-26Update git submodulesStephen Wong1-0/+0
* Update docs/submodules/clover from branch 'master' - clover fraser: preliminary documents checkin * add preliminary Clover Fraser release notes * add preliminary Clover Fraser user guide Change-Id: I84b0ae1538aaa175245dd47d90ac2343eaa26cc4 Signed-off-by: Stephen Wong <stephen.kf.wong@gmail.com>
2018-03-26Update git submodulesTrevor Bramwell1-0/+0
* Update docs/submodules/releng from branch 'master' - Merge "Publish fraser/functest.yaml" - Publish fraser/functest.yaml Change-Id: Id5431eca0a078926976d4c96287aee9eb271dbf0 Signed-off-by: Cédric Ollivier <cedric.ollivier@orange.com>
2018-03-26Update git submodulesTrevor Bramwell1-0/+0
* Update docs/submodules/releng from branch 'master' - Merge "Add availability yaml for Fraser release" - Add availability yaml for Fraser release add availability yaml for Fraser to create the stable branch automatically JIRA: HA-35 Change-Id: Ied9b760b16dbe93cee2d633a225b3596cb59ad22 Signed-off-by: fuqiao <fuqiao@chinamobile.com>
2018-03-26Update git submodulesAric Gardner1-0/+0
* Update docs/submodules/releng from branch 'master' - Merge "Set Jenkins Automation user git configs globally" - Set Jenkins Automation user git configs globally These settings don't appear to be being picked up when the commit happens. Setting them globally should fix this. Change-Id: Ic93a65c7b1676a465e85af3909b20ba2bcf60f74 Signed-off-by: Trevor Bramwell <tbramwell@linuxfoundation.org>
2018-03-26Update git submodulesAakashKT1-0/+0
* Update docs/submodules/ovn4nfv from branch 'master' - Scenario Documentation k8s-ovn-lb-noha scenario Change-Id: I45fa19ed861b873118e1afedcf930cbdff3ecd37 Signed-off-by: AakashKT <aakash.kt@research.iiit.ac.in>
2018-03-26Update git submodulesPatrice Buriez1-0/+0
* Update docs/submodules/samplevnf from branch 'master' - Trivial: fix trailing white-spaces Makefile checks for some coding style rules. Previous commit introduced trailing white-spaces, which broke compilation. Change-Id: Ia57fc9b1428b4a9f8537dce4875e62ac55265fe3 Signed-off-by: Patrice Buriez <patrice.buriez@intel.com>
2018-03-26Update git submodulesRodolfo Alonso Hernandez1-0/+0
* Update docs/submodules/yardstick from branch 'master' - Merge "Install RabitMQ for RPC messaging between processes" - Install RabitMQ for RPC messaging between processes In NetworkServices Tescases, the TGs (traffic generators) run the traffic in a separate process. In order to synchronize the traffic injection and the runner interval loops, an RPC server is needed to publish/subscribe events. RabbitMQ is a well supported MQ in Linux (used in OpenStack or collectd) and supported by Python implemented projects like oslo.messaging [1]. RabbitMQ default configuration: - Port: 5672 - User/password: yardstick/yardstick [1]https://github.com/openstack/oslo.messaging JIRA: YARDSTICK-1068 Change-Id: I15db294ee430fb38e574a59b9ce1bf0f8b651a67 Signed-off-by: Rodolfo Alonso Hernandez <rodolfo.alonso.hernandez@intel.com>