aboutsummaryrefslogtreecommitdiffstats
path: root/moon_interface
diff options
context:
space:
mode:
authorRuan HE <ruan.he@orange.com>2018-01-30 13:41:04 +0000
committerGerrit Code Review <gerrit@opnfv.org>2018-01-30 13:41:04 +0000
commit9da7ac6718d66b73ba7fc8fc70e656a70e4db766 (patch)
tree672d21b1c8a8fd7ac67a3d2f2b2e265b22493fd2 /moon_interface
parent0da820e8d8ff75ff9e12b80501cc38aa1f3507a8 (diff)
parent57a6fa48a7c5c581db50f9590b9ad6c4be43ac2d (diff)
Merge "adding some comments to enahnce"
Diffstat (limited to 'moon_interface')
-rw-r--r--moon_interface/moon_interface/http_server.py6
-rw-r--r--moon_interface/moon_interface/server.py8
2 files changed, 2 insertions, 12 deletions
diff --git a/moon_interface/moon_interface/http_server.py b/moon_interface/moon_interface/http_server.py
index 82ee5d91..a2e25377 100644
--- a/moon_interface/moon_interface/http_server.py
+++ b/moon_interface/moon_interface/http_server.py
@@ -114,12 +114,6 @@ class HTTPServer(Server):
def get_400_json(e):
return jsonify({"result": False, "code": 400, "description": str(e)}), 400
- '''
- [Note] i have tried to simulate authz post request (authz_Requests/run) to return 500 response code
- and an AuthzException thrown from their [Line 63] and catched here , then the server here return response
- with 403 code [Forbidden] , is it correct if so why sometime at authz [from Line 137] return a response
- with error code , i think we can do it in the same way as the one mentioned?
- '''
self.app.register_error_handler(400, lambda e: get_400_json)
self.app.register_error_handler(403, exceptions.AuthException)
diff --git a/moon_interface/moon_interface/server.py b/moon_interface/moon_interface/server.py
index d38dae28..29403a6b 100644
--- a/moon_interface/moon_interface/server.py
+++ b/moon_interface/moon_interface/server.py
@@ -16,9 +16,7 @@ def create_server():
conf = configuration.get_configuration("components/pipeline").get(
"components/pipeline", {}).get("interface", {})
- '''
- [Note] i think pipeline should be changed to interface
- '''
+
hostname = conf.get("hostname", "pipeline")
port = conf.get("port", 80)
bind = conf.get("bind", "127.0.0.1")
@@ -26,9 +24,7 @@ def create_server():
hostname = "interface"
bind = "127.0.0.1"
port = 80
- '''
- [Note] i think pipeline should be changed to interface
- '''
+
configuration.add_component(uuid="pipeline",
name=hostname,
port=port,