diff options
author | SerenaFeng <feng.xiaowei@zte.com.cn> | 2016-08-23 13:44:36 +0800 |
---|---|---|
committer | Morgan Richomme <morgan.richomme@orange.com> | 2016-08-26 06:48:33 +0000 |
commit | f3da85065e34b3058cace165443f6f919f959a0b (patch) | |
tree | e5716aad90288dfaa9d39fc550571862381f6e87 /utils/openstack_utils.py | |
parent | 224f176cee5544483f3a37bb59a3d9aae1791e44 (diff) |
refactor create or get image process to eliminate reduplicate
Some places when create image is referred, they check if image exist,
if exist use it directly, else create a new one.
Abstract a method to integrate the process
JIRA: FUNCTEST-432
Change-Id: I83d1112aa5cb0d3cdfab92fd49cd5f2c1cceff82
Signed-off-by: SerenaFeng <feng.xiaowei@zte.com.cn>
(cherry picked from commit 5f5af6b1d8d0af19db143e67f04f67a643af863c)
Diffstat (limited to 'utils/openstack_utils.py')
-rwxr-xr-x | utils/openstack_utils.py | 20 |
1 files changed, 20 insertions, 0 deletions
diff --git a/utils/openstack_utils.py b/utils/openstack_utils.py index d30ca629c..a7bc899ab 100755 --- a/utils/openstack_utils.py +++ b/utils/openstack_utils.py @@ -889,6 +889,26 @@ def create_glance_image(glance_client, image_name, file_path, disk="qcow2", return None +def get_or_create_image(name, path, format): + image_exists = False + glance_client = get_glance_client() + + image_id = get_image_id(glance_client, name) + if image_id != '': + logger.info("Using existing image '%s'..." % name) + image_exists = True + else: + logger.info("Creating image '%s' from '%s'..." % (name, path)) + image_id = create_glance_image(glance_client, name, path, format) + if not image_id: + logger.error("Failed to create a Glance image...") + else: + logger.debug("Image '%s' with ID=%s created successfully." + % (name, image_id)) + + return image_exists, image_id + + def delete_glance_image(nova_client, image_id): try: nova_client.images.delete(image_id) |