Remove all logers as utils method args.

As it modifies method params, it could break the testcases.

JIRA: FUNCTEST-428

Change-Id: I4263d9bd812f1803e513464e3c321cc4a7281958
Signed-off-by: Cédric Ollivier <cedric.ollivier@orange.com>

14 files changed, 15 insertions, 31 deletions

diff --git a/testcases/Controllers/ODL/OpenDaylightTesting.py b/testcases/Controllers/ODL/OpenDaylightTesting.py
index 22df9f667..173de87f9 100755
--- a/testcases/Controllers/ODL/OpenDaylightTesting.py
+++ b/testcases/Controllers/ODL/OpenDaylightTesting.py
@@ -172,7 +172,7 @@ class ODLTestCases:
             details['description'] = result.suite.name
             details['tests'] = visitor.get_data()
             if not ft_utils.push_results_to_db(
-                    "functest", "odl", cls.logger, start_time, stop_time,
+                    "functest", "odl", start_time, stop_time,
                     result.suite.status, details):
                 cls.logger.error("Cannot push ODL results to DB")
                 return False
diff --git a/testcases/Controllers/ONOS/Sfc/Sfc.py b/testcases/Controllers/ONOS/Sfc/Sfc.py
index a52019875..99d07aaed 100644
--- a/testcases/Controllers/ONOS/Sfc/Sfc.py
+++ b/testcases/Controllers/ONOS/Sfc/Sfc.py
@@ -217,7 +217,6 @@ class Sfc:
         logger.info("Result is " + status)
         functest_utils.push_results_to_db("functest",
                                           "onos_sfc",
-                                          logger,
                                           start_time,
                                           stop_time,
                                           status,
diff --git a/testcases/Controllers/ONOS/Teston/onosfunctest.py b/testcases/Controllers/ONOS/Teston/onosfunctest.py
index 2790e6941..717df82aa 100755
--- a/testcases/Controllers/ONOS/Teston/onosfunctest.py
+++ b/testcases/Controllers/ONOS/Teston/onosfunctest.py
@@ -249,7 +249,6 @@ def OnosTest():
 
         functest_utils.push_results_to_db("functest",
                                           "onos",
-                                          logger,
                                           start_time,
                                           stop_time,
                                           status,
diff --git a/testcases/OpenStack/rally/run_rally-cert.py b/testcases/OpenStack/rally/run_rally-cert.py
index f3eb79d26..f7199d301 100755
--- a/testcases/OpenStack/rally/run_rally-cert.py
+++ b/testcases/OpenStack/rally/run_rally-cert.py
@@ -362,7 +362,6 @@ def run_task(test_name):
         logger.debug("Push Rally detailed results into DB")
         functest_utils.push_results_to_db("functest",
                                           "Rally_details",
-                                          logger,
                                           start_time,
                                           stop_time,
                                           status,
@@ -495,7 +494,6 @@ def main():
         logger.debug("Pushing Rally summary into DB...")
         functest_utils.push_results_to_db("functest",
                                           case_name,
-                                          logger,
                                           start_time,
                                           stop_time,
                                           status,
diff --git a/testcases/OpenStack/tempest/gen_tempest_conf.py b/testcases/OpenStack/tempest/gen_tempest_conf.py
index 4aa814a51..688a92402 100755
--- a/testcases/OpenStack/tempest/gen_tempest_conf.py
+++ b/testcases/OpenStack/tempest/gen_tempest_conf.py
@@ -116,7 +116,7 @@ def main():
     if not os.path.exists(TEMPEST_RESULTS_DIR):
         os.makedirs(TEMPEST_RESULTS_DIR)
 
-    deployment_dir = ft_utils.get_deployment_dir(logger)
+    deployment_dir = ft_utils.get_deployment_dir()
     configure_tempest_multisite(deployment_dir)
 
 
diff --git a/testcases/OpenStack/tempest/run_tempest.py b/testcases/OpenStack/tempest/run_tempest.py
index 306664feb..9285b67d9 100755
--- a/testcases/OpenStack/tempest/run_tempest.py
+++ b/testcases/OpenStack/tempest/run_tempest.py
@@ -166,7 +166,7 @@ def configure_tempest(deployment_dir):
 
     logger.debug("Generating new tempest.conf file...")
     cmd = "rally verify genconfig"
-    ft_utils.execute_command(cmd, logger)
+    ft_utils.execute_command(cmd)
 
     logger.debug("Finding tempest.conf file...")
     if not os.path.isfile(tempest_conf_file):
@@ -228,7 +228,7 @@ def generate_test_list(deployment_dir, mode):
             testr_mode = 'tempest.api.' + mode
         cmd = ("cd " + deployment_dir + ";" + "testr list-tests " +
                testr_mode + ">" + TEMPEST_RAW_LIST + ";cd")
-        ft_utils.execute_command(cmd, logger)
+        ft_utils.execute_command(cmd)
 
 
 def apply_tempest_blacklist():
@@ -373,7 +373,6 @@ def run_tempest(OPTION):
         try:
             ft_utils.push_results_to_db("functest",
                                         case_name,
-                                        None,
                                         start_time,
                                         stop_time,
                                         status,
@@ -399,7 +398,7 @@ def main():
     if not os.path.exists(TEMPEST_RESULTS_DIR):
         os.makedirs(TEMPEST_RESULTS_DIR)
 
-    deployment_dir = ft_utils.get_deployment_dir(logger)
+    deployment_dir = ft_utils.get_deployment_dir()
     create_tempest_resources()
 
     if "" == args.conf:
diff --git a/testcases/OpenStack/vPing/vping_util.py b/testcases/OpenStack/vPing/vping_util.py
index 3f4adae73..9c35c230a 100644
--- a/testcases/OpenStack/vPing/vping_util.py
+++ b/testcases/OpenStack/vPing/vping_util.py
@@ -456,7 +456,6 @@ def push_result(report, case, start_time, stop_time, details):
             logger.debug("Pushing vPing %s results into DB..." % case)
             ft_utils.push_results_to_db('functest',
                                         case,
-                                        logger,
                                         start_time,
                                         stop_time,
                                         details['status'],
diff --git a/testcases/features/copper.py b/testcases/features/copper.py
index c79754a1b..e03e60f1c 100755
--- a/testcases/features/copper.py
+++ b/testcases/features/copper.py
@@ -42,7 +42,7 @@ def main():
 
     start_time = time.time()
 
-    ret_val = functest_utils.execute_command(cmd, logger, exit_on_error=False)
+    ret_val = functest_utils.execute_command(cmd, exit_on_error=False)
 
     stop_time = time.time()
     duration = round(stop_time - start_time, 1)
@@ -58,14 +58,13 @@ def main():
         'duration': duration,
         'status': test_status,
     }
-    functest_utils.logger_test_results(logger, "Copper",
+    functest_utils.logger_test_results("Copper",
                                        "copper-notification",
                                        details['status'], details)
     try:
         if args.report:
             functest_utils.push_results_to_db("copper",
                                               "copper-notification",
-                                              logger,
                                               start_time,
                                               stop_time,
                                               details['status'],
diff --git a/testcases/features/doctor.py b/testcases/features/doctor.py
index 02edd25ca..713931346 100755
--- a/testcases/features/doctor.py
+++ b/testcases/features/doctor.py
@@ -41,7 +41,7 @@ def main():
     cmd = 'cd %s/tests && ./run.sh' % DOCTOR_REPO
     start_time = time.time()
 
-    ret = functest_utils.execute_command(cmd, logger, info=True,
+    ret = functest_utils.execute_command(cmd, info=True,
                                          exit_on_error=False)
 
     stop_time = time.time()
@@ -62,13 +62,12 @@ def main():
     status = "FAIL"
     if details['status'] == "OK":
         status = "PASS"
-    functest_utils.logger_test_results(logger, "Doctor",
+    functest_utils.logger_test_results("Doctor",
                                        "doctor-notification",
                                        status, details)
     if args.report:
         functest_utils.push_results_to_db("doctor",
                                           "doctor-notification",
-                                          logger,
                                           start_time,
                                           stop_time,
                                           status,
diff --git a/testcases/features/domino.py b/testcases/features/domino.py
index 291a3b49b..f99a53b6c 100755
--- a/testcases/features/domino.py
+++ b/testcases/features/domino.py
@@ -42,7 +42,7 @@ def main():
     cmd = 'cd %s && ./tests/run_multinode.sh' % DOMINO_REPO
     start_time = time.time()
 
-    ret = functest_utils.execute_command(cmd, logger, exit_on_error=False)
+    ret = functest_utils.execute_command(cmd, exit_on_error=False)
 
     stop_time = time.time()
     duration = round(stop_time - start_time, 1)
@@ -68,14 +68,13 @@ def main():
     elif details['status'] == "SKIPPED":
         status = "SKIP"
 
-    functest_utils.logger_test_results(logger, "Domino",
+    functest_utils.logger_test_results("Domino",
                                        "domino-multinode",
                                        status, details)
     if args.report:
         if status is not "SKIP":
             functest_utils.push_results_to_db("domino",
                                               "domino-multinode",
-                                              logger,
                                               start_time,
                                               stop_time,
                                               status,
diff --git a/testcases/features/promise.py b/testcases/features/promise.py
index 3728adfe5..27186550e 100755
--- a/testcases/features/promise.py
+++ b/testcases/features/promise.py
@@ -245,7 +245,6 @@ def main():
 
         functest_utils.push_results_to_db("promise",
                                           "promise",
-                                          logger,
                                           start_time,
                                           stop_time,
                                           status,
diff --git a/testcases/features/sfc/sfc.py b/testcases/features/sfc/sfc.py
index 3cf1052b6..5f771137d 100755
--- a/testcases/features/sfc/sfc.py
+++ b/testcases/features/sfc/sfc.py
@@ -414,7 +414,7 @@ def main():
                         " :) \n" + '\033[0m')
 
     # TODO report results to DB
-    # functest_utils.logger_test_results(logger, "SFC",
+    # functest_utils.logger_test_results("SFC",
     # "odl-sfc",
     # status, details)
     # see doctor, promise, domino, ...
@@ -422,7 +422,6 @@ def main():
         # logger.info("Pushing odl-SFC results")
         # functest_utils.push_results_to_db("functest",
         #                                  "odl-sfc",
-        #                                  logger,
         #                                  start_time,
         #                                  stop_time,
         #                                  status,
diff --git a/testcases/vnf/vIMS/vIMS.py b/testcases/vnf/vIMS/vIMS.py
index 373761794..83ea86dbb 100755
--- a/testcases/vnf/vIMS/vIMS.py
+++ b/testcases/vnf/vIMS/vIMS.py
@@ -122,7 +122,6 @@ def step_failure(step_name, error_msg):
         status = "PASS"
     functest_utils.push_results_to_db("functest",
                                       "vims",
-                                      None,
                                       TESTCASE_START_TIME,
                                       stop_time,
                                       status,
@@ -244,7 +243,6 @@ def test_clearwater():
 
         functest_utils.push_results_to_db("functest",
                                           "vims",
-                                          logger,
                                           TESTCASE_START_TIME,
                                           end_time_ts,
                                           status,
@@ -407,10 +405,10 @@ def main():
 
     logger.info("Prepare virtualenv for cloudify-cli")
     cmd = "chmod +x " + VIMS_DIR + "create_venv.sh"
-    functest_utils.execute_command(cmd, logger)
+    functest_utils.execute_command(cmd)
     time.sleep(3)
     cmd = VIMS_DIR + "create_venv.sh " + VIMS_DATA_DIR
-    functest_utils.execute_command(cmd, logger)
+    functest_utils.execute_command(cmd)
 
     cfy.download_manager_blueprint(
         CFY_MANAGER_BLUEPRINT['url'], CFY_MANAGER_BLUEPRINT['branch'])
diff --git a/testcases/vnf/vRNC/parser.py b/testcases/vnf/vRNC/parser.py
index 00593b0b0..a895ef8df 100755
--- a/testcases/vnf/vRNC/parser.py
+++ b/testcases/vnf/vRNC/parser.py
@@ -44,7 +44,6 @@ def main():
 
     start_time = time.time()
     ret = functest_utils.execute_command(cmd,
-                                         logger,
                                          info=True,
                                          exit_on_error=False)
     stop_time = time.time()
@@ -54,8 +53,7 @@ def main():
                                                        start_time,
                                                        stop_time)
 
-    functest_utils.logger_test_results(logger,
-                                       project,
+    functest_utils.logger_test_results(project,
                                        case_name,
                                        status,
                                        details)
@@ -64,7 +62,6 @@ def main():
         logger.debug("Report Parser Results to DB......")
         functest_utils.push_results_to_db(project,
                                           case_name,
-                                          logger,
                                           start_time,
                                           stop_time,
                                           status,