diff options
| author |   SerenaFeng <feng.xiaowei@zte.com.cn> | 2016-08-23 13:44:36 +0800 |
|---|---|---|
| committer |   Morgan Richomme <morgan.richomme@orange.com> | 2016-08-26 06:48:33 +0000 |
| commit | f3da85065e34b3058cace165443f6f919f959a0b (patch) | |
| tree | e5716aad90288dfaa9d39fc550571862381f6e87 /testcases/OpenStack/vPing | |
| parent | 224f176cee5544483f3a37bb59a3d9aae1791e44 (diff) | |
refactor create or get image process to eliminate reduplicate
Some places when create image is referred, they check if image exist,
if exist use it directly, else create a new one.
Abstract a method to integrate the process
JIRA: FUNCTEST-432
Change-Id: I83d1112aa5cb0d3cdfab92fd49cd5f2c1cceff82
Signed-off-by: SerenaFeng <feng.xiaowei@zte.com.cn>
(cherry picked from commit 5f5af6b1d8d0af19db143e67f04f67a643af863c)
Diffstat (limited to 'testcases/OpenStack/vPing')
| -rw-r--r-- | testcases/OpenStack/vPing/vping_util.py | 23 |
1 files changed, 5 insertions, 18 deletions
diff --git a/testcases/OpenStack/vPing/vping_util.py b/testcases/OpenStack/vPing/vping_util.py index c16c5d659..3f4adae73 100644 --- a/testcases/OpenStack/vPing/vping_util.py +++ b/testcases/OpenStack/vPing/vping_util.py @@ -147,24 +147,11 @@ def create_security_group(): def create_image(): - EXIT_CODE = -1 - - # Check if the given image exists - image_id = os_utils.get_image_id(glance_client, GLANCE_IMAGE_NAME) - if image_id != '': - logger.info("Using existing image '%s'..." % GLANCE_IMAGE_NAME) - else: - logger.info("Creating image '%s' from '%s'..." % (GLANCE_IMAGE_NAME, - GLANCE_IMAGE_PATH)) - image_id = os_utils.create_glance_image(glance_client, - GLANCE_IMAGE_NAME, - GLANCE_IMAGE_PATH, - GLANCE_IMAGE_FORMAT) - if not image_id: - logger.error("Failed to create a Glance image...") - exit(EXIT_CODE) - logger.debug("Image '%s' with ID=%s created successfully." - % (GLANCE_IMAGE_NAME, image_id)) + _, image_id = os_utils.get_or_create_image(GLANCE_IMAGE_NAME, + GLANCE_IMAGE_PATH, + GLANCE_IMAGE_FORMAT) + if not image_id: + exit(-1) return image_id |