Default neutron dhcp_agents_per_network to number of agents

This patch will set neutron's dhcp_agents_per_network equal to the
number of deployed neutron DHCP agents unless otherwise explicitly set.

Partial-bug: #1632721
Change-Id: I5533e42c5ba9f72cc70d80489a07e30ee2341198

1 files changed, 76 insertions, 0 deletions

diff --git a/spec/classes/tripleo_profile_base_neutron_spec.rb b/spec/classes/tripleo_profile_base_neutron_spec.rb
new file mode 100644
index 0000000..504be5b
--- /dev/null
+++ b/spec/classes/tripleo_profile_base_neutron_spec.rb
@@ -0,0 +1,76 @@
+#
+# Copyright (C) 2016 Red Hat, Inc.
+#
+# Licensed under the Apache License, Version 2.0 (the "License"); you may
+# not use this file except in compliance with the License. You may obtain
+# a copy of the License at
+#
+#      http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing, software
+# distributed under the License is distributed on an "AS IS" BASIS, WITHOUT
+# WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See the
+# License for the specific language governing permissions and limitations
+# under the License.
+#
+
+require 'spec_helper'
+
+describe 'tripleo::profile::base::neutron' do
+  let :params do
+    { :step                    => 5,
+      :oslomsg_notify_password => 'foobar',
+      :oslomsg_rpc_password    => 'foobar'
+    }
+  end
+
+  shared_examples_for 'tripleo::profile::base::neutron' do
+    before :each do
+      facts.merge!({ :step => params[:step] })
+    end
+
+    context 'when no dhcp agents per network set' do
+      before do
+        params.merge!({
+          :dhcp_nodes => ['netcont1.localdomain', 'netcont2.localdomain', 'netcont3.localdomain']
+        })
+      end
+      it 'should equal the number of dhcp agents' do
+        is_expected.to contain_class('neutron').with(:dhcp_agents_per_network => 3)
+      end
+    end
+
+    context 'when dhcp agents per network is set' do
+      before do
+        params.merge!({
+          :dhcp_agents_per_network => 2
+        })
+      end
+      it 'should set the the value' do
+        is_expected.to contain_class('neutron').with(:dhcp_agents_per_network => 2)
+      end
+    end
+
+    context 'when dhcp agents per network is greater than number of agents' do
+      before do
+        params.merge!({
+          :dhcp_nodes => ['netcont1.localdomain', 'netcont2.localdomain'],
+          :dhcp_agents_per_network => 5
+        })
+      end
+      it 'should set value and complain about not enough agents' do
+        is_expected.to contain_class('neutron').with(:dhcp_agents_per_network => 5)
+      end
+    end
+  end
+
+  on_supported_os.each do |os, facts|
+    context "on #{os}" do
+      let(:facts) do
+        facts.merge({ :hostname => 'node.example.com' })
+      end
+
+      it_behaves_like 'tripleo::profile::base::neutron'
+    end
+  end
+end