ifcfg: Add support for dns_servers

Adds in the ability to optionally configure DNS
server settings via the ifcfg file formats.
The dns_servers JSON is an array which currently
supports either 1 or 2 DNS servers (per limitations
of the ifcfg format).

Change-Id: I9edecfdd4e1d0f39883b72be554cd92c5685881d

2 files changed, 39 insertions, 0 deletions

diff --git a/os_net_config/tests/test_impl_ifcfg.py b/os_net_config/tests/test_impl_ifcfg.py
index e32aff2..ec2a36c 100644
--- a/os_net_config/tests/test_impl_ifcfg.py
+++ b/os_net_config/tests/test_impl_ifcfg.py
@@ -331,6 +331,34 @@ DHCLIENTARGS=--foobar
 """
         self.assertEqual(em1_config, self.get_interface_config('em1'))
 
+    def test_interface_single_dns_server(self):
+        interface1 = objects.Interface('em1', dns_servers=['1.2.3.4'])
+        self.provider.add_interface(interface1)
+        em1_config = """# This file is autogenerated by os-net-config
+DEVICE=em1
+ONBOOT=yes
+HOTPLUG=no
+NM_CONTROLLED=no
+BOOTPROTO=none
+DNS1=1.2.3.4
+"""
+        self.assertEqual(em1_config, self.get_interface_config('em1'))
+
+    def test_interface_dns_servers(self):
+        interface1 = objects.Interface('em1', dns_servers=['1.2.3.4',
+                                                           '5.6.7.8'])
+        self.provider.add_interface(interface1)
+        em1_config = """# This file is autogenerated by os-net-config
+DEVICE=em1
+ONBOOT=yes
+HOTPLUG=no
+NM_CONTROLLED=no
+BOOTPROTO=none
+DNS1=1.2.3.4
+DNS2=5.6.7.8
+"""
+        self.assertEqual(em1_config, self.get_interface_config('em1'))
+
 
 class TestIfcfgNetConfigApply(base.TestCase):
 
diff --git a/os_net_config/tests/test_objects.py b/os_net_config/tests/test_objects.py
index c824ba8..8488370 100644
--- a/os_net_config/tests/test_objects.py
+++ b/os_net_config/tests/test_objects.py
@@ -119,6 +119,17 @@ class TestInterface(base.TestCase):
         interface1 = objects.object_from_json(json.loads(data))
         self.assertEqual("--foobar", interface1.dhclient_args)
 
+    def test_from_json_dns_servers(self):
+        data = """{
+"type": "interface",
+"name": "em1",
+"use_dhcp": true,
+"dns_servers": ["1.2.3.4"]
+}
+"""
+        interface1 = objects.object_from_json(json.loads(data))
+        self.assertEqual(["1.2.3.4"], interface1.dns_servers)
+
     def test_from_json_dhcp_nic1(self):
         def dummy_numbered_nics(nic_mapping=None):
             return {"nic1": "em3"}