diff options
author | Steven Hardy <shardy@redhat.com> | 2015-01-22 11:33:38 +0000 |
---|---|---|
committer | Steven Hardy <shardy@redhat.com> | 2015-02-24 09:20:55 +0000 |
commit | 70c235d30aee3a401414f622b3de4f09f4b3d180 (patch) | |
tree | 323c5f65cfa02701ef2ae208e917e3e06a434e2e /os_net_config/impl_ifcfg.py | |
parent | a4ad189558a414c6029b4dfbc8e459339ebe534d (diff) |
Move noop flag to provider base-class
Moving this flag makes it easier to implement additional functions
which work differently depending on noop mode being set, vs passing
it into every function like apply()
Change-Id: I796792aece3e40322523e910a3b87f7ab9a451dd
Diffstat (limited to 'os_net_config/impl_ifcfg.py')
-rw-r--r-- | os_net_config/impl_ifcfg.py | 9 |
1 files changed, 5 insertions, 4 deletions
diff --git a/os_net_config/impl_ifcfg.py b/os_net_config/impl_ifcfg.py index a728f53..62f2a41 100644 --- a/os_net_config/impl_ifcfg.py +++ b/os_net_config/impl_ifcfg.py @@ -49,7 +49,8 @@ def cleanup_pattern(): class IfcfgNetConfig(os_net_config.NetConfig): """Configure network interfaces using the ifcfg format.""" - def __init__(self): + def __init__(self, noop=False): + super(IfcfgNetConfig, self).__init__(noop) self.interface_data = {} self.route_data = {} self.bridge_data = {} @@ -211,16 +212,16 @@ class IfcfgNetConfig(os_net_config.NetConfig): if bond.routes: self._add_routes(bond.name, bond.routes) - def apply(self, noop=False, cleanup=False): + def apply(self, cleanup=False): """Apply the network configuration. - :param noop: A boolean which indicates whether this is a no-op. :param cleanup: A boolean which indicates whether any undefined (existing but not present in the object model) interface should be disabled and deleted. :returns: a dict of the format: filename/data which contains info for each file that was changed (or would be changed if in --noop mode). + Note the noop mode is set via the constructor noop boolean """ logger.info('applying network configs...') restart_interfaces = [] @@ -257,7 +258,7 @@ class IfcfgNetConfig(os_net_config.NetConfig): update_files[bridge_route_path] = route_data logger.info('No changes required for bridge: %s' % bridge_name) - if noop: + if self.noop: return update_files if cleanup: |