aboutsummaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorCédric Ollivier <cedric.ollivier@orange.com>2018-08-29 16:08:14 +0200
committerCédric Ollivier <cedric.ollivier@orange.com>2018-08-29 16:13:59 +0200
commit231062122d8d47a939a0e054aa128e4f96671cc6 (patch)
tree66a30a45780b1c1f4d5b0b790192eb3db81bc0bb
parent42232cd54126980854ea92df1ccfe2c812b93536 (diff)
Stop verifying ResultWriter.write_results exit codes
ResultWriter.write_results() returns false if one test fails. It's skipped by run() because the report is correctly generated. [1] https://robot-framework.readthedocs.io/en/2.9.2/_modules/robot/reporting/resultwriter.html Change-Id: If29059b272679ed89a1189e0bb52997c83401b94 Signed-off-by: Cédric Ollivier <cedric.ollivier@orange.com> (cherry picked from commit 76f86384a93aea045645d4e17b4e74beed07fa52)
-rw-r--r--xtesting/core/robotframework.py2
-rw-r--r--xtesting/tests/unit/core/test_robotframework.py2
2 files changed, 2 insertions, 2 deletions
diff --git a/xtesting/core/robotframework.py b/xtesting/core/robotframework.py
index 9865a26f..2791b559 100644
--- a/xtesting/core/robotframework.py
+++ b/xtesting/core/robotframework.py
@@ -127,7 +127,7 @@ class RobotFramework(testcase.TestCase):
try:
self.parse_results()
self.__logger.info("Results were successfully parsed")
- assert self.generate_report() == 0
+ self.generate_report()
self.__logger.info("Results were successfully generated")
except RobotError as ex:
self.__logger.error("Run suites before publishing: %s", ex.message)
diff --git a/xtesting/tests/unit/core/test_robotframework.py b/xtesting/tests/unit/core/test_robotframework.py
index 4cda171c..398cf87a 100644
--- a/xtesting/tests/unit/core/test_robotframework.py
+++ b/xtesting/tests/unit/core/test_robotframework.py
@@ -283,7 +283,7 @@ class RunTesting(unittest.TestCase):
def test_generate_report_err(self):
with mock.patch.object(self.test, 'generate_report',
return_value=1) as mmethod:
- self._test_generate_report(self.test.EX_RUN_ERROR)
+ self._test_generate_report(self.test.EX_OK)
mmethod.assert_called_once_with()
def test_generate_report(self):