From 3478059d4397c5ee3a1d1e4707c5883afd0974a8 Mon Sep 17 00:00:00 2001 From: Emma Foley Date: Mon, 5 Mar 2018 17:41:33 +0000 Subject: assertTrue(mock.called) -> mock.assert_called When checking whether a mocked method has been called, mock.assert_called or mock.assert_called_once should be used, and not unittest.assertTrue(mock.called) This change does this update. It can be verified with: grep -irn "self.assertTrue(.*called)" --exclude-dir=.tox And the replacement was done with: sed -i 's/self.assertTrue(\(.*\).called)/\1.assert_called_once()/g' Change-Id: I4f26e0c736bf33e0b2413c8e8c33dbdb91f090e2 JIRA: YARDSTICK-865 Signed-off-by: Emma Foley --- yardstick/tests/unit/benchmark/scenarios/lib/test_attach_volume.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) (limited to 'yardstick/tests/unit/benchmark/scenarios/lib/test_attach_volume.py') diff --git a/yardstick/tests/unit/benchmark/scenarios/lib/test_attach_volume.py b/yardstick/tests/unit/benchmark/scenarios/lib/test_attach_volume.py index a61195f66..2964ecc14 100644 --- a/yardstick/tests/unit/benchmark/scenarios/lib/test_attach_volume.py +++ b/yardstick/tests/unit/benchmark/scenarios/lib/test_attach_volume.py @@ -23,4 +23,4 @@ class AttachVolumeTestCase(unittest.TestCase): args = {"options": options} obj = AttachVolume(args, {}) obj.run({}) - self.assertTrue(mock_attach_server_volume.called) + mock_attach_server_volume.assert_called_once() -- cgit 1.2.3-korg